Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jan 19, 2022
  2. Jan 18, 2022
  3. Jan 17, 2022
  4. Jan 14, 2022
    • dpsutton's avatar
      Fix flaky tests (#19701) · e64d3192
      dpsutton authored
      Our email tests can be a bit brittle. Sometimes we assert the first
      email in the email inbox is some password reset email, but a race makes
      it such that its a "logged in from new ip" email. Othertimes, we might
      assert that there are only emails to a particular user but maybe another
      test might have triggered an email to another user.
      
      We often might just want two predicates: did the user receive an email
      with this subject, or did the user receive an email with this body.
      
      This simply adds those.
      
      It should be safe from races as it can handle emails to multiple users
      and multiple emails to the same user.
      Unverified
      e64d3192
    • Alexander Kiselev's avatar
      Unverified
      dbaf2d58
    • adam-james's avatar
      Incorrect progressbar alert 10899 (#19649) · 5a5a789d
      adam-james authored
      * Comparison for goals depends on alert_above_goal and if progressbar.
      
      This commit sets up the timeseries predicate and writes tests for what I think the correct behaviours should be:
      
      timeseries, alert above -> (<= goal-value value)
       - (<= 5.9 6) true  -> alert sent
       - (<= 6 6)   true  -> alert sent
       - (<= 6.1 6) false -> alert not sent
      
      progressbar, alert above -> (<= goal-value value)
       - (<= 5.9 6) true  -> alert sent
       - (<= 6 6)   true  -> alert sent
       - (<= 6.1 6) false -> alert not sent
      
      timeseries, alert below -> (>= goal-value value)
       - (>= 6.1 6) true   -> alert sent
       - (>= 6 6)   true   -> alert sent. NOTE: this is to match prior behaviour, but I don't understand why it is this way?
       - (>= 5.9 6) faluse -> alert not sent
      
      progressbar, alert below -> (> goal-value value)
       - (> 6.1 6) true   -> alert sent
       - (> 6 6)   false  -> alert not sent. NOTE: this is what should fix the bug (#10899)
       - (> 5.9 6) faluse -> alert not sent
      
      I think there may be a cleaner way to write and present the tests, so the next commit(s) will address that.
      
      * Simplified Tests for goal-met? predicate.
      
      The goal-met predicate is tested directly with mock data to make the tests more readable.
      
      The change to `metabase.pulse/goal-met?` fixes #10899 while preserving the goal-met behaviour for any non-progress
      goal. The behaviour should now be as follows:
      
      ```
      | Timeseries? | alert_above? | goal | val | goal-met? |
      +-------------+--------------+------+-----+-----------+
      |     f       |      t       |  5   |  4  |     f     |
      |     f       |      t       |  5   |  5  |     t     |
      |     f       |      t       |  5   |  6  |     t     |
      |     f       |      f       |  5   |  4  |     t     |
      |     f       |      f       |  5   |  5  |     f     | <--- this is new behaviour
      |     f       |      f       |  5   |  6  |     f     |
      
      |     t       |      t       |  5   |  4  |     f     |
      |     t       |      t       |  5   |  5  |     t     |
      |     t       |      t       |  5   |  6  |     t     |
      |     t       |      f       |  5   |  4  |     t     |
      |     t       |      f       |  5   |  5  |     t     |
      |     t       |      f       |  5   |  6  |     f     |
      ```
      
      Otherwise, alerts should be triggered as before.
      
      * added issue number to test
      
      * fixed alignment issue
      
      * swapped goal and value around in comparison for readability
      
      * Fixing nits
      
      * Timeseries and progress bar now follow same logic
      
      I asked for clarification about when alerts fire in #ama-product in Metabase's Slack. There was consensus around the
      idea that 'reaches the goal' does generally imply 'meets the goal', so we can use the same comparators between
      progress bar and timeseries goals now.
      
      This simplifies the goal-met? function again because it's no longer necessary to check if the given data is a
      timeseries goal.
      
      * Adjusted text in goal line alert modal
      
      * ran prettier
      Unverified
      5a5a789d
    • Nemanja Glumac's avatar
      Fix 19630 (#19655) · 1dae9127
      Nemanja Glumac authored
      * Fix duplicate model tooltip
      
      * Fix archive model title
      
      * Fix edit model modal title
      
      * Fix model verification title
      
      * Fix add model to dashboard title
      
      * Fix failing unit test
      
      * Update model's archive message
      Unverified
      1dae9127
    • Luis Paolini's avatar
      Separate builder from tester (#19491) · 05438f7e
      Luis Paolini authored
      * Separate builder from tester
      
      * indentation error
      
      * Final testing [ci nocache]
      
      * [ci nocache]
      Unverified
      05438f7e
    • Jeff Bruemmer's avatar
      docs - slack update (#19593) · 5291b0d3
      Jeff Bruemmer authored
      Unverified
      5291b0d3
    • Jeff Evans's avatar
      Fix bigquery-cloud-sdk dataset-id normalization logic (#19663) · e48b21db
      Jeff Evans authored
      Move bulk of dataset-id normalization logic into new private helper fn
      
      Perform app DB update for db-details after dataset-id has been turned into inclusion filter
      
      Add test to confirm that normalization only happens once
      Unverified
      e48b21db
    • Alexander Polyankin's avatar
      Unverified
      02400723
    • Nemanja Glumac's avatar
      Update assets related to Models (previously "Datasets") (#19676) · 0cba123b
      Nemanja Glumac authored
      * Update SVG model illustration
      
      * Update dataset -> model icons and their references
      
      * Update icon names in collections
      Unverified
      0cba123b
Loading