This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 03, 2021
-
-
Walter Leibbrandt authored
Co-authored-by:
Raimon Grau <raimonster@gmail.com>
-
Jeff Evans authored
Add new namespace to manage diagnostic info about the DW DB connection pools Adding new atom/fn/macro to wrap the capture of diagnostic info, modeled after the call counting functionality of toucan.db Capturing diagnostic info from a new `datasource-with-diagnostic-info!` fn in the execute namespace, and calling that from the various drivers (instead of `datasource`) Adding to log message generated for the "stats" portion of the line logged via middleware to output this information
-
Ariya Hidayat authored
-
- May 02, 2021
-
-
Ariya Hidayat authored
Use the lexical determination of enclosing function, which makes it more robust agains syntax error or incompleteness. Also, increase the test coverage. * Fix testing the operator * Offer the help text upon a complete field reference (with some tests)
-
- May 01, 2021
-
-
Ariya Hidayat authored
Add some more extensive unit tests. * Test for operator, not whitespace
-
Ariya Hidayat authored
This ensures that the test is deterministic, i.e not exhibiting different behavior relative to the current date.
-
Ariya Hidayat authored
This ensures that the test is deterministic, i.e not exhibiting different behavior relative to the current date.
-
Alexander Lesnenko authored
-
- Apr 30, 2021
-
-
Howon Lee authored
* limit and offset work upon hand exercise * limit added * add the test * docstring is wrong make it not wrong * fix namespace decl * they were test bugs only * stick that limit and offset in there * Permissions imports * make it work in dbs that are not just h2 * add limit test get * needs integer * juice the coverity lol * just stick querying in the overall dealie * tests pass * add counter * rip out the clauses * not just if limited * docstring misplaced * more linting * cool tests * tests pass but lacking test lol * group id works * test works * fix jeff nits * break that api * add test for count * cypress works for some reason lol * fix capitalizations * admin people pagination frontend (#15821) * admin people pagination frontend * admin people pagination and search specs * address review comments * fix rebase * address review comments Co-authored-by:
Alexander Lesnenko <alxnddr@users.noreply.github.com>
-
Ariya Hidayat authored
-
Ariya Hidayat authored
This is carried out via lexical replacement, i.e. finding the token to be replaced, instead of the rather-brittle and often-incorrect regex for prefix/postfix. * Always place the caret after the replacement text * Only accept suggested "(" when there is no forthcoming "(" already
-
Ariya Hidayat authored
As we progress better with refactoring and simplification, the complexity threshold should be reduced as well.
-
- Apr 29, 2021
-
-
Alexander Lesnenko authored
-
Dalton authored
-
Alexander Lesnenko authored
-
Ariya Hidayat authored
-
- Apr 28, 2021
-
-
Ariya Hidayat authored
-
Dalton authored
* replace onMouseUp with onClick * make TableInteractive cell keyboard accessible
-
Ariya Hidayat authored
-
- Apr 27, 2021
-
-
Ariya Hidayat authored
-
Alexander Lesnenko authored
An example of failed smoke tests run prior to this fix: https://app.circleci.com/pipelines/github/metabase/metabase/15496/workflows/d4937774-3ef6-412b-a7c8-a6b9e47b5515/jobs/594197
-
Ariya Hidayat authored
It's terrifying to see lots of error messages when the expression is invalid or not completed yet. To overcome this, we display only one, the highest-priority and most friendly one. The rank is: * tokenization error, e.g. mismatched parentheses * type-checking error, e.g. incorrect count of function arguments * syntax error (from the parser) * Fix coding style issue * Robust against non-Array compileError
-
Noah Moss authored
* fix grammar in developers guide * more small dev guide fixes
-
- Apr 26, 2021
-
-
Luis Paolini authored
* Update .ebextensions to send memory usage to Cloudwatch and also install inspector agent to actively monitor threats. Added full Cloudwatch agent with metrics config, simplified config file. Fix #9021 * Adding a few items to documentation * Apply suggestions from code review Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> * Add a few more changes to finish this PR Co-authored-by:
Jeff Bruemmer <jeff@metabase.com>
-
Jeff Evans authored
Set c3p0 dataSourceName property to include Metabase specific info Change data-warehouse-connection-pool-properties multimethod to include database as 2nd param Setting the dataSourceName c3p0 property to have the format db-<N>-<D>-<DB> where <N> is the DW database ID, <D> is the driver name, and <DB> is the database name from the db details Adding test Setting c3p0 dataSourceName for the app DB pool as well
-
Gustavo Saiani authored
-
Ariya Hidayat authored
* Custom expression: friendlier message on failing tokenization This covers cases such as: * invalid characters * unterminated quoted string * unterminated bracket/field reference * Ensure that tokenizerError is initialized properly
-
Alexander Lesnenko authored
-
Nemanja Glumac authored
* Fix `eslint-react/no-string-refs` errors (#15427) * Handle errors in `AdminLayout.jsx` * Rmove unused ref from `MetadataEditorApp.jsx` * Remove unused ref from `EditBar.jsx` * Handle errors in `Confirm.jsx` * Handle errors in `Header.jsx` * Handle errors in `NewsletterForm.jsx` * Handle errors in `ColorPicker.jsx` * Remove unused ref from `PasswordReveal.jsx` * Handle errors in `Triggerable.jsx` * Handle errors in `TokenField.jsx` * Handle errors in `DashboardHeader.jsx` * Handle errors in `RefreshWidget.jsx` * Handle errors in `DatabaseEditApp.jsx` * Handle errors in `FieldRemapping.jsx` * Handle errors in `ObjectActionsSelect.jsx` * Handle errors in `ObjectRetireModal.jsx` * Remove unused ref from `UserGroupSelect.jsx` * Handle errors in `PermissionsGrid.jsx` * Handle errors in `ParameterTargetWidget.jsx` * Handle errors in `ParameterValueWidget.jsx` * Handle errors in `PulseEdit.jsx` * Handle errors in `PulseEditName.jsx` * Handle errors in `DataSelector.jsx` * Remove unused ref from `FieldWidget.jsx` * Handle errors in `NativeQueryEditor.jsx` * Handle errors in `SearchBar.jsx` * Handle errors in `ExpressionEditorTextfield.jsx` * Remove unused ref from `FieldWidget.jsx` * Remove unused ref from `SpecificDatePicker.jsx` * Handle errors in `RevisionMessageModal.jsx` * Handle errors in `Setup.jsx` * Handle errors in `LeafletMap.jsx` * Handle errors in `TableSimple.jsx` * Handle errors in `PieChart.jsx` * Handle errors in `Progress.jsx` * Remove unused refs from `QueryBuilder.jsx` * Remove unused ref and methods from `MetadataHeader.jsx` * Remove unused ref from `DashboardActions.jsx` * Handle errors in `DatabaseListApp.jsx` Note: dynamic refs * Handle errors in `LegendHorizontal.jsx` Note: dynamic refs * Disable linting rule `react/no-string-refs` in `LegendVertical.jsx` Note: dynamic refs * Partially handle errors in `GuiQueryEditor.jsx` * Disable linting rule `react/no-string-refs` in `GuiQueryEditor.jsx` Note: dynamic refs * Revert "Remove unused ref from `DashboardActions.jsx`" This reverts commit 5facb9d60ecb561093af15efcfc99b29ff96980e. * Handle errors in `DashboardActions.jsx` * Remove redundant `ReactDOM.findDOMNode` from `Setup.jsx` * Revert "Handle errors in `DashboardActions.jsx`" This reverts commit b3d64b8f7a982e0371d225d0d624ecbeaf776b76. * Disable linting for `DashboardActions.jsx` * Fix prettier error * Delete non-existing prop `getTarget` * Fix typo * Fix typos in more places * Fix `footerRef` check * Turn on `react/no-string-refs` lint rule * Disable `react/prop-types` in files that are breaking the build * Fix broken refs Co-authored-by:
alxnddr <alxnddr@gmail.com>
-
- Apr 23, 2021
-
-
Ariya Hidayat authored
-
Ariya Hidayat authored
* Custom expression: a new exception-free, safe (bounded) tokenizer * Address code review feedback
-
Alexander Lesnenko authored
* Revert "Fix tooltip value on unaggregated data (#15472)" This reverts commit 057b6bbc. * Fix wrong tooltip on charts with unaggregated data * unskip repro for #11907 * temporary set resize throttling to 0 when the app is open in Cypress to reduce flakiness
-
Dalton authored
* Add a basic ClampedText UI component * sprinkle some classes * rmv some unneeded css props * update component section * make line-breaks work correctly * fix prop type error * safeguard ref reference
-
Dalton authored
* add timeline component * rmv BEM classes
-
- Apr 22, 2021
-
-
dpsutton authored
* Table collection_revision -> collection_permission_graph_revision in anticipation of getting collection revisions in, need the table name as the previous table named this was tracking changes to the permission graph * rename collection permission graph revision alias * Remove unnecessary or for precondition * Rename sequence in sql liquibase has a renameSequence changeset but it doesn't work for h2 obviously. However, it doesn't allow this constraint to be honored with a precondition. Just having this changeset on h2 blows up
-
Dalton authored
* add icons for bucm * 32px wide icons Co-authored-by:
Maz Ameli <maz@metabase.com>
-
Ariya Hidayat authored
-
Cam Saul authored
Merge `release-x.39.x` to `master`
-
Nemanja Glumac authored
* Add repro for 15725 * Test both repro steps scenarios
-
Anton Kulyk authored
* Optimize hasChildren collection check * Extract ItemList renderItem method * Optimize VirtualizedList * Fix collection page scroll behavior * Remove redundant import
-