Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 13, 2020
  2. Nov 12, 2020
  3. Nov 11, 2020
    • Cam Saul's avatar
      Mega sync performance improvements (#13746) · a81ae199
      Cam Saul authored
      * Add a Postgres test [ci postgres]
      
      * Mega-optimized SELECT probe query [ci drivers]
      
      * Mega sync improvements [ci drivers]
      
      * Even more amazing sync perf improvements [ci drivers]
      
      * Fix bad edit [ci drivers]
      
      * Test/lint fixes :wrench:
      
      * Test fix :wrench: [ci drivers]
      
      * Some driver fixes :wrench: [ci drivers]
      
      * Address PR feedback [ci drivers]
      
      * Test fixes for everything except for Oracle [ci drivers]
      
      * Fix Oracle [ci drivers]
      
      * Fix Redshift [ci redshift]
      Unverified
      a81ae199
  4. Nov 10, 2020
  5. Nov 09, 2020
  6. Nov 06, 2020
    • dpsutton's avatar
      Fingerprints reduce over table-rows-sample instead of realizing all (#13688) · 1256e7b8
      dpsutton authored
      * Fingerprints reduce over table-rows-sample instead of realizing all
      
      tests are failing because we test fingerprinters a lot by supplying
      fake results and then reducing over those results. Now we are reducing
      over them in the query processor and need to get a better testing
      strategy.
      
      I think i can stub out the query-processor to take the `:rff` and just
      transduce over some fake supplied results but need to verify
      
      * Hijack query-processor to use rff on fake data
      
      * Docstring and make private `table-rows-sample-query`
      
      * Fix tests to use query function rather than hijack qp
      
      also was calling empty not empty? :(
      
      * drivers check [ci drivers]
      
      * Docstring cleanup for rff and remove outdated comment
      
      * Make rff required for table-rows-sample
      
      now you must reduce over the reducible row set rather than realizing
      the results in memory and then working with them
      
      * empty commit for drivers [ci drivers]
      Unverified
      1256e7b8
    • Cam Saul's avatar
      Mega build script improvements (#13638) · cfa6bf84
      Cam Saul authored
      * Mega build script improvements
      
      * Look for project.clj to determine root directory since we delete .git on CI for speed
      
      * If .git folder is missing (i.e., in CI) fail gracefully
      
      * Don't need to generate version file to run Cypress tests, right?
      
      * Build uberjar step can cache version.properties
      (so the Cypress test steps don't need to generate it again)
      
      * Flush caches
      
      * Update uberjar cache key
      Unverified
      cfa6bf84
  7. Nov 05, 2020
  8. Nov 04, 2020
  9. Nov 03, 2020
  10. Nov 02, 2020
  11. Oct 30, 2020
  12. Oct 29, 2020
  13. Oct 28, 2020
    • Ariya Hidayat's avatar
      Put yaml-lint into devDependencies (#13600) · 8be77462
      Ariya Hidayat authored
      * Put yaml-lint into devDependencies
      
      That way, the CI run is more reproducible (no need to install yaml-lint
      on the fly).
      
      * Attempt to lint YAML files via yarn run
      
      * Update the CI workflow dependency for yaml-linter
      Unverified
      8be77462
    • dpsutton's avatar
      Show engine in Task trouble shooting logs (#13608) · 73737b41
      dpsutton authored
      * Show engine in Task trouble shooting logs
      
      in an effort to get better feedback when people raise issues about
      long running sync processes, include the database engine in the logs.
      
      Also wrapped `th` in a `tr` inside the `thead` to remove react warning
      
      * Const intead of let on the db_id_to_engine
      
      * Swap db id for db name
      
      * Move comment out of jsx
      Unverified
      73737b41
  14. Oct 27, 2020
    • Nemanja Glumac's avatar
      Fix failing Cypress test in `dashboard-drill` spec file (#13612) · cb4371e9
      Nemanja Glumac authored
      * Fix failing Cypress test in `dashboard-drill` spec file
      
      * Assert that the page content rendered (as per @dacort 's suggestion)
      Unverified
      cb4371e9
    • Tim Macdonald's avatar
      [Fixes #11879] [Fixes #8410] Don't wrap email attachment filenames (#13563) · 91ff78a2
      Tim Macdonald authored
      * [Fixes #11879] [Fixes #8410] Don't wrap email attachment filenames
      
      * Non-ASCII characters in filenames are encoded [as per IETF RFC
        2047](https://tools.ietf.org/html/rfc2047) (c.f. #8410)
      * Sufficiently-long _encoded_ filenames are sent over multiple lines
          as per [RFC 2184 section
          3](https://tools.ietf.org/html/rfc2184#section-3), for example:
      
          ```
          Content-Disposition: attachment;
            filename*0="=?UTF-8?Q?T=C3=A9=C5=BFting_non-ASCII_=C4=8D=C4=A5=C3=A4ract";
            filename*1="ers.xlsx?="
          ```
      * Many mail clients do the right thing, but Gmail does not
      
      This commit therefore turns off wrapping, as per [Bill Shannon's
      Stack Overflow answer re. an undocumented system
      property](https://stackoverflow.com/a/53344141/220529)
      (Bill Shannon co-wrote the Java email library, which is used by postal
      (the Clojure wrapper we use).
      
      * (Hopefully) fix race condition in dashboard drill Cypress spec
      
      Suggested by @flamber
      
      * Skip flaky Cypress tests (per Nemanja)
      
      * Only set `mail.mime.splitlongparameters` once
      Unverified
      91ff78a2
    • dpsutton's avatar
      Adds dev/src/dev/nocommit to ignore file (#13353) · 1ab05174
      dpsutton authored
      * Adds dev/src/dev/nocommit to ignore file [ci skip]
      
      now you can create a folder nocommit/ under the dev classpath root so
      you can keep some namespaces around as you work on features.
      
      Ex:
      
      ```clojure
      (ns dev.nocommit.oom
        (:require [metabase.models
                   [database :refer [Database]]
                   [field :refer [Field]]
                   [table :refer [Table]]]
                  [metabase.sync.analyze
                   [fingerprint :as analyze.fingerprint]]
                  [metabase.sync :as sync]
                  [metabase.sync
                   [field-values :as sync.field-values]]
                  [metabase.models.field-values :as field-values]
                  [metabase.sync.analyze.fingerprint.fingerprinters :as fingerprinters]
                  [metabase
                   [util :as u]]
                  [metabase.sync.sync-metadata.fields :as metadata.fields]
                  [metabase.sync.sync-metadata.fields.fetch-metadata :as fetch-metadata]
                  [metabase.query-processor :as qp]
                  [toucan.db :as db]
                  [metabase.db
                   [metadata-queries :as metadata-queries]]))
      
      (def pg (Database 4))
      
      (comment
        (fetch-metadata/db-metadata pg emails-table)
        (metadata.fields/sync-fields! pg)
      
        (sync/sync-database! pg))
      
      (clojure.test/run-tests 'whatever-namespace)
      
      ```
      
      I ended up with lots of `(comment ...)` blocks in lots of different
      namespaces and this has helped keep my worktree clean.
      
      * Empty commit to trigger CI [ci skip]
      
      skipping ci thought so hopefully the checks on Github are satisified.
      Unverified
      1ab05174
    • Kyle Doherty's avatar
Loading