This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 09, 2023
-
-
Oisin Coveney authored
-
- Aug 07, 2023
-
-
Anton Kulyk authored
-
- Aug 03, 2023
-
-
Cal Herries authored
-
shaun authored
-
- Aug 02, 2023
-
-
Kamil Mielnik authored
* Add actions dropdown to object detail modal (#32331) * Rename showActions to showControls * Use Flex * Import Flex from local modules * Make horizontalAttachments a prop in EntityMenu * Use EntityMenu to create actions dropdown * Render actions menu conditionally * Add useActionListQuery * Fetch actions in ObjectDetailHeader * Remove unused canRunActions prop * Move logic to root component * Fix tests * Use canRunAction and fetch databases in ObjectDetail view * Rename actions to actionItems and getActions to getActionItems * Extract getActionItems to utils * Update tests * Rename modelActions to actions * Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems * Consolidate getActionItems * Use theme scale values for Mantine Flex component * Either render all controls or none * Fix default props/state in EntityMenu * Fix props * Update ObjectDetail unit tests * Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction * Update tests with more specific non-implicit action cases * Use singular form to match function interface * Add unit tests for getActionItems * Update test case name * Avoid using Database constructor - Use metadata.database() instead * Add integration tests for basic cases when action menu is rendered and not * Fix post-merge error * Endpoint to fetch implicit actions param values (#32466) * Add default update action to actions dropdown in object detail modal (#32433) * Rename showActions to showControls * Use Flex * Import Flex from local modules * Make horizontalAttachments a prop in EntityMenu * Use EntityMenu to create actions dropdown * Render actions menu conditionally * Add useActionListQuery * Fetch actions in ObjectDetailHeader * Remove unused canRunActions prop * Move logic to root component * Fix tests * Use canRunAction and fetch databases in ObjectDetail view * Rename actions to actionItems and getActions to getActionItems * Extract getActionItems to utils * Update tests * Rename modelActions to actions * Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems * Consolidate getActionItems * Use theme scale values for Mantine Flex component * Either render all controls or none * Fix default props/state in EntityMenu * Fix props * Update ObjectDetail unit tests * Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction * Update tests with more specific non-implicit action cases * Use singular form to match function interface * Add unit tests for getActionItems * Update test case name * Sort imports * Rename initialValues to values * Rename dashcardParamValues to initialValues * Lift fetchInitialValues up from ActionParametersInputForm * Rename refetchValues to prefetchValues * Fix tests * Refactor shouldPrefetch to be a prop * Get rid of dashboard and dashcard props from ActionParametersInputForm * Lift the canPrefetch condition up as it is not desired outside of dashboards * Hook update action with temporary API * Use executeActionId in fetchInitialValues * Fix post-merge conflict * Rename prefetchValues to prefetchDashcardValues * Use the new endpoint * Use rem values instead of scale values - See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835 * Lift data reloading out of executeRowAction * Add onSuccess prop to ActionExecuteModal * Use onSubmitSuccess from ActionParametersInputForm * Reload question after action is successful * Fix stale prop issues in ActionParametersInputForm * Fix object id in initialValues * Add prefetchesInitialValues prop to make useActionForm more generic * Ignore public actions for now * Fix id mixup * Update unit test * Remove redundant memoization * Use modern JS syntax instead of noop * Move getNextId to __support__/utils * Extract isImplicitDeleteAction & isImplicitUpdateAction * Reuse isImplicitDeleteAction * Log error to console * Get rid of useLatest * Fix post-merge build error * Add default delete action to actions dropdown in object detail modal (#32556) * Rename showActions to showControls * Use Flex * Import Flex from local modules * Make horizontalAttachments a prop in EntityMenu * Use EntityMenu to create actions dropdown * Render actions menu conditionally * Add useActionListQuery * Fetch actions in ObjectDetailHeader * Remove unused canRunActions prop * Move logic to root component * Fix tests * Use canRunAction and fetch databases in ObjectDetail view * Rename actions to actionItems and getActions to getActionItems * Extract getActionItems to utils * Update tests * Rename modelActions to actions * Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems * Consolidate getActionItems * Use theme scale values for Mantine Flex component * Either render all controls or none * Fix default props/state in EntityMenu * Fix props * Update ObjectDetail unit tests * Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction * Update tests with more specific non-implicit action cases * Use singular form to match function interface * Add unit tests for getActionItems * Update test case name * Sort imports * Rename initialValues to values * Rename dashcardParamValues to initialValues * Lift fetchInitialValues up from ActionParametersInputForm * Rename refetchValues to prefetchValues * Fix tests * Refactor shouldPrefetch to be a prop * Get rid of dashboard and dashcard props from ActionParametersInputForm * Lift the canPrefetch condition up as it is not desired outside of dashboards * Hook update action with temporary API * Use executeActionId in fetchInitialValues * Fix post-merge conflict * Rename prefetchValues to prefetchDashcardValues * Use the new endpoint * Use rem values instead of scale values - See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835 * Lift data reloading out of executeRowAction * Add onSuccess prop to ActionExecuteModal * Use onSubmitSuccess from ActionParametersInputForm * Reload question after action is successful * Fix stale prop issues in ActionParametersInputForm * Fix object id in initialValues * Add prefetchesInitialValues prop to make useActionForm more generic * Ignore public actions for now * Fix id mixup * Update unit test * Add DeleteObjectModal * Introduce useActionQuery * Use useActionQuery in DeleteObjectModal * Hook action execution * Fix typo in copy * Sort exports * Remove redundant memoization * Use modern JS syntax instead of noop * Move getNextId to __support__/utils * Extract isImplicitDeleteAction & isImplicitUpdateAction * Reuse isImplicitDeleteAction * Fix object modal getting closed with Escape key when delete or update modals are open * Rename isUpdateModalOpen to isActionExecuteModalOpen, updateActionId to actionId * Navigate to sibling row or close the modal on deletion * Revert "Navigate to sibling row or close the modal on deletion" This reverts commit 8b24685eee5cd968f53cc14b7194a66588fb5845. * Close object detail on deletion * Add error handling * Add error handling * Greatly simplify DeleteObjectModal - remove useActionQuery usage - remove useActionQuery - remove DeleteObjectModal.styled.tsx * Improve diff * Shorten code * Always cast objectId to number - See https://metaboat.slack.com/archives/C057T1QTB3L/p1690292706101109?thread_ts=1690279562.697669&cid=C057T1QTB3L "the reason you’re not seeing it fail on the sample dataset is probably because you’re using h2 for sample-dataset. it’ll fail the same if you use a postgres one. h2 is probably more loose in type so it allows sending a string for id. nevertheless, I think you can use cast it to the correct type using the param type. I think we did that on the UI where we execute actions from model details page." * Inline disabled into JSX * Use a more friendly error message when failed to delete an object because it's referenced by other objects - See: https://metaboat.slack.com/archives/C057LE0Q4PQ/p1690377421352469?thread_ts=1690208614.530869&cid=C057LE0Q4PQ * Revert "Use a more friendly error message when failed to delete an object because it's referenced by other objects" This reverts commit 28327ac9b53ae92300e579d047b7f136d54e581e. Friendly message is going to be implemented in https://github.com/metabase/metabase/issues/32694 * Rename initialValues back to dashcardParamValues in ActionVizForm * Tests for basic deletes and updates on object detail views (#32525) * Rename showActions to showControls * Use Flex * Import Flex from local modules * Make horizontalAttachments a prop in EntityMenu * Use EntityMenu to create actions dropdown * Render actions menu conditionally * Add useActionListQuery * Fetch actions in ObjectDetailHeader * Remove unused canRunActions prop * Move logic to root component * Fix tests * Use canRunAction and fetch databases in ObjectDetail view * Rename actions to actionItems and getActions to getActionItems * Extract getActionItems to utils * Update tests * Rename modelActions to actions * Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems * Consolidate getActionItems * Use theme scale values for Mantine Flex component * Either render all controls or none * Fix default props/state in EntityMenu * Fix props * Update ObjectDetail unit tests * Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction * Update tests with more specific non-implicit action cases * Use singular form to match function interface * Add unit tests for getActionItems * Update test case name * Sort imports * Rename initialValues to values * Rename dashcardParamValues to initialValues * Lift fetchInitialValues up from ActionParametersInputForm * Rename refetchValues to prefetchValues * Fix tests * Refactor shouldPrefetch to be a prop * Get rid of dashboard and dashcard props from ActionParametersInputForm * Lift the canPrefetch condition up as it is not desired outside of dashboards * Hook update action with temporary API * Use executeActionId in fetchInitialValues * Fix post-merge conflict * Rename prefetchValues to prefetchDashcardValues * Use the new endpoint * Use rem values instead of scale values - See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835 * Lift data reloading out of executeRowAction * Add onSuccess prop to ActionExecuteModal * Use onSubmitSuccess from ActionParametersInputForm * Reload question after action is successful * Fix stale prop issues in ActionParametersInputForm * Fix object id in initialValues * Add prefetchesInitialValues prop to make useActionForm more generic * Add test cases for other types of actions * Ignore public actions for now * Add e2e test for actions in object detail view * Add second step and extract helpers * Remove duplication by changing hierarchy * Add step with enabling model actions * Fix visiting model page * Remove redundant code * Ignore public actions for now * Fix id mixup * Update unit test * Add objectId argument and function to open the modal * Define whole order object to reuse * Implement assertOrderFormPrefilled * Assert Created At * Add assertion to check whether object with new id has been reloaded * Use all caps for constants * Verify updating an object * Fix test name * Assert toast is shown on update * Format code * Use writable tables instead of sample db to avoid persisting updates between tests - do not mock objects, assert against whatever comes from API * Format code to wake GitHub up * Add DeleteObjectModal * Introduce useActionQuery * Use useActionQuery in DeleteObjectModal * Hook action execution * Fix typo in copy * Sort exports * Remove redundant memoization * Use modern JS syntax instead of noop * Move getNextId to __support__/utils * Extract isImplicitDeleteAction & isImplicitUpdateAction * Reuse isImplicitDeleteAction * Fix object modal getting closed with Escape key when delete or update modals are open * Rename isUpdateModalOpen to isActionExecuteModalOpen, updateActionId to actionId * Navigate to sibling row or close the modal on deletion * Revert "Navigate to sibling row or close the modal on deletion" This reverts commit 8b24685eee5cd968f53cc14b7194a66588fb5845. * Close object detail on deletion * Add error handling * Add error handling * Greatly simplify DeleteObjectModal - remove useActionQuery usage - remove useActionQuery - remove DeleteObjectModal.styled.tsx * Improve diff * Shorten code * Rename initialValues back to dashcardParamValues in ActionVizForm * Extract assertScoreUpdatedInTable * Extract visitModelDetail * Add deletion and toast assertion * Remove unused arguments * Assert delete failed * Update tests order after starting with writable db * Move assertions to beginning of the test, remove enableDatabaseActions * Test disabling model actions * Add extra assertion * Update names * Update the deletion assertion * Remove unused code * Wrap tests in another describe, setup dashboard test * Fix setup, use asAdmin util * Add assertion for dashboard object view * Update test names * Extract actions to a constant * Add test to open update object modal * Update assertion order * Add test to open delete object modal * Organize tests * Add a test case for implicit public delete action & implicit archived delete action * Remove redundant async * Reuse findActionInActionMenu * Remove redundant constant * Fix tests * Add a test case for databases with disabled actions * Update wording * Use dataset instad of a query question * Revert name change as it does not make sense * Format code * Add a test case for users with no write permission * Add a test case for when showControls is false * Add a test case for models with clauses * Use metadata.question() instead of new Question() * Tests for various number of PKs in a model (#32784) * Add a test case for 0 PKs in a model * Add a test case for 2 PKs in a model * Improve test names * Fix typo * Use plural form for "PK" --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Jul 31, 2023
-
-
Alexander Polyankin authored
-
- Jul 21, 2023
-
-
shaun authored
* month-year formats (“January, 2023” → “January 2023”) * quarter-year formats (“Q1 - 2023” or “Q1, 2023” → “Q1 2023”)
-
Oisin Coveney authored
-
- Jul 14, 2023
-
-
Oisin Coveney authored
-
- Jul 10, 2023
-
-
Alexander Polyankin authored
-
Denis Berezin authored
* Add long column name handling for column filter * Refactored solution to utilize Ellipsified component * Review fixes * Add e2e test, more review fixes
-
- Jul 08, 2023
-
-
shaun authored
-
- Jul 07, 2023
-
-
Anton Kulyk authored
-
- Jul 06, 2023
-
-
Uladzimir Havenchyk authored
jsdom lib had a perf problem with getComputedStyle method, which is used a lot with css in js solutions. The problem was addressed in JSDOM 22.1.0, but jest itself waits for the major upgrade to take it into account. The temporary proposed solution is to use yarn resolutions.
-
- Jul 05, 2023
-
-
Kamil Mielnik authored
Adding filter of summarized field grouped by latitude and longitude on a map changes visualization type (#31646) * Take sourceQuery into account if StructuredQuery does not have any aggregations or breakouts when determining Question's default display - It's an attempt to fix #30057 * Don't check source query for models * Use source query breakouts and aggregations to determine default display only if the question does not have any breakouts, aggregations, and joins - Make the condition to always use "table" display for Models more prominent * Revert first attempt * Introduce CardObject and fix displayIsLocked typing * Refactor maybeUnlockDisplay into maybeResetDisplay * Revert "Introduce CardObject and fix displayIsLocked typing" This reverts commit 770e7a50d3b9f381741ba7cb1655c1d9be5f295c. * Improve diff * Update unit tests after maybeUnlockDisplay to maybeResetDisplay refactoring * Update maybeResetDisplay unit tests * Improve test case names * Add tag for the test that reproduces the issue * Add test for issue #30057 - use visualize() helper - extract addCountGreaterThan2Filter() * Add a test case for adding columns * Add a test case for removing columns (resetting to default value) * Add a test case for adding aggregations * Add another test case * Reuse e2e helpers - add missing "field" parameter support in addSummaryGroupingField - add removeSummaryGroupingField * Remove redundant condition * Update issue id in tests after extracting separate GitHub issue
-
- Jul 04, 2023
-
-
john-metabase authored
This reverts commit 9da0bd76.
-
shaun authored
-
- Jun 30, 2023
-
-
Alexander Polyankin authored
-
- Jun 29, 2023
-
-
Ryan Laurie authored
* require table primary key to enable basic actions * add unit tests * update model detail page test metadata
-
Anton Kulyk authored
* Migrate notebook aggregations to MLv2 — Operators (1) (#31527) * Add aggregation types * Add aggregation TypeScript wrappers * Move `AggregateStep` to its own directory * Port basic features to MLv2 * Deprecate `AggregationPopover` * Fix MLv1's aggregation clause validation * Fix import * `requiresField` → `requiresColumn` * Add basic tests for `AggregationPicker` * Add `findAggregationOperator` test utility * Add basic tests for `AggregateStep` * Make stage index explicit * Highlight selections, add picker back button * Use long display name for aggregation clauses * Remove `React` imports * Enable temporal bucketing * Use aggregation JS wrappers * Fix `Icon` import * Patch unit test according to BE changes * Fix E2E test * Simplify `Aggregation's` `dimension` method * Fix formatting * Migrate notebook aggregations to MLv2 — Metrics (2) (#31528) * Add basic legacy metrics support * Don't show archived metrics * Highlight selected metric * Extract `AggregationPopover` in notebook step * Fix `onClose` prop * Fix icon * Add missing metric types * Use MLv2 to manage metrics * Remove legacy query logic * Add `Aggregatable` type * Migrate notebook aggregations to MLv2 — Inline expressions (3) (#31529) * Revert "Remove legacy query logic" This reverts commit 722804d3a6684762701351c658625b5439c75c2b. * Use HTML labels in `ExpressionWidget` * Support inline expressions for aggregations * Fix import * Fix picker navigation * Fix type error * Remove `ts-expect-error` * Migrate notebook aggregations to MLv2 — Disable MLv1 validation (4) (#31530)
-
- Jun 26, 2023
-
-
Ryan Laurie authored
* allow image preview in object detail
-
Alexander Polyankin authored
-
- Jun 23, 2023
-
-
Aleksandr Lesnenko authored
-
- Jun 21, 2023
-
-
Emmad Usmani authored
* add distinct urls for dashboard tabs * switch to using useEffect * refactor separate hook useSyncURLSlug * add to public dashboards * fix bug when saving * rename hooks to match codebase convention * don't show slug in url when only one tab remains * update DashboardTabs unit test to include slug logic * refactor test to use findSlug helper method * replace history entry when initializing tab * more unit tests * another unit test * add e2e tests
-
- Jun 20, 2023
-
-
john-metabase authored
-
- Jun 19, 2023
-
-
Mahatthana (Kelvin) Nomsawadi authored
* Encourage admin users to connect to a database (#31210) * Encourage admin users to connect to a database * Only render either payment banner or database prompt banner Discussed here: https://metaboat.slack.com/archives/C057T1QTB3L/p1685549180307149?thread_ts=1685547913.580079&cid=C057T1QTB3L * Improve mobile view layout * Address review: Remove `withRouter` HoC * Address review: Remove optional chaining * Address review: Refactor a component's deprecated `shouldRender` property * Add an e2e test to cover happy path * Remove new translation in `aria-label` * Fix sticky parameter widgets when showing database prompt banner * Fix E2E tests * Address review: Add missing unit tests * Fix a failed E2E test from rebasing off `master` branch * Add analytics (#31470) * 2/x Add analytics * Fix a failed E2E test from merging code from master * Prevent rendering the database prompt banner when white labeling (#31471) * 3/x Convert enterpise settings selectors to TypeScript * Add missing enterprise settings selectors tests * Don't render db prompt banner when white labeling * Reorganize the test to make an EE test more standing out * Address review: Remove unused function * 4/x Follow up reviews and tests (#31545) * 4/x Address review: Simplify code structure * Address review: Fix variable name collision * Move logic to display database banner to a hook * Remove unnecessary await * Restructure AppBanner tests * Swap test position to match the defined test matrix * Address review: removed outdated comment * Address review: Make `useShouldShowDatabasePromptBanner` hook tests clearer * Address review: Make conditions easier to follow Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * 5/x Add embedding tests (#31557) * 5/x Add embedding tests * Clean up: Fix a selector signature * Address review: Using existing utility * Ensures that embedding pages are loaded before asserting UI not existing * Ready to write PublicQuestion tests * Move public and signed embeds tests to unit tests * Removed outdated eslint comment --------- Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Jun 13, 2023
-
-
Kamil Mielnik authored
* Remove unused openCollection prop * Preserve collection sorting given by API in getExpandedCollectionsById - Fixes #31294 * Use Collections.getListStatePath() to unhardcode the object path * Use CollectionId instead of any * Extract Collections.selectors.getCollectionList * Convert Collections selectors unit tests to TypeScript * Remove redundant selector * Add a unit test for Collections.selectorsgetExpandedCollectionsById * Use createMockCollection for all test collections - Use Partial<Collection> instead of MockCollection type * Add a test case for non-nested collections * Rename identifiers * Add a test suite for snippet collections * Fix SnippetCollections.selectors.getExpandedCollectionsById * Refactor tests * Refactor tests * Revert unit tests for selectors * Revert convert selectors to TypeScript * Add error support to setupCollectionsEndpoints * Introduce useCollectionsQuery * Fix tests * Add unit tests for preserving order of collections in ItemPicker * Make assertions more semantic * Allow mocking root collection - Make ROOT_COLLECTION object match Collection type * Add tests for preserving order in snippet collections list - fix case with an undefined snippet collections list * Update test case with data loading necessary for ItemPicker underneath the EditSandboxModal after updating selectors * Update test case with data loading necessary for ItemPicker underneath the AddToDashSelectDashModal after updating selectors * Rename useCollectionsQuery to useCollectionListQuery * Remove leftover fetchMock * Move error out of setupCollectionsEndpoints * Fix ModelDetailPage unit tests setup * Remove leftover fetchMocks * Revert changes to ROOT_COLLECTION constant - use createMockCollection * Fix typing * Remove dead link to Source Sans Pro font - it caused markdown check to fail during CI, this fixes it - it seems that the font has been removed from Google Fonts - users can still choose this font in Metabase settings - removal confirmation: https://metaboat.slack.com/archives/C5XHN8GLW/p1686320576992299?thread_ts=1686319384.637909&cid=C5XHN8GLW * Fix getExpandedCollectionsById selector * Revert adding useCollectionListQuery in unit tests
-
- Jun 09, 2023
-
-
Alexander Polyankin authored
-
- Jun 08, 2023
-
-
Alexander Polyankin authored
-
- Jun 07, 2023
-
-
Cam Saul authored
* Question URL methods to functions * Move URLs to their own file --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Alexander Polyankin authored
-
- Jun 05, 2023
-
-
Kamil Mielnik authored
* Make NativeQueryEditor testable - Mock just NativeQueryEditor.prototype.loadAceEditor instead of entire NativeQueryEditor * Fix invalid propTypes * Fix DatasetQueryEditor not re-rendering when props change - remove custom arePropsEqual argument from React.memo() on NativeQueryEditor - Fixes #30680 * Add a dirty initial NativeQueryEditor test setup * Add DatasetQueryEditor tests * Revert "Add a dirty initial NativeQueryEditor test setup" This reverts commit 0f985db272a2e8f1be755bda07c3b642fdf90f83. * Get rid of test errors * Clean up DatasetQueryEditor test * Add a test case for re-rendering of DatasetQueryEditor * Make setup function more reusable * Add 2 more test cases * Bring back global NativeQueryEditor mock as many tests depend on it * Add an e2e test for #30680 * Optimize DatasetEditor by conditionally rendering DatasetQueryEditor only when it can be seen * Remove redundant code * ESLint * Use createMockCollection instead of a cast * Move all Native Query creation to createMockNativeDatasetQuery * Use setupCollectionsEndpoints * Introduce setupNativeQuerySnippetEndpoints and use it in DatasetQueryEditor.unit.spec.tsx * Extract explanatory importDatasetQueryEditor * Remove file accidentally added when merging master * Add missing data-testid that got lost during a merge
-
- Jun 02, 2023
-
-
Maz Ameli authored
* arrow_left * check mark * arrow_up and chevrons * add, close, contract, embed, expand, sort * change viewbox to 16 * icons in +New menu, search, and sidebar toggle * info_outlined, connections or fk icon, and tweaks to x-ray suggestion icons * fix database icon * ellipsis, person, and tweak ellipsis size in collections sidebar * home, reference or book, pencil or edit, table * dashboard action icons, and remove reference to unused ClockIcon.jsx * question action icons and related component tweaks * larger icons on HomeModelCard on homepage * dashboard and add_to_dash * snippet and variables * all the chart type icons and some field type ones * mail and groups * make sidebar icons darker blue * fix add-your-data icon * filled mail icon and use it on events modal * stars * bolt and x-rays and a bunch more * granular, metric, revision history * arrows, formula, snippets * click, cloud, boolean, unpin * return, hourglass, popover * pause, ldap, burger * gear info list pin moon sum sun verified warning * fix size of row details modal icons * fix size of left nav icons * fix size on filter widgets and some selects * set default size to 16 to fix entity menu icons etc * fix pagination icons * size and color on ItemPicker * bump up database icon in /browse to 32px * /browse bolt icon size * find and remove instances of 14px size declarations * sql editor icons * sql expand/contract button alignment * collection breadcrumbs * remove two more size 14 declarations * viz selector * fix add icon in New button * fix size of ModelDetailLink * icon for question list empty state * get rid of model_framed icon * try to fix event tick icons, replace balloons with cake * standardize size of question footer actions * fix dinosaur * switch star_outline to star, and star to star_filled * fix notebook sort action * switch data picker from table2 to table * fix slack icon * restyle HomeXrayCard * fix List icon * fix sidebar toggle icon size * fix icon size in field picker popovers * fix summarize sidebar field type icons * fix summarize sidebar Add buttons * table heading sort icons * fix filter icon, resize button icons * bulk filters icons * admin datamodel icons sizing * fix datamodel metric and segment icons, and sort icon * dashboard interactivity sidebar close icon * get rid of grabber2 * bookmark and question actions icon sizes * revert icon * Icons cleanup (#31147) * remove timeline event icon stroke * cleanup * add 16x16 viewbox to svgs that were missing it * add slack_colorized * correct the join_full_outer icon * timeline events, cleanup * fix broken icons * more cleanup * fix storybook * fix all types * add stories * try fixing arrow_split --------- Co-authored-by:
Maz Ameli <maz@metabase.com> * fix specs * fix specs * remove unused icons * use constants * increase node memory allocation * bump for chromatic too * fixes * fix arrow_split icon * fix arrow_split path attributes * fix path again and fix sizing of drillthrough menu icons * more spec fixes * prettier --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Oisin Coveney authored
-
Oisin Coveney authored
-
Anton Kulyk authored
-
- May 31, 2023
-
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Add `dimensionOptionsForValidation` * Add `getMLv1CompatibleDimension` dimension method * Use `getMLv1CompatibleDimension` * Fix `getMLv1CompatibleDimension` usage * Add tests for `getMLv1CompatibleDimension`
-