This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Dec 07, 2022
-
-
dpsutton authored
* Fix flaky `remap-human-readable-string-column-test` Quite annoying test that would flake quite a bit in CI. the problem is that the mechanism for `mt/with-column-remappings` wasn't aware of the case when there were pre-existing mappings. It just blindly added a new mapping. But when the middleware fetching the remappings, it found the preexisting ones. For the venue.name field in this test, that was ("20th Century Cafe","25°","33 Taps","800 Degrees Neapolitan Pizzeria", ...). We were passing in fake names like "apple", "banana", "kiwi" and it found no remappings for those in the db. So the fix is to check for pre-existing ones, and if found, use `tu/with-temp-vals-in-db` to temporarily set them to the desired values, otherwise use some new ones with `tt/with-temp*` as it was doing previously. * log errors for CI * Only use type :full field values when remapping we store cached chained filter values in here (with type :linked-filter, there are also type :sandbox in there) but the :full are the ones that are used for remapping. In the tests, if the chain link tests have already run, there can be 6 field values for the field here (`(mt/id :venues :name)`) and we want to make sure we update the full one, not the chain filter ones ```clojure [{:hash_key "576275248", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.592931Z", :type :linked-filter, :updated_at #t "2022-12-07T21:10:22.972907Z", :human_readable_values ("Appletini" "Bananasplit" "Kiwi-flavored Thing"), ;; the test updatedthe existing :linked-filter one :id 560, :values ("apple" "banana" "kiwi"), :field_id 15, :created_at #t "2022-12-07T21:08:35.592931Z"} {:hash_key "-897793959", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.695344Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:35.695344Z", :human_readable_values [], :id 564, :values ("Kinaree Thai Bistro" "Krua Siri"), :field_id 15, :created_at #t "2022-12-07T21:08:35.695344Z"} {:hash_key "388078290", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.742561Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:35.742561Z", :human_readable_values [], :id 566, :values ("Tacos Villa Corona" "Tito's Tacos"), :field_id 15, :created_at #t "2022-12-07T21:08:35.742561Z"} {:hash_key "-299897589", :has_more_values false, :last_used_at #t "2022-12-07T21:08:35.777517Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:35.777517Z", :human_readable_values [], :id 567, :values ("Festa" "Fred 62"), :field_id 15, :created_at #t "2022-12-07T21:08:35.777517Z"} {:hash_key "-391654650", :has_more_values false, :last_used_at #t "2022-12-07T21:08:36.681046Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:36.681046Z", :human_readable_values [], :id 569, :values ("Baby Blues BBQ" "Beachwood BBQ & Brewing" "Bludso's BBQ"), :field_id 15, :created_at #t "2022-12-07T21:08:36.681046Z"} {:hash_key "1784886858", :has_more_values false, :last_used_at #t "2022-12-07T21:08:36.860010Z", :type :linked-filter, :updated_at #t "2022-12-07T21:08:36.860010Z", :human_readable_values [], :id 572, :values ("Baby Blues BBQ" "Beachwood BBQ & Brewing" "Bludso's BBQ"), :field_id 15, :created_at #t "2022-12-07T21:08:36.860010Z"} {:hash_key nil, :has_more_values false, :last_used_at #t "2022-12-07T21:04:04.299251Z", :type :full, ;; but should have updated this one :updated_at #t "2022-12-07T21:04:04.299251Z", :human_readable_values [], :id 4, :values ("20th Century Cafe" "25°" "33 Taps" "800 Degrees Neapolitan Pizzeria" "BCD Tofu House"), :field_id 15, :created_at #t "2022-12-07T20:57:21.896298Z"}] ``` * remove CI logging
-
Natalie authored
-
Case Nelson authored
Resolves #16132 We have been simplifying $expr operations for [awhile](https://github.com/metabase/metabase/blob/8e989499e936c04000b13a88f4934e96692083a2/modules/drivers/mongo/src/metabase/driver/mongo/query_processor.clj#L571-L588), since at least 4fba5cfe. It's possible that there are some cases that we do not simplify that we should, but from this investigation, they seem like legit uses remaining.
-
Natalie authored
-
Luiz Arakaki authored
* review athena manifest * review case and add helper text * add better helper text to AWS Credentials Provider Chain * fix capitalization * add helper text to password too * Update modules/drivers/athena/resources/metabase-plugin.yaml Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Jeff Bruemmer authored
-
Aleksandr Lesnenko authored
* remove TextInput and use core/Input * review
-
Cal Herries authored
* Add snowflake datetime-diff implementation * Get timestamps without timezones or offsets working * Convert to timestamp_tz, not timestamp * Format rows in tests * Fix snowflake set-parameter * Add failing tests * Fix bigquery * Formatting * Replace literals for datetime-diff-time-zones-test * Revert "Fix snowflake set-parameter" This reverts commit c24348a436f3f0f2639a12d6ea368399d1549739. * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset * Fix snowflake for time zones * Undo changes to extract and date-trunc * Explicitly set UTC timezone * Fix mismatched types * Remove redundant bindings * Remove redundant comment * Add failing tests * Remove duplicate dataset
-
- Dec 06, 2022
-
-
Cam Saul authored
-
Nick Fitzpatrick authored
* Change hasBreakout check * Adding computedSettings prop to ChartSettings
-
Case Nelson authored
* Disable field value scanning for inactive fields Fixes #26863 Adds `last-used-at` to `metabase_fieldvalues` table. This is used to track when full FieldValues are fetched, which should always happen through `get-or-create-full-field-values!` If an inactive FieldValues is queried, they will be updated immediately to be returned to the user and a new last-used-at will be set so that sync will start picking it up. During field values sync, if `last-used-at` occurred more than 14 days ago, then we will no longer query and synchronize this field until it is queried for again. * Fix flaky test by waiting half a second for last-used-at to change * Updates from review * Remove flakiness from test by checking sync
-
Nemanja Glumac authored
* [Docs] Fix external broken link * Link to the Cypress intro page without anchors * Exclude Cypress links from checks all together * Add back `.html` extension to the link
-
Ariya Hidayat authored
-
Braden Shepherdson authored
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
-
Anton Kulyk authored
* Add `SnippetCollectionForm` * Add `SnippetCollectionFormModal` * Use new form * Remove old form * Clean up snippet collections entity * Fix submit button title * Fix initial values
-
Anton Kulyk authored
* Add `NativeQuerySnippet` type * Add `NativeQuerySnippet` mocks * Add `snippets` to entities store type * Add `SnippetCollectionName` component * Support snippet folders in `FormCollectionPicker` * Add `SnippetForm` * Add `SnippetFormModal` * Use new `SnippetFormModal` * Remove `SnippetModal` * Fix initial values formatting * Ensure errors are displayed * Simplify archive button * Remove commented out code * Detach entity loader props from own props * Add unit tests * Fix test names * Fix modal props usage * Use `NativeQuerySnippetId` type * Make description field nullable * Fix `FormTextArea` styling
-
Ngoc Khuat authored
-
Cal Herries authored
* Add failing tests * Fix bigquery * Formatting
-
Cal Herries authored
* Fix formatting for datetime function docs * Undo datetimeAdd and datetimeSubtract
-
- Dec 05, 2022
-
-
Anton Kulyk authored
-
Alexander Polyankin authored
-
Natalie authored
-
Cal Herries authored
* Replace literals for datetime-diff-time-zones-test * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset
-
Cam Saul authored
-
Braden Shepherdson authored
It could generate Dimensions which depend on their own parent Fields, which causes the Fields to have circular deps and fail to load. This prevents Fields from allowing dependencies on themselves.
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
Jeff Bruemmer authored
-
Cal Herries authored
* Add now with extract test * Test against UTC too * Refactor based on Ngoc's suggestion
-
Alexander Polyankin authored
-
- Dec 02, 2022
-
-
Maz Ameli authored
-
Cam Saul authored
* Move the config-from-file code into the advanced-config directory since that's the feature we want to flag on * Always apply the :settings section first in the config file * config-from-file should check that we have a premium token with the :advanced-config feature * Sort namespace * Settings does not have to come first anymore * Remove empty `binding` forms * Test fix?
* Test fix? * Fix failing tests, for real this time * Revert "Fix failing tests, for real this time" This reverts commit 0a57055b1be249d9ba5b6b6ebe4f163e1f21e2b2. * Don't make the tests parallel since that breaks other stuff Co-authored-by:Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Cam Saul authored
* Fix `has-user-setup` Setting not being cached correctly * Fix Kondo error
-
Maz Ameli authored
* update pot for x.45 * create new po file for arabic * add translation changes * pull in finished translations
-
Natalie authored
-