Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 21, 2023
    • Ngoc Khuat's avatar
      db/update! -> t2/update! (#29308) · b8b6fdfe
      Ngoc Khuat authored
      db/update! -> t2/update!
      Unverified
      b8b6fdfe
    • Cam Saul's avatar
      Port query description logic to MLv2 (#29200) · 8f554528
      Cam Saul authored
      * Query  D E S C R I P T I O N S
      
      * WIP
      
      * MLv2 Query description
      
      * Test fixes
      
      * More robust error handling
      
      * MLv2 more shuffling things around
      
      * Remove unneeded impl
      
      * Cumulative FE changes
      
      * WIP
      
      * lib.expressions -> lib.expression
      
      * Address PR feedback
      
      * Fix everything
      
      * Oops fix missing metadata
      
      * Test fixes :wrench:
      
      * Fixes post-merge
      
      * Fix merge conflict
      
      * JS metadata overhaul
      
      * Test fix :wrench:
      
      * Test fix
      
      * Hack to workaround busted JOINs
      
      * Use Braden's better fix
      
      * Cumulative fixes
      
      * Test fixes :wrench:
      
      * Remove unused
      
      * Include temporal unit in query description
      
      * Don't change indentation
      
      * Revert e2e browser changes
      
      * Revert bin change
      
      * Meaningless change to kick CI
      Unverified
      8f554528
  2. Mar 20, 2023
  3. Mar 19, 2023
  4. Mar 17, 2023
  5. Mar 16, 2023
    • Nick Fitzpatrick's avatar
      Updating graph.metrics when column is removed (#29189) · aa3a5978
      Nick Fitzpatrick authored
      * Updating graph.metrics when column is removed
      
      * updating logic and adding unit tests
      Unverified
      aa3a5978
    • Emmad Usmani's avatar
      revert centering of undo toast (#29292) · 05b38d79
      Emmad Usmani authored
      Unverified
      05b38d79
    • dpsutton's avatar
      Ensure we use the ssh tunnel on action execution (#29228) · 37ebb437
      dpsutton authored
      * Ensure we use the ssh tunnel on action execution
      
      I'm gonna see if we have an existing way to run tests against ssh dbs. I
      see there are some tests that use a faking ssh server. Not sure if those
      are useful or not. But otherwise ssh stuff needs out of process help to
      accomplish so not sure if it's easily feasible right now
      
      * introduce new `with-unpooled-connection-spec` macro
      
      it is identical to the `with-connection-spec-for-testing-connection`
      macro but has a better name. In the future they could diverge as testing
      requirements and action requirements change. But we want that
      _implementation_ (which correctly uses tunnels), but we do not want a
      "testing connection" slug in the usage.
      
      In the future (or now if we prefer a different name) we can rename it,
      find the usages that are not testing vs the ones that are, etc.
      
      * tests for actions over ssh
      
      * unused require of mb.u.ssh
      
      had brought it in but then stuffed all of this inside of
      `with-unpooled-connection-spec` so no need to worry about ssh, closing
      it, ensuring the port is there, etc.
      
      * Don't test h2 with ssh tunnel
      
      details lack a host and it npe's in the ssh tunnel stuff. No big loss as
      ssh on h2 is not supported (due to this error, and probably many more)
      
      * Switch to toucan2 for db access in tests
      
      * Use connection pool for custom actions connection
      
      Was originally using `jdbc/get-connection` from the details of the
      db. This was a one-off non-pooled connection that also did not reuse ssh
      tunnels. I thought the one-off connection was important since it is not
      read only, but that's not the case. So we can reuse the exact same
      mechanism that the implicit actions are using with
      `metabase.driver.sql-jdbc.actions/with-jdbc-transaction`.
      
      * cyclic dependency
      
      almost moved it into execute, but that gives a very inviting
      `sql-jdbc.execute/with-jdbc-transaction`. Welcoming even. But
      `sql-jdbc.actions/with-jdbc-transaction` lets you know its only for
      transactions.
      Unverified
      37ebb437
    • metamben's avatar
      Add filter constructor functions (#29253) · cf662f31
      metamben authored
      * Add filter constructor functions
      
      * Revert changes to defop
      
      * Address linter complaints
      
      * Add function to set the query filter
      
      * Address linter complaints
      
      * Fix test name
      Unverified
      cf662f31
    • Jeff Bruemmer's avatar
    • Alexander Polyankin's avatar
Loading