This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 21, 2024
-
-
Nick Fitzpatrick authored
* updating @reduxjs/toolkit * kick ci --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
metamben authored
Fixes #48721
-
Sloan Sparger authored
* track items being moved to trash * fix spelling * fix unit tests
-
Aleksandr Lesnenko authored
* hide pivoted exports under env var * only export pivoted when the env var is true Also added tests to confirm. * must specify :export for public settings * spec * change setting to :internal since it's only via env var * use correct visibility add setting to settings.yaml for serialization --------- Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
Jeff Bruemmer authored
* note about metrics permissions * clarify viewing and editing * clollection
-
John Swanson authored
On MySQL 8.0.17, the following is prohibited: ``` WITH RECURSIVE MyRecursiveCTE (...) AS ( SELECT ... FROM bar UNION ALL SELECT ... FROM bar JOIN MyRecursiveCTE ON ... ) ``` Instead, you need to do: ``` WITH RECURSIVE MyRecursiveCTE (...) AS ( SELECT ... FROM bar UNION ALL SELECT ... FROM MyRecursiveCTE JOIN bar ON ... ) ``` Basically, just putting the CTE on the left vs. the right side of the join (which is exactly equivalent under the hood) fixes the issue. I can't actually find any documentation of this change, but it seems that sometime between MySQL 8.0.17 and MySQL 8.0.33, MySQL started allowing this, perhaps just an optimization where it now notices the equivalence and does the right thing. I originally tested this on what I believed was the oldest version of MySQL we supported, but didn't read carefully enough. We recommend 8.0.33 or higher here: https://www.metabase.com/docs/latest/databases/connections/mysql But that's not for the AppDB - for that, we recommend 8.0.17 or higher.
-
Alexander Solovyov authored
-
Sloan Sparger authored
* add alert to prompt admins to clean up a collection * clean up * pr feedback * fix i18n issue * copy changes
-
Hervé Labas authored
* Add metrics support in diagnostics dialog * Update unit test
-
Chris Truter authored
-
Nemanja Glumac authored
* Do not show `PaymentBanner` on hosted instances * Add test for the missing token status
-
Nicolò Pretto authored
* fix padding on published embeds list * add border to public links shared list to be consistent with embeds
-
Ngoc Khuat authored
-
John Swanson authored
* Fix serdes of missing cards in click behavior When exporting a dashboard, we export its dashcards, including cards referenced inside its viz_settings. The problem is that viz_settings might have references to now-nonexistent cards. This is an initial stab at cleaning up the problem, specifically for click behavior. If Dashboard D has Dashcard DC, which has a click-behavior that links to Card C, then when we collect the descendants of D, we'll include a reference to C - even if C has been deleted. So this makes two changes: first, when calculating the descendants of a dashcard, don't include links to cards that don't exist. And, when exporting the click behavior, remove the whole thing entirely if the card it points to doesn't exist.
-
Chris Truter authored
Make model ranking dynamic, so that: 1. We can experiment with it on-the-fly in Stats. 2. We can make it context dependent in future.
-
Ngoc Khuat authored
-
Phoomparin Mano authored
* add stories for dark theme * add dark theme editor stories * add entity picker colors * add editor-only picker * remove redundant story wrapper for dark theme stories * add theme keys to docs * add warning message
-
github-automation-metabase authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Prevent tests file from being imported when building SDK * Exclude more test files from SDK build
-
Ngoc Khuat authored
-
Chris Truter authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Put `#locale` behind the feature flag * Prepare folder structure for unit testing * Refactor: extract a setup function as a shared util * Add #locale tests * Add all tests * Prepare folder structure for unit testing * Refactor: extract a setup function as a shared util * Add locale tests * Add all questions tests * Fix failed E2E * Tidy up questions tests * Tidy up dashboards tests * Fix test name typo Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com>
-
Phoomparin Mano authored
* emit typescript when in a typescript project * also check dependencies for typescript dep
-
- Nov 20, 2024
-
-
Romeo Van Snick authored
* Allow searching a single select list picker * Fix unit tests * Add repro for 49642 * Remove selection when searching * Rename parameter to value because it does not need to be a prefix Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Simplify loading state for ListField * Use same DEBOUNCE_FILTER_TIME in ListField * Don't rely on waitTimeContext in test * Fix lint * Add initialization state for filter widget * Update Loki Snapshots * Update Loki Snapshots * Allow picking other values when selecting a single value dropdown value * Add comment about initialization * Use setup in test * Update Loki Snapshots --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Metabase Automation <github-automation@metabase.com>
-
Ngoc Khuat authored
-
bryan authored
* actually return values from getHidden - Arrow functions with {}'s do not implicitly return! * boolean fiddling
-
Phoomparin Mano authored
-
Phoomparin Mano authored
* update suggested import path * update suggested import path * add small tests for import paths * update comments * clarify the import path message Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
Phoomparin Mano authored
* revamp the create question component * docs updates * add stories and update styles * prevent switching to visualization when it is not ready * ensure CreateQuestion works in flex parents * add basic e2e tests for CreateQuestion * ensure that switching between editor and visualization works * use the save button for the disabled state * update the question title when the question is saved * implement updating questions in place * rename replaceQuestion * make CreateQuestion props all optional * add background color to modal header * hide the save button if question is dirty * hide save button instead of disabling per design feedback * update e2e tests * revert e2e helpers * add title update assertions * whitespace changes
-
github-actions[bot] authored
* Add new strings for v51.4 * Update translations * kick ci --------- Co-authored-by:
github-actions <github-actions@github.com> Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Tyler Plude authored
-
Roman Abdulmanov authored
-
Jeff Bruemmer authored
-
Ngoc Khuat authored
Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
Roman Abdulmanov authored
-
Alberto Perdomo authored
* Update versions in SDK introduction * SDK - Update next-js versions * Tweak wording about React versions * Tweak Next.js versions * Bump node version to 20 * Bump node version to 20
-
Kamil Mielnik authored
* Allow navigating with arrow up/down between lines in expression editor * Do not hijack up/down arrow keys for autocomplete suggestions navigation when there's only 1 suggestion * Add explanatory comments * Convert tokenizer to TS * Add a test * Format code * Add basic test case * Fix a deprecation * Handle incomplete bracket identifier tokens * Shorten code * Add comment * Fix suggestion not always getting selected * Fix computation * Fix types * Update comment * Add repros for #49882 * Add repro * Fix comment * Deprecate a HOC * Update assertion * Remove _.compose and default export * Fix types in ExplicitSize * Fix typing in ExpressionEditorTextfield * Fix types * Fix error handling * Fix showing errors when expression is invalid * Do not submit null expressions * Fix typing * Update assertion * Fix flaky test * Fix filter * Decrease flakiness * Fix crashing * Add comment * Fix incomplete bracket idenfitiers * Fix type * Improve typing * Add an explanatory comment
-
Chris Truter authored
* Rank based on when the current user last viewed the item * Fix tests
-
Mahatthana (Kelvin) Nomsawadi authored
* Refactor: Speed up E2E tests by not relying on UI * Quarantine flaky E2E assertions
-
- Nov 19, 2024
-
-
Romeo Van Snick authored
* Allow TableInteractive to render it's own empty message * Pass renderEmptyMessage to visualization in model editor * Add reproduction for #37300 * Use double equals ofr null check Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-