Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 12, 2024
  2. Aug 09, 2024
  3. Aug 08, 2024
    • Phoomparin Mano's avatar
      feat(sdk): connect databases, generate models and x-rays from the CLI (#46502) · 178997d7
      Phoomparin Mano authored
      
      * add setup commands
      
      * fix settings definition
      
      * update environment variables for cli
      
      * handle instances not being ready
      
      * update error messages
      
      * add more specific loading messages
      
      * loading spinner state
      
      * improve error message
      
      * use a fixed demo setup token
      
      * remove extraneous spinner
      
      * update status checks
      
      * update container messages
      
      * update wait timing
      
      * create api keys
      
      * extract constants
      
      * remove manual steps
      
      * Add anonymous tracking + other things. will need to clean up
      
      * Modify SDK for better structure
      
      * remove line from print.ts
      
      * Update webpack.embedding-sdk-cli.config.js back to production
      
      * Add types and add quick note
      
      * Fix a typo
      
      * Add index file, simplify types, use an array
      
      * Add safer json parsing
      
      * use delay of 100ms between each setup call
      
      * Suggestions from review
      
      * ensure that cli works
      
      * Attempt to fix jest errors
      
      * Remove node-fetch from sdk code to hopefully get unit tests working again
      
      * add database connection
      
      * add connection details handling
      
      * refactor asking for database connection info
      
      * apply actual database id for syncing schema
      
      * fix failing database sync step
      
      * allow table selection
      
      * create model for each table
      
      * handle errors in model creation
      
      * fix incorrect model display name
      
      * create x-rays based on user data
      
      * consolidate instance setup message
      
      * workaround for inquirer eventemitter issue
      
      * fix yarn.lock file
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      178997d7
    • Mahatthana (Kelvin) Nomsawadi's avatar
      Fix unintentional color changes (#46516) · 6fb1e51d
      Mahatthana (Kelvin) Nomsawadi authored
      * Sync storybook colors with the main app
      
      * Fix Metabase badge color
      
      * Fix wrong mixed brand colors
      
      * Add mistakenly removed colors
      
      * Update comments
      
      * Correct `brand-light` color
      
      * Fix wrong Mantine button color when passing `color` prop
      
      * Update loki snapshots
      6fb1e51d
    • Uladzimir Havenchyk's avatar
      e1af9340
  4. Aug 07, 2024
    • Phoomparin Mano's avatar
      feat(sdk): CLI to bootstrap an embedding-ready Metabase instance (#46080) · 4ce37a25
      Phoomparin Mano authored
      
      * add setup commands
      
      * fix settings definition
      
      * update environment variables for cli
      
      * handle instances not being ready
      
      * update error messages
      
      * add more specific loading messages
      
      * loading spinner state
      
      * improve error message
      
      * use a fixed demo setup token
      
      * remove extraneous spinner
      
      * update status checks
      
      * update container messages
      
      * update wait timing
      
      * create api keys
      
      * extract constants
      
      * remove manual steps
      
      * Add anonymous tracking + other things. will need to clean up
      
      * Modify SDK for better structure
      
      * remove line from print.ts
      
      * Update webpack.embedding-sdk-cli.config.js back to production
      
      * Add types and add quick note
      
      * Fix a typo
      
      * Add index file, simplify types, use an array
      
      * Add safer json parsing
      
      * use delay of 100ms between each setup call
      
      * Suggestions from review
      
      * ensure that cli works
      
      * Attempt to fix jest errors
      
      * Remove node-fetch from sdk code to hopefully get unit tests working again
      
      * fix yarn.lock file
      
      * revert capture groups change
      
      ---------
      
      Co-authored-by: default avatarOisin Coveney <oisin@metabase.com>
      4ce37a25
    • Uladzimir Havenchyk's avatar
      e2e: add cypress-terminal-report (#46483) · 63d029c7
      Uladzimir Havenchyk authored
      
      * e2e: add cypress-terminal-report
      
      * enable video recording
      
      * revert error
      
      * add a comment
      
      * Update e2e/support/cypress.js
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      63d029c7
  5. Aug 05, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [Milestone 2] Re-design transparent theme for static embedding and public links (#46428) · 3d5233bc
      Mahatthana (Kelvin) Nomsawadi authored
      
      * Update popover dark theme on part of ParameterFieldWidget (#45813)
      
      * Add filter visual tests
      
      * Simplify embed CSS colors
      
      * [WIP] theme filter popover
      
      * Move theme to global node, so it affects portal too
      
      * Fix embed colors
      
      * Theme part of ParameterFieldWidget
      
      * Add story for parameter with dropdown
      
      * Update loki snapshots
      
      * Update more popover style
      
      * Update loki snapshots
      
      * Remove outdated snapshots
      
      * Update loki snapshots with production build
      
      * Fix loki not working with `userEvent`
      
      * Theme mantine popover
      
      * Improve dark theme text-brand visibility
      
      * Update loki snapshots from master change
      
      * Fix new colors not working in SDK
      
      * Fix flaky Loki tests
      
      * Filter popover dark theme part 2 (#46284)
      
      * Theme Date all options
      
      * wip add month and year filter
      
      * Fix wrong CSS custom property declaration
      
      * Test hover state
      
      * Update Loki snapshots
      
      * Theme date month and year
      
      * Add quarter and year tests
      
      * Theme date single and date range
      
      * Style relative date
      
      * Update frontend/src/metabase/admin/datamodel/components/filters/pickers/DatePicker/DatePickerHeader.styled.tsx
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Complete theming filter popover night mode (#46365)
      
      * Style unit of time and number widget
      
      * Attempt to fix flaky Loki snapshots
      
      * Address white background checkbox on dark theme
      
      * Style search filter single value
      
      * Fix mis color
      
      * Update snapshots
      
      * Remove duplication on play functions since they're long
      
      * Milestone 2 polishing (#46382)
      
      * Matches the footer padding with header padding
      
      * Update snapshots
      
      * Add E2E to prevent further problem
      
      * Try to reduce flaky Loki tests
      
      * Remove unused color shades (#46421)
      
      * Update no results illustration to work better on dark theme
      
      * Update loki snapshots
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      3d5233bc
  6. Jul 31, 2024
  7. Jul 30, 2024
  8. Jul 29, 2024
  9. Jul 25, 2024
  10. Jul 24, 2024
    • Phoomparin Mano's avatar
      feat(sdk): add CLI to download and start Metabase locally for better onboarding experience (#45784) · 3fe37391
      Phoomparin Mano authored
      * add webpack configuration for cli
      
      * add requirements checking
      
      * docker check
      
      * docker start command
      
      * port checks
      
      * add getting started steps
      
      * add final install message
      
      * cleanup cli text
      
      * handle force-closing prompt
      
      * build the cli when running build-embedding-sdk
      
      * wording updates
      
      * add redundant prompt in case of small terminals
      
      * remove redundant instruction
      
      * make sure the user confirms the step
      
      * change container name to metabase-enterprise-embedding
      
      * migrate cli to es modules instead of webpack
      
      * add shebang line for npx
      
      * add cli dependencies to devDependencies
      
      * Revert "add cli dependencies to devDependencies"
      
      This reverts commit 5d5e952c.
      
      * Revert "add shebang line for npx"
      
      This reverts commit 766fdda0.
      
      * Revert "migrate cli to es modules instead of webpack"
      
      This reverts commit 7d1b0651.
      3fe37391
    • Denis Berezin's avatar
  11. Jul 22, 2024
    • Uladzimir Havenchyk's avatar
      replace babel-loader with swc-loader (#45843) · e02589a3
      Uladzimir Havenchyk authored
      - babel is kept to transpile fonts file as swc emotion plugin doesn't handle our case correctly. I didn't find a root cause of wrong behaviour, but the safe past is to keep using babel + emotion plugin for one file and all others can be transpiled with swc
      - react fast-refresh now handled by swc
      - swc-loader can't read browserslist config from package.json, so we had to manually specify supported browsers in webpack
      e02589a3
    • Nemanja Glumac's avatar
      ci: Run without Replay (#45799) · 62688d78
      Nemanja Glumac authored
      * Uninstall ReplayIO
      
      * Remove Replay config
      
      * Install and use custom Chrome v111
      
      * Simplify comment
      
      * Set a specific Chrome version commit
      
      * Skip repro for #22517
      62688d78
  12. Jul 20, 2024
  13. Jul 17, 2024
    • Uladzimir Havenchyk's avatar
    • Mahatthana (Kelvin) Nomsawadi's avatar
      [Milestone 1] Re-design transparent theme for static embedding and public links (#45633) · ffa54f0f
      Mahatthana (Kelvin) Nomsawadi authored
      
      * refactor: Simplify code (#44275)
      
      * Remove dead code
      
      * Remove values same as default options
      
      * Simplify hook API: Removing unused argument
      
      * review: Remove redundant code
      
      * Update look and feel copy (#44277)
      
      * Update static embed tab name
      
      * Update copies + rearrange settings
      
      * Use Mantine Select
      
      * Fix E2E tests by applying new copies
      
      * Fix unit tests
      
      * Fix more E2E tests
      
      * review: Add a comment on Mantine `value` quirk
      
      * Adjust spacing and relevant tests
      
      * Move `transparent` theme to its own toggle option (#44362)
      
      * Reorder the function to match the visual order
      
      * Make function name consistent
      
      * Introduce the new background option (do nothing yet)
      
      * Remove redundant exports
      
      * Tighten up values to reduce confusion
      
      * Make the parameters order consistent
      
      * Only show background option on dashboads (spec)
      
      * Allow dashboard embed background to be transparent
      
      * Make filter background and header/footer transparent
      
      * Fix type error
      
      * Fix unit tests
      
      * Fix E2E tests
      
      * Fix checkerboard pattern not showing when no background
      
      * Add unit tests
      
      * Add missing copy update
      
      * Remove remnants from outdated solutions within the PR
      
      * Improve code comment references
      
      * Fix E2E tests since the last copy change
      
      * Fix type errors from merging master
      
      * Update light theme style (#44488)
      
      * Add background to dashboard filter on light theme
      
      * Make position sticky works with transparent background
      
      * Fix sticky filters not working on theme=transparent
      
      * Fix unit tests
      
      * Simplify IntersectionObserver components + fix E2E tests
      
      * Add storybook for embedded dashboard
      
      * Clarify the use of ExplicitSize context
      
      * Remove unused code
      
      * Formatting
      
      * Review: Better mock `isWithinIframe`
      
      * Update dark theme to match the new design (#45134)
      
      * Update light theme checkerboard colors
      
      * Update checkerboard colors
      
      * Consolidate dashboard light/dark border style
      
      * Use `--mb-color-text-primary` for light theme dashboard
      
      * Update embed dashboard dark theme primary color
      
      * Migrate dashboard text-secondary color
      
      * Migrate text-tertiary color
      
      * Migrate gold, axis, and split line to CSS custom properties
      
      * Fix failed e2e tests
      
      * Fix static viz not working
      
      * Update loki snapshots
      
      * Remove unnecessary CSS custom property
      
      * Make diff more consistent
      
      * Address review: reusing type
      
      * Support backward compatibility when passing `theme=transparent` (#45214)
      
      * Match preview query with the actual code query
      
      * Handle backward compatibility when `theme=transparent` on dashboard
      
      * Add unit tests
      
      * Address review: Make tests less repetitive
      
      * Update Metabase banner upsell UI (#45424)
      
      * Prepare folder for nested components
      
      * Update upsell UI
      
      - add `fullWidth` variant
      - align title to the left
      
      * Fix Upsell banner having horizontal scroll on full width
      
      * Add new Metabase banner upsell component
      
      * Fix unit tests
      
      * Address review: Fix typo
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      
      * Address review: Move upsel UI to `admin/upsells`
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      
      * Remove unnecessary ESLint disable comment
      
      We can remove it since the file is in admin folder, and is already excluded from the rule.
      
      * Address review: remove default value property
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Address review: Extract magic number
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * More UI updates (#45450)
      
      * Update dark theme text colors to match the new design
      
      * Update powered by metabase logo
      
      * Update loki snapshots
      
      * Fix unit tests
      
      * Fix formatting
      
      * Fix wrong dark theme metabase logo badge color
      
      * Address review: Compress SVG with svgo
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Fix E2E tests
      
      * Update loki snapshots
      
      * Clarify Metabase base colors with comments
      
      ---------
      
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      
      * Add more tests (#45628)
      
      * Add static embed question stories
      
      * Add loki snapshots
      
      * Add transparent theme for static dashboard tests
      
      * Add transparent theme tests for static questions
      
      * Assert `background` option in analytics tests
      
      * Remove tests for logic that has been moved
      
      * Update loki snapshots
      
      * Fix failed E2E tests from merging master
      
      ---------
      
      Co-authored-by: default avatarRyan Laurie <30528226+iethree@users.noreply.github.com>
      Co-authored-by: default avatarDenis Berezin <denis.berezin@metabase.com>
      ffa54f0f
  14. Jul 15, 2024
  15. Jul 12, 2024
  16. Jul 11, 2024
  17. Jul 09, 2024
    • Denis Berezin's avatar
      feat(sdk): Add Dashboard loading event handlers (#45153) · 51330810
      Denis Berezin authored
      * feat(sdk): Add Dashboard loading event handlers
      
      * Refactor to redux state
      
      * Fix logic with load with cards data
      
      * Fix nasty e2e fails
      
      * Fix nasty e2e fails
      
      * Add global events
      
      * Fix issue with loading event
      
      * Fix issue with loading event
      
      * Review fixes
      
      * Add unit tests
      
      * Fix unit tests
      51330810
  18. Jul 05, 2024
    • Uladzimir Havenchyk's avatar
      lint: add stylelint support for emotion components (#45132) · c168b34e
      Uladzimir Havenchyk authored
      
      * lint: add stylelint support for emotion components
      
      * drop comment
      
      * fix pattern order
      
      * Use one version of typescript
      
      * use :focus not :outline
      
      * Use the logical CSS property "inset-inline-start:" (not "inline-start:" which doesn't exist) as replacement for the physical css property "left:"
      
      * Use mb-color-focus for focus color
      
      * Drop dead code
      
      ---------
      
      Co-authored-by: default avatarRaphael Krut-Landau <raphael.kl@gmail.com>
      c168b34e
    • Romeo Van Snick's avatar
      Allow setting labels for filters (#44352) · 0d5bc020
      Romeo Van Snick authored
      
      * Add csv-stringify package
      
      * Split values at comma
      
      WIP: Parse values using json
      
      * Add label to ParameterValue and add ParameterValue to value config
      
      * Use custom label in FieldValuesWidget
      
      * Allow passing displayValue from outside of RemappedValue
      
      * Allow passing displayValue in ParameterFieldWidgetValue
      
      * Get custom value label in FormatterParameterValue
      
      * Allow rendering custom displayValue in FieldValuesWidget
      
      * Add custom ParameterValue types
      
      * Fix ParameterValuePicker type
      
      * Fix jest import for csv-stringify
      
      * Add missing RTKQ exports for paramters
      
      * Use direct implementation of useGetParameterValues
      
      * Fix ValueSourceModal tests
      
      * Add tests for value parsing and stringifying
      
      * Use custom label in list too
      
      * Render the custom label in a parameter value
      
      * Setup parameter mocks in embed test
      
      * Add info about splitting values with comma
      
      * Add model hint when user is using labels
      
      * Add test for cusom labels on dashboards
      
      * Handle label-value pairs in test
      
      * Test custom labels in parameter search input
      
      * Use the label to parse the value for text inputs
      
      * Fix comma's to commas
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      
      * Use strong instead of styling link
      
      * Use getInput instead of ignoring eslint rule
      
      * Use arrow function
      
      * Add newlines between tests
      
      * Use uppercase for test value
      
      * Name value
      
      * Use getLabel and getValue helpers to avoid indexing confusion
      
      * Pull out confusing condition
      
      * Move out getLabel helper
      
      * Be more explicit about non-existent config values
      
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      
      * Move setupParameterValuesEndpoints to setup
      
      * Add loading state
      
      * Do not use alert to implement info box
      
      * Fix formatting
      
      * Remove undefined from getValue signature
      
      * Use getLearnUrl
      
      * Remove dependency on column
      
      * Make custom field labels work in the absence of fields
      
      * Support custom values for non-field parameters
      
      * Add test for native question parameters
      
      * Add newline in test
      
      * Add test case for when show-metabase-links is false
      
      * Just fall back to rendering value when fetching label, or in case it failed
      
      * Add test for loading state of FormattedParameterValue
      
      * Do not fetch custom label for FormattedParameterValue
      
      * Add table with ip addresses
      
      * Add test for IPAddress filter with custom labels
      
      * Add test for custom labels on type/Quantity fields
      
      * Remove getInput helper in test
      
      * Remove unused hasCustomLabel value
      
      * Split up into common and premium tests
      
      * Make fieldValues a map for performance
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
      0d5bc020
  19. Jul 01, 2024
  20. Jun 28, 2024
  21. Jun 26, 2024
  22. Jun 25, 2024
  23. Jun 20, 2024
  24. Jun 19, 2024
    • Kamil Mielnik's avatar
      Upgrade RTK to v2 (#44339) · 6daecbc6
      Kamil Mielnik authored
      * Upgrade @reduxjs/toolkit from ^1.9.3 to ^2.2.5
      
      * Fix typing
      
      * Upgrade redux-actions and @types/redux-actions
      
      * Fix type errors
      
      * Fix type errors
      
      * Upgrade react-redux from ^8.0.5 to ^9.1.2
      - remove @types/react-redux as it's no-longer-needed
      
      * Upgrade redux-promise from ^0.5.0 to ^0.6.0
      - upgrade @types/redux-promise
      
      * Remove unused @types/redux-logger
      
      * Revert "Upgrade redux-actions and @types/redux-actions"
      
      This reverts commit 65005a00.
      
      * Remove createWeakSelector as weakMapMemoize is the default memoization strategy now
      
      * Do not call unsubscribe if it does not exist
      
      * Do not subscribe
      
      * Remove console.log
      
      * Make DelayedLoadingSpinner always render something with data-testid="spinner" so that tests can be aware of when things are loading
      
      * Fix JoinStep unit tests
      
      * Fix AddToDashSelectDashModal unit tests
      
      * Fix SegmentApp unit tests
      
      * Bring back original subscription logic
      
      * Fix DataUsageStep unit tests
      
      * Fix ManageApiKeys unit tests
      
      * Simplify comment
      
      * Fix MainNavbar unit tests
      
      * Fix HomeRecentSection unit tests
      
      * Use afterEach instead of afterAll to reset mocks
      
      * Remove explanatory variable
  25. Jun 14, 2024
  26. Jun 07, 2024
  27. Jun 06, 2024
  28. Jun 04, 2024
Loading