Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 16, 2024
    • Nicolò Pretto's avatar
      `embedding-sdk:dev`: --watch that makes "fixed" dts (#48574) · 302a9946
      Nicolò Pretto authored
      * faster --watch command for the sdk
      
      * apparently we want an empty line at the end of jsons, but prettier removes it?
      
      * format tasks.json with prettier :confused:
      
      * vscods tasks, move watch task from webpack config to the fixup script
      
      * cleanup webpack config
      
      * adds clean + waits for dist folder when not existing
      
      * minimal doc for the sdk commands
      302a9946
  2. Oct 14, 2024
    • Cam Saul's avatar
      Collapse `metabase.shared.*` namespaces (#48646) · 6024bf01
      Cam Saul authored
      * Collapse `metabase.shared.*` namespaces
      
      * Fix Kondo warnings
      
      * Does updating the stories-data keys fix the failing tests?
      
      * Appease msgcat
      
      * Appease msgcat
      
      * Fix typo
      
      * Make the build happy
      
      * Appease fslint
      6024bf01
  3. Sep 30, 2024
    • John Swanson's avatar
      Do not cache all token check failures (#48147) · 0ef2052f
      John Swanson authored
      * Do not cache all token check failures
      
      We want to cache token checks to avoid an issue where we repeatedly ask
      the store "hey, is this token valid?? is this token valid?? is this
      token valid??" for the same token.
      
      However, transient errors can also occur. For example, maybe a network
      issue causes the HTTP request to fail entirely. In this case, if we
      cache the result, the user needs to restart metabase (or wait 5 minutes
      until the cache is cleared) before they can attempt to validate their
      token again.
      
      This PR moves the cache logic deeper into the stack. We want to cache
      "successful" responses from the store API - cases where the store has
      told us categorically that the token is or is not valid. We don't want
      or need to cache other things that might happen. Maybe your token isn't
      the right length - we can recalculate that, it's ok. Maybe you get a 503
      error from the Store - we should let you retry. Maybe your network is
      having issues and you can't contact the Store at all - again, we should
      let you retry.
      
      The one potential issue I see here is that if the store goes down, we'll
      massively increase the number of requests we send to the store,
      potentially making it harder to recover. If this is a concern, I can add
      a circuit breaker: if we repeatedly get errors back from the store, back
      off and stop making requests for a while.
      
      * Add a circuit breaker to store API requests
      
      In the pathological case where the store goes down for >5 minutes, the
      cache will expire and all instances everywhere will start repeatedly
      making requests for token validation at once. This might make recovering
      from an outage more difficult.
      
      This adds a circuit breaker around the API request. If the call
      repeatedly throws (5XX errors, socket timeouts, etc.) then we'll pause
      for 1 minute, during which time all calls to token validation will
      immediately fail without making any request to the API.
      
      After one minute, we'll allow one request through to the API. If it
      succeeds, we'll go back to normal operation. Otherwise, we'll wait
      another minute.
      0ef2052f
  4. Sep 05, 2024
  5. Aug 29, 2024
    • Cam Saul's avatar
      Update Kondo to `2024.08.01` and add `deps.edn` aliases to run from the JVM (#47370) · 7fb88340
      Cam Saul authored
      * Add `clojure -M:kondo` and `clojure -M:kondo:kondo/all` and bump version
      
      * Fix Kondo errors
      
      * Fix Kondo+LSP issues with `defendpoint`, `defenterprise`, etc.
      
      * Use replace-deps instead of deps for speed
      
      * Ok apparently maybe we do need to copy configs when we run Kondo on CI
      
      * Oops `./bin/kondo.sh` should not try to use `clj-kondo`
      
      * Remove references to GA driver folders
      7fb88340
  6. Aug 24, 2024
  7. Aug 23, 2024
  8. Aug 22, 2024
  9. Aug 20, 2024
  10. Aug 07, 2024
    • lbrdnk's avatar
      Add `relative-time-interval` mbql function 2 (#46438) · 582fa9ad
      lbrdnk authored
      * Add :relative-time-interval mbql function
      
      * Add relativeDateFilterPartsRelativeTimeInterval
      
      * Update display-name-method :relative-time-interval
      
      * Update desugar-relative-time-interval
      
      * Define relative-time-filter op
      
      * Add or update tests
      
      * Update tests
      
      * Update display-name-method
      
      * Update test
      
      * Fix positive relative-time-interval shift
      
      * Add checkins:1-per-day:60 dataset
      
      * Update var name
      
      * Bail out from optimization of relative-time-interval desugared filters
      
      * Update dataset kondo hook
      
      * Generate cache required for kondo hooks in kondo.sh
      
      * Rename dataset
      582fa9ad
  11. Aug 01, 2024
  12. Jul 30, 2024
  13. Jul 25, 2024
  14. Jul 23, 2024
  15. Jul 17, 2024
  16. Jul 15, 2024
    • Ryan Laurie's avatar
      Automate docs version list update PR (#45048) · 28070212
      Ryan Laurie authored
      * automate version list update pr
      
      * updates
      
      * remove release-list babashka script :cry:
      
      * Revert "remove release-list babashka script :cry:"
      
      This reverts commit 372a570f9af030abd6f297116e14568b3b51afa6.
      
      * add deprecation message
      28070212
  17. Jul 08, 2024
  18. May 31, 2024
    • Mahatthana (Kelvin) Nomsawadi's avatar
      ci(sdk): Autogenerate changelog on build (#43364) · 78db8c49
      Mahatthana (Kelvin) Nomsawadi authored
      * Auto tag embedding team for PR review + dry run npm publish
      
      * Install changelog generation package
      
      * Add the initial changelog
      
      * feat(sdk): This is an empty commit. For testing purposes.
      
      * Update SDk build script to include changelog
      
      * Check if a tag exists
      
      * Ensure changelog is in the released package
      
      * Fix workflow
      
      * Remove unnecessary step
      
      * Ensure we can have access to release utils script when checking out master
      
      * Fix the step to create a PR updating readme and changelog
      
      * Fix changelog generation
      
      * Fix couldn't download changelog
      
      * Clean up steps
      78db8c49
  19. May 30, 2024
  20. May 28, 2024
  21. May 17, 2024
  22. Apr 30, 2024
  23. Apr 29, 2024
  24. Apr 24, 2024
  25. Apr 08, 2024
  26. Apr 04, 2024
  27. Apr 02, 2024
  28. Feb 06, 2024
  29. Jan 31, 2024
  30. Jan 18, 2024
  31. Jan 17, 2024
  32. Jan 09, 2024
  33. Jan 04, 2024
  34. Jan 03, 2024
  35. Dec 20, 2023
  36. Dec 08, 2023
  37. Nov 15, 2023
Loading