This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 07, 2024
-
-
Alex Yarosh authored
* docs: cloud environment variables * Apply suggestions from code review Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com> --------- Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
- Nov 06, 2024
-
-
adam-james authored
* Pivot Measures Order Used in Pivot Exports Fixes #48442 A pivot table can have any number of measures, and the user can order these by dragging in the UI. Before this PR, that order was ignored and measures would alway be in index order, which is confusing for any user who needs the measures to be displayed in a particular order, especially if they've re-ordered them in the pivot viz settings UI. A test has been added to check that measure order is used. A few minor changes to the pivot qp and post-processor - measure indices are looked up in the pivot qp and added in viz-settings order - the pivot measures are only added if the qp has not already added them. - pivot-opts Malli spec has been made in the namespace, adjusted to allow `nil` as a valid pivot-opts output, and used in relevant functions * address review points. * add a rows order test * Filter out Empty Rows from Pivot Exports Fixes #49353 The linked issue is not actually related to pivot export size but is instead related to the 'Min of Created At: Month' aggregation; the default aggregation function was `+`, so it broke when the date string was encountered. That was fixed. As I was trynig to keep the export small if possible, I noticed that in some cases empty rows are appended, so I added the filter so that if a pivot row's values are completely empty, it doesn't add it. Finally, this PR also adds the 'sub section totals' which I noticed were missing from the exports. This comes up when you have 3+ pivot-rows configured, so you can see the subtotals for the first pivot row and the subtotals nested within those sections for the second pivot row, and so on. * add test for non-numeric values * Make sure the new name refs match on aggregations not just breakouts * cljfmt
-
Noah Moss authored
-
Alexander Polyankin authored
* Fix :pivot-measures with column names * Fix the test * Update src/metabase/query_processor/pivot.clj Co-authored-by:
Braden Shepherdson <braden@metabase.com> * Add a test * Add a test --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
Braden Shepherdson authored
Adds filters to generative testing for queries. There's a lot of new code here, but don't panic, it's quite straightforward: generating filter values, in the right shapes for various filter expressions.
-
Ngoc Khuat authored
-
Ngoc Khuat authored
-
- Nov 05, 2024
-
-
Ngoc Khuat authored
-
Alexander Polyankin authored
-
metamben authored
The query can contain all kinds of things, in particular the whole original query in the case of pivot questions, so we should check only the part that actually gets resolved by the middleware.
-
Case Nelson authored
* perf: Implement faster sync methods for postgres Fixes #48575 Pulls work from redshift into the common postgres driver. * Fix tests and formatting * Move nested-field-column sync to sync functions so describe-fields will also get them * Fix test * Fix test * Remove fixed safety test * Add test specific database-supports feature for pk metadata * Fix test * perf: faster mysql sync with describe-fields Fixes: #49010 * Adrress PR feedback * Fix tests * Fix test * Add nil table-schema * Don't use subselect for field-comment * Fix quoting weird identifiers * Make format string inline * Update src/metabase/driver/mysql.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Update src/metabase/driver/mysql.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Fix tests * Fix database-type * Fix tests * Fix test * Fix tests * Exclude mysql table_schema * Handle tinyInt1IsBit * Fix test * Only get one db at a time --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Braden Shepherdson authored
These are helpful for creating literal dates and times in a cross-platform way. Useful for generating queries, in particular for expression and filter values.
-
Braden Shepherdson authored
The ref (usually) contains enough information to unambiguously find the matching implictly-joined column, even if there are several FKs that could join the target table. The remaining ambiguous case is if the *same* FK column exists multiple times - current MBQL uses raw field IDs for the FK field, so it can't distinguish between eg. an FK in the main table and the one from a self-join.
-
Chris Truter authored
-
Oleksandr Yakushev authored
* [streaming-response] Use HttpEndpoint.isOpen() instead of reading a byte from TCP socket * Comment out cancellation test
-
- Nov 04, 2024
-
-
adam-james authored
* Pivot Measures Order Used in Pivot Exports Fixes #48442 A pivot table can have any number of measures, and the user can order these by dragging in the UI. Before this PR, that order was ignored and measures would alway be in index order, which is confusing for any user who needs the measures to be displayed in a particular order, especially if they've re-ordered them in the pivot viz settings UI. A test has been added to check that measure order is used. A few minor changes to the pivot qp and post-processor - measure indices are looked up in the pivot qp and added in viz-settings order - the pivot measures are only added if the qp has not already added them. - pivot-opts Malli spec has been made in the namespace, adjusted to allow `nil` as a valid pivot-opts output, and used in relevant functions * address review points. * add a rows order test
-
Braden Shepherdson authored
Also fix a bug in `lib.breakout/existing-breakouts` that treated breakouts on duplicate columns from different joins as existing, even though they're not.
-
- Nov 01, 2024
-
-
Nick Fitzpatrick authored
* Adding moderation status to Dashboards * react sins * verification coll: subselect on card + dashboard * fix the 3 failing BE tests * add an api test for dashboard verification * verified dashboards are never stale * e2e tests * code cleanup * unit test and e2e test cleanup * PR Feedback * backend test fixes * Nick shouldn't touch clojure * type fix * indent * fix last 2 BE tests --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
Noah Moss authored
-
Braden Shepherdson authored
In particular, this allows for a nearly-blank query without its `:database` set.
-
- Oct 31, 2024
-
-
Braden Shepherdson authored
Previously these were omitted, and it caused invalid SQL to be generated, since the ORDER BY (time unit not updated) and GROUP BY (time unit updated) did not line up. Fixes #49263.
-
lbrdnk authored
* [WIP] Adjust dependent dashboard cards * Use transducer to make it less hairy (?) * Looks better now * Exception handling and log * Throw away indices * Add mapping deletion * Avoid redundant db roundtrips * Add test * Update update-mapping * Docstring * Docstrings * Format * Comment * comment * Shutdown deletion * Adjust update generationcode * Add tests * Comment * Remove deletion completely for now * Use transaction * Update test * Comment * Update src/metabase/models/card.clj Co-authored-by:
Braden Shepherdson <braden@metabase.com> * Update src/metabase/models/card.clj Co-authored-by:
Braden Shepherdson <braden@metabase.com> * Update src/metabase/models/card.clj Co-authored-by:
Braden Shepherdson <braden@metabase.com> * Format and parens * Address remaining remarks * cljfmt * Update src/metabase/models/card.clj Co-authored-by:
Braden Shepherdson <braden@metabase.com> * Address review remarks --------- Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
Oleksandr Yakushev authored
-
Alexander Polyankin authored
-
- Oct 30, 2024
-
-
Noah Moss authored
-
Case Nelson authored
* perf: Implement faster sync methods for postgres Fixes #48575 Pulls work from redshift into the common postgres driver. * Fix tests and formatting * Move nested-field-column sync to sync functions so describe-fields will also get them * Fix test * Fix test * Remove fixed safety test * Add test specific database-supports feature for pk metadata * Fix test * Adrress PR feedback * Fix test * Don't use subselect for field-comment * Fix quoting weird identifiers * Make format string inline
-
Oleksandr Yakushev authored
-
Noah Moss authored
-
Oleksandr Yakushev authored
-
- Oct 29, 2024
-
-
adam-james authored
* Mongo objects should download as JSON, not EDN Fixes #48198 Prior to this change, object columns (base or effective type of :type/Dictionary) were just formatted with `(str value)` which results in a csv or json download containing EDN formatted objects. This is a bug because we present object column values as json in the app, so the expected formatting of the download should match this. The formatter function now takes this type into account. As well, since this is a type of formatting that should be always applied (even when format_rows is false), the function is modified to unconditionally apply the json/encode formatting to dictionary types when encountered. * add a test * add proper condition to test * card-download should be public * uncomment json encoding formatter * set-cell! should keep encoded json string for Objects I think this is the correct change; I don't really understand the reason for wrapping, encoding, decoding, and then string-ing that value. Maybe I'm missing something. * Adjusted xlsx Object set-cell! implementation * forgot the not... inverted
-
bryan authored
-
Jeff Bruemmer authored
-
Noah Moss authored
-
- Oct 25, 2024
-
-
Noah Moss authored
Co-authored-by:
bryan <bryan.maass@gmail.com>
-
dpsutton authored
* Fix csp directives for embed previews We set content security directives to allow for iframes on dashboards. This list did not include 'self' so we can't actually host an iframe pointing at our, well, self. Embed previews work by just embedding an iframe with the dashboard and this breaks if we don't allow iframes from our self. * e2e test --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
-
Chris Truter authored
### Description This PR updates Macaw to the latest version, which exposes a new analyzer which handles compound queries. It also finishes the migration to using tagged-union result maps consistently across all the interfaces. This should also remove the atrociously verbose analysis error messages in CI.
-
Chris Truter authored
This standards on a "just maps" approach to returning disabled, disallowed, or failed query analysis. This is as opposed to the hodgepodge approach of significant `nil`, untagged unions with keywords, and exceptions. Essentially we have a classic "either" style tagged union, where `:error` is the tag.
-
- Oct 24, 2024
-
-
bryan authored
* upgrades is-airgapped? defn to defsetting airgap-enabled - uses the airgap-enabled settings value to remove Cloud section in SettingsEditor - "Metabase Enterprise Airgap" -> "Enterprise Airgap" * hide still need help section in airgap mode * move flag checking into selectors * fe lint * ts type check * use optional chaining and nullish coalescing * hide StillNeedHelp in ag mode * adding airgap-enabled to createMockSettings --------- Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-