This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 09, 2023
-
-
Ngoc Khuat authored
-
dpsutton authored
* Remove personal collections from collection detail page https://github.com/metabase/metabase/pull/28023 Added "sub collections" to the collection detail page. Makes sense. The problem is that personal collections started appearing in this view. We have traditionally treated personal collections as siblings to the "Our Analytics" root of collections. So this was an impedence mismatch. This PR just removes all personal collections from the items returned from `"api/collection/root/items"`. The personal collection is still visible in the sidebar (returned from `api/collection/tree?tree=true&exclude-other-user-collections=true&exclude-archived=true` . Furthermore, all personal collections are still visible from the "three dots" menu on the sidebar. * poke ci * remove last personal collections from tests * e2e tests don't include a personal collection in the details page. * off by one from removing personal collections * Can't select personal collections if they aren't there
-
Cal Herries authored
-
Cal Herries authored
* Remove retrieve-dashboard-card call * Have `update-dashboard-card!` return nil, not true
-
Anton Kulyk authored
-
Alexander Polyankin authored
-
- Mar 08, 2023
-
-
Cam Saul authored
* MLv2 metadata overhaul, second try * Stricter linting for MLv2 * Address PR feedback * Revert fancy fn schema for now * Remove unused import * Test fixes
* Oops fix bad :require form * Misc MLv2 improvements from #28921 * Fix indentation * expression.non-integer-real * Remove debugging stuff * More cleanup * Test fixes: ::ref/field shouldn't fail if checked against a non-sequential object -
Aleksandr Lesnenko authored
-
Nick Fitzpatrick authored
* Adding classname prop to ObjectDetail * making className optional
-
dpsutton authored
Occasionally in CI we get ``` “Syntax error compiling at (release/version_info_test.clj:46:26).\nNo such var: json/read-json\n”, ``` from `release.version-info-test`. This namespace requires `[clojure.data.json :as json]` and uses the function `json/read-json` which is deprecated since version 2.x. The way that deprecated function is defined in version 2.0.2 is ```clojure (ns clojure.data.json) ... (load "json_compat_0_1") ``` and in `clojure/data/json_compat_0_1.clj`: ```clojure (in-ns 'clojure.data.json) (defn read-json "DEPRECATED; replaced by read-str. ...) ``` And I guess the way that hawk requires some namespaces we can get into this half loaded, half not finished state and the var is not (yet) defined. So we can just put aside this nonsense and use a non-deprecated var that isn't defined with a `load` statement but in the regular namespace we require.
-
Case Nelson authored
* Remove usages of dataset_query.type (#28683) * Remove usages of dataset_query.type * Remove more usages of dataset_query * Introduce usesSegment and usesMetric methods on Question * Fix type check * Fix type * Get query for UtilQuery * Fix conflicting added imports
-
Emmad Usmani authored
-
Alexander Polyankin authored
-
Cam Saul authored
-
Mark Bastian authored
All minor version dependencies have been updated to the latest. 3 libraries caused breakage and are documented here: https://github.com/metabase/metabase/issues/28967.
-
Ryan Laurie authored
* improved datetime handling *
more tests -
Ryan Laurie authored
* normalize icon sizes and spacing * clean up some types
-
Natalie authored
-
Alexander Polyankin authored
-
Ngoc Khuat authored
-
Anton Kulyk authored
* Properly connect actions to search entity * Add e2e test
-
Anton Kulyk authored
-
metamben authored
* Make nil equality comparable * Add Malli schema for filter expressions
-
Anton Kulyk authored
* Fix dashboard filter values coercsion for actions * update custom action e2e test to cover parameters --------- Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
Aleksandr Lesnenko authored
-
- Mar 07, 2023
-
-
Cam Saul authored
* MLv2 metadata overhaul, second try * Stricter linting for MLv2 * Address PR feedback
-
Gustavo Saiani authored
-
Noah Moss authored
* bind *card-id* when executing a dashboard subscription so that perm checks work properly * refactor & address test comment * fix spacing * unskip repro that this also fixes
-
Noah Moss authored
-
Gustavo Saiani authored
-
dpsutton authored
Calling our basis function with just :oss or :ee we don't end up with an `:argmap` key. ```clojure uberjar=> (def basis (create-basis :oss)) ,#'build.uberjar/basis uberjar=> (:argmap basis) nil ;; nothing extra in oss uberjar=> (def basis (create-basis :ee)) ,#'build.uberjar/basis uberjar=> (:argmap basis) {:extra-paths ["enterprise/backend/src"]} ;; and if other aliases are used: uberjar=> (def basis' (b/create-basis {:project "deps.edn" :aliases [:dev :test]})) ,#'build.uberjar/basis' uberjar=> (:argmap basis') {:extra-deps {lambdaisland/deep-diff2 {:mvn/version "2.7.169"}, methodical/methodical {:mvn/version "0.15.1"}, io.github.metabase/hawk {:sha "45ed36008014f9ac1ea66beb56fb1c4c39f8342b"}, ....} :extra-paths ["dev/src"...] :jvm-opts ["-Dmb.run.mode=dev" ...] :exec-fn metabase.test-runner/find-and-run-tests-cli} ```
-
dpsutton authored
* Fix flaky test and test for a new case flaky test was annoying. It would timeout after 45 seconds. And annoyingly, it times out on the _client_, not the server. So we don't get the proper error message we expect. And what's happening is that the backend just hooks up the pipe from it's request to the response. And if no bytes ever come across, we just twiddle our thumbs until the http request in the test gives up. The only reliable way i could think of to fix this is to spin up a webserver that just accepts and then ignores requests (which is what github did to us in the flaky test). Had to bump the ring adapter to get the newly exposed `:async-timeout 60000` parameter. By default the webserver in the test has a timeout of 30 seconds, which is shorter than the 45 second timeout for the test's request to the geojson endpoint. * add comment * clean up test server logic --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Alexander Polyankin authored
-
Ngoc Khuat authored
-
Gustavo Saiani authored
-
- Mar 06, 2023
-
-
Cam Saul authored
Clean up `metabase.query-processor-test.timezones-test/filter-datetime-by-date-in-timezone-test` (#28474) * Get more info about flaky presto test failures * Include testing context * Fix flaky test
-
Alexander Polyankin authored
-
Anton Kulyk authored
* Remove redundant `isSettings` prop * Extract `FormFieldEditorDragContainer` * Extract `FormFieldEditor` component * Update field editor UI * Disable validation in parameters editor * Fix crash on adding a new parameter * Add new tests and fix existing * Remove redundant `overflow: hidden` * Use shorter flex properties * Remove redundant `key` prop * Increase icon size
-
Gustavo Saiani authored
-
Ngoc Khuat authored
This reverts commit fbe83eaa.
-