This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 23, 2021
-
-
Nemanja Glumac authored
-
Jeff Bruemmer authored
* consolidated official database lists * update README to link to official list * specify GA version
-
Nemanja Glumac authored
Expands "pin collection item" workflow to include in a following manner: - Pins both dashboard and a question - Asserts that only the dashboard is visible on the home page (according to the documentation in https://www.metabase.com/docs/latest/users-guide/06-sharing-answers.html)
-
Nemanja Glumac authored
Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Nemanja Glumac authored
#15289 Repro: Abandoning archive collection process should let you stay in the same collection (#15299) * Add initial set of archiving collections tests * Add repro for #15289 Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Luis Paolini authored
-
- Mar 22, 2021
-
-
Nemanja Glumac authored
#15281 Repro: Users with read permissions are offered to save new dashboard in collections they only have read access to (#15282)
-
Jeff Bruemmer authored
-
- Mar 20, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Mar 19, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
#15256 Repro: "Duplicate" dashboard modal says it "failed", when it actually did duplicate successfully (#15257)
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
dpsutton authored
* Handle renaming column casing products -> Products and the like need to worry about one issue though: what if they _add_ a new column that has a name that is the same but for casing: products and Products. We would probably identify arbitrarily one of these with the existing products column and probably bad things will happen. Need to extend this check that identifies the casing indifference only in the case that there is no ambiguity * comment and issue# in testing form * Rename `:before-drop` -> `:before-sync` and for after as well
-
- Mar 18, 2021
-
-
Nemanja Glumac authored
* Add more user roles to the default testing snapshot * Update all related tests
-
Luis Paolini authored
-
Luis Paolini authored
-
Luis Paolini authored
-
Nemanja Glumac authored
* Add `cypress-skip-test` library This is the official Cypress library for conditionally skipping/running tests. https://github.com/cypress-io/cypress-skip-test * Enable `cy.onlyOn` and `cy.skipOn` custom commands in all tests Reference: https://github.com/cypress-io/cypress-skip-test#example
-
- Mar 17, 2021
-
-
Cam Saul authored
Merge pull request from GHSA-m8w4-6wxv-8v6m * Fix sandboxed Field Values regression * Test fixes
* Dox fix -
Jeff Evans authored
Merge pull request from GHSA-pxfh-93j9-h745 Check read permission on the instance from get Check write permission on the instance from revert Rewrite expectations to clojure.test in revision_test.clj Remove some ugliness (in the delay) and switch to fixtures instead Add new test in revision_test.clj for preventing unauthorized reversions
-
- Mar 16, 2021
-
-
Nemanja Glumac authored
-
- Mar 15, 2021
-
-
Cam Saul authored
-
Nemanja Glumac authored
#15163 Repro: Cannot view SQL question when accessing via dashboard with filters connected to modified card without SQL permissions (#15169) * Expand test to include "nosql" scenario * Add additional check for native query editor
-
Nemanja Glumac authored
#13347 Repro: Cannot select "Saved Questions", which belongs to database user doesn't have Data-permissions for (#15177)
-
- Mar 13, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
#15106 Repro: "Dirty" query fails when sandboxing on linked table column with multiple dimensions and remapping (#15141)
-
Nemanja Glumac authored
-
- Mar 12, 2021
-
-
Jeff Evans authored
Include partitioned tables in sync Add new table type ("PARTITIONED TABLE") to `.getTables` invocation Add test for Postgres to ensure all partitions, in addition to main table, are synced (for PG version 10 or higher) Pull `exec!` into helper fn in `postgres_test.clj`
-
Nemanja Glumac authored
#15105 Repro: When Sandbox is granted to linked table column, but no access to the linked table, then "dirty" queries fail (#15139)
-
Luis Paolini authored
* Update full-app-embedding.md Added a detail about SameSite=None cookie * Update docs/enterprise-guide/full-app-embedding.md Co-authored-by:
Jeff Bruemmer <jeff@metabase.com> Co-authored-by:
Jeff Bruemmer <jeff@metabase.com>
-
Robert Roland authored
It's possible for the scheduler to get in a weird state if the sync fails while it executes. This change makes it *only* recreate a job/task if the schedule has changed or if it is missing. Previously, clearing the state at every start had bad effects if the JVM had terminated during the sync. Adds a vector of Exception classes that signal a "fatal" exception during sync for a specific database. If these exceptions occur, the sync for that database stops and will pick up next time. This will have to be expanded per driver, but I don't see a way around that, as each driver will have its own, unique way of failing. metabase/metabase#14817
-
- Mar 10, 2021
-
-
Nemanja Glumac authored
* Move user groups above users * Use `email` in a user object instead of `username` * Add `createUser` function - Get rid of `makeUserObject` and store users' group membership directly within the user object * Improve `createUser` function * Add sandboxed user to the main `USERS` object * Use newly constructed `sandboxed` user in tests * Export `signInAsSandboxedUser()` * Fix function name Co-authored-by:
Paul Rosenzweig <paulrosenzweig@users.noreply.github.com> * Fix linter errors * Simplify `createUser()` function * Use user attributes directly in tests * Fix broken tests * Destructure users in tests * Use double quotes * Extract Cypress user data (#15103) * Extract user data in a separate file * Convert `createUser` function to a Cypress custom command * Convert `signIn` function to a Cypress custom command * Convert `signInAsAdmin` function to a Cypress custom command * Convert `signInAsNormalUser` function to a Cypress custom command * Convert `signInAsSandboxedUser` function to a Cypress custom command * Convert `signOut` function to a Cypress custom command * Guard against user groups data falling out of sync Co-authored-by:
Paul Rosenzweig <paulrosenzweig@users.noreply.github.com>
-
dpsutton authored
* Fix click through behavior (#15014) * formatting * Safer get's, author metadata and correct added * Don't return anything if we didn't modify it * Make private and add a docstring * Generate json strings rather than long in-line versions * Docstrings and prevent migrating ones that may already be migrated * Noisier as it now merges click_behavior on top of existing * update docstring with new nesting * always keep column settings previously the script was only looking for column settings which included view_as or link_template. Now we always keep those columns and merge in the new click_behavior when those keys are present * linkTemplateText -> linkTextTemplate * Ensure dashcard goes on top of card viz settings * Update expected now that dash merges on top of card * drop columns that don't have view_as so we don't overwrite the top level stuff if there is already a click_behavior. That signifies that either this migration has run, or perhaps already has had manual intervention. An open question is if we extend this to the columns: if there's manual intervention do we really want to be mucking about in here? Also, go back to the dropping columns style. ```clojure (if (and ...) (assoc m col (merge field-settings click-behavior)) m) ;; here we omit the column again in our reduce-kv ``` * Fundamentally: scour card for click and merge them into dashcard reshape all click behaviors in both and merge them in. Still some broken tests at the moment * Remove old style click behavior no longer expected * fixed * Some more comments and remove some silly select keys and when-lets just compute both keys and then u/select-non-nil-keys and be done with it * Docstrinc additions about nil * Remove niles, test scenario #5 from flamber * Handle empties and nil _AFTER_ merging previously had taken care to punt things down to nil, collapse empty maps, etc. but this is a value that will merge on top of a map rather than with the map ```clojure (m/deep-merge {:a {:b :c}} {:a nil}) {:a nil} ;; vs (m/deep-merge {:a {:b :c}} {:a {}}) {:a {:b :c}} ``` so let the postwalk after the merge clean up empty collections and nil values and let them blend as normal * Deep merge and prioritize new shape in card and dashcard ```clojure (m/deep-merge fixed-card fixed-dashcard (existing-fixed card) (existing-fixed dashcard)) ``` This is the change here essentially. Fix the card and dashcard, look for existing new shapes on the card and dashcard as well * Don't merge existing fix from card. can't happen this change though did help out. we want to resolve when there are old style and new style on the same dashcard. In this case, the new style should persist: ```clojure (testing "If there is migration eligible on dash but also new style on dash, new style wins" (let [dash {"column_settings" {"[\"ref\",[\"field-id\",4]]" {"view_as" "link" "link_template" "http://old" ;; this stuff could be migrated "link_text" "old" "column_title" "column title" "click_behavior" {"type" "link", "linkType" "url", ;; but there is already a new style and it wins "linkTemplate" "http://new", "linkTextTemplate" "new"}}}}] (is (= {"column_settings" {"[\"ref\",[\"field-id\",4]]" {"click_behavior" {"type" "link", "linkType" "url", "linkTemplate" "http://new", "linkTextTemplate" "new"}, "column_title" "column title"}}} (migrate nil dash))))) ``` note the column settings for field-id 4 have the old style and the new style but the result is that the new style survives. This happens from the `(m/deep-merge fixed-card fixed-dashcard (existing-fixed dashcard))` as the existing is put on top * Don't strip original values * propagate old info in migration test
-
- Mar 08, 2021
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-