This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 30, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
- Apr 16, 2024
-
-
metabase-bot[bot] authored
* Fix unable to disable scan field values (#41170) * Migration to remove scan field values triggers for DBs that turn it off (#41348) --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Apr 15, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
- Apr 07, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Apr 03, 2024
-
-
metabase-bot[bot] authored
* Do not put js code into page title * Typecheck * Add e2e test * Update e2e/test/scenarios/question/document-title.cy.spec.js --------- Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Apr 02, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Maz Ameli <maz@metabase.com>
-
- Mar 29, 2024
-
-
metabase-bot[bot] authored
* resolve conflicts and update few tests to await userEvents properly * Fix for userEvents 14 on Master (#40761) * Nick is sad * tests passing * fix lint and unit after rebasing on latest 49 branch --------- Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
- Mar 27, 2024
-
-
metabase-bot[bot] authored
Correct issue where EE only LDAP user provisioning feature is breaking OSS instances (#40685) (#40699) Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com>
-
metabase-bot[bot] authored
* Add backport resolution script * Fix filtering on LocalDates (#40530) * Split from #40146: only the filter changes * Don't include format-rows changes here. * Test fixes
* Test fix * Misc test fixes * Test fix * Tweak SQL Server fix * Fix Kondo errors * Updated api/dataset tests * Test fix --------- Co-authored-by:Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by:
Cam Saul <github@camsaul.com>
-
metabase-bot[bot] authored
Fixes #40328 [Our documentation](https://www.metabase.com/docs/latest/people-and-groups/managing#group-managers ) states that: > Group managers can: > > - View all people in the Admin settings > People tab. This fixes enforcement to be aligned with the documentation. This behavior makes sense, because as the docs also state, Group Managers should be allowed to *add* people to the group they manage, which they can only do if they can see those people! Initially, I also removed a faulty test, which was described as: ``` ;; Non-segmented users are allowed to ask for a list of all of the users in the Metabase instance. Pulse email lists ;; are an example usage of this. Segmented users should not have that ability. Instead they should only see ;; themselves. This test checks that GET /api/user for a segmented user only returns themselves ``` but actually failed to test this in a relevant way (because it was testing the `GET /api/user` endpoint rather than the `GET /api/user/recipients` endpoint). The test had continued to pass only because the user was the only member of the group they managed. I initially thought this behavior wasn't desired, but as it turns out, it *is* in fact documented behavior to disallow sandboxed users from seeing any email suggestions. Investigating, I found that a bug was allowing sandboxed users to see all users on the `/api/user/recipients` endpoint if the user-visibility setting was set to `:all`. Thus, the second commit fixes the bug and re-adds the (fixed) test. A sandboxed user now only sees their own user when hitting `/api/user/recipients`. Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com>
-
metabase-bot[bot] authored
return collections in same order from /api/collections/tree and /api/collections/:id/items (#40044) (#40263) There were two problems here: - one endpoint was sorting in the database, but not putting 'analytics' last. - one endpoint was sorting in the database, but then sorting again in clojure, which had subtly different behavior for special characters Fixes #39965 Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
- Mar 25, 2024
-
-
John Swanson authored
I started a much more complex fix with a job that tried to clean up stale `refreshing` PersistedInfos... then talked to Dan, who pointed out that because only one instance is running these jobs at any given time, we can just add `refreshing` to the list of refreshable states.
-
metabase-bot[bot] authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Mar 22, 2024
-
-
metabase-bot[bot] authored
* Fix flaky whitelabel test (#40441) * Fix flaky whitelabel test * Update another test for `landing-page` * Fix failed tests This was because the new toast notification label isn't backported to 49 since it was part of the new feature --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
- Mar 21, 2024
-
-
metabase-bot[bot] authored
* Often slo won't be setup, but we should still delete the session * test that we delete the session even when "/handle_slo" is not called * cleanup test * take the cookie from the session, not as a parameter Co-authored-by:
bryan <bryan.maass@gmail.com>
-
- Mar 20, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
bryan <bryan.maass@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
- Mar 18, 2024
-
-
metabase-bot[bot] authored
* Re-export `rem` helper from Mantine * Use `rem` in a few components as a PoC Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Mar 14, 2024
-
-
metabase-bot[bot] authored
# Conflicts: # frontend/src/metabase/browse/analytics.ts # frontend/src/metabase/browse/components/BrowseApp.tsx # frontend/src/metabase/browse/components/ModelExplanationBanner.tsx # frontend/src/metabase/routes.jsx Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
- Mar 13, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Mar 12, 2024
-
-
metabase-bot[bot] authored
* Convert QueryVisualization to a functional component * Add a custom message after loading for a while * Add test for slow database message * Loop through different custom messages * Use cy.clock to test timeouts * Make getLoadingMessage a function Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
- Mar 04, 2024
-
-
metabase-bot[bot] authored
* wip * SLO works with auth slo handler route * move slo handling endpoint to /auth/sso/handle_slo * fix slo redirect url * SLO works, and the sso-handle-slo for saml is where it belongs - a ton of cleanup * fix api/session namespace + add docstrings * cleaning up logout action * add slo logout test along with slo response xml * whitespace + linter * add docstring * update exclusions in deps.edn * un-require metabase-enterprise ns from oss ns * add docs for how to setup SLO to metabase docs * docs: clarify that setting up SLO is optional * move slo logout endpoint into ee code - removes sso-info defenterprise since it is no longer needed * use current version of saml20-clj --------- Co-authored-by:
bryan <bryan.maass@gmail.com> Co-authored-by:
Nick Fitzpatrick <nickfitz.582@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
- Feb 29, 2024
-
-
metabase-bot[bot] authored
* Don't delete "off" persisted_info records If they are off, they are "eligible" models for persistence that we do not want to persist. And to remember that use choice to not persist them we need to keep the record around. This was handled previously, but https://github.com/metabase/metabase/pull/39219 was a bit too blunt. We had a bunch of records in a "creating" state that we weren't removing, so i deleted them regardless of state. But we want to make sure that the "off" ones are not deleted. On stats, a bunch of ones that were set to off are now slated to be persisted after the prune job deleted the persisted_info records. * unused local. whoops Co-authored-by:
dpsutton <dan@dpsutton.com>
-
- Feb 23, 2024
-
-
Kamil Mielnik authored
* Include e2e directory in prettier scripts * Align ESLint & prettier paths in "lint-stage" & "scripts" in package.json * Handle ts files in e2e tests * Format "lint-prettier-pure" script the same way as "prettier" * Ignore database files in ESLint as they reference a file that is git-ignored but does exist locally * Remove duplicated eslint call * Manually fix ESLint-reported issues * Upgrade eslint-plugin-import * Configure import/order rule for consistent, predictable imports * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line" * Ensure imports are in a single block * Move or remove informative comments between import statements * Remove imports-grouping comments * Configure groups - the difference between the default setting is the presence of "internal" group * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies * Move comment to the same line as import * Run "yarn eslint-fix" 5 times * Manually fix imports order in remaining files * Run "yarn prettier" * Fix import * Fix circular dependency * Fix circular dependency * ESLint
-
- Feb 22, 2024
-
-
metabase-bot[bot] authored
* initial stuff * remove check for sub collections in personal collections * remove test * cleanup and adjusting tests * import spacint --------- Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
Jerry Huang <jhuang37050@gmail.com>
-
metabase-bot[bot] authored
* Browse models: Add one filter (#38661) * Browse models: refactoring (#38730) * Browse models: expandable/collapsible collections (#38704)
-
- Feb 21, 2024
-
-
metabase-bot[bot] authored
* Use fetchMock.flush() to prevent tests from interfering with each other * Revert "Use fetchMock.flush() to prevent tests from interfering with each other" This reverts commit 03f1277cf2bf481ac36db212e15b4f29511a386b. * Add typing for requests in the redux store * Fix QueryBuilder flakes by introducing waitForLoadingRequests * Simplify interface * Add mocks for requests in redux store, update types * Simplify code * Increase timeout Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
- Feb 19, 2024
-
-
metabase-bot[bot] authored
* Admin UI for disabling user auto provisioning (#38716) * impl feature * makes use of existing form components and deletes custom widget * e2e tests * fix lints * fixes lint around Metabase name usage * removed the select keys line to allow for whatever setting to be updated * fix defaulting logic for ldap and jwt, fixes unit test * snip snap snip snap * fix unit and maybe lint tests * fix ldap code * fixes trimming null * fixes e2e ldap tests * e2e progress * breaking local e2e in hopes of fixing ci... --------- Co-authored-by:
Jerry Huang <jhuang37050@gmail.com> * fix lint --------- Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Jerry Huang <jhuang37050@gmail.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
metabase-bot[bot] authored
* add getIsEECode selector * isEEBuild function * Revert "add getIsEECode selector" This reverts commit 3fc3fa79a24b73cfc5ba7c8c0be060c5211dc698. * remove isEnterprise * rename plugin to be more explicit Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
- Feb 16, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
- Feb 14, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
- Feb 11, 2024
-
-
Nick Fitzpatrick authored
* adding links with hardcoded IDs * add audit-info endpoint * fix perms * Fetching Dashboard IDs from the API * e2e tests * add BE tests * kinda busted * InstanceAnalyticsButton * removing unused file * Update enterprise/backend/src/metabase_enterprise/audit_app/api/user.clj Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> --------- Co-authored-by:
Jerry Huang <jhuang37050@gmail.com> Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Feb 10, 2024
-
-
Ryan Laurie authored
* Connection Impersonation for Redshift * redshift test based on the existing postgres one * fix test * fix test * change impersonation UI for redshift * copy/style updates * update tests for new copy * update copy * lets tweak it even more --------- Co-authored-by:
Noah Moss <noahbmoss@gmail.com>
-
- Feb 09, 2024
-
-
Jerry Huang authored
* add BE for billing status * add BE for billing status * fix whitespace * fix english * address comments * fix whitespace * fix comments * update design * update design * add test * consume json error * address comments * update url
-
John Swanson authored
Sometimes analytics bits get removed by other tests (e.g. deleting all cards, dashboards, users, etc.). When we run `ensure-audit-db-installed!`, though, the checksum hasn't changed (since the underlying analytics files didn't change), so we skip reloading the data. This sets `last-analytics-checksum` to `-1` (meaning: skip the checksum and just load the analytics data) when running `ensure-audit-db-installed!` in the tests that we've seen flake.
-
bryan authored
* load analytics only when changed using a checksum - over audit deserialization files * update docstrings * fix testing wording * fix nil analytics-resource-dir * in tests, when you delete the audit db, set the checksum back to 0 * add a comment * WIP hashing ia content from inside a jar * Do the unzip sooner, still hashes the file system Co-authored-by:
John Swanson <john.swanson@metabase.com> * cleanup java-time -> java-time.api --------- Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
Noah Moss authored
* Connection Impersonation for Redshift * redshift test based on the existing postgres one * fix test * fix test
-