This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 05, 2024
-
-
metabase-bot[bot] authored
* Enable not emptyable arguments for is-empty and not-empty clauses (#40957) * Enable not emptyable arguments for is-empty and not-empty clauses * Add review remarks * Shorten dataset name so it is usable with some drivers * Disable test for Athena * Handle possibly missing base type * Update comment * Missing base type field is treated as not emptyable * Update desugar middleware Now middleware adds base type to fields with integer id that are missing that first. This ensures correct function of is-empty expansion. * Update desugar middleware Cleanup base types necessary for desugaring is-empty * Update desugar middleware cleanup * Update test * Adjust tests * Remove now redundant e2e test * Update comment * Backport new emptyable definition and derivates --------- Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com>
-
- Dec 14, 2023
-
-
Ryan Kienstra authored
* Move sample-dataset.edn into test-data.edn Replace (mt/dataset sample-dataset with (mt/dataset test-data Replace more references to sample-dataset with test-data Fix the format of the combined data Might revert: remove test that doesn't apply, now that there's 1 DB Make api.database-test pass, though expected could be wrong * Update unit tests for combined dataset * Bump Bigquery version from v3_ to v4_ * Bump v3_test-data to v4_test-data * Remove wrapping with mt/dataset Alphabetize fk-mappings * Remove needless whitespace edits * Fix failed e2e_test by removing reference to sample-dataset * Fix tests for Mongo, Oracle, Snowflake, and Presto * Fix unit tests again for Mongo, Presto, and Snowflake * Will revert: run driver tests on my fork * Will revert: run driver tests on my draft fork * Revert "Will revert: run driver tests on my draft fork" This reverts commit 078c8af1. * Revert "Will revert: run driver tests on my fork" This reverts commit e3e2922f. * Make the postgres driver test pass again by reverting a change * Apply Case Nelson's patch to fix Athena test https://github.com/metabase/metabase/pull/36064#issuecomment-1824837705 Props @snoe * Remove (mt/dataset sample-dataset) from new tests * Maybe fix Athena driver tests Revert needless deletions of (mt/dataset test-data Maybe those deletions caused the failing Athena driver tests. But those deletions are out of scope for this PR either way. * Remove sample-dataset reference from a test in the master merge * In card_test.clj, replace sample-dataset with test-data * Merge in master, resolve conflict in pivot-from-model-test * Merge in master, resolve conflict in pivot-from-model-test * Must revert: allow databse creation To see if it will fix: https://github.com/metabase/metabase/actions/runs/7120808552/job/19388845720?pr=36064#step:3:441 Athena database creation is disabled: not creating database v2_test_data. Tests will likely fail. * Revert "Must revert: allow databse creation" This reverts commit d4c8f129. * Add back in (mt/dataset where I deleted it But replace sample-dataset with test-data. This might be wrong, or maybe it's not needed in so many places. But it could show if this is the problem. * Fix the failed sync test --------- Co-authored-by:
Case Nelson <case@metabase.com>
-
- Feb 08, 2021
-
-
Cam Saul authored
* Quick sync * Try reducing -Xmx for :ci profile a bit to prevent random test failures * Update quick sync parameter name * Update docstring for dataset * Fix sync-database! schema * Fix schema again * Test fix
-