This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 23, 2020
-
-
Nemanja Glumac authored
* Add QA Mongo DB to the Cypress tests in CI * Refactor tests - Use API to add database - group all query tests together * Fix prettier error for bcd4a366
-
Cam Saul authored
-
Nemanja Glumac authored
* Extract `addPostgresDatabase()` to a global Cypress helper function * Add repro for #13571 * Refactor tests - Use API to add database - Extract query test into a separate file
-
- Nov 19, 2020
-
-
Damon P. Cortesi authored
* Enable enterprise cypress tests (#13756) * Get auditing.cy.spec to pass * Skip custom drill through tests until we replace them * A few updates to the whitelabel test case: - Move custom colors into constant variable to reference throughout - remove some 'it' blocks we didn't need to speed up tests - Remove a few 'wait's - Restructure tests to be a bit more in line with best practices * Update the snippet permissions test: - Create test for just creating snippet as admin - Create test for inability to create snippet as user by default - Quarantine the user snippet creation test * Rename sandboxes * Replace legacy ENABLE_ENTERPRISE_EDITION env variable with MB_EDITION * Add MB_EDITION env variable to Cypress test run * Fix admin settings `auth` cypress test (#13841) [ci skip] * Fix `snippet` Cypress test for CI (#13843) - related: https://github.com/metabase/metabase-enterprise/issues/543 Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Nov 18, 2020
-
-
Maz Ameli authored
-
-
dpsutton authored
keyed off of column names that include "update" which are date, time, or datetime columns.
-
Nemanja Glumac authored
(Nested queries using metric got wrong SQL) Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Nemanja Glumac authored
(Not all columns of nested question available for Dashboard filter) Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
- Nov 17, 2020
-
-
Nemanja Glumac authored
* Restore before each test * Extract repro steps for #13000 into a helper function * Add repro for #13649
-
- Nov 16, 2020
-
-
Nemanja Glumac authored
The bug was fixed in #13808 .
-
Paul Rosenzweig authored
* fix scalar error when rendering null * remove ".only" from test * make check for null more explicit
-
Nemanja Glumac authored
* Refactors an original repro for #13000 to use API instead of "clicking" around UI. * Shortens the time to run this test from an average of ~20s to a bit less than ~3s
-
Nemanja Glumac authored
(Filtering Custom Expression from aggregated result fails with column not found)
-
- Nov 13, 2020
-
-
Robert Roland authored
This reverts commit 23ccd0c3.
-
Nemanja Glumac authored
-
Nemanja Glumac authored
(Cannot choose granularity of dates on Summarize with Simple question from Saved Question)
-
flamber authored
-
Nemanja Glumac authored
-
- Nov 12, 2020
-
-
Nemanja Glumac authored
-
- Nov 10, 2020
-
-
Cam Saul authored
* Fix Pie chart visualization error when rows contain nils (#13626) * Add positive assertion to CY test * Fix prettier linter * Quarantine the failing part of the "Pie chart" test Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
- Nov 09, 2020
-
-
Nemanja Glumac authored
* Quarantine flaky tests (#13682) (#13683) * Quarantine flaky tests (#13682) * Add TODO note re: `describeWithToken` Co-authored-by: Nemanja Glumac * Add a circleci workflow that runs a set of Cypress smoketests (#12775) * Add a circleci nightly workflow that runs a bigger set of Cypress smoketests * Run this every hour while we're testing it, add a small fix to the admin test * Smoketests: Skip some known failing tests Co-authored-by:
Ariya Hidayat <ariya@metabase.com> * Narrow down the quarantine for chart_drill spec (#13682) (#13699) * CI: Fix the cache key for uberjar for running smoketest (#13698) Smoketest for OSS edition (for now) * Fix `settings/settings.cy.spec.js` flakes (#13701) - isolated flake (`it.only("should surface an error when validation for any field fails (metabase#4506)", () => {...})`) passed 10x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348275781) - the whole spec passed 20x (https://github.com/nemanjaglumac/metabase-tests/actions/runs/348306177) * CI: Update uberjar oss key for smoketest (#13704) * Fix Cypress flakes in `dashboard/dashboard.cy.spec.js` file (#13703) * Fix flakes in `revisions screen` block * Improve test assertions (there were some rendering problems, so I adjusted the assertions) * Narrow down the quarantine for dash_drill spec (#13682) (#13706) * Fix `metrics.cy.spec.js` flakes (#13709) * Fix `metrics.cy.spec.js` flakes (#13682) * Refactor the test using API * Smoketest: run nightly at 1am PST (#13711) 1 am PST = 09:00 UTC CircleCI cron is for UTC: https://circleci.com/docs/2.0/workflows/#scheduling-a-workflow * Upgrade Cypress to v5.5.0 (#13674) * Upgrade Cypress to v5.5.0 * Needed to unset the `DISPLAY` ENV through `config.yml` to finally make this work! (Reference: https://github.com/cypress-io/cypress/issues/4034#issuecomment-486773042 ) * Improve `segments` tests with the use of API (#13718) * Unquarantine `scenarios/pulse/pulse.cy.spec.js` (#13727) * Unset `DISPLAY` ENV in smoketests CI group (#13732) * Unquarantine ee `custom_drill_through/drill_through.cy.spec.js` [ci skip] (#13734) * Unquarantine `question/nested.cy.spec.js` (#13733) Co-authored-by:
Ariya Hidayat <ariya@metabase.com> Co-authored-by:
Damon P. Cortesi <d.lifehacker@gmail.com>
-
Cam Saul authored
* Fix formatting temporal values as day of week with custom day of week (#13604) * Pretty * PR feedback * Need to update when user locale changes as well * Update Moment start of week in i18n.js instead * Make it nice * Remove some unneeded stuff
-
Cam Saul authored
* Split expression suggestions into separate component Fix error messages not appearing in ExpressionsWidget * Enable test * Fix suggestion popup keyboard behavior * Don't try to parse empty input (#12140) * Remove stray console.log * Revert test enabling * Prettier * Address feedback
-
Nemanja Glumac authored
-
- Nov 05, 2020
-
-
Simon Belak authored
* Fix SQL for custom columns referring to aggregations. Fixes #12762 * Add test & enable cypress
-
Simon Belak authored
* Rebase * Typo * Add repro for #10511 Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
- Nov 04, 2020
-
-
Nemanja Glumac authored
* Add repro for #13626 [ci skip] Note: Once this issue is fixed, add a positive assertion to the Cypress test.
-
- Nov 03, 2020
-
-
Nemanja Glumac authored
* Add repro for #13235 [ci skip] (Cannot filter by selecting remapped display value from dropdown list)
-
- Nov 02, 2020
-
-
Nemanja Glumac authored
* Fix obsolete MBQL syntax in `localization.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/6b5765718daff384a1831cd7383401369b8c1725. * Fix obsolete MBQL syntax in `dashboard.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/2958b836cc73c16b74b6e6e8fd96a6dabd12f60e. * Fix obsolete MBQL syntax in `nested.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/ab762e1ffb8cd79fedc050709c059e8c8b87ef9b. * Fix obsolete MBQL syntax in `dashboard-drill.cy.spec.js` [ci skip] Introduced in: https://github.com/metabase/metabase/commit/cb4371e9fcc45ec242d106c4a01c4a0d68d4c324. * Fix obsolete MBQL syntax in `nulls.cy.spec.js` Introduced in: https://github.com/metabase/metabase/commit/854f5317df724abc0a6026b06bfa539d15d34fa6. * Add positive assertion for repro for #13571
-
- Oct 30, 2020
-
-
Nemanja Glumac authored
* Add repro for #12872 (Between Dates filter behaves inconsistently based on whether the column is from a joined table or not)
-
Robert Roland authored
When a database is updated via the admin interface, any sensitive data (private keys, passwords, etc) should be handled on an "upsert" basis - only modify those fields if they were changed from the "protected password" value. This affects all database drivers. Resolves #13442
-
- Oct 29, 2020
-
-
Ariya Hidayat authored
-
Nemanja Glumac authored
* Update obsolete repro for #12985 * Remove `funnel_add` icon
-
Nemanja Glumac authored
-
- Oct 28, 2020
-
-
dpsutton authored
* Show engine in Task trouble shooting logs in an effort to get better feedback when people raise issues about long running sync processes, include the database engine in the logs. Also wrapped `th` in a `tr` inside the `thead` to remove react warning * Const intead of let on the db_id_to_engine * Swap db id for db name * Move comment out of jsx
-
- Oct 27, 2020
-
-
Nemanja Glumac authored
* Fix failing Cypress test in `dashboard-drill` spec file * Assert that the page content rendered (as per @dacort 's suggestion)
-
Tim Macdonald authored
* [Fixes #11879] [Fixes #8410] Don't wrap email attachment filenames * Non-ASCII characters in filenames are encoded [as per IETF RFC 2047](https://tools.ietf.org/html/rfc2047) (c.f. #8410) * Sufficiently-long _encoded_ filenames are sent over multiple lines as per [RFC 2184 section 3](https://tools.ietf.org/html/rfc2184#section-3), for example: ``` Content-Disposition: attachment; filename*0="=?UTF-8?Q?T=C3=A9=C5=BFting_non-ASCII_=C4=8D=C4=A5=C3=A4ract"; filename*1="ers.xlsx?=" ``` * Many mail clients do the right thing, but Gmail does not This commit therefore turns off wrapping, as per [Bill Shannon's Stack Overflow answer re. an undocumented system property](https://stackoverflow.com/a/53344141/220529) (Bill Shannon co-wrote the Java email library, which is used by postal (the Clojure wrapper we use). * (Hopefully) fix race condition in dashboard drill Cypress spec Suggested by @flamber * Skip flaky Cypress tests (per Nemanja) * Only set `mail.mime.splitlongparameters` once
-
Robert Roland authored
* Repro for #13571: Display rows whose value is `null` (#13591) [ci skip] * Reproduces #13571 Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> * [[null]] is a valid response Previously, this said that a result of `[[null]]` was an empty result set, but in reality, it's a valid result set of a single column with a null value. Resolves #13571 Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
- Oct 24, 2020
-
-
Nemanja Glumac authored
* Reproduces #13571 Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-