Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 26, 2021
    • Jeff Evans's avatar
      Update MS SQL Server JDBC driver version (#15287) · d6765a11
      Jeff Evans authored
      Bump mssql-jdbc version from 7.4.1.jre8 to 9.2.1.jre8
      
      Bump plugin version accordingly
      
      Override prepared-statement and statement multimethods for :sqlserver to not set holdability at the statement level
      
      Fixing inaccurate log statements
      d6765a11
  2. Mar 24, 2021
    • Jeff Evans's avatar
      Support SSL server certificate parameter for MySQL (#15172) · 54f6a5e7
      Jeff Evans authored
      Adding ssl-cert config field to MySQL DB details map, to hold the server cert chain in PEM format (similar to what is done in MongoDB driver)
      
      Updating MySQL driver init to map :ssl-cert into :serverSslCert for the JDBC url, when ssl is in use and cert is provided (the MariaDB driver we are using accepts PEM format certificates inline directly for the param value, so no need to shepherd into a temp file)
      
      Adding new test to mysql_test.clj to run a single test while connecting via SSL with PEM cert
      
      Update CircleCI config:
       - use extra-env to set all the MySQL SSL instance DB related vars (for an RDS instance, currently)
       - adding the rds-combined-ca-bundle.pem certificate to resources/certificates
       - loading that cert bundle from resources directory via env var
      
      Adding to/fixing assertion in connection-spec-test for :ssl
      54f6a5e7
    • Dalton's avatar
      split SharingSidebar into a few separate components (#15203) · 0b676bdb
      Dalton authored
      
      * split SharingSidebar into a few components
      
      * rmv emailRecipientText prop (unused)
      
      * use pulse.id in place of pulseId
      
      * use _.partial to avoid passing index prop
      
      * cut a few lines of code
      
      * add minor comment for components with too many props
      
      * add proptypes to new components and fix key errs
      
      * move time formatting utils
      
      * add handling for 12pm
      
      Co-authored-by: default avatarflamber <1447303+flamber@users.noreply.github.com>
      
      Co-authored-by: default avatarflamber <1447303+flamber@users.noreply.github.com>
      0b676bdb
    • Dalton's avatar
      Add it.only error linting rule (#15312) · 2b71c419
      Dalton authored
      * add new linting package
      
      * add rule to eslint config
      
      * remove it.only
      
      * fix race condition err in test
      2b71c419
    • Tim Macdonald's avatar
      9fe00e3d
  3. Mar 23, 2021
  4. Mar 22, 2021
  5. Mar 19, 2021
    • Cam Saul's avatar
      Record login history (#15129) · 3a5eface
      Cam Saul authored
      * Record login history [WIP]
      
      * WIP
      
      * Add API endpoint and ugly React component
      
      * Fix fn name
      
      * Lookin good
      
      * Test fixes :wrench:
      
      * Prettier
      
      * Test fix
      
      * Test fixes :wrench:
      
      * Better login history info
      
      * Less ugly login history & tests
      
      * Update migration numbers
      
      * Deduplicate https-request? util function from metabase.server.middleware .session & .util
      
      * Refactor -- new Ring request utils namespace
      
      * Test fixes :wrench:
      
      * Reorganize stuff a bit; API endpoint tests
      
      * Tests for login/logout recording history
      
      * Test fix :wrench:
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Copy FE test fixture DB so it stops getting changed every time we run tests
      
      * Test fixes :wrench:
      
      
      
      * layout and code style tweaks
      
      * Fix ns sorting
      
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      3a5eface
    • Ariya Hidayat's avatar
    • Dalton's avatar
      add minWidth to Sidebar (#15242) · b49e9046
      Dalton authored
      b49e9046
    • dpsutton's avatar
      Fix typo in semantic migration (#15218) · 3099c35a
      dpsutton authored
      * Fix typo in semantic migration
      
      * Update semantic migrations for mysql compatibility
      
      mysql updates as it goes, not in a row level transaction. So
      
      ```sql
      update a = null,
             b = (case a ...)
      where a is not null
      ```
      
      mysql will use the new null value of a rather than the pre-udpate
      value of a whereas pg and h2 will do row level transaction so you are
      considering the pre-updated value of a.
      
      Solution is to update these migrations to leave semantic type alone
      and then one final set semantic_type = null where coercion_strategy is
      not null. This is sensical since these two properties used to both be
      in semantic_type, so if we extracted a coercion it could not have had
      a meaningful semantic_type before.
      3099c35a
    • dpsutton's avatar
      Look at effective-type in the UI (#15213) · e4a16b9a
      dpsutton authored
      * Look at effective-type in the UI
      
      still want to fall back to base_type if effective_type is not
      present. Our inference doesn't set effective_type at the moment as
      this change was super invasive and led to conflicts to other refactors
      at the time. In the future almost nothing except for query processors
      should care about base_type and only look at the (required)
      effective_type.
      
      * Check base and semantic (not base and effective) when no effective_type
      
      * Correct typo in isNumericBaseType
      
      was incorrectly checking effective_type instead of either effective or base
      e4a16b9a
    • Maz Ameli's avatar
      tweak coercion copy (#15239) · 826537b1
      Maz Ameli authored
      826537b1
    • Ariya Hidayat's avatar
      Custom expression editor: avoid squiggly red lines (spellchecking) (#15234) · 55dfc8dc
      Ariya Hidayat authored
      It does not make sense anyway for the web browser to suggest corrections
      for function names etc.
      55dfc8dc
    • Dalton's avatar
      add throttle to ExplicitSize height/width recalc (#15235) · 3771c362
      Dalton authored
      * add throttle to ExplicitSize height/width recalc
      
      * add comment
      3771c362
  6. Mar 18, 2021
  7. Mar 17, 2021
  8. Mar 16, 2021
Loading