This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 26, 2021
-
-
Jeff Evans authored
Bump mssql-jdbc version from 7.4.1.jre8 to 9.2.1.jre8 Bump plugin version accordingly Override prepared-statement and statement multimethods for :sqlserver to not set holdability at the statement level Fixing inaccurate log statements
-
- Mar 24, 2021
-
-
Jeff Evans authored
Adding ssl-cert config field to MySQL DB details map, to hold the server cert chain in PEM format (similar to what is done in MongoDB driver) Updating MySQL driver init to map :ssl-cert into :serverSslCert for the JDBC url, when ssl is in use and cert is provided (the MariaDB driver we are using accepts PEM format certificates inline directly for the param value, so no need to shepherd into a temp file) Adding new test to mysql_test.clj to run a single test while connecting via SSL with PEM cert Update CircleCI config: - use extra-env to set all the MySQL SSL instance DB related vars (for an RDS instance, currently) - adding the rds-combined-ca-bundle.pem certificate to resources/certificates - loading that cert bundle from resources directory via env var Adding to/fixing assertion in connection-spec-test for :ssl
-
Dalton authored
* split SharingSidebar into a few components * rmv emailRecipientText prop (unused) * use pulse.id in place of pulseId * use _.partial to avoid passing index prop * cut a few lines of code * add minor comment for components with too many props * add proptypes to new components and fix key errs * move time formatting utils * add handling for 12pm Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Dalton authored
* add new linting package * add rule to eslint config * remove it.only * fix race condition err in test
-
Tim Macdonald authored
-
- Mar 23, 2021
-
-
Cam Saul authored
Port the metabase.mbql utility namespaces to ./shared/ so they can be used on both the frontend and backend.
-
Paul Rosenzweig authored
-
Paul Rosenzweig authored
* Add cypress tests for reference/metrics/:id page * Add metrics/:metricId/edit route * Use router location for metric's isEditing state Data Reference keeps `isEditing` state flag in Redux store (it's shared across metrics, segments and DB references) Metrics page now uses router's path name to distinguish reading and editing states * Use non-Redux callbacks at MetricDetailContainer * Add missing prop type definition * Fix editing callbacks not passed to MetricDetail * Fix signInAsAdmin test utility usage * Reorder imports * Use cy.findByText instead of cy.contains * Fix Metrics data reference test For some reason, when running Cypress tests, the page appears in `cannot read property fields of undefined` However it works correctly when running Metabase locally Checking for undefined `fields` explicitly fixes the problem Anyway, most likely this component is going to be removed in #15209 * Fix metrics test Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Dalton authored
-
Maz Ameli authored
* nicer no-results search message * also update SRP
-
Howon Lee authored
* complicated prefix trim to solve 15247 * found regression, hah * lint * test
-
- Mar 22, 2021
-
-
Ariya Hidayat authored
* Custom expression editor: fix Enter not commmitting the change * Remove superfluous onChange * Merge onDone and onUpdateAndCommit
-
Kyle Doherty authored
* initial prototype of 'Explore results' * use ViewButton * use same button type as ViewFooter * check for database * extract explore results url into fn
-
Maz Ameli authored
-
Ariya Hidayat authored
The width should be fixed only when the editor is being used in the notebook, and not from the sidebar.
-
Luis Paolini authored
-
Ariya Hidayat authored
There is this famous Firefox issue with empty contentEditable: https://bugzilla.mozilla.org/show_bug.cgi?id=1020973 The workaround is to inject <br> when there is no expression (it will be wiped out anyway on subsequent typing by the user).
-
Kyle Doherty authored
* use schema list loader to check for number of schemas when displaying table context * set loadingAndErrorWrapper to false to prevent UI flash * fix up translation strings for metric/segments * remove duplicate length check
-
- Mar 19, 2021
-
-
Cam Saul authored
* Record login history [WIP] * WIP * Add API endpoint and ugly React component * Fix fn name * Lookin good * Test fixes
* Prettier * Test fix * Test fixes * Better login history info * Less ugly login history & tests * Update migration numbers * Deduplicate https-request? util function from metabase.server.middleware .session & .util * Refactor -- new Ring request utils namespace * Test fixes * Reorganize stuff a bit; API endpoint tests * Tests for login/logout recording history * Test fix * Test fixes * Test fix * Copy FE test fixture DB so it stops getting changed every time we run tests * Test fixes * layout and code style tweaks * Fix ns sorting Co-authored-by:Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
Ariya Hidayat authored
-
Dalton authored
-
dpsutton authored
* Fix typo in semantic migration * Update semantic migrations for mysql compatibility mysql updates as it goes, not in a row level transaction. So ```sql update a = null, b = (case a ...) where a is not null ``` mysql will use the new null value of a rather than the pre-udpate value of a whereas pg and h2 will do row level transaction so you are considering the pre-updated value of a. Solution is to update these migrations to leave semantic type alone and then one final set semantic_type = null where coercion_strategy is not null. This is sensical since these two properties used to both be in semantic_type, so if we extracted a coercion it could not have had a meaningful semantic_type before.
-
dpsutton authored
* Look at effective-type in the UI still want to fall back to base_type if effective_type is not present. Our inference doesn't set effective_type at the moment as this change was super invasive and led to conflicts to other refactors at the time. In the future almost nothing except for query processors should care about base_type and only look at the (required) effective_type. * Check base and semantic (not base and effective) when no effective_type * Correct typo in isNumericBaseType was incorrectly checking effective_type instead of either effective or base
-
Maz Ameli authored
-
Ariya Hidayat authored
It does not make sense anyway for the web browser to suggest corrections for function names etc.
-
Dalton authored
* add throttle to ExplicitSize height/width recalc * add comment
-
- Mar 18, 2021
-
-
Tim Macdonald authored
* Prioritize exact matches when querying the DB for a search * Limit length of search input * Add some tests * Add card.description to search results
-
Cam Saul authored
Merge x.38.2 -> master
-
Ariya Hidayat authored
-
Cam Saul authored
-
Dalton authored
-
Nemanja Glumac authored
* Add `cypress-skip-test` library This is the official Cypress library for conditionally skipping/running tests. https://github.com/cypress-io/cypress-skip-test * Enable `cy.onlyOn` and `cy.skipOn` custom commands in all tests Reference: https://github.com/cypress-io/cypress-skip-test#example
-
- Mar 17, 2021
-
-
Nemanja Glumac authored
-
Cam Saul authored
Merge pull request from GHSA-m8w4-6wxv-8v6m * Fix sandboxed Field Values regression * Test fixes
* Dox fix -
Cam Saul authored
* Port code for building i18n resources to Clojure build scripts; remove dep on gettext * Use Metabase classloader * Test fixes
* Bump adoptopenjdk version * Delete gettext dependency from Dockerfile * Update developers-guide.md * Address PR feedback * Fix frontend singular msgstr format Co-authored-by:Luis Paolini <paoliniluis@gmail.com>
-
Cam Saul authored
Merge release x.38.x -> master 2021-03-16
-
Jeff Evans authored
Merge pull request from GHSA-pxfh-93j9-h745 Check read permission on the instance from get Check write permission on the instance from revert Rewrite expectations to clojure.test in revision_test.clj Remove some ugliness (in the delay) and switch to fixtures instead Add new test in revision_test.clj for preventing unauthorized reversions
-
Cam Saul authored
-
Cam Saul authored
* Convert even more old-style tests to the new style * Test fixes
-
- Mar 16, 2021
-
-
Cam Saul authored
-