Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jul 05, 2023
    • Ryan Laurie's avatar
      Make text measurement function naming more consistent (#32086) · d819ee53
      Ryan Laurie authored
      * create measureTextWidth functions
      
      * update rowChart and utils
      
      * update static viz
      Unverified
      d819ee53
    • Anton Kulyk's avatar
      Migrate QB summarization sidebar to MLv2 (#31564) · 3739812f
      Anton Kulyk authored
      * Make bucket pickers more customizable
      
      * Allow hiding expressions in `AggregationPicker`
      
      * Migrate `SummarizeSidebar` to MLv2
      
      * Delegate more stuff to aggregation components
      
      * Polish for breakout components
      
      * Don't copy queries into sidebar state
      
      * Use two breakouts in sidebar tests
      
      * Use long display name for pinned breakouts
      
      * Fix "replace column" used instead of "add column"
      
      * Fix extra spacing
      
      * Fix tooltip position
      
      * Fix pinned breakouts display
      
      * Fix E2E test
      
      * Clean up bucket pickers
      
      * Fix types
      
      * Fix border width
      
      * Simplify `BreakoutColumnList`
      
      * Add `withDefaultBucket` helper
      
      * Avoid `byRole` queries in sidebar tests
      
      * Fix UI jumps while searching
      
      * Hide "Custom expression" option
      Unverified
      3739812f
    • Alexander Polyankin's avatar
    • Alexander Polyankin's avatar
    • Kamil Mielnik's avatar
      Fix - Filter box in table has horizontal scroll (#32119) · d41d3342
      Kamil Mielnik authored
      * Fix #31339
      
      * Add an e2e for horizontal scrollbar presence
      
      * Add an e2e test for the originally reported issue #31339
      
      * Remove inline headerCells
      
      * Format tests
      
      * Remove redundant code
      
      * Move tests to table visualization scenarios tests suite
      Unverified
      d41d3342
    • Kamil Mielnik's avatar
      Adding filter of summarized field grouped by latitude and longitude on a map... · 443a8ced
      Kamil Mielnik authored
      Adding filter of summarized field grouped by latitude and longitude on a map changes visualization type (#31646)
      
      * Take sourceQuery into account if StructuredQuery does not have any aggregations or breakouts when determining Question's default display
      - It's an attempt to fix #30057
      
      * Don't check source query for models
      
      * Use source query breakouts and aggregations to determine default display only if the question does not have any breakouts, aggregations, and joins
      - Make the condition to always use "table" display for Models more prominent
      
      * Revert first attempt
      
      * Introduce CardObject and fix displayIsLocked typing
      
      * Refactor maybeUnlockDisplay into maybeResetDisplay
      
      * Revert "Introduce CardObject and fix displayIsLocked typing"
      
      This reverts commit 770e7a50d3b9f381741ba7cb1655c1d9be5f295c.
      
      * Improve diff
      
      * Update unit tests after maybeUnlockDisplay to maybeResetDisplay refactoring
      
      * Update maybeResetDisplay unit tests
      
      * Improve test case names
      
      * Add tag for the test that reproduces the issue
      
      * Add test for issue #30057
      - use visualize() helper
      - extract addCountGreaterThan2Filter()
      
      * Add a test case for adding columns
      
      * Add a test case for removing columns (resetting to default value)
      
      * Add a test case for adding aggregations
      
      * Add another test case
      
      * Reuse e2e helpers
      - add missing "field" parameter support in addSummaryGroupingField
      - add removeSummaryGroupingField
      
      * Remove redundant condition
      
      * Update issue id in tests after extracting separate GitHub issue
      Unverified
      443a8ced
  2. Jul 04, 2023
  3. Jul 03, 2023
  4. Jun 30, 2023
  5. Jun 29, 2023
    • Nick Fitzpatrick's avatar
    • Aleksandr Lesnenko's avatar
    • Ryan Laurie's avatar
      Require table primary key to enable basic actions (#31929) · 45759946
      Ryan Laurie authored
      * require table primary key to enable basic actions
      
      * add unit tests
      
      * update model detail page test metadata
      Unverified
      45759946
    • Nick Fitzpatrick's avatar
      13455 column order after removal (#31856) · 77fbb582
      Nick Fitzpatrick authored
      * remove disabled columns from isValid check
      
      * Applying column indexes before filtering
      
      * Adding test to GH 29140, updating test helpers in settings.cy.spec.js
      
      * Adjusting indexes when sorting via table header
      
      * e2e test adjustments
      Unverified
      77fbb582
    • Anton Kulyk's avatar
    • Cal Herries's avatar
    • Kamil Mielnik's avatar
      Fix - Trend charts look very broken with new dashboard grid changes (#31722) · 78ffada6
      Kamil Mielnik authored
      * Fix component name
      
      * Show only 1 title line on small SmartScalars
      
      * Style PreviousValueVariation and the separator
      - Get rid of flexbox so that the default browser text-wrapping algorithm is used
      - Be pixel-perfect about margin-left
      
      * Bring back height calculation based on number of lines
      
      * Format change
      
      * Fix ellipsis in ScalarValue
      
      * Make spacing consistent
      
      * Style VariationIcon and VariationValue
      - get rid of a utility class and inline CSS
      
      * Add ellipsis to previous value, style tooltip
      
      * Ensure consistent width of SmartScalar children
      
      * Update JS to match CSS
      
      * Refactor measureText to return the whole TextMetrics object
      
      * Extract hardcoded padding out of ScalarValue
      
      * Update measure text to return height explicitly
      
      * Account for height in the findSize function
      
      * Improve spacing
      
      * Improve styling
      
      * Fix build, bring back removed styling
      
      * Make previous value responsive
      
      * Revert #31724
      
      * Fix typing
      - Introduce TextWidthMeasurer type
      
      * Remove redundant CSS and elements
      
      * Rename formatChangeSmart to formatChangeAutoPrecision
      
      * Fix ellipsis on previous value
      
      * Improve 2 lines threshold value and introduce explanatory constant
      
      * Format code
      
      * Remove redundant code
      
      * Update findSize tests
      
      * Fix overflow in Scalars
      
      * Add overflow test boilerplate
      
      * Include more sizes in the test
      
      * Format code
      
      * Add tests for scalar
      - add scalar-description to assertions
      
      * Extract assertDescendantNotOverflowsContainer
      
      * Remove redundant check
      
      * Extract setupDashboardWithQuestionInCards
      
      * Reorder cards from biggest to lowest horizontally
      
      * Extract assertDescendantsNotOverflowDashcards
      
      * Add test case for when sidebar is open
      
      * Format code
      
      * Ignore elements without dimensions in assertions
      
      * Reorder cards from biggest to smallest vertically
      
      * Add 1x cards in tests for scalars
      
      * Add tests for various viewports
      
      * Improve naming
      
      * Format code
      
      * Fix cursor: pointer being shown on container hover instead of icon hover
      
      * Improve vertical icon alignment, make ScalarDescriptionPlaceholder padding consistent with ScalarDescriptionContainer
      
      * Account for title lines count in Scalar
      
      * Refactor tests to allow better test case descriptons
      
      * Use useful viewports
      
      * Find a testable way to fix ellipsis
      
      * Adjust test data
      
      * Add assertion messages
      
      * Fix tooltip not shown on value when ellipsis is applied
      
      * Add test for tooltips in 1x2 card
      
      * Add tests for 2x2 & 5x3 cards
      - fix CSS issues breaking tests
      
      * Add tests for 2x2 card
      
      * Add tests for more card sizes
      
      * Assert ellipsis is applied
      
      * Fix assertions
      
      * Update unit tests
      
      * Rename TITLE_2_LINES_THRESHOLD to TITLE_2_LINES_HEIGHT_THRESHOLD
      
      * Fix typo
      
      * Make mock data reflect real data a bit more
      
      * Fix cursor: pointer being applied on the container hover instead of icon
      
      * Don't assume the "space" function will return values in pixels
      
      * Move Scalar to its own directory
      
      * Extract constants.ts and utils.ts from Scalar
      
      * Move SmartScalar to its own directory
      
      * Extract constants.ts and utils.ts from SmartScalar
      
      * Extract styles computation out of SmartScalar
      
      * Extract getValueWidth & getValueHeight to utils
      
      * Update value height computation
      
      * Update typing
      
      * Make capitalization work as intended
      
      * Fix inversed calculation
      
      * Add missing gridSize prop
      
      * Remove capitalization logic and improve breakpoints
      - I believe the original intention was to capitalize only the first character, but every word is capitalized and it looks weird
      
      * Extract createCardsRow
      
      * Break down the tests into more suites because cypress can't consistently handle loading 20 dashboard card simultaneously
      
      * Improve names
      
      * Remove mistakenly added size 1 smart cards from tests
      
      * Sort props to see differences
      
      * Fix vertical center alignment in Scalar
      - this change also affects SmartScalar, see discussion: https://metaboat.slack.com/archives/C057T1QTB3L/p1688020307409629?thread_ts=1687997714.132239&cid=C057T1QTB3L
      
      * Replace within() + contains() with findByText()
      
      * Don't export getTitleHeight
      - move it to below where it's used
      
      * Remove unused gridSize prop
      
      * Use consistent code style
      
      * Simplify separators logic
      
      * Remove concatRecursively
      
      * Fix typo
      
      * Optimize test suite
      
      * Fix typo
      
      * Add unit tests for Scalar utils: getValueHeight & getValueWidth
      
      * Add unit tests for SmartScalar utils
      
      * Fix e2e tests
      - update card width in test caes
      - wrap cases requiring cy.viewport() in it to prevent test issues
      Unverified
      78ffada6
    • Alexander Polyankin's avatar
      Fix copy in joins (#31984) · d45c8d61
      Alexander Polyankin authored
      Unverified
      d45c8d61
    • Alexander Polyankin's avatar
    • Anton Kulyk's avatar
      Migrate notebook aggregations to MLv2 (#31855) · c529a888
      Anton Kulyk authored
      * Migrate notebook aggregations to MLv2 — Operators (1) (#31527)
      
      * Add aggregation types
      
      * Add aggregation TypeScript wrappers
      
      * Move `AggregateStep` to its own directory
      
      * Port basic features to MLv2
      
      * Deprecate `AggregationPopover`
      
      * Fix MLv1's aggregation clause validation
      
      * Fix import
      
      * `requiresField` → `requiresColumn`
      
      * Add basic tests for `AggregationPicker`
      
      * Add `findAggregationOperator` test utility
      
      * Add basic tests for `AggregateStep`
      
      * Make stage index explicit
      
      * Highlight selections, add picker back button
      
      * Use long display name for aggregation clauses
      
      * Remove `React` imports
      
      * Enable temporal bucketing
      
      * Use aggregation JS wrappers
      
      * Fix `Icon` import
      
      * Patch unit test according to BE changes
      
      * Fix E2E test
      
      * Simplify `Aggregation's` `dimension` method
      
      * Fix formatting
      
      * Migrate notebook aggregations to MLv2 — Metrics (2) (#31528)
      
      * Add basic legacy metrics support
      
      * Don't show archived metrics
      
      * Highlight selected metric
      
      * Extract `AggregationPopover` in notebook step
      
      * Fix `onClose` prop
      
      * Fix icon
      
      * Add missing metric types
      
      * Use MLv2 to manage metrics
      
      * Remove legacy query logic
      
      * Add `Aggregatable` type
      
      * Migrate notebook aggregations to MLv2 — Inline expressions (3) (#31529)
      
      * Revert "Remove legacy query logic"
      
      This reverts commit 722804d3a6684762701351c658625b5439c75c2b.
      
      * Use HTML labels in `ExpressionWidget`
      
      * Support inline expressions for aggregations
      
      * Fix import
      
      * Fix picker navigation
      
      * Fix type error
      
      * Remove `ts-expect-error`
      
      * Migrate notebook aggregations to MLv2 — Disable MLv1 validation (4) (#31530)
      Unverified
      c529a888
    • Cal Herries's avatar
  6. Jun 28, 2023
Loading