Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. May 03, 2021
  2. May 02, 2021
  3. May 01, 2021
  4. Apr 30, 2021
    • Howon Lee's avatar
      Admin people pagination backend (#15687) · b5a427b4
      Howon Lee authored
      
      * limit and offset work upon hand exercise
      
      * limit added
      
      * add the test
      
      * docstring is wrong make it not wrong
      
      * fix namespace decl
      
      * they were test bugs only
      
      * stick that limit and offset in there
      
      * Permissions imports
      
      * make it work in dbs that are not just h2
      
      * add limit test get
      
      * needs integer
      
      * juice the coverity lol
      
      * just stick querying in the overall dealie
      
      * tests pass
      
      * add counter
      
      * rip out the clauses
      
      * not just if limited
      
      * docstring misplaced
      
      * more linting
      
      * cool tests
      
      * tests pass but lacking test lol
      
      * group id works
      
      * test works
      
      * fix jeff nits
      
      * break that api
      
      * add test for count
      
      * cypress works for some reason lol
      
      * fix capitalizations
      
      * admin people pagination frontend (#15821)
      
      * admin people pagination frontend
      
      * admin people pagination and search specs
      
      * address review comments
      
      * fix rebase
      
      * address review comments
      
      Co-authored-by: default avatarAlexander Lesnenko <alxnddr@users.noreply.github.com>
      b5a427b4
    • Ariya Hidayat's avatar
      274be949
    • Ariya Hidayat's avatar
      Custom expression editor: correctly accept the suggestion (#15872) · 8df9d954
      Ariya Hidayat authored
      This is carried out via lexical replacement, i.e. finding the token to
      be replaced, instead of the rather-brittle and often-incorrect regex for
      prefix/postfix.
      
      * Always place the caret after the replacement text
      
      * Only accept suggested "(" when there is no forthcoming "(" already
      8df9d954
    • Ariya Hidayat's avatar
      Cap the method cyclomatic complexity in the front-end code (#15871) · d6a2b32f
      Ariya Hidayat authored
      As we progress better with refactoring and simplification, the
      complexity threshold should be reduced as well.
      d6a2b32f
  5. Apr 29, 2021
  6. Apr 28, 2021
  7. Apr 27, 2021
  8. Apr 26, 2021
    • Luis Paolini's avatar
      Update .ebextensions (add Cloudwatch agent & AWS Inspector) (#14718) · ddfac7ed
      Luis Paolini authored
      
      * Update .ebextensions to send memory usage to Cloudwatch and also install inspector agent to actively monitor threats. Added full Cloudwatch agent with metrics config, simplified config file. Fix #9021
      
      * Adding a few items to documentation
      
      * Apply suggestions from code review
      
      Co-authored-by: default avatarJeff Bruemmer <jeff@metabase.com>
      
      * Add a few more changes to finish this PR
      
      Co-authored-by: default avatarJeff Bruemmer <jeff@metabase.com>
      ddfac7ed
    • Jeff Evans's avatar
      Set c3p0 dataSourceName property to include Metabase specific info (#15681) · 478ec730
      Jeff Evans authored
      Set c3p0 dataSourceName property to include Metabase specific info
      
      Change data-warehouse-connection-pool-properties multimethod to include database as 2nd param
      
      Setting the dataSourceName c3p0 property to have the format db-<N>-<D>-<DB> where <N> is the DW database ID, <D> is the driver name, and <DB> is the database name from the db details
      
      Adding test
      
      Setting c3p0 dataSourceName for the app DB pool as well
      478ec730
    • Gustavo Saiani's avatar
      Fix typo in documentation (#15798) · 0fa915db
      Gustavo Saiani authored
      0fa915db
    • Ariya Hidayat's avatar
      Custom expression: friendlier message on failing tokenization (#15787) · 420e7be8
      Ariya Hidayat authored
      * Custom expression: friendlier message on failing tokenization
      
      This covers cases such as:
      * invalid characters
      * unterminated quoted string
      * unterminated bracket/field reference
      
      * Ensure that tokenizerError is initialized properly
      420e7be8
    • Alexander Lesnenko's avatar
      remove flow suppressions (#15805) · 68a39235
      Alexander Lesnenko authored
      68a39235
    • Nemanja Glumac's avatar
      [SCHEDULED, Week 19] Fix `react/no-string-refs` errors (#15547) · 8888de33
      Nemanja Glumac authored
      
      * Fix `eslint-react/no-string-refs` errors (#15427)
      
      * Handle errors in `AdminLayout.jsx`
      
      * Rmove unused ref from `MetadataEditorApp.jsx`
      
      * Remove unused ref from `EditBar.jsx`
      
      * Handle errors in `Confirm.jsx`
      
      * Handle errors in `Header.jsx`
      
      * Handle errors in `NewsletterForm.jsx`
      
      * Handle errors in `ColorPicker.jsx`
      
      * Remove unused ref from `PasswordReveal.jsx`
      
      * Handle errors in `Triggerable.jsx`
      
      * Handle errors in `TokenField.jsx`
      
      * Handle errors in `DashboardHeader.jsx`
      
      * Handle errors in `RefreshWidget.jsx`
      
      * Handle errors in `DatabaseEditApp.jsx`
      
      * Handle errors in `FieldRemapping.jsx`
      
      * Handle errors in `ObjectActionsSelect.jsx`
      
      * Handle errors in `ObjectRetireModal.jsx`
      
      * Remove unused ref from `UserGroupSelect.jsx`
      
      * Handle errors in `PermissionsGrid.jsx`
      
      * Handle errors in `ParameterTargetWidget.jsx`
      
      * Handle errors in `ParameterValueWidget.jsx`
      
      * Handle errors in `PulseEdit.jsx`
      
      * Handle errors in `PulseEditName.jsx`
      
      * Handle errors in `DataSelector.jsx`
      
      * Remove unused ref from `FieldWidget.jsx`
      
      * Handle errors in `NativeQueryEditor.jsx`
      
      * Handle errors in `SearchBar.jsx`
      
      * Handle errors in `ExpressionEditorTextfield.jsx`
      
      * Remove unused ref from `FieldWidget.jsx`
      
      * Remove unused ref from `SpecificDatePicker.jsx`
      
      * Handle errors in `RevisionMessageModal.jsx`
      
      * Handle errors in `Setup.jsx`
      
      * Handle errors in `LeafletMap.jsx`
      
      * Handle errors in `TableSimple.jsx`
      
      * Handle errors in `PieChart.jsx`
      
      * Handle errors in `Progress.jsx`
      
      * Remove unused refs from `QueryBuilder.jsx`
      
      * Remove unused ref and methods from `MetadataHeader.jsx`
      
      * Remove unused ref from `DashboardActions.jsx`
      
      * Handle errors in `DatabaseListApp.jsx`
      
      Note: dynamic refs
      
      * Handle errors in `LegendHorizontal.jsx`
      
      Note: dynamic refs
      
      * Disable linting rule `react/no-string-refs` in `LegendVertical.jsx`
      
      Note: dynamic refs
      
      * Partially handle errors in `GuiQueryEditor.jsx`
      
      * Disable linting rule `react/no-string-refs` in `GuiQueryEditor.jsx`
      
      Note: dynamic refs
      
      * Revert "Remove unused ref from `DashboardActions.jsx`"
      
      This reverts commit 5facb9d60ecb561093af15efcfc99b29ff96980e.
      
      * Handle errors in `DashboardActions.jsx`
      
      * Remove redundant `ReactDOM.findDOMNode` from `Setup.jsx`
      
      * Revert "Handle errors in `DashboardActions.jsx`"
      
      This reverts commit b3d64b8f7a982e0371d225d0d624ecbeaf776b76.
      
      * Disable linting for `DashboardActions.jsx`
      
      * Fix prettier error
      
      * Delete non-existing prop `getTarget`
      
      * Fix typo
      
      * Fix typos in more places
      
      * Fix `footerRef` check
      
      * Turn on `react/no-string-refs` lint rule
      
      * Disable `react/prop-types` in files that are breaking the build
      
      * Fix broken refs
      
      Co-authored-by: default avataralxnddr <alxnddr@gmail.com>
      8888de33
  9. Apr 23, 2021
  10. Apr 22, 2021
Loading