Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 19, 2024
  2. Jun 06, 2024
  3. Jun 03, 2024
  4. May 14, 2024
    • Ryan Laurie's avatar
      Recents Picker Tab (#42079) · 52d32c15
      Ryan Laurie authored
      * add recents tab
      
      type updates
      
      fix unit test
      
      change where we filter recents
      
      WIP Recents Tab
      
      wip recents
      
      design updates
      
      update recents design to match search
      
      use new recents format
      
      initial recents implementation
      
      fix types
      
      * fix e2e tests
      
      * update more e2e tests
      
      * allow recents filters
      
      * update test mocks
      
      * add unit tests for recents tab
      
      * update e2e tests
      
      * add e2e tests for recents picker tab
      
      * fix lost access test
      Unverified
      52d32c15
  5. Apr 18, 2024
    • Ryan Laurie's avatar
      Question + Model Picker (#40207) · 784c26ac
      Ryan Laurie authored
      * WIP questionpicker
      
      * use to replace dashcard content
      
      * much better stuff
      
      * question picker
      
      * values source card modal
      
      * create action form
      
      * awesome hacky fix for crashing model detail page
      
      * use entity picker in sandboxing modal
      
      * deprecate ye olde question picker
      
      * keep old question picker in add-card dashboard sidebar
      
      * better last level check
      
      * update types
      
      * make stuff better
      
      * fix rebase conflicts
      
      * better initial value handling
      
      * update e2e tests
      
      * sweet sweet unit tests
      
      * fix sandbox tests
      
      * fix tests
      
      * type fix
      
      * fixes
      
      * search style improvements
      
      * remove unused prop
      
      * safer path detection
      
      * delayed loading spinner
      
      * change confirm default
      
      * set default collection for placeholder card
      
      * address review comments
      
      * update unit tests
      
      * update e2e tests
      
      * fix re-rebase
      
      * add some happy little comments
      Unverified
      784c26ac
  6. Mar 28, 2024
  7. Feb 20, 2024
    • Kamil Mielnik's avatar
      RFC 70 - Automate sorting imports (#33883) · 2aa3cec6
      Kamil Mielnik authored
      * Upgrade eslint-plugin-import
      
      * Configure import/order rule for consistent, predictable imports
      
      * Change "eslint-disable-next-line no-restricted-imports" into "eslint-disable-line"
      
      * Ensure imports are in a single block
      
      * Move or remove informative comments between import statements
      
      * Remove imports-grouping comments
      
      * Configure groups
      - the difference between the default setting is the presence of "internal" group
      
      * Manually fix imports order and disable "import/order" rule in files with possible circular dependencies
      
      * Move comment to the same line as import
      
      * Run "yarn eslint-fix" 5 times
      - Remaining: 16 problems (16 errors, 0 warnings)
      
      * Manually fix imports order in remaining files
      
      * Run "yarn prettier"
      
      * Fix import
      
      * Fix circular dependency
      
      * Fix circular dependency
      
      * Remove unused action creator (it was inlined in 702988ec3f8bd4c6bf6bbbdf169dca25a0ca5a13 due to circular dependency)
      
      * Re-add accidentally removed code
      
      * Fix typing
      
      * ESLint
      Unverified
      2aa3cec6
  8. Jan 08, 2024
  9. Oct 09, 2023
    • Kamil Mielnik's avatar
      Introduce waitForLoaderToBeRemoved util (#34432) · 7f4d07a1
      Kamil Mielnik authored
      * Introduce waitForLoadingSpinnerToDisappear
      
      * Use waitForLoadingSpinnerToDisappear in QueryBuilder tests
      
      * Use waitForLoadingSpinnerToDisappear in ObjectDetailWrapper tests
      
      * Use waitForLoadingSpinnerToDisappear in DashboardApp tests
      
      * Use waitForLoadingSpinnerToDisappear in ActionCreatorModal tests
      
      * Use waitForLoadingSpinnerToDisappear in DatabaseEditApp tests
      
      * Use waitForLoadingSpinnerToDisappear in MetricApp tests
      
      * Use waitForLoadingSpinnerToDisappear in SegmentApp tests
      
      * Use waitForLoadingSpinnerToDisappear in DatabasesPermissionsPage tests
      
      * Use waitForLoadingSpinnerToDisappear in GroupsPermissionsPage tests
      
      * Use waitForLoadingSpinnerToDisappear in PremiumEmbeddingLicensePage tests
      
      * Use waitForLoadingSpinnerToDisappear in TableBrowser tests
      
      * Use waitForLoadingSpinnerToDisappear in FieldValuesWidget tests
      
      * Use waitForLoadingSpinnerToDisappear in DataPicker-Models tests
      
      * Use waitForLoadingSpinnerToDisappear in DataPicker-Questions tests
      
      * Use waitForLoadingSpinnerToDisappear in DataPicker-RawData tests
      
      * Use waitForLoadingSpinnerToDisappear in ActionSidebar tests
      
      * Use waitForLoadingSpinnerToDisappear in DashboardHeader tests
      
      * Use waitForLoadingSpinnerToDisappear in SearchBar tests
      
      * Use waitForLoadingSpinnerToDisappear in SearchResults tests
      
      * Use waitForLoadingSpinnerToDisappear in SearchResultsDropdown tests
      
      * Use waitForLoadingSpinnerToDisappear in MainNavbar tests
      
      * Use waitForLoadingSpinnerToDisappear in Navbar tests
      
      * Use waitForLoadingSpinnerToDisappear in PublicAction tests
      
      * Use waitForLoadingSpinnerToDisappear in DefaultPicker tests
      
      * Use waitForLoadingSpinnerToDisappear in TypeFilterContent tests
      
      * Use waitForLoadingSpinnerToDisappear in SearchApp tests
      
      * Replace waitForElementToBeRemoved(() => screen.queryByText("Loading...")) with waitForLoadingSpinnerToDisappear();
      
      * Replace waitForElementToBeRemoved(() => screen.queryByText(/loading/)) with waitForLoadingSpinnerToDisappear();
      
      * Remove all remaining waitForElementToBeRemoved usages
      
      * Replace all spinner queries by text with queries by test-id
      
      * Make spinner existence assertions consistent
      
      * Consolidate imports
      
      * Connect comment to code
      
      * Add explanatory comment
      
      * Rename waitForLoadingSpinnerToDisappear to waitForLoaderToBeRemoved
      Unverified
      7f4d07a1
  10. Aug 22, 2023
  11. Jun 13, 2023
    • Kamil Mielnik's avatar
      Respect alphabetical order of collections in "Move" modal (#31355) · 750f1cfe
      Kamil Mielnik authored
      * Remove unused openCollection prop
      
      * Preserve collection sorting given by API in getExpandedCollectionsById
      - Fixes #31294
      
      * Use Collections.getListStatePath() to unhardcode the object path
      
      * Use CollectionId instead of any
      
      * Extract Collections.selectors.getCollectionList
      
      * Convert Collections selectors unit tests to TypeScript
      
      * Remove redundant selector
      
      * Add a unit test for Collections.selectorsgetExpandedCollectionsById
      
      * Use createMockCollection for all test collections
      - Use Partial<Collection> instead of MockCollection type
      
      * Add a test case for non-nested collections
      
      * Rename identifiers
      
      * Add a test suite for snippet collections
      
      * Fix SnippetCollections.selectors.getExpandedCollectionsById
      
      * Refactor tests
      
      * Refactor tests
      
      * Revert unit tests for selectors
      
      * Revert convert selectors to TypeScript
      
      * Add error support to setupCollectionsEndpoints
      
      * Introduce useCollectionsQuery
      
      * Fix tests
      
      * Add unit tests for preserving order of collections in ItemPicker
      
      * Make assertions more semantic
      
      * Allow mocking root collection
      - Make ROOT_COLLECTION object match Collection type
      
      * Add tests for preserving order in snippet collections list
      - fix case with an undefined snippet collections list
      
      * Update test case with data loading necessary for ItemPicker underneath the EditSandboxModal after updating selectors
      
      * Update test case with data loading necessary for ItemPicker underneath the AddToDashSelectDashModal after updating selectors
      
      * Rename useCollectionsQuery to useCollectionListQuery
      
      * Remove leftover fetchMock
      
      * Move error out of setupCollectionsEndpoints
      
      * Fix ModelDetailPage unit tests setup
      
      * Remove leftover fetchMocks
      
      * Revert changes to ROOT_COLLECTION constant
      - use createMockCollection
      
      * Fix typing
      
      * Remove dead link to Source Sans Pro font
      - it caused markdown check to fail during CI, this fixes it
      - it seems that the font has been removed from Google Fonts
      - users can still choose this font in Metabase settings
      - removal confirmation: https://metaboat.slack.com/archives/C5XHN8GLW/p1686320576992299?thread_ts=1686319384.637909&cid=C5XHN8GLW
      
      * Fix getExpandedCollectionsById selector
      
      * Revert adding useCollectionListQuery in unit tests
      Unverified
      750f1cfe
  12. May 31, 2023
  13. May 17, 2023
  14. Feb 23, 2023
  15. Feb 14, 2023
Loading