Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 02, 2020
  2. Feb 26, 2020
    • Kyle Doherty's avatar
      Improve month picker legibility (#11973) · 256f8cef
      Kyle Doherty authored
      * switch to 3up grid
      
      * cleanup
      Unverified
      256f8cef
    • Kyle Doherty's avatar
      Tweak date picker visuals (#11990) · 987db8a4
      Kyle Doherty authored
      * tweak date picker visuals
      
      * update Calendar snapshot
      Unverified
      987db8a4
    • Walter Leibbrandt's avatar
      Support for question references in native query template tags (#11835) · 013a6a0d
      Walter Leibbrandt authored
      * Port tests from expectations to clojure.test
      
      * Fix docstring
      
      * Added :question template tag type with lookup
      
      * s/question/card/
      
      * Fix typo: s/substitue/substitute/g
      
      * Wrap card query parameter data in a record
      
      Just like `FieldFilter`s.
      
      * Unrelated: Improve test layout
      
      * Add substitution of card query parameters in queries
      
      This implementation is incomplete.
      
      * Finish substitution of card query in parent query
      
      * Basic FE support for question template tags
      
      * Update card ID on tag name update
      
      Also, don't use `\d` in regexes.
      
      * yarn prettier
      
      * Add support for MBQL queries in template tag lookup
      
      * Return query strings directly as tag value
      
      * Fix query type lookup
      
      * Initialize QP store for MBQL→native conversion
      
      * Fix MBQL to native query conversion
      
      * Port tests from expectations to clojure.test
      
      * Add middleware to resolve tables/fields from referenced cards
      
      This needs to happen before `substitute-parameters` in the QP pipeline,
      so that `substitute-parameters` can convert any MBQL queries (from
      referenced cards) into native queries. Maybe it should be consolidated
      with the other resolution steps.
      
      * Use mbql-query util instead of manual query def
      
      * Add docstring to now public function
      
      * Remove unused import
      
      * Fix docstring positioning :face_palm:
      
      
      
      * Clean ns declaration
      
      * Convert tests to clojure.test
      
      * Be more specific about errors we're looking expecting
      
      Invalid queries caused unexpected exceptions to be thrown when checking
      permissions.
      
      * Recursively check permissions of referenced queries
      
      * Add incomplete test [WIP]
      
      * Finish permission check test for referenced MBQL queries
      
      * Add tests for referenced native queries perms check
      
      * Clean ns
      
      * Use existing mbql-to-native middleware
      
      Rather than calling driver-specific `mbql->native` directly.
      
      * Fix formatting
      
      * Use more comprehensive qp func for converting query to native
      
      * front end updates
      
      * Check that all referenced queries are from the same db
      
      * Add test for checking db id of referenced MBQL query
      
      * Clean ns
      
      * add metadata and better error states to UI
      
      * move error message beneath the question picker
      
      * Combine `vals`+`filter`+`map` into a single `keep`
      
      * Rename `CardQuery`→`ReferencedCardQuery`
      
      * Cosmetic: fix typo and formatting
      
      * Test substitution of multiple sub-queries
      
      * Test CTE syntax substitution of multiple sub-queries
      
      * Clean ns
      
      * Clean ns
      
      * Simplify referenced card substitution tests
      
      * Test recursive sub-query substitution
      
      * Cosmetic: typos
      
      * Fix parameter names in comments
      
      * Check that queries don't include circular sub-queries
      
      * Clean ns
      
      * Give users a more user-friendly error for circular referencing sub-queries
      
      * Test referencing queries with parameters
      
      * Update src/metabase/query_processor/middleware/resolve_referenced.clj
      
      Co-Authored-By: default avatarMaz Ameli <maz@metabase.com>
      
      * Fix error message and combine card name queries
      
      * Wrap sub-query error in a more user friendly explanation
      
      * Cosmetic: function argument alignment
      
      * Test error handling of referenced sub-queries
      
      * Remove unused 1-arity version of `card-subquery-graph`
      
      * Cosmetic: indentation
      
      * Normalize l10n of error messages
      
      * Reuse functions for looking up referenced cards from query
      
      * implement FE PR feedback
      
      * card -> card_id backend changes
      
      * fix tests
      
      * fix another test
      
      * disallow space between # and number
      
      * Align new middleware with newer QP architecture
      
      * Align sub-query error handling with the new QP
      
      It seems like exceptions are handled more consistently in the new QP, so
      we can be less hacky.
      
      * (Re)wrap sub-query errors in user-friendly expalanation
      
      * Rename `xformf`→`rff` to align with QP changes
      
      * force cypress click on select placeholder
      
      * move popover attachement and cap its height
      
      * icon spacing
      
      * customize highlighting for template tags
      
      Co-authored-by: default avatarPaul Rosenzweig <paulrosenzweig@users.noreply.github.com>
      Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
      Unverified
      013a6a0d
  3. Feb 25, 2020
  4. Feb 24, 2020
  5. Feb 21, 2020
  6. Feb 20, 2020
  7. Feb 19, 2020
  8. Feb 18, 2020
  9. Feb 14, 2020
  10. Feb 13, 2020
  11. Feb 10, 2020
  12. Feb 06, 2020
  13. Feb 05, 2020
Loading