This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Oct 27, 2023
-
-
Nemanja Glumac authored
* Stop caching the uberjar for E2E tests * Bring back SHA1 in an uberjar name * Adjust the download uberjar action * Fix uberjar name for percy
-
Mark Bastian authored
Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Case Nelson authored
-
Ryan Laurie authored
-
Alexander Polyankin authored
-
Anton Kulyk authored
-
Anton Kulyk authored
-
Oisin Coveney authored
Closes https://github.com/metabase/metabase/issues/35037 ### Description Ensures that clicking on a search/recents entry only triggers the onClick action, rather than the href/redirect behavior that the issue brings up. _What Changed:_ - Added a new prop `isEnabled` to the InfoTextTableLink component. - Modified the href attribute of a ResultTitle component. ### How to verify - Create a new dashboard A, save it and visit it - Create a new dashboard B and edit it. - Add a link card to it - A dropdown with "Recently viewed" items will appear - Click header of the first entry in it with a mouse ### Checklist - [X] Tests have been added/updated to cover changes in this PR
-
Case Nelson authored
-
- Oct 26, 2023
-
-
dpsutton authored
Annoying warnings on startup ;#### Before ```shell Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/rule/:prefix/:dashboard-template [prefix Prefix] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/rule/:prefix/:dashboard-template [dashboard-template DashboardTemplate] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/cell/:cell-query [cell-query Base64EncodedJSON] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/cell/:cell-query/rule/:prefix/:dashboard-template [prefix Prefix] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/cell/:cell-query/rule/:prefix/:dashboard-template [dashboard-template DashboardTemplate] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/cell/:cell-query/rule/:prefix/:dashboard-template [cell-query Base64EncodedJSON] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/rule/:prefix/:dashboard-template/compare/:comparison-entity/:comparison-entity-id-or-query [prefix Prefix] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/rule/:prefix/:dashboard-template/compare/:comparison-entity/:comparison-entity-id-or-query [dashboard-template DashboardTemplate] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/cell/:cell-query/compare/:comparison-entity/:comparison-entity-id-or-query [cell-query Base64EncodedJSON] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/cell/:cell-query/rule/:prefix/:dashboard-template/compare/:comparison-entity/:comparison-entity-id-or-query [prefix Prefix] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/cell/:cell-query/rule/:prefix/:dashboard-template/compare/:comparison-entity/:comparison-entity-id-or-query [dashboard-template DashboardTemplate] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:entity/:entity-id-or-query/cell/:cell-query/rule/:prefix/:dashboard-template/compare/:comparison-entity/:comparison-entity-id-or-query [cell-query Base64EncodedJSON] Either add :fn to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:key [key kebab-cased-keyword] Either add :keyword to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:key [key kebab-cased-keyword] Either add :keyword to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:zoom/:x/:y/:lat-field/:lon-field [lat-field :string] Either add :string to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. Warning: missing route-param regex for schema: /:zoom/:x/:y/:lat-field/:lon-field [lon-field :string] Either add :string to metabase.api.common.internal/->matching-regex or metabase.api.common.internal/no-regex-schemas. ``` ;#### After ;#### Fixes ;###### :fn We logged lots of startups that we didn't have a regex for the `:fn` type validator in routes. And this is generally not possible. So we should generally just ignore function based validators, as we're not going to write a regex for what a function validates/accepts. All of these `:fn` matchers are in the x-ray namespace matching base64 encoded json, an existing dashboard template prefix (`(malli.core/validate Prefix "TransactionTable")`), ;###### `:keyword`: Add a regex `#"[\S]+"` that just looks for non space characters ;###### String matches `:string` ```clojure (def ^:private kebab-cased-keyword "Keyword that can be transformed from \"a_b\" -> :a-b" [:keyword {:decode/json #(keyword (u/->kebab-case-en %))}]) ... (api/defendpoint GET "/:key" "Fetch a single `Setting`." [key] {key kebab-cased-keyword} (with-setting-access-control (setting/user-facing-value key))) ``` We don't want a regex for this. Whatever we are currently accepting in the route matching is our desired behavior. Arbitrary strings don't have a good regex and we don't want to restrict what the route currently does. ```clojure (api/defendpoint GET "/:zoom/:x/:y/:lat-field/:lon-field" "This endpoints provides an image with the appropriate pins rendered given a MBQL `query` (passed as a GET query string param). We evaluate the query and find the set of lat/lon pairs which are relevant and then render the appropriate ones. It's expected that to render a full map view several calls will be made to this endpoint in parallel." [zoom x y lat-field lon-field query] {zoom ms/Int x ms/Int y ms/Int lat-field :string lon-field :string query ms/JSONString} ...) ```
-
Oisin Coveney authored
-
Denis Berezin authored
* Fix entities fetch caching * Add proper unit test, fix loop issue * Review fixes, unit test fix
-
lbrdnk authored
* Update sql qp to handle interval subtraction * Update tests checking interval subtraction * Transform assertions to exceptions
-
Cam Saul authored
-
Case Nelson authored
-
Jeff Bruemmer authored
-
Maz Ameli authored
* update copy and tests for confirmation modal * fix tests
-
Nicolò Pretto authored
Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com> Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
Cal Herries authored
-
Kamil Mielnik authored
* Reuse addOrUpdateDashboardCard * Extract 15993 repro * Extract 16334 repro * Extract 23137 repro * Extract 18067 repro * Remove unused alias * Extract GAUGE_QUESTION_DETAILS & PROGRESS_QUESTION_DETAILS * Reuse addOrUpdateDashboardCard * Commit a dumb change to trigger uberjar rebuild * Revert "Commit a dumb change to trigger uberjar rebuild" This reverts commit 27ef0600ad0dae1dec98bf1e7282e5872b7293e7.
-
shaun authored
-
Anton Kulyk authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
Cal Herries authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
[ci skip]
-
Braden Shepherdson authored
This is useful for migrating from serdes v1 to v2. Fixes #34871.
-
Nemanja Glumac authored
-
- Oct 25, 2023
-
-
Aleksandr Lesnenko authored
-
Cam Saul authored
-
shaun authored
-
Cal Herries authored
Explain why linked filters and "From connected fields" don't work for native variables on the dashcard (#34969)
-
Jeff Bruemmer authored
-
Cal Herries authored
-
Anton Kulyk authored
-
Ngoc Khuat authored
-
Anton Kulyk authored
-
Nick Fitzpatrick authored
* fix scrolling while dragging column items * Add issue number for scrolling --------- Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
-
Ngoc Khuat authored
-
Cal Herries authored
-
Nemanja Glumac authored
* Separate Replay E2E tests from the main workflow * Fix workflow conditionals
-