This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 21, 2023
-
-
Nemanja Glumac authored
* Revert "Improve external filter checks (#35740)" This reverts commit 8ef7eb59. * Revert "Make Chromatic workflow 3rd party friendly (#35708)" This reverts commit 931029e0. * Revert "Make E2E workflow 3rd party friendly (#35643)" This reverts commit b547eb7e. * Revert "PoC External workflow run trigger (#34951)" This reverts commit df16fc89.
-
Jeff Bruemmer authored
-
Jeff Bruemmer authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
* Fix E2E dashboard cards "default sizes" flake * Increase the request timeout and remove the `@flaky` tag * Add test to the "slow" E2E group
-
Ngoc Khuat authored
* Revert "When attemp to delete inactive tables, skip tables that have active cards (#35693)" This reverts commit 2586ef0d. * Revert "Daily task to delete old inactive tables (#35443)" This reverts commit cd975913.
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix static/public embed crashes when query returns error * Add E2E test to reproduce the issue * Sort the key more consistently
-
- Nov 20, 2023
-
-
Ngoc Khuat authored
-
Aleksandr Lesnenko authored
* fix TableSimple styles * tweak sorting icon opacity * Update TableSimple.styled.tsx
-
Jerry Huang authored
-
shaun authored
-
Cam Saul authored
-
Alexander Polyankin authored
Revert "Revert "Rollback mbqlv2 drills - sort, fk-filter, summarize-column-by-time (#35917)" (#35926)" (#35951)
-
dpsutton authored
* Revert "Clarify stacktraces from malli validation errors (#34712)" This reverts commit 1a0f2d65. * Alternative fix for mu/defn correctness issue https://github.com/metabase/metabase/pull/34712 introduced a correctness bug: ```clojure (macroexpand '(metabase.util.malli/defn foo [x :- string?] :foo)) (def foo "Inputs: [x :- string?]\n Return: :any" (clojure.core/fn ([a] (metabase.util.malli.fn/validate-input {:fn-name 'user/foo} string? a) ((clojure.core/fn [x] :foo) a)))) ``` The simplest demo of the bug is ```clojure user=> (metabase.util.malli/defn foo [x] a) #'user/foo ``` The macro used simple and predictable args for it's emitted functions. This was not a problem with the original shape: (different macroexpansions of `(mu/defn foo [x :- int?] (inc x))`): prior to 34712: ```clojure (def foo "Inputs: [x :- int?]\n Return: :any" (clojure.core/let [&f (clojure.core/fn [x] (inc x))] (clojure.core/fn ([a] ;; simple argument name not a problem (metabase.util.malli.fn/validate-input {:fn-name (quote metabase.util.malli.fn-test/foo)} int? a) (&f a))))) ``` after 34712: ```clojure (def foo "Inputs: [x :- int?]\n Return: :any" (clojure.core/fn ([a] ;; simple argument name is now a problem (metabase.util.malli.fn/validate-input {:fn-name 'user/foo} int? a) ((clojure.core/fn [x] (inc x)) a)))) ``` after this PR: ```clojure (def foo "Inputs: [x :- int?]\n Return: :any" (clojure.core/let [&f (clojure.core/fn [x] (inc x))] (clojure.core/fn ([a] ;; again simple argument name is not a problem (try (metabase.util.malli.fn/validate-input {:fn-name (quote metabase.util.malli.fn-test/foo)} int? a) (&f a) (catch java.lang.Exception error (throw (metabase.util.malli.fn/fixup-stacktrace error)))))))) ``` And the fix here is just to remove the StackTraceElements which reference `validate`, `validate-input`, or `validate-output`. * fix tests tests are run in the user namespace similar to ```clojure user=> (clojure.test/run-tests 'metabase.util.malli.fn-test) Testing metabase.util.malli.fn-test Ran 8 tests containing 43 assertions. 0 failures, 0 errors. {:test 8, :pass 43, :fail 0, :error 0, :type :summary} ``` But we still want the namespace of _this_ file m.u.m.fn-test
-
Nemanja Glumac authored
-
-
Oleg Gromov authored
-
metamben authored
-
Nick Fitzpatrick authored
-
Denis Berezin authored
-
Alexander Solovyov authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Nov 19, 2023
-
-
Ngoc Khuat authored
-
- Nov 17, 2023
-
-
Noah Moss authored
-
bryan authored
* audit-log only when hosted or has-feature: audit * lint fix * check for the right feature name, and test better * fix metabase.api.setting-test * fix a bunch of tests * fix a couple more tests * bit of cleanup * lint fixes * fix testing function * fix whitespace * linter fix * fix so many tests * fix the rest of the tests, IIUC * fix the last test * lint fix * remove outdated tests (from the merge conflict) * disable-other-sso-types needs to _reset_ premium features. - patches in the audit-app feature by default. * Just need to re-add :audit-app as a premium feature * try improving disable-other-sso-types
-
Jeff Bruemmer authored
-
Braden Shepherdson authored
Expressions which just wrap a real Field get `:id`, `:table_id` etc. so they match a `[:field {} 7]` ref. If that real field exists (table default or joined), prefer that over the expressions.
-
Jerry Huang authored
-
Uladzimir Havenchyk authored
-
metamben authored
-
Mark Bastian authored
Fixes #33499 We added a bunch of OTEL spans to figure out what was going on with super long page loads. Turns out it was a slow pprint of massive objects. This PR removes a few spans, but not all. The ones removed are either redundant or almost certainly not needed (I did remove the one around the offending code, but the negative space that would show if it happened again would reveal the issue -- LMK if we think we should put that one back). One important thing to consider when reviewing this PR is if we like the current coverage level around the `metabase.events` code (plus a couple extra things that were instrumented). It feels right, but if it seems too onerous we could remove some. As an observation, it _might_ make sense to add instrumentation to the high level functions in toucan2 itself, such as hydrate, select, etc. This would give us transparent instrumentation on the library and we could easily view traces to see the bounds of our db hot spots.
-
Denis Berezin authored
-
Jacob Joseph authored
-
Jeff Bruemmer authored
-
Roman Abdulmanov authored
-
Cal Herries authored
-
Alexander Solovyov authored
resolves #35880
-
Denis Berezin authored
-
Nemanja Glumac authored
* Fix "slugify collection url" flake * Remove the `@flaky` tag
-
Uladzimir Havenchyk authored
-