This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 13, 2024
-
-
github-automation-metabase authored
Fixes: #46558 In #45575 we introduced casting uuid fields for drilldowns. However we failed to include a check that the rhs was itself another field of uuid type and so no casting should occur. This broke joins on models when the database_type of the field may not be known. Co-authored-by:
Case Nelson <case@metabase.com>
-
John Swanson authored
* Nicer error messages for linting migrations In general, just throw exceptions instead of using clojure spec here. You'll only get one error per run, but that seems fine. I did keep some specs around, but run them slightly differently. Rather than validating the whole collection of changeSets at once with `s/+`, just `doseq` through the changeSets and validate each one separately. That way, the value that's presented as erroneous is much smaller (a single changeSet) and it's easier to see what went wrong. * Update bin/lint-migrations-file/test/lint_migrations_file_test.clj * Update bin/lint-migrations-file/src/lint_migrations_file.clj * Require preConditions for certain liquibase change types to encourage idempotence (#44578) * remove `!`s from non-side-effecty fns * add preConditions to a few v51 migrations --------- Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
github-automation-metabase authored
* Refactor filter utils to TS * Remove type casts * Improve dimension instantiation * Fix typing Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Aug 12, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
Nemanja Glumac authored
* Fix relative date options popover * Add repro for #46342 * Revert "Fix relative date options popover" This reverts commit ceaf62d9. * Use the Mantine Popover z-index
-
github-automation-metabase authored
* conditional dismissal step * check for download status in the container * try fixing flakes again * try again * chartPathWithFillColor already verifies chart has been rendered Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
github-automation-metabase authored
* Dowload Row Limit Env Var Adds `MB_DOWNLOAD_ROW_LIMIT` to enable changing the row limit on downloads and alert/subscription attachments (not the rendered tables, but the .csv, etc.). Based on: #44982 (Thanks, @r-kot) Partially implements: #28144 The difference in this PR compared to #44982 is that the download limit applies to all downloads, the only exception being when the limit is above `qp.i/absolute-max-results` (1048575, based on Excel's limitation); in such a case, the user supplied limit is only used if the download is csv or json, and `qp.i/absolute-max-results` is used for xlsx. This PR also fixes alert/subscription attachment limits; prior to this, they were set to the in-app limit of 2000 rows, but now they will follow the user supplied download-row-limit. This PR also adds a test to the downloads-and-exports test namespace, confirming that they follow the supplied limit, or the max limit if none is supplied. * add test confirming the default limit works * fix test to use the download-row-limit * address review feedback * Update src/metabase/public_settings.clj * add test covering case where download-row-limit is unset --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
github-automation-metabase authored
* Revert "Remove unused humanizeCoercionStrategy and its test suite (#36136)" This reverts commit 5375347e. * humanize coercion strategies, add e2e test * unit test adjustment * pr feedback Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
Alexander Solovyov authored
Also OpenAPI generation now handles parameter renaming, like in `{c :count}` destructuring.
-
github-automation-metabase authored
* Fix oom during sync field values (#46524) Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Aug 08, 2024
-
-
github-automation-metabase authored
* Last Used Param Value doesn't fill in with default value if cleared Fixes #46368 The Last used parameter value is cleared when the frontend sends `nil` as the parameter's value. This works except in cases where a user clears a parameter with a default value. In this case, we want to indicate that the parameter is cleared, so we store `nil` in the appdb in such a case. * Update src/metabase/query_processor/dashboard.clj * add assertion showing that 'nil' with default is still stored --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
github-automation-metabase authored
backported "fix(webapp/browse): Fix bug where verified filter is applied to recents even when no verified models exist" (#46559) This is a backport of three PRs: #46462, #46487, and #46571. The last of these corrects a broken e2e test introduced when the other two were combined -
github-automation-metabase authored
* Convert `AlertListPopoverContent` to TS (#46413) * Fix backport test, hopefully --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
* make series style settings tab first * spec Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
* e2e: add cypress-terminal-report * enable video recording * revert error * add a comment * Update e2e/support/cypress.js --------- Co-authored-by:
Uladzimir Havenchyk <uladzimir.dev@gmail.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
- Aug 07, 2024
-
-
github-automation-metabase authored
* bump loki tolerance * fix loki-update command * Update Loki Snapshots --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
github-automation-metabase authored
== Goal == Prevent admins of Metabase Cloud instances with Metabase Cloud Storage from accidentally breaking their upload configuration, since in this scenario that is automatically managed by Metabase Cloud to use the attached data warehouse. == How to test == On a subscription with Metabase Cloud Storage: * The "Uploads" section in the left sidebar of `/admin/settings` does not show * A "not found" page is shown at `/admin/settings/uploads` where one would otherwise expect the "Uploads Settings" page * `PUT /api/setting` with an `uploads-settings` field in the body fails with `403 Forbidden` and the setting is not changed * `PUT /api/setting/uploads-settings` fails with `403 Forbidden` and the setting is not changed * `GET /api/setting` contains an element with `key: "uploads-settings"` and a value * `GET /api/setting/uploads-settings` responds with the value * `GET /api/session/properties` contains the `uploads-settings` field Closes: https://github.com/metabase/harbormaster/issues/5121 Co-authored-by:
Dennis Schridde <63082+devurandom@users.noreply.github.com> Co-authored-by:
Ryan Laurie <iethree@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
github-automation-metabase authored
* Add unit test for #46574 * Handle non-numeric values in NumberFingerprint * Be more realistic about NumberFingerprintDisplayInfo type * Add comment on why the types are unknown Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
github-automation-metabase authored
Fixes #46440 couple things come together here. Bad escaping: The `{` characters are used for format strings and placeholders like ```clojure impl=> (translate "fr" "After {0}" ["Bob"]) "Après Bob" ``` And if you want _literal_ {'s in your translation string, you must escape them like "'{" or "'}" using an apostrophe. But this isn't the end of our worries. in `resources/zh-CN.edn`, we actually have _two_ translations for the original string: ```clojure "User lookup filter. The placeholder '{login'} will be replaced by the user supplied login." "用户找过滤器,占位符 '{login'} 将替换为用户提供的登录名。" ,,, "User lookup filter. The placeholder '{login}' will be replaced by the user supplied login." "用户查找筛选器。占位符“{login}”将替换为用户提供的登录名。" ``` And this later has unescaped curlies. The fix for that is at https://poeditor.com/projects/po_edit?per_page=20&id=200535&id_language=31&filter=&order=&search=User+lookup+filter but will need to wait for the new source translation string in this instance with the corrected escaping. ```clojure ;; simulate what happens at runtime impl=> (translated-format-string "zh_CN" "User lookup filter. The placeholder '{login}' will be replaced by the user supplied login." {}) "用户查找筛选器。占位符“{login}”将替换为用户提供的登录名。" impl=> (MessageFormat. *1 (locale "zh_CN")) Execution error (NumberFormatException) at java.lang.NumberFormatException/forInputString (NumberFormatException.java:67). For input string: "login" ;; the problematic zh-CN string impl=> (MessageFormat. "用户查找筛选器。占位符“{login}”将替换为用户提供的登录名。") Execution error (NumberFormatException) at java.lang.NumberFormatException/forInputString (NumberFormatException.java:67). For input string: "login" ;; minimal reproduction impl=> (MessageFormat. "“{login}”") Execution error (NumberFormatException) at java.lang.NumberFormatException/forInputString (NumberFormatException.java:67). For input string: "login" ``` Co-authored-by:
dpsutton <dan@dpsutton.com>
-
github-automation-metabase authored
Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com>
-
github-automation-metabase authored
== Goal == Currently the config file (`MB_CONFIG_FILE_PATH`) only allows adding or changing databases, but not removing them. Since connected databases can be managed as a service by us, it becomes necessary to delete any information Metabase has about them, including any stored credentials. Since this is a destructive operation with no way to revert (without restoring from a backup), we raise the bar for accidental deletion and require not just a (boolean) flag, but a magic string to be set. == How to test == 1. Configure a database as described in https://www.metabase.com/docs/latest/configuring-metabase/config-file#databases. 2. Start your Metabase instance. 3. Verify the database shows up in the "admin" section and it works. Create a dashboard and questions using the database. 4. Add a `delete: "DELETE_WITH_DEPENDENTS:${name}"` line to your database configuration section. 5. Restart your Metabase instance. 6. Verify the database no longer shows up in the "admin" section. Notice that questions using it are gone, too. References: https://github.com/metabase/harbormaster/issues/5173 Co-authored-by:
Dennis Schridde <63082+devurandom@users.noreply.github.com>
-
github-automation-metabase authored
dep is brought in by google cloud From `clj -X:deps tree :aliases '[:ee :drivers]'` ``` . metabase/bigquery-cloud-sdk metabase/modules/drivers/bigquery-cloud-sdk . com.google.cloud/google-cloud-bigquery 2.38.1 . com.google.cloud/google-cloud-core 2.35.0 [...] . javax.annotation/javax.annotation-api 1.3.2 ``` Before this change: ``` ❯ clj -X:deps tree :aliases '[:ee :drivers]' | grep 'javax.annotation/javax.annotation-api' . javax.annotation/javax.annotation-api 1.3.2 ``` After: ``` ❯ clj -X:deps tree :aliases '[:ee :drivers]' > deps-master ❯ echo $? 0 ``` Co-authored-by:
dpsutton <dan@dpsutton.com>
-
github-automation-metabase authored
Co-authored-by:
Chris Truter <chris@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
- Aug 06, 2024
-
-
github-automation-metabase authored
* allow edits to uers with empty name fields * add repro for 40750 * whoopsie Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* Add v0.49.22 to the list of releases * Update releases.md --------- Co-authored-by:
Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-