* Fix fallback long display name for Cards

* Test updates

* Fix #32920

* Remove stray println

* Make `:branches` realize during `:case` compilation

Previously `:branches` were generated with use of `for`,
yeilding lazy sequence. It caused problems, if the sequence
got realized after processing of query ie. without initialized
qp store. That was the case with /dataset/native api
call containing `:case` with `:now`.

* Update /dataset/native test

---------

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Reproduce #32963

* Don't lock display for models

* test custom column after aggregations

* skip repro

* Move dashboard bookmarks spec to `organization`

* Move dashboard filter related specs to appropriate group

* Create new `dashboard-cards` E2E group

* Fix for login history, the fix was written by Cam

* kondo

* Fix removing series from the legend
- Fixes #12794

* Use slice instead of filter

* Format code (-1 LOC)

* Refactor AddSeriesModal to TS

* Fix typing error

* Refactor state.state into state.isLoading
- remove leftover isLoadingMetadata

* Hide the "x" button for the first legend item in the chart in AddSeriesModal

* Fix typo

* Use named export for AddSeriesModal

* Fix dashcardData typing

* Export Props

* Add test boilerplate

* Reduce test setup boilerplate

* Reduce test setup boilerplate

* Add test for the 'x' button

* Add tests for removing series from legend

* Add comprehensive test case

* fix: cancel ongoing query when removing card from dashboard

* test: #12926 remove card test with xhr.abort stub

* test: use cy.on(fail instead, to specifically expect that request to be aborted

* Revert "test: use cy.on(fail instead, to specifically expect that request to be aborted"

This reverts commit 75e204e8e2c45cc490d79729ee12795ea10291fa.

* refactor: move cancelFetchCardData inside removeCardFromDashboard, which becomes a thunk

* doc jsdocs for should_wait param in visitDashboard

* "undo remove card" re-fetches the card

* test: test for undo -> re-fetch card

* refactor: removed unused param

* revert should_wait on visitDashboard in favor or manually using cy.visit

* artificially slow down requests via cy instead of using pg_sleep

* rename before block

* when undoing remove card, only refetch data if needed

* remove debug console log

* refactor: remove .within call with only one function call inside

* docs: add comment to req.continue

* test: adds assertion that the query data is actually loaded

* remove data already present check as it is already in the thunk

Introduced in #32598, even though it already exists.
https://github.com/metabase/metabase/blob/master/e2e/test/scenarios/embedding/embedding-smoketests.cy.spec.js#L317:L325

[ci skip]

* Add repro test

* Run MLv2 clean-up before running a query

* Clean redundant stages

* Fix test

* Use both clean ups

* Introduce backport reminder CI workflow

* Only trigger against `master`

* Re-trigger when author adds a label

* Disable PR bot reviews

* Keep the job name terse

* Fully hydrate PUT-ed collections, which the FE depends on

[Fixes #30235]

* Add repro test for #30235

* Set token features properly

---------

Co-authored-by: Denis Berezin <denis.berezin@metabase.com>

* QP: use Malli

* Fix schema names

* Fix missing namespaces

* Fix busted stuff

* Simplify the new schema

* Test fix 

* Test fixes 

* MongoDB fixes 

* FAST mu/defn

* Malli registry

* Misc fixes

* Some cleanup

* Misc cleanup and test fixes 

* mu/disable-enforcement

* Test fix

* Fix Cljs version of `disable-enforcement`

* Misc improvements

* Update tests

* Fix Kondo warnings

* Fix Kondo warnings

* Fix busted Malli schema

* PR feedback

* Fix busted schema

* Kondo fixx

* Test fixes 

* Use Malli version of `describe` now that PR was merged

* Work around https://github.com/metosin/malli/issues/924

* Test fixes 

* Improvements

* Test fix

based on https://github.com/orgs/community/discussions/26303 and my experience, workflows with `always()` will not cancel even if a new run of the same workflow appears with concurrency and cancel-in-progress:true. Official documentation suggests using `!cancelled()` instead

* [MLv2] Add function to sync join-condition temporal bucketing options

* Return the modified join-condition instead of the whole query

* Adding tests

* Fix linter

* Install Chrome immediately after checkout

* Switch to Chromium 111.0.5563.146

* Add actions dropdown to object detail modal (#32331)

* Rename showActions to showControls

* Use Flex

* Import Flex from local modules

* Make horizontalAttachments a prop in EntityMenu

* Use EntityMenu to create actions dropdown

* Render actions menu conditionally

* Add useActionListQuery

* Fetch actions in ObjectDetailHeader

* Remove unused canRunActions prop

* Move logic to root component

* Fix tests

* Use canRunAction and fetch databases in ObjectDetail view

* Rename actions to actionItems and getActions to getActionItems

* Extract getActionItems to utils

* Update tests

* Rename modelActions to actions

* Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems

* Consolidate getActionItems

* Use theme scale values for Mantine Flex component

* Either render all controls or none

* Fix default props/state in EntityMenu

* Fix props

* Update ObjectDetail unit tests

* Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction

* Update tests with more specific non-implicit action cases

* Use singular form to match function interface

* Add unit tests for getActionItems

* Update test case name

* Avoid using Database constructor
- Use metadata.database() instead

* Add integration tests for basic cases when action menu is rendered and not

* Fix post-merge error

* Endpoint to fetch implicit actions param values (#32466)

* Add default update action to actions dropdown in object detail modal (#32433)

* Rename showActions to showControls

* Use Flex

* Import Flex from local modules

* Make horizontalAttachments a prop in EntityMenu

* Use EntityMenu to create actions dropdown

* Render actions menu conditionally

* Add useActionListQuery

* Fetch actions in ObjectDetailHeader

* Remove unused canRunActions prop

* Move logic to root component

* Fix tests

* Use canRunAction and fetch databases in ObjectDetail view

* Rename actions to actionItems and getActions to getActionItems

* Extract getActionItems to utils

* Update tests

* Rename modelActions to actions

* Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems

* Consolidate getActionItems

* Use theme scale values for Mantine Flex component

* Either render all controls or none

* Fix default props/state in EntityMenu

* Fix props

* Update ObjectDetail unit tests

* Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction

* Update tests with more specific non-implicit action cases

* Use singular form to match function interface

* Add unit tests for getActionItems

* Update test case name

* Sort imports

* Rename initialValues to values

* Rename dashcardParamValues to initialValues

* Lift fetchInitialValues up from ActionParametersInputForm

* Rename refetchValues to prefetchValues

* Fix tests

* Refactor shouldPrefetch to be a prop

* Get rid of dashboard and dashcard props from ActionParametersInputForm

* Lift the canPrefetch condition up as it is not desired outside of dashboards

* Hook update action with temporary API

* Use executeActionId in fetchInitialValues

* Fix post-merge conflict

* Rename prefetchValues to prefetchDashcardValues

* Use the new endpoint

* Use rem values instead of scale values
- See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835

* Lift data reloading out of executeRowAction

* Add onSuccess prop to ActionExecuteModal

* Use onSubmitSuccess from ActionParametersInputForm

* Reload question after action is successful

* Fix stale prop issues in ActionParametersInputForm

* Fix object id in initialValues

* Add prefetchesInitialValues prop to make useActionForm more generic

* Ignore public actions for now

* Fix id mixup

* Update unit test

* Remove redundant memoization

* Use modern JS syntax instead of noop

* Move getNextId to __support__/utils

* Extract isImplicitDeleteAction & isImplicitUpdateAction

* Reuse isImplicitDeleteAction

* Log error to console

* Get rid of useLatest

* Fix post-merge build error

* Add a spinner to action modal when fetching values

* Use Flex instead of styled component

* Add default delete action to actions dropdown in object detail modal (#32556)

* Rename showActions to showControls

* Use Flex

* Import Flex from local modules

* Make horizontalAttachments a prop in EntityMenu

* Use EntityMenu to create actions dropdown

* Render actions menu conditionally

* Add useActionListQuery

* Fetch actions in ObjectDetailHeader

* Remove unused canRunActions prop

* Move logic to root component

* Fix tests

* Use canRunAction and fetch databases in ObjectDetail view

* Rename actions to actionItems and getActions to getActionItems

* Extract getActionItems to utils

* Update tests

* Rename modelActions to actions

* Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems

* Consolidate getActionItems

* Use theme scale values for Mantine Flex component

* Either render all controls or none

* Fix default props/state in EntityMenu

* Fix props

* Update ObjectDetail unit tests

* Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction

* Update tests with more specific non-implicit action cases

* Use singular form to match function interface

* Add unit tests for getActionItems

* Update test case name

* Sort imports

* Rename initialValues to values

* Rename dashcardParamValues to initialValues

* Lift fetchInitialValues up from ActionParametersInputForm

* Rename refetchValues to prefetchValues

* Fix tests

* Refactor shouldPrefetch to be a prop

* Get rid of dashboard and dashcard props from ActionParametersInputForm

* Lift the canPrefetch condition up as it is not desired outside of dashboards

* Hook update action with temporary API

* Use executeActionId in fetchInitialValues

* Fix post-merge conflict

* Rename prefetchValues to prefetchDashcardValues

* Use the new endpoint

* Use rem values instead of scale values
- See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835

* Lift data reloading out of executeRowAction

* Add onSuccess prop to ActionExecuteModal

* Use onSubmitSuccess from ActionParametersInputForm

* Reload question after action is successful

* Fix stale prop issues in ActionParametersInputForm

* Fix object id in initialValues

* Add prefetchesInitialValues prop to make useActionForm more generic

* Ignore public actions for now

* Fix id mixup

* Update unit test

* Add DeleteObjectModal

* Introduce useActionQuery

* Use useActionQuery in DeleteObjectModal

* Hook action execution

* Fix typo in copy

* Sort exports

* Remove redundant memoization

* Use modern JS syntax instead of noop

* Move getNextId to __support__/utils

* Extract isImplicitDeleteAction & isImplicitUpdateAction

* Reuse isImplicitDeleteAction

* Fix object modal getting closed with Escape key when delete or update modals are open

* Rename isUpdateModalOpen to isActionExecuteModalOpen, updateActionId to actionId

* Navigate to sibling row or close the modal on deletion

* Revert "Navigate to sibling row or close the modal on deletion"

This reverts commit 8b24685eee5cd968f53cc14b7194a66588fb5845.

* Close object detail on deletion

* Add error handling

* Add error handling

* Greatly simplify DeleteObjectModal
- remove useActionQuery usage
- remove useActionQuery
- remove DeleteObjectModal.styled.tsx

* Improve diff

* Shorten code

* Always cast objectId to number
- See https://metaboat.slack.com/archives/C057T1QTB3L/p1690292706101109?thread_ts=1690279562.697669&cid=C057T1QTB3L
  "the reason you’re not seeing it fail on the sample dataset is probably because you’re
  using h2 for sample-dataset. it’ll fail the same if you use a postgres one.
  h2 is probably more loose in type so it allows sending a string for id.
  nevertheless, I think you can use cast it to the correct type using the param type.
  I think we did that on the UI where we execute actions from model details page."

* Inline disabled into JSX

* Use a more friendly error message when failed to delete an object because it's referenced by other objects
- See: https://metaboat.slack.com/archives/C057LE0Q4PQ/p1690377421352469?thread_ts=1690208614.530869&cid=C057LE0Q4PQ

* Use useAsyncFn to avoid race conditions

* Add typing to NO_VALUES constant

* Remove redundant condition

* Introduce useActionQuery hook

* Get rid of HOCs in ActionExecuteModal using useActionQuery

* Do not crash app on unexpected events

* Refactor ActioExecuteModal to use named export

* WIP: Lift data fetching out ActionParametersInputForm
- Update ActionExecuteModal
- TODO:
  - update from dashboard does not work yet
  - other usages

* Revert "Use a more friendly error message when failed to delete an object because it's referenced by other objects"

This reverts commit 28327ac9b53ae92300e579d047b7f136d54e581e.

Friendly message is going to be implemented in https://github.com/metabase/metabase/issues/32694

* Rename initialValues back to dashcardParamValues in ActionVizForm

* Don't move ActionExecuteModal to keep nice diff

* Fix export

* Fix typing

* Handle empty state in ActionExecuteModal

* Move useActionInitialValues to hooks

* Tests for basic deletes and updates on object detail views (#32525)

* Rename showActions to showControls

* Use Flex

* Import Flex from local modules

* Make horizontalAttachments a prop in EntityMenu

* Use EntityMenu to create actions dropdown

* Render actions menu conditionally

* Add useActionListQuery

* Fetch actions in ObjectDetailHeader

* Remove unused canRunActions prop

* Move logic to root component

* Fix tests

* Use canRunAction and fetch databases in ObjectDetail view

* Rename actions to actionItems and getActions to getActionItems

* Extract getActionItems to utils

* Update tests

* Rename modelActions to actions

* Extract isValidImplicitDeleteAction and isValidImplicitUpdateAction out of getActionItems

* Consolidate getActionItems

* Use theme scale values for Mantine Flex component

* Either render all controls or none

* Fix default props/state in EntityMenu

* Fix props

* Update ObjectDetail unit tests

* Add unit tests for isValidImplicitDeleteAction and isValidImplicitUpdateAction

* Update tests with more specific non-implicit action cases

* Use singular form to match function interface

* Add unit tests for getActionItems

* Update test case name

* Sort imports

* Rename initialValues to values

* Rename dashcardParamValues to initialValues

* Lift fetchInitialValues up from ActionParametersInputForm

* Rename refetchValues to prefetchValues

* Fix tests

* Refactor shouldPrefetch to be a prop

* Get rid of dashboard and dashcard props from ActionParametersInputForm

* Lift the canPrefetch condition up as it is not desired outside of dashboards

* Hook update action with temporary API

* Use executeActionId in fetchInitialValues

* Fix post-merge conflict

* Rename prefetchValues to prefetchDashcardValues

* Use the new endpoint

* Use rem values instead of scale values
- See https://github.com/metabase/metabase/pull/32331#discussion_r1267827835



* Lift data reloading out of executeRowAction

* Add onSuccess prop to ActionExecuteModal

* Use onSubmitSuccess from ActionParametersInputForm

* Reload question after action is successful

* Fix stale prop issues in ActionParametersInputForm

* Fix object id in initialValues

* Add prefetchesInitialValues prop to make useActionForm more generic

* Add test cases for other types of actions

* Ignore public actions for now

* Add e2e test for actions in object detail view

* Add second step and extract helpers

* Remove duplication by changing hierarchy

* Add step with enabling model actions

* Fix visiting model page

* Remove redundant code

* Ignore public actions for now

* Fix id mixup

* Update unit test

* Add objectId argument and function to open the modal

* Define whole order object to reuse

* Implement assertOrderFormPrefilled

* Assert Created At

* Add assertion to check whether object with new id has been reloaded

* Use all caps for constants

* Verify updating an object

* Fix test name

* Assert toast is shown on update

* Format code

* Use writable tables instead of sample db to avoid persisting updates between tests
- do not mock objects, assert against whatever comes from API

* Format code to wake GitHub up

* Add DeleteObjectModal

* Introduce useActionQuery

* Use useActionQuery in DeleteObjectModal

* Hook action execution

* Fix typo in copy

* Sort exports

* Remove redundant memoization

* Use modern JS syntax instead of noop

* Move getNextId to __support__/utils

* Extract isImplicitDeleteAction & isImplicitUpdateAction

* Reuse isImplicitDeleteAction

* Fix object modal getting closed with Escape key when delete or update modals are open

* Rename isUpdateModalOpen to isActionExecuteModalOpen, updateActionId to actionId

* Navigate to sibling row or close the modal on deletion

* Revert "Navigate to sibling row or close the modal on deletion"

This reverts commit 8b24685eee5cd968f53cc14b7194a66588fb5845.

* Close object detail on deletion

* Add error handling

* Add error handling

* Greatly simplify DeleteObjectModal
- remove useActionQuery usage
- remove useActionQuery
- remove DeleteObjectModal.styled.tsx

* Improve diff

* Shorten code

* Rename initialValues back to dashcardParamValues in ActionVizForm

* Extract assertScoreUpdatedInTable

* Extract visitModelDetail

* Add deletion and toast assertion

* Remove unused arguments

* Assert delete failed

* Update tests order after starting with writable db

* Move assertions to beginning of the test, remove enableDatabaseActions

* Test disabling model actions

* Add extra assertion

* Update names

* Update the deletion assertion

* Remove unused code

* Wrap tests in another describe, setup dashboard test

* Fix setup, use asAdmin util

* Add assertion for dashboard object view

* Update test names

* Extract actions to a constant

* Add test to open update object modal

* Update assertion order

* Add test to open delete object modal

* Organize tests

* Add a test case for implicit public delete action & implicit archived delete action

* Remove redundant async

* Reuse findActionInActionMenu

* Remove redundant constant

* Fix tests

* Add a test case for databases with disabled actions

* Update wording

* Use dataset instad of a query question

* Revert name change as it does not make sense

* Format code

* Add a test case for users with no write permission

* Add a test case for when showControls is false

* Add a test case for models with clauses

* Use metadata.question() instead of new Question()

* Remove duplicated code

* Update ActionVizForm

* Improve success callback in ActionExecuteModal

* Remove commented out code

* Update test to account for the loading state

* Fix import and name

* Move test cases to ActionExecuteModal

* Extract Options interface

* Move the "Choose a record to update" empty state to ActionParametersInputModal (the only place where it's used)
- Remove hasPrefetchedValues

* Update test with missing prop

* Clean up ActionExecuteModal tests

* Add ActionVizForm test suite

* Rename Props back to ActionExecuteModalProps for consistency

* Tests for various number of PKs in a model (#32784)

* Add a test case for 0 PKs in a model

* Add a test case for 2 PKs in a model

* Improve test names

* Fix typo

* Use plural form for "PK"

* Fix header action not shown in empty state

* Bring back hasPrefetchedValues
- this is to avoid showing spinner when initial values have already been loaded (e.g. when automatically closing the ExecuteActionModal after successful update)

* Bring back hasPrefetchedValues logic and update tests

* ESLint

* Use checkNotNull

* Fix handling 0 as an id in initialValues in ObjectDetail

* Add assertion that the flicker that used to occur before this PR does not occur anymore

---------

Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>

* Add a repro

* Not hardcoding the question IDs

* Address review: Improve readability

* Add `ColorName` type to `metabase/lib/colors`

* Add `color` prop to `BucketPickerPopover`

* Add `color` prop `QueryColumnPicker`

* Fix `AggregationPicker`

* Fix `AggregateStep`

* Fix `BreakoutStep`

* Fix `SortStep`

* Fix bucket picker in `SummarizeSidebar`

* Avoid redundant `div`

* Reuse dashboard E2E util

* Add the repro

* Add UI assertion to avoid ambiguity

* dont hard code table ID in actions test

* simplify test

* break down and wait more, remove page loads

* Remove superfluous intercept and wait

* Make sure repaint happened

* Make sure virtualized table populates all rows

* Add grep tags

* Increase the request timeout

---------

Co-authored-by: Nemanja <31325167+nemanjaglumac@users.noreply.github.com>

* Add repro

* Correct new E2E helper behavior

The error message we show when Google SSO login fails had a bit of CSS issue. Fixed that with some flex box styling. (#32817)