This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 22, 2024
-
-
Nemanja Glumac authored
* Throw for `Snippets.api.delete` * Add boilerplate `snippet` RTK API * Add boilerplate RTK-compatibility layer for main `Snippets.api` endpoints * Add types * Add cache invalidation
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix not sending necessary HTTP headers when downloading results * Fix fail E2E tests * Add E2E test * Fix failed tests * Fix unit tests * Fix download on subpath * Fix unit tests for subpath
-
Nemanja Glumac authored
* Add RTK Query `revision` API * Re-wire `Revisions` entity `list` to work with RTK Query * Re-wire the `Revisions` entity `revert` to work with RTK Query
-
- Apr 19, 2024
-
-
Braden Shepherdson authored
These functions are implemented with hairy regular expressions, and it's more user-friendly and future-proof to name those functions in MBQL rather than baking the `regexextract` and regex into the user's query. It lets us evolve the regexes in the future if we detect a bug, and it improves the UX since the user sees a meaningful function instead of regexextract([My URL Column], "(?<=[@\.])(?!www\.)[^@\.]+(?=\.[^@\.]{1,3}\.[^@\.]+$|\.[^@\.]+$)") Also refactors the regexes somewhat so that they work for emails as well as URLs, and there's always just one layer of `:regex-match-first`. Previously this was separated into two steps: URL or email to host, and host to (sub)domain. Part of the follow-up for Extract Column epic #38964.
-
Uladzimir Havenchyk authored
* Reset mapping after change of operator for native questions * Add a basic test * Better name for a test
-
Kamil Mielnik authored
* Account for non-hydrated properties in GET /api/dashboard * Fix provideTags --------- Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Nicolò Pretto authored
-
Nemanja Glumac authored
* Delete unused endpoint from `PermissionsApi` * Add group tag helpers * Define RTK Query 5 main endpoints for `permissionApi` (group) * Re-wire 5 main api methods in groups entity to work with RTK Query * Re-wire `clearMember` action to work with RTK Query * Add `Groups.api.update` * Update types * Fix membership failing to update after `CREATE_MEMBERSHIP` * Make sure `members` is not undefined * Fix cache invalidation
-
Noah Moss authored
Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
Kamil Mielnik authored
* Fix Dispatch type * Fix typing * Fix types
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate --border-* * Migrate *breadcrumb* * Migrate --color-bg-black * Migrate --color-bg-dark * Migrate --color-bg-light * Migrate --color-bg-medium * Migrate --color-bg-white * Migrate --color-border * Migrate --color-brand* * Migrate --color-error * Migrate --color-focus * Migrate --color-shadow * Migrate --color-success * Migrate --color-text-dark * Migrate --color-text-light * Migrate --color-text-medium * Migrate --color-text-white * Migrate --color-white * Migrate --default-border-radius * Migrate --default-button-border-radius * Migrate --default-font-family * Migrate --default-font-size * Migrate --default-header-margin * Migrate --gap-1 * Migrate --icon-width * Migrate --input-border-color * Migrate --input-border-radius * Migrate --margin-* * Migrate --muted-color * Migrate --padding-* * Migrate --page-header-padding * Migrate --subtitle-color * Migrate --title-color * Reset to master * Remove unused --color-text-default * Remove unused --color* * Remove unused CSS custom properties * Prefix only necessary CSS custom properties
-
Uladzimir Havenchyk authored
-
- Apr 18, 2024
-
-
Nemanja Glumac authored
* Throw for unused Tasks endpoints * RTK Query `taskApi` * Wire tasks entity list and get endpoints to use RTK Query * Fix typo * Expose `taskApi` * Rework `TaskModal` to use RTK Query api * Throw on `Tasks.api.get` * Rework `TaskApp` to use RTK Query api * Delete `Tasks` entity ... which never should've been an entity in the first place. * Delete unused `TaskApi` entry * Fix next pagination page not being properly disabled * Do not export `isLastPage` function * Convert TasksApp to TS * Use Mantine Tooltip * Remove stray comment * Add empty lines for better legibility * Update the response type * Define `task_details` type more strictly * Use the existing `DatabaseId` type * Provide tags for `list` and `get` endpoints * Address code review * Handle error and loading in the `TasksApp` * Handle error and loading in the `TaskModal` * Extract the page size into a variable * Index databases without mutation * Refactor TaskModal
-
Ryan Laurie authored
-
Raphael Krut-Landau authored
-
Denis Berezin authored
* Fix parameters parse * Add e2e test * Add e2e test
-
Raphael Krut-Landau authored
* Put Schedule in two columns * Simplify timezone display * Support 24-hour format * Fix bugs
-
Ryan Laurie authored
* WIP questionpicker * use to replace dashcard content * much better stuff * question picker * values source card modal * create action form * awesome hacky fix for crashing model detail page * use entity picker in sandboxing modal * deprecate ye olde question picker * keep old question picker in add-card dashboard sidebar * better last level check * update types * make stuff better * fix rebase conflicts * better initial value handling * update e2e tests * sweet sweet unit tests * fix sandbox tests * fix tests * type fix * fixes * search style improvements * remove unused prop * safer path detection * delayed loading spinner * change confirm default * set default collection for placeholder card * address review comments * update unit tests * update e2e tests * fix re-rebase * add some happy little comments
-
Nemanja Glumac authored
* Add the pagination type * Add the pagination helper * Update types * Update `user` API * Update `collection` API * Update `search` API * Update `UserListQuery` type * Explicitly define default pagination inputs * Remove the pagination helper * Update and fix types `limit` and `offset` are actually nullable. * Separate types (again) * Fix `PaginationResponse` type
-
Phoomparin Mano authored
* external link cards should apply the correct target attribute * add unit tests for absolute and relative question links in link cards
-
Nicolò Pretto authored
* FeedbackModal for the Embedding Homepage * add source and change to correct endpoint * fix tests, adding await and fixing endpoint * use toEqual to also check for the source * addresses PR feedback * button becomes Send when email is written * make 'comments' optional, trim inputs and refactor tests * product-feedback endpoint (#40974) * mvp of the proxy endpoint for the product feedback * cleanup and fixes * email :string -> ms/NonBlankString * revert my solution * Dan diff file * makes fields other than source optional * don't use default value in dev, to not spam the prod endpoint * change from setting to function for product-feedback-url, as it's not meant to be changed by end users * changed endpoint as per https://metaboat.slack.com/archives/C010ZSXQY87/p1712918951362979?thread_ts=1704910781.153589&cid=C010ZSXQY87 * fix wrong dismiss reason sent for 'I'm not interested right now' * Update frontend/src/metabase/home/components/EmbedHomepage/EmbedHomepage.tsx Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * renamed field: feedback -> comment --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Mahatthana (Kelvin) Nomsawadi authored
-
- Apr 17, 2024
-
-
Kamil Mielnik authored
* Add provideDashboardListTags and provideDashboardTags * Keep the utils sorted alphabetically * Include collection tags in dashboard tags * Add getDashboard * Migrate basic CRUD dashboard endpoints to RTK * Migrate remaining dashboard endpoints to RTK * Fix save dashboard action * Remove unused favorite/unfavorite dashboard endpoints * Fix copy dashboard action * Move types to types file * Type dashboard API requests * Fix get * Fix typo * Pass body * Add a comment * Support noEvent option to fix a failing test
-
-
Noah Moss authored
Co-authored-by:
Noah Moss <noahbmoss@gmail.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Sloan Sparger <sloansparger@gmail.com>
-
Romeo Van Snick authored
-
Nicolò Pretto authored
-
Mahatthana (Kelvin) Nomsawadi authored
* Migrate .floatLeft, .floatRight * Remove unused components
-
Mahatthana (Kelvin) Nomsawadi authored
-
Nicolò Pretto authored
-
Oisin Coveney authored
-
- Apr 16, 2024
-
-
Denis Berezin authored
* Fix table styles calculation * Review fixes * Fix unit tests
-
Nemanja Glumac authored
* Define the types for the `create` user request * First draft for the create user API using RTK Query * Export RTK user API * Define explicit `create` api for the user entity * Define `updatePassword` mutation * Wire users entity `resetPasswordManual` to use RTK under the hood * Use `updatePassword` mutation * Wire users list calls * Remove unused `update_password` from services * Fix the dispatch used to list users * Dispatch the action type and the payload * Wire `deactivateUser` to work with RTK * Wire `reactivateUser` to work with RTK * Delete unused entries from `UserApi` * Convert the reducer to use `switch` statement * Remove unused user `send_invite` endpoint from FE * Wire `resetPasswordEmail` in users entity to work with RTK * Provide cache invalidation for the `userApi` * Add `provideUserListTags` helper * Pass `email` as a sole argument * Throw on `get` a user This endpoint hasn't been used in a long itme. Removed in https://github.com/metabase/metabase/pull/41334/files#diff-241e0afa11f03a0942eb322aa47695e58496379b0b6d42e6e59ecf6a20fe623cL448 * Use RTK Query to `updateUser` * Fix wrong syntax * Use RTK Query to `getUser` It was used by `.load` and `fetch` after all. * Export `useUpdateUserMutation` * Refactor `getRecipientsList` * Fix response type for the `getUser` * Pass user id as a sole argument instead of in an object * Fix users entity `get` method * Fix the user update password form * Fix unit tests * Fix deactivate and reactivate query invocations See e949812. * Adjust types according to the feedback * Order utils alphabetically * Throw on `delete` * Revert "Fix unit tests" This reverts commit 2c329e836427010ad08bfd0511eb1a9df4ba95d6. * Fix FE unit test mocks * Rename imports to use plural for consistency * Fix one last remaining FE unit test
-
Nemanja Glumac authored
-
Romeo Van Snick authored
* Add list of most popular functions and aggregations * Render 'All functions' link on expression dropdown * Suggest popular functions when no input is given * Do not return focus to search bar * Default to not matching any substring * Open suggestions when the expression editor opens * Group expressions by group * Render group titles in dropdown * Match the expression suggestions height to the design * Add tests for popular functions * Convert tests to it-style * Only return supported popular functions * Limit most used functions group to 5 items * Make the suggestion footer keyboard-accessible * Make a different group for popular aggregations * Remove padding on suggestion list * Resize list * Add test for popular functions in suggest * Move showMetabaseLinks into args * Remove unneeded optional chain * Clarify popup issue in ACE hack * Use correct target for links * Reference correct method in comment * Split up popular expressions * Remove Set around popular functions/aggregations * Do not allow interacting with suggestion header * Do not use _ prefix for variable * Add verb in test * Remove unused async in test * Test if functions are in document * Move tests for suggestWithFooter to separate file * Use correct target in link * Fix typo in key * Allow picking suggestion when textbox is empty * Remove unnecessary cast * Avoid double scroll bars * Only show link to all functions when editor is empty * Split up popular functions between expressions and filters * Fix type of popular variable * Use the same heuristic for footer as for popular expressions * Close suggestions when the editor is not focused * Add missing open prop in test * Simplify test * Add selector for expression editor widget * Fix e2e tests Fix e2e tests * Avoid non-interactive clicks from closing the dropdown * Use custom expression helpers in broken test * Fix test * Remove should exist check for selector
-
Oisin Coveney authored
-
Nicolò Pretto authored
-
Oisin Coveney authored
-
- Apr 15, 2024
-
-
Braden Shepherdson authored
The drill-thru is mostly a stub to put an entry in the context menu. Most of the logic for this is built on the FE using the existing functions for consuming and creating expressions. See [thread](https://metaboat.slack.com/archives/C06P22KS4JH/p1712264174056569) for a lot more context. This also adds `docs/developer-guide/mbql-library-changelog.md` and documents adding this function to the library as the first change in the API. I'll follow up in another PR with Github automation to expect the changelog to be updated whenever `src/metabase/lib/js.cljs` changes. Fixes #39978.
-
Jesse Devaney authored
* fix progress bar in query builder * add spec to verify regression fix
-