This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Apr 26, 2022
-
-
Maz Ameli authored
-
Alexander Lesnenko authored
* show when users don't have access to foreign table fields data model * change copy
-
Alexander Lesnenko authored
-
Nemanja Glumac authored
-
Michael Connell authored
* Update dashboard link in README This PR updates the dashboard link in the README from `answers` to `dashboards` * more www Co-authored-by:
Jeff Bruemmer <jeffbruemmer@gmail.com>
-
Cam Saul authored
-
dpsutton authored
Fixes #19860 SNAPSHOT tables in bigquery hold diffs from an underlying table: https://cloud.google.com/bigquery/docs/table-snapshots-intro. But the support in the sdk only came in 1.135.0 : https://github.com/googleapis/java-bigquery/blob/main/CHANGELOG.md#11350-2021-06-28 I picked the most recent 1.135 version. Running ```shell clj -A:dev:ee:ee-dev:drivers:drivers-dev -Stree ``` Shows conflicts on ``` X google-http-client-jackson2 1.39.2 :older-version ; using 1.39.2-sp.1 from google analytics X com.fasterxml.jackson.core/jackson-core 2.12.3 :older-version ; from cheshire we have 2.12.4 X com.google.http-client/google-http-client 1.39.2 :superseded ; using 1.39.2-sp.1 from google-http-client-jackson2 (1.39.2-sp1) X commons-codec/commons-codec 1.15 :use-top ; pinned to this version at top level X com.google.guava/guava 30.1.1-android :use-top ; pinned to 31.0.1-jre top level ``` So I think this change is quite safe. After the release we should investigate the breaking changes that come in the 2.0.0 release and look into getting onto 2.10.10. This version worked locally for me but I don't want to introduce that into the release just yet.
-
Nick Fitzpatrick authored
* Remove right click option when unable to write to collections * Permissions for snippets root requires :namespace key on the collection * pr feedback Co-authored-by:
Case Nelson <case@metabase.com>
-
Nick Fitzpatrick authored
* Only allow bulk invalidation when there are things to invalidate * Updating test * human readable weird logic * Update frontend/test/metabase/scenarios/question/reproductions/17910-revision-history-update.js Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
Maz Ameli authored
* build pot file * update translations for 0.43
-
Ryan Laurie authored
-
Ariya Hidayat authored
-
Alexander Lesnenko authored
* hide custom mapping for users with no permissions * remove log
-
Ariya Hidayat authored
-
Alexander Lesnenko authored
-
Alexander Polyankin authored
-
dpsutton authored
``` ❯ clj-kondo --lint src:shared/src src/metabase/api/common/validation.clj:2:33: warning: Inconsistent alias. Expected str instead of string. src/metabase/api/database.clj:664:5: warning: Redundant let expression. src/metabase/api/table.clj:18:45: warning: Inconsistent alias. Expected field-values instead of sync.field-values. src/metabase/cmd.clj:123:5: warning: unused binding docs src/metabase/db/data_migrations.clj:15:52: warning: Inconsistent alias. Expected perms-group instead of group. src/metabase/db/data_migrations.clj:55:15: warning: #'metabase.db.data-migrations/data-migrations is deprecated src/metabase/db/data_migrations.clj:62:24: warning: #'metabase.db.data-migrations/data-migrations is deprecated src/metabase/db/data_migrations.clj:63:7: warning: #'metabase.db.data-migrations/run-migration-if-needed! is deprecated src/metabase/db/data_migrations.clj:154:1: warning: #'metabase.db.data-migrations/defmigration is deprecated src/metabase/db/data_migrations.clj:201:1: warning: #'metabase.db.data-migrations/defmigration is deprecated src/metabase/db/setup.clj:59:5: warning: Missing catch or finally in try src/metabase/driver/postgres.clj:18:63: warning: Inconsistent alias. Expected sql-jdbc.describe-table instead of sql-jdbc.sync.describe-table. src/metabase/driver/postgres.clj:304:9: warning: unused binding nfc-path src/metabase/driver/postgres.clj:323:60: warning: unused binding fields-fields src/metabase/driver/sql_jdbc/sync/describe_table.clj:253:39: error: Expected: set or nil, received: seq. src/metabase/driver/sql_jdbc/sync/describe_table.clj:254:39: error: Expected: set or nil, received: seq. src/metabase/driver/sql_jdbc/sync/describe_table.clj:333:11: warning: unused binding map-inner src/metabase/models/secret.clj:248:23: warning: use :else as the catch-all test expression in cond src/metabase/pulse/render/body.clj:216:64: warning: unused binding cols src/metabase/task/refresh_slack_channel_user_cache.clj:52:25: error: clojurewerkz.quartzite.schedule.simple/with-interval-in-seconds is called with 1 arg but expects 2 linting took 5988ms, errors: 3, warnings: 17 ``` ``` ❯ clj-kondo --lint src:shared/src src/metabase/task/refresh_slack_channel_user_cache.clj:52:25: error: clojurewerkz.quartzite.schedule.simple/with-interval-in-seconds is called with 1 arg but expects 2 linting took 5270ms, errors: 1, warnings: 0 ``` Want to call out a few things: The following all related to the new paths into json feature. Wanted howon to verify that nothing got dropped with these unused bindings. ``` src/metabase/driver/postgres.clj:304:9: warning: unused binding nfc-path src/metabase/driver/postgres.clj:323:60: warning: unused binding fields-fields src/metabase/driver/sql_jdbc/sync/describe_table.clj:253:39: error: Expected: set or nil, received: seq. src/metabase/driver/sql_jdbc/sync/describe_table.clj:254:39: error: Expected: set or nil, received: seq. src/metabase/driver/sql_jdbc/sync/describe_table.clj:333:11: warning: unused binding map-inner ```
-
Bryan Maass authored
* explain what is going on during encryption key rotation * better argument error handling for commands
-
Jeff Bruemmer authored
-
Alexander Kiselev authored
* fix dashboard serialization+deserialization * remove dashboard shortcuts back button * update datetime filter serialization code for starting from/exclude * remove disable startingFrom/Exclude props * fix unit tests * fix unit tests
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Anton Kulyk authored
* Don't turn read-only queries into ad-hoc ones * Allow reordering table columns for no-data users * Handle URL change on viz changes for no-data users * Don't show "rerun overlay" for no-data users * Don't show "rerun overlay" for no-data users * Don't show "Save" button on read only questions * Allow changing viz settings locally for no-data * Add e2e tests * Fix no-data user can't use parameters * Remove #9772 repro * Fix "Save" button * Fix read-only column resizing test * Fix #18433
-
Nick Fitzpatrick authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
Anton Kulyk authored
* Add test * Reload FKs when browsing objects
-
Alexander Lesnenko authored
-
Mahatthana (Kelvin) Nomsawadi authored
-
metamben authored
Deserialize dashboard Starting From/Exclude datetime filters
-
Alexander Lesnenko authored
* return download results button to publicly shared questions * remove waiting for cardQuery
-
Alexander Lesnenko authored
-
- Apr 25, 2022
-
-
Howon Lee authored
Parsed JSON columns should turn into detail-view only if (and only if) they are initially synced for table: already visible JSON columns shouldn't magically go away because people don't like already visible stuff just magically going away.
-
Nick Fitzpatrick authored
-
Bryan Maass authored
- if a keyword has namespace, send json encoded string: "ns/key" otherwise "key"
-
Ryan Laurie authored
* show empty state for empty login history
-
Ryan Laurie authored
* fix infinite-loading dashboard on 403
-
Ryan Laurie authored
-
Alexander Lesnenko authored
-
Ariya Hidayat authored
-