Commits · eb6b3356dfe0e68d21f2510035e732219cda65b1 · Engineering Digital Service / Metabase

This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated 33 seconds ago.

Nov 19, 2024

refactor(sdk): use ignore flag instead of mounted ref (#50069) (#50149) · eb6b3356

github-automation-metabase authored 4 months ago


* Revert "fix(sdk): put a bandage on the flashing error on static question in strict mode (#49659)"

This reverts commit c57b3a38.

* refactor(sdk): use ignore flag instead of mounted ref

Co-authored-by: Nicolò Pretto <info@npretto.com>

Unverified

eb6b3356

Nov 07, 2024
- fix(sdk): put a bandage on the flashing error on static question in strict mode (#49659) (#49704) · 9a949510
  github-automation-metabase authored 4 months ago
  
  Co-authored-by: Nicolò Pretto <info@npretto.com>
  Unverified
  
  9a949510
Oct 25, 2024

fix(sdk): static question should cancel requests on component unmount (#48808) (#49138) · b7651d7e

github-automation-metabase authored 5 months ago


* cancel request on unmount in static question

* use deferred promise

* remove logs

* alias cancelled to deferred.promise

* extract useLoadStaticQuestion hook

* add tests for request cancellation

* change updateQuestion method

* add sanity check with fetchMock

Co-authored-by: Phoomparin Mano <poom@metabase.com>

Unverified

b7651d7e