Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Oct 25, 2024
    • Chris Truter's avatar
      Consistent error handling for both NQA interfaces (#49023) · f022ed81
      Chris Truter authored
      This standards on a "just maps" approach to returning disabled, disallowed, or failed query analysis. This is as opposed to the hodgepodge approach of significant `nil`, untagged unions with keywords, and exceptions.
      
      Essentially we have a classic "either" style tagged union, where `:error` is the tag.
      Unverified
      f022ed81
  2. Oct 24, 2024
  3. Oct 23, 2024
    • Chris Truter's avatar
      Analyze native tables more conservatively by default (#48990) · f9e6dfc6
      Chris Truter authored
      ### Description
      
      This is a low level step towards applying table-level permissions to native queries.
      
      It replaces the more generic and powerful `:ast-walker-1` analyzer with the more conservative `:basic-select` version we recently landed. The advantage of this version is that it protects against dynamic table references and false negatives due to masking.
      Unverified
      f9e6dfc6
  4. Oct 16, 2024
  5. Aug 22, 2024
  6. Aug 21, 2024
  7. Aug 05, 2024
    • Chris Truter's avatar
      Various hardenings for SQL analysis (#46432) · 39bb33ec
      Chris Truter authored
      ### Description
      
      This change should fix some explosions in stats due to phantom fields, while also making things a bit more rigorous.
      
      - Record the table schema in query_field - especially useful for unknown tables
      - Allow null table names in query_field - they might be phantoms, or they might not
        - We still have the option to filter them out in tools we build on top
      - Tighten up matching logic to consider schema
      Unverified
      39bb33ec
  8. Aug 01, 2024
  9. Jul 29, 2024
  10. Jul 15, 2024
Loading