Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Dec 29, 2022
  2. Dec 28, 2022
  3. Dec 26, 2022
  4. Dec 23, 2022
  5. Dec 22, 2022
  6. Dec 21, 2022
    • adam-james's avatar
      Fixes to static-viz datetime formatter, in particular, issues #27020 and #27105 (#27339) · 05e0cc1b
      adam-james authored
      * Handle abbreviation and date-separator in a fn, where defaults are passed in in any place where nil COULD exist
      
      Moving abbreviation and date-separator string changes into a post-processing fn allows each unit case to handle the
      date-style default formatting, and eliminates the problem of date-style being `nil` in the let statement. It was this
      scenario where `abbreviate` was `true`, but `date-style` was `nil`.
      
      In many cases, if `date-style` is nil, then so is `abbreviate` and `date-separator`, in fact, the default from the
      frontend sends nil for all of these keys. In such a case, none of the branches run and nil is safely passed
      through. It is then handled appropriately with `(or ...)` expressions in each entry for the case statement.
      
      But, it is indeed possible to have a nil `date-style` with non-nil `abbreviate` or `date-separator` keys. Now, the
      post-process-date-style function is only ever called AFTER the default date-style is set in whatever case branch is needed.
      
      * Turn frontend day format 'dddd' into backend format 'EEEE'
      
      The frontend sends a datetime format string to the backend and some elements are not equivalent to the expectations
      the java datetime formatter has.
      
      * Unskip e2e reproductions
      
      * Add a test for all 'written date' combos
      
      * These tests fail b/c I fixed the 'default' from Abbreviated to non-abbreviated
      
      * Add test 'matrix' for numerically formatted dates, and each separator
      
      * Finally, add tests to confirm that custom-formatting is applied
      Unverified
      05e0cc1b
  7. Dec 20, 2022
  8. Dec 19, 2022
  9. Dec 16, 2022
  10. Dec 15, 2022
  11. Dec 14, 2022
    • Noah Moss's avatar
      BE endpoint to clear group memberships (#26555) · 7828c1e6
      Noah Moss authored
      * BE endpoint to clear group membership
      
      * update ee group manager tests with clear-memberships
      Unverified
      7828c1e6
    • Noah Moss's avatar
      Hide auth config pages from setting managers (#27187) · 90320851
      Noah Moss authored
      * make auth settings adminOnly on FE
      
      * WIP backend changes
      
      * Update relevant settings
      
      * address lint warning
      
      * new tests, and a bunch of reorganization
      
      * remove broken EE settings test, and fix validation in google & ldap endpoints
      
      * fix cypress tests
      
      * add clarifying table to setting docs
      Unverified
      90320851
    • dpsutton's avatar
      Relieve db pressure on api/health check (#27192) · 0975f5d9
      dpsutton authored
      * Relieve db pressure on api/health check
      
      https://github.com/metabase/metabase/issues/26266
      
      Servers under heavy load can be slow to respond to the api/health
      check. This can lead to k8s killing healthy instances happily humming
      along serving requests.
      
      One idea floated was to use QoSFilters
      https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/servlets/QoSFilter.html
      to prioritize those requests in front of others. But I suspect this
      might not be our bottleneck.
      
      Our health endpoint was updated to see if it could acquire an endpoint
      when we were dealing with connection pool issues. We were reporting the
      instance was healthy once it has finished the init process, but would
      report healthy if 60/15 app-db connections were used and no actual
      queries could complete.
      
      The remedy was adding
      `(sql-jdbc.conn/can-connect-with-spec? {:datasource (mdb.connection/data-source)})`
      to the endpoint. But now to get information about the health of the
      system we have to wait in the queue to get a datasource.
      
      The hope is that this change which monitors for recent db
      checkins (query success) and checkouts (query begun) can be a proxy for
      db activity without having to wait for a connection and hit the db ourselves.
      
      Some simple and crude benchmarking:
      - use `siege` to hit `api/database/<app-db>/sync_schema`
      - in a separate tab, use `siege` to hit `api/health`
      
      Three trials with unconditional db access and conditional db
      access (look for recent activity set by the new `ConnectionCustomizer`).
      
      One siege client is synching the app-db's schema with 80 clients each
      sending 60 requests. the other has 1 client sending 60 requests to api/health.
      
      Run             |  Elapsed Time | max tx  | tx rate
       before change  |    7.16s      |  0.79s  |  8.38 tx/s
       before change  |   23.91s      |  1.44s  |  2.51 tx/s
       before change  |   13.00s      |  0.50s  |  4.62 tx/s
      ----------------------------------------------------
       after change   |    4.46s      |  0.27s  |  13.45 tx/s
       after change   |    5.81s      |  0.61s  |  10.33 tx/s
       after change   |    4.54s      |  0.44s  |  13.22 tx/s
      
      Full(er) results below:
      
      ```
      Unconditional db access
      =======================
      
      siege -c80 -r 40 "http://localhost:3000/api/database/2/sync_schema POST" -H "Cookie: $SESSION"
      
      siege -c 1 -r 60 "http://localhost:3000/api/health"
      
      Elapsed time:		        7.16 secs
      Response time:		        0.12 secs
      Transaction rate:	        8.38 trans/sec
      Longest transaction:	        0.79
      Shortest transaction:	        0.01
      
      Elapsed time:		       23.91 secs
      Response time:		        0.40 secs
      Transaction rate:	        2.51 trans/sec
      Longest transaction:	        1.44
      Shortest transaction:	        0.02
      
      Elapsed time:		       13.00 secs
      Response time:		        0.22 secs
      Transaction rate:	        4.62 trans/sec
      Longest transaction:	        0.50
      Shortest transaction:	        0.06
      
      Conditional db access
      ==============================================================
      
      Elapsed time:		        4.46 secs
      Response time:		        0.07 secs
      Transaction rate:	       13.45 trans/sec
      Longest transaction:	        0.27
      Shortest transaction:	        0.01
      
      Elapsed time:		        5.81 secs
      Response time:		        0.10 secs
      Transaction rate:	       10.33 trans/sec
      Longest transaction:	        0.61
      Shortest transaction:	        0.00
      
      Elapsed time:		        4.54 secs
      Response time:		        0.08 secs
      Transaction rate:	       13.22 trans/sec
      Longest transaction:	        0.44
      Shortest transaction:	        0.01
      ```
      
      * Remove reflection in `.put` call (not the reflections trategy)
      
      also remove the call to `classloader/the-classloader` as it did nothing
      
      * Comment and settle on a single method
      
      * tests
      
      * select from db twice
      
      had a failure in CI. give it time to do its thing with another db call
      
      * block to wait for timestamp update?
      
      * unflake the tests
      
      tasks and events from outside the thread can hit the db. the
      ConnectionCustomizer is also run from c3p0 controlled threads so we
      can't easily isolate everything to our thread
      
      Was running
      
      ```clojure
      (comment
        (dotimes [n 5]
          (dotimes [_ 100]
            (recent-activity-test)
            (CheckinTracker-test))
          (println (* (inc n) 100)))
          )
      ```
      
      to run the tests 500 times and would keep getting flakes at a rate
      ~1/100 to 1/500. Just frustration for the future.
      
      * typehint
      
      * Switch it up a bit
      
      Tests were flaking in h2 and I don't know why. I'm switching to just
      updating recent activity on most methods.
      Unverified
      0975f5d9
    • Cal Herries's avatar
      Improve datetimeDiff type error message (#27225) · 8e385d49
      Cal Herries authored
      * Update test
      
      * Update implementations
      Unverified
      8e385d49
  12. Dec 13, 2022
  13. Dec 12, 2022
  14. Dec 09, 2022
  15. Dec 08, 2022
    • Cam Saul's avatar
      Add import and export (SerDes v2) commands (#26984) · 3d5ddd9c
      Cam Saul authored
      * Add import and export (SerDes v2) commands
      
      * Allow use of deprecated dump/load in EE tests
      Unverified
      3d5ddd9c
    • metamben's avatar
      Store DBMS version in Database (#26983) · f4901387
      metamben authored
      * Store DBMS version in Database
      * Add DBMS version to anonymous stats
      * Add dbms_version sync tests
      * Add test for DBMS versions in anonymous stats
      Unverified
      f4901387
    • Bryan Maass's avatar
      only query for db-metadata once per sync operation + scan each table for its PKs (#26810) · d3a98472
      Bryan Maass authored
      * memoize snowflake describe-database w/ 5 min ttl
      
      * pass in db-metadata where it is used,
      
      - rather than querying for it in random functions
      
      * update callsite of sync-tables-and-database!
      
      * let sync-metabase-metadata! look up db-metadata
      
      - only when needed
      
      * pass catalog (db), and schema to .getPrimaryKeys
      
      * let describe-table* add in the nil table-name
      
      * cleanup
      
      * use :snowflake instead of driver for inheritance
      
      * concurrent-sync-test should call describe-database once
      
      * cleaning up
      
      * call add-table-pks with 3 args
      
      * call add-table-pks with 3 args
      
      * try escaping entity names to appease Oracle Driver
      
      - Oracle wants the table-name to be escaped
      - escape is usually a no-op
      
      * pass driver to escape entity
      
      * pull get-table-pks into a multimethod,
      
      - handle the discrepancy directly in Oracle driver
      
      * remove inline def
      
      * fix colliding consistent-namespace linting
      
      - metabase.driver.sql-jdbc.common and
        metabase.driver.sql-jdbc.sync.common were
        mapped to sql-jdbc.common
      - metabase.driver.sql-jdbc.sync.common is now
        mapped to sql-jdbc.sync.common
      
      * fix reflection warnings
      
      * apply fix for getting oracle pks
      
      * nix an unused arg
      Unverified
      d3a98472
    • metamben's avatar
      Fingerprint bigquery by previewing tables (#26962) · 1c588b60
      metamben authored
      * Fingerprint bigquery by previewing tables
      * Address review comments
      Unverified
      1c588b60
Loading