This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 17, 2022
-
-
Alexander Polyankin authored
-
Howon Lee authored
Trivial trends previously broke. Now they default to basically the ordinary single value viz.
-
- Jan 14, 2022
-
-
dpsutton authored
Our email tests can be a bit brittle. Sometimes we assert the first email in the email inbox is some password reset email, but a race makes it such that its a "logged in from new ip" email. Othertimes, we might assert that there are only emails to a particular user but maybe another test might have triggered an email to another user. We often might just want two predicates: did the user receive an email with this subject, or did the user receive an email with this body. This simply adds those. It should be safe from races as it can handle emails to multiple users and multiple emails to the same user.
-
Alexander Kiselev authored
-
adam-james authored
* Comparison for goals depends on alert_above_goal and if progressbar. This commit sets up the timeseries predicate and writes tests for what I think the correct behaviours should be: timeseries, alert above -> (<= goal-value value) - (<= 5.9 6) true -> alert sent - (<= 6 6) true -> alert sent - (<= 6.1 6) false -> alert not sent progressbar, alert above -> (<= goal-value value) - (<= 5.9 6) true -> alert sent - (<= 6 6) true -> alert sent - (<= 6.1 6) false -> alert not sent timeseries, alert below -> (>= goal-value value) - (>= 6.1 6) true -> alert sent - (>= 6 6) true -> alert sent. NOTE: this is to match prior behaviour, but I don't understand why it is this way? - (>= 5.9 6) faluse -> alert not sent progressbar, alert below -> (> goal-value value) - (> 6.1 6) true -> alert sent - (> 6 6) false -> alert not sent. NOTE: this is what should fix the bug (#10899) - (> 5.9 6) faluse -> alert not sent I think there may be a cleaner way to write and present the tests, so the next commit(s) will address that. * Simplified Tests for goal-met? predicate. The goal-met predicate is tested directly with mock data to make the tests more readable. The change to `metabase.pulse/goal-met?` fixes #10899 while preserving the goal-met behaviour for any non-progress goal. The behaviour should now be as follows: ``` | Timeseries? | alert_above? | goal | val | goal-met? | +-------------+--------------+------+-----+-----------+ | f | t | 5 | 4 | f | | f | t | 5 | 5 | t | | f | t | 5 | 6 | t | | f | f | 5 | 4 | t | | f | f | 5 | 5 | f | <--- this is new behaviour | f | f | 5 | 6 | f | | t | t | 5 | 4 | f | | t | t | 5 | 5 | t | | t | t | 5 | 6 | t | | t | f | 5 | 4 | t | | t | f | 5 | 5 | t | | t | f | 5 | 6 | f | ``` Otherwise, alerts should be triggered as before. * added issue number to test * fixed alignment issue * swapped goal and value around in comparison for readability * Fixing nits * Timeseries and progress bar now follow same logic I asked for clarification about when alerts fire in #ama-product in Metabase's Slack. There was consensus around the idea that 'reaches the goal' does generally imply 'meets the goal', so we can use the same comparators between progress bar and timeseries goals now. This simplifies the goal-met? function again because it's no longer necessary to check if the given data is a timeseries goal. * Adjusted text in goal line alert modal * ran prettier
-
Nemanja Glumac authored
* Fix duplicate model tooltip * Fix archive model title * Fix edit model modal title * Fix model verification title * Fix add model to dashboard title * Fix failing unit test * Update model's archive message
-
Luis Paolini authored
* Separate builder from tester * indentation error * Final testing [ci nocache] * [ci nocache]
-
Jeff Bruemmer authored
-
Jeff Evans authored
Move bulk of dataset-id normalization logic into new private helper fn Perform app DB update for db-details after dataset-id has been turned into inclusion filter Add test to confirm that normalization only happens once
-
Alexander Polyankin authored
-
Nemanja Glumac authored
* Update SVG model illustration * Update dataset -> model icons and their references * Update icon names in collections
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-
Noah Moss authored
-
Nemanja Glumac authored
* Fix flaking repro for 11439 * Fix linter
-
Noah Moss authored
-
Alexander Lesnenko authored
This reverts commit 5fdeed90.
-
Noah Moss authored
-
- Jan 13, 2022
-
-
Nemanja Glumac authored
* Turn this into a ~~dataset~~ model * Model revision history copy updates * Datasets -> Models copy update * "Dataset management -> Model management" copy update * This is a ~~dataset~~ model now * Models in data picker copy changes * Models in search app copy changes * Update models copy in tests * Update frontend/src/metabase/lib/revisions/revisions.unit.spec.js Co-authored-by:
Maz Ameli <maz@metabase.com> * Update frontend/src/metabase/lib/revisions/revisions.js Co-authored-by:
Maz Ameli <maz@metabase.com> * Fix and update e2e tests Co-authored-by:
Maz Ameli <maz@metabase.com>
-
Gustavo Saiani authored
-
Alexander Lesnenko authored
* clean up old static charts * specs
-
Nemanja Glumac authored
* Extract models into a separate e2e group * Split models tests into smaller logical units * Keep `getCollectionItemRow` helper scoped to a single file * Keep `testDataPickerSearch` helper scoped to a single file * Update the name from `datasets` to `models`
-
Ariya Hidayat authored
-
Gustavo Saiani authored
-
Jeff Bruemmer authored
-
Alexander Polyankin authored
-
Luis Paolini authored
We have to build and publish EE, otherwise some features can't be tested
-
Alexander Lesnenko authored
* add waterfall static viz e2e specs * fix createQuestionAndAddToDashboard command * formatting
-
Alexander Polyankin authored
-
Cam Saul authored
-
dpsutton authored
* Don't update tables in a schema one by one Code had wanted to log each table which is admirable. But on bigquery there can be 15,000 tables and this will lock up calls to /api/database. On stats they are taking about 18s for me. Need to do once and let the db do the heavy lifting * Also where schema is nil * slightly better query
-
- Jan 12, 2022
-
-
Ariya Hidayat authored
When the text representation gets reformatted, the old caret position might not be sensible anymore. Hence, just push the caret to the end. * Add e2e test for caret position after blur and refocus Co-authored-by:
Gustavo Saiani <gustavo@poe.ma>
-
dpsutton authored
-
Chris Wu authored
* Add Pulse URL param to email settings * Undo frontend changes -- make config only allowable by env var * Make config enterprise only * Address feedback * Change namespace and token feature * newline * Rename var and add docs
-
Dalton authored
* Cache dashboard parameter values * move some logic to utils files * Fix e2e tests * add comment + const to clarify getParameterValuesSearchKey
-
frannietrempe authored
-
Jeff Evans authored
Add functions to describe-database namespace for performing inclusive/exclusive schema filtering Add tests for these functions in isolation Update `:bigquery-cloud-sdk` driver and QP code to remove the single `dataset-id` conn-param Changing :bigquery-cloud-sdk` driver to use dataset inclusion/exclusion filters instead Updating `add.cy.spec.js` Cypress test to account for new structure Add data upgrade (via `driver/normalize-db-details` implementation) to change `dataset-id` property to inclusion filter Add test to confirm data upgrade Adding server side expansion of `:schema-filters` type connection property
-
Noah Moss authored
-
Alexander Polyankin authored
-
Alexander Polyankin authored
-