Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Mar 31, 2021
  2. Mar 30, 2021
  3. Mar 29, 2021
    • Luis Paolini's avatar
      Update common.clj (#15335) · 795c1729
      Luis Paolini authored
      Unverified
      795c1729
    • Dalton's avatar
      add string/number operator subtypes to dashboard parameter filters (#15068) · f10e9cf2
      Dalton authored
      
      * Remove location sub-categories
      
      These sub-categories are only for filtering the list of options
      when mapping a parameter filter to a field. Since we are introducing
      operator types as a sub-category of location, city/zip/etc. just get in
      the way.
      
      * add number section + number/string operator subtypes
      
      Light refactor of meta/Dashboard changes
      
      rmv 'all-options' options (for now)
      
      * add/update parameter type icons
      
      * pass operator to ParameterFieldWidget + show input per operator field
      
      * Add operator helper fns that aren't dependent on fields/tables
      
      * Make operator prop optional
      
      fix date filter err
      
      * add combined  name for native question filter widget type list
      
      Otherwise, a field that matches both "Location" and "Category"
      options will show duplicate "Starts with" options, etc. Now,
      that'll look like "Category - Starts with" and "Location - Starts with"
      
      * correct some unused prop/arg passing
      
      * Convert location/category parameter types to string for query
      
      location/category don't mean anything to BE but we use them for
      "reasons" on the FE. Reasons are legacy reliance on unique-ness of
      the parameter.type value, primarily.
      
      * operators in backend
      
      * Remove errant tap>
      
      * Docstrings and differing numbers in tests in some dbs
      
      * Make unary private so docstring checker ~shuts-up~ is satisfied
      
      * Don't parse arguments to operators params
      
      they were coming in just fine from the FE as numeric or string
      types. no need to ensure strings everywhere and parse here
      
      * add max-width to PopoverPicker
      
      * rmv unused value
      
      * use combinedName on dashboard parameters
      
      * fix parameter to mbql code
      
      * Ensure = operator filter popovers have no label
      
      This is to match "old" style of parameter popover
      
      * Update Cypress tests to reflect new parameter flow
      
      fix cypress dashboard parameter tests
      
      Fix more cy tests
      
      * Don't call fk/joinAlias on ExpressionDimension
      
      The methods don't exist on ExpressionDimension class.
      
      This doesn't make them work (yet), but it prevents the app
      from crashing.
      
      * Namespace doc and remove unnecessary comment
      
      * tap>-spy in dev
      
      * first pass at substitution of new operators in native
      
      * Docstring on wrap-value-literals-in-mbql to appease the gods
      
      * variadic equality operators (string/= number/=)
      
      * move functions out of component file
      
      * Pass parameter object to tag editor for use in default input
      
      We should inline this input eventually because it looks ugly.
      
      * map parameters in Questions to correct type
      
      * continue to pass janky fake parameter for text/number tags
      
      * mongo native substitution
      
      * variadic not-equals for string and number
      
      * Docstring and use correct function to make errors
      
      * add number/between dash param cy test
      
      * Update function name to better reflect behavior
      
      * Add unit tests for paramer/operator util fns
      
      add unit tests for parameter util functions
      
      add unit test for operator util fns
      
      * add variadic string 'is not' param operator option
      
      * Modify operator parameter display labels
      
      don't append 'matches exactly' to location/category parameters
      
      label tweaks
      
      Update cy tests to reference correct label name
      
      rmv it.only
      
      * Desugar mongo parameters mbql
      
      desugaring makes for a bit more verbose query but that's ok.This
      change was done to ensure that we negated regexes in a correct way,
      and to do so we always return the string version. This ensures that it
      can be json/generate-string'd for native parameters or left as
      datastructures and sent to monger
      
      * Cleanup stale comments and fixup docstring for consistency
      
      * Arglists metadata on defmulti and denude some threaded forms
      
      * add single arity number tag predicate to variable filter
      
      * add Location operators to fix parameter<->filter mapping
      
      For question filters to work we need for the new parameter operators
      to be supported by "location" fields in all areas of the app.
      
      * Don't show coords for param number widgets
      
      I don't think we want to support all the various number operators when
      dealing with coordinates, so in order to avoid that I'm preventing the
      mapping of number parameter operator to coord fields.
      
      * prevent mapping of tags to non-equal operators
      
      while possibly useful to end users, this needs more UI work on the
      native question side of things.
      
      * Ensure parameter values are wrapped in an array
      
      When an = operator is mapped to a field AND a tag, it ends up not being
      wrapped in an array due to the TextWidget (I think).
      
      ensure parameter value is an array
      
      ensure number params have an array value
      
      * Sort imports correctly
      
      clojure-lsp used to do this incorrectly (sorting `[` before `j`) and
      that has now been fixed
      
      Co-authored-by: default avatardan sutton <dan@dpsutton.com>
      Unverified
      f10e9cf2
    • Dalton's avatar
      Add CollapseSection UI component (#15358) · f7bb82dd
      Dalton authored
      * Add CollapseSection component
      
      * Replace header string prop with header node prop
      
      * update nounage open/closed --> expanded/collapsed
      
      * add className prop
      Unverified
      f7bb82dd
    • Howon Lee's avatar
      Check to see if `done` button is enabled whenever custom expr changes (#15293) · bc92d8ca
      Howon Lee authored
      This is done by firing an event on change which mutates if blankness of the input changes
      Unverified
      bc92d8ca
    • Dalton's avatar
      add default param value selector (#15361) · 922b9036
      Dalton authored
      Unverified
      922b9036
  4. Mar 26, 2021
    • Jeff Evans's avatar
      Update MS SQL Server JDBC driver version (#15287) · d6765a11
      Jeff Evans authored
      Bump mssql-jdbc version from 7.4.1.jre8 to 9.2.1.jre8
      
      Bump plugin version accordingly
      
      Override prepared-statement and statement multimethods for :sqlserver to not set holdability at the statement level
      
      Fixing inaccurate log statements
      Unverified
      d6765a11
  5. Mar 24, 2021
  6. Mar 23, 2021
  7. Mar 22, 2021
  8. Mar 19, 2021
    • Cam Saul's avatar
      Record login history (#15129) · 3a5eface
      Cam Saul authored
      * Record login history [WIP]
      
      * WIP
      
      * Add API endpoint and ugly React component
      
      * Fix fn name
      
      * Lookin good
      
      * Test fixes :wrench:
      
      * Prettier
      
      * Test fix
      
      * Test fixes :wrench:
      
      * Better login history info
      
      * Less ugly login history & tests
      
      * Update migration numbers
      
      * Deduplicate https-request? util function from metabase.server.middleware .session & .util
      
      * Refactor -- new Ring request utils namespace
      
      * Test fixes :wrench:
      
      * Reorganize stuff a bit; API endpoint tests
      
      * Tests for login/logout recording history
      
      * Test fix :wrench:
      
      * Test fixes :wrench:
      
      * Test fix :wrench:
      
      * Copy FE test fixture DB so it stops getting changed every time we run tests
      
      * Test fixes :wrench:
      
      
      
      * layout and code style tweaks
      
      * Fix ns sorting
      
      Co-authored-by: default avatarKyle Doherty <5248953+kdoh@users.noreply.github.com>
      Unverified
      3a5eface
    • Ariya Hidayat's avatar
    • Dalton's avatar
      add minWidth to Sidebar (#15242) · b49e9046
      Dalton authored
      Unverified
      b49e9046
    • dpsutton's avatar
      Fix typo in semantic migration (#15218) · 3099c35a
      dpsutton authored
      * Fix typo in semantic migration
      
      * Update semantic migrations for mysql compatibility
      
      mysql updates as it goes, not in a row level transaction. So
      
      ```sql
      update a = null,
             b = (case a ...)
      where a is not null
      ```
      
      mysql will use the new null value of a rather than the pre-udpate
      value of a whereas pg and h2 will do row level transaction so you are
      considering the pre-updated value of a.
      
      Solution is to update these migrations to leave semantic type alone
      and then one final set semantic_type = null where coercion_strategy is
      not null. This is sensical since these two properties used to both be
      in semantic_type, so if we extracted a coercion it could not have had
      a meaningful semantic_type before.
      Unverified
      3099c35a
    • dpsutton's avatar
      Look at effective-type in the UI (#15213) · e4a16b9a
      dpsutton authored
      * Look at effective-type in the UI
      
      still want to fall back to base_type if effective_type is not
      present. Our inference doesn't set effective_type at the moment as
      this change was super invasive and led to conflicts to other refactors
      at the time. In the future almost nothing except for query processors
      should care about base_type and only look at the (required)
      effective_type.
      
      * Check base and semantic (not base and effective) when no effective_type
      
      * Correct typo in isNumericBaseType
      
      was incorrectly checking effective_type instead of either effective or base
      Unverified
      e4a16b9a
Loading