This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 31, 2021
-
-
Tim Macdonald authored
* Set lein as the preferred build tool for Cider * Add search-typeahead-enabled setting
-
Dalton authored
-
Jeff Bruemmer authored
* update search images and text * edits on search text * trim search text
-
Jeff Bruemmer authored
* add duplicate question section * Maz edits Co-authored-by:
Maz Ameli <maz@metabase.com> * phrasing Co-authored-by:
Maz Ameli <maz@metabase.com>
-
Tim Macdonald authored
-
Nemanja Glumac authored
-
Dalton authored
* add default param values section * use index for key instead of not-unique val
-
Jeff Evans authored
* Add missing "is" assertions to various tests * Fixing save-card-with-empty-result-metadata-test by simply asserting on API response * Fix more failing tests * Switch row-type-agnostic-test back to strings for expected * Modify check for convert-id-to-string to also include keys whose :base_type is :type/Number, in addition to :type/Integer to fix failures in Oracle and Snowflake
-
Jeff Evans authored
Fix Oracle SSL tests Define new test for Oracle SSL connectivity, in oracle_test.clj, similar to how things work in mysql_test.clj Add new test util macro, with-env-keys-renamed-by, to support running tests with environ keys temporarily renamed Using new test macro from both MySQL and Oracle SSL connectivity tests Removing now unneeded be-tests-oracle-ssl-ee CircleCI job Removing now unneeded test-selector parameter for test-driver orb in CircleCI config.yml Updating JVM_OPTS to use a trust store that starts with cacerts and adds the RDS root CA, rather than one only containing the RDS root CA
-
- Mar 30, 2021
-
-
Luis Paolini authored
-
Kyle Doherty authored
This reverts commit ea4c591b.
-
Cam Saul authored
* No more old-style tests * Presto test fix
-
- Mar 29, 2021
-
-
Luis Paolini authored
-
Dalton authored
* Remove location sub-categories These sub-categories are only for filtering the list of options when mapping a parameter filter to a field. Since we are introducing operator types as a sub-category of location, city/zip/etc. just get in the way. * add number section + number/string operator subtypes Light refactor of meta/Dashboard changes rmv 'all-options' options (for now) * add/update parameter type icons * pass operator to ParameterFieldWidget + show input per operator field * Add operator helper fns that aren't dependent on fields/tables * Make operator prop optional fix date filter err * add combined name for native question filter widget type list Otherwise, a field that matches both "Location" and "Category" options will show duplicate "Starts with" options, etc. Now, that'll look like "Category - Starts with" and "Location - Starts with" * correct some unused prop/arg passing * Convert location/category parameter types to string for query location/category don't mean anything to BE but we use them for "reasons" on the FE. Reasons are legacy reliance on unique-ness of the parameter.type value, primarily. * operators in backend * Remove errant tap> * Docstrings and differing numbers in tests in some dbs * Make unary private so docstring checker ~shuts-up~ is satisfied * Don't parse arguments to operators params they were coming in just fine from the FE as numeric or string types. no need to ensure strings everywhere and parse here * add max-width to PopoverPicker * rmv unused value * use combinedName on dashboard parameters * fix parameter to mbql code * Ensure = operator filter popovers have no label This is to match "old" style of parameter popover * Update Cypress tests to reflect new parameter flow fix cypress dashboard parameter tests Fix more cy tests * Don't call fk/joinAlias on ExpressionDimension The methods don't exist on ExpressionDimension class. This doesn't make them work (yet), but it prevents the app from crashing. * Namespace doc and remove unnecessary comment * tap>-spy in dev * first pass at substitution of new operators in native * Docstring on wrap-value-literals-in-mbql to appease the gods * variadic equality operators (string/= number/=) * move functions out of component file * Pass parameter object to tag editor for use in default input We should inline this input eventually because it looks ugly. * map parameters in Questions to correct type * continue to pass janky fake parameter for text/number tags * mongo native substitution * variadic not-equals for string and number * Docstring and use correct function to make errors * add number/between dash param cy test * Update function name to better reflect behavior * Add unit tests for paramer/operator util fns add unit tests for parameter util functions add unit test for operator util fns * add variadic string 'is not' param operator option * Modify operator parameter display labels don't append 'matches exactly' to location/category parameters label tweaks Update cy tests to reference correct label name rmv it.only * Desugar mongo parameters mbql desugaring makes for a bit more verbose query but that's ok.This change was done to ensure that we negated regexes in a correct way, and to do so we always return the string version. This ensures that it can be json/generate-string'd for native parameters or left as datastructures and sent to monger * Cleanup stale comments and fixup docstring for consistency * Arglists metadata on defmulti and denude some threaded forms * add single arity number tag predicate to variable filter * add Location operators to fix parameter<->filter mapping For question filters to work we need for the new parameter operators to be supported by "location" fields in all areas of the app. * Don't show coords for param number widgets I don't think we want to support all the various number operators when dealing with coordinates, so in order to avoid that I'm preventing the mapping of number parameter operator to coord fields. * prevent mapping of tags to non-equal operators while possibly useful to end users, this needs more UI work on the native question side of things. * Ensure parameter values are wrapped in an array When an = operator is mapped to a field AND a tag, it ends up not being wrapped in an array due to the TextWidget (I think). ensure parameter value is an array ensure number params have an array value * Sort imports correctly clojure-lsp used to do this incorrectly (sorting `[` before `j`) and that has now been fixed Co-authored-by:
dan sutton <dan@dpsutton.com>
-
Dalton authored
* Add CollapseSection component * Replace header string prop with header node prop * update nounage open/closed --> expanded/collapsed * add className prop
-
Howon Lee authored
This is done by firing an event on change which mutates if blankness of the input changes
-
Dalton authored
-
- Mar 26, 2021
-
-
Jeff Evans authored
Bump mssql-jdbc version from 7.4.1.jre8 to 9.2.1.jre8 Bump plugin version accordingly Override prepared-statement and statement multimethods for :sqlserver to not set holdability at the statement level Fixing inaccurate log statements
-
- Mar 24, 2021
-
-
Jeff Evans authored
Adding ssl-cert config field to MySQL DB details map, to hold the server cert chain in PEM format (similar to what is done in MongoDB driver) Updating MySQL driver init to map :ssl-cert into :serverSslCert for the JDBC url, when ssl is in use and cert is provided (the MariaDB driver we are using accepts PEM format certificates inline directly for the param value, so no need to shepherd into a temp file) Adding new test to mysql_test.clj to run a single test while connecting via SSL with PEM cert Update CircleCI config: - use extra-env to set all the MySQL SSL instance DB related vars (for an RDS instance, currently) - adding the rds-combined-ca-bundle.pem certificate to resources/certificates - loading that cert bundle from resources directory via env var Adding to/fixing assertion in connection-spec-test for :ssl
-
Dalton authored
* split SharingSidebar into a few components * rmv emailRecipientText prop (unused) * use pulse.id in place of pulseId * use _.partial to avoid passing index prop * cut a few lines of code * add minor comment for components with too many props * add proptypes to new components and fix key errs * move time formatting utils * add handling for 12pm Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com> Co-authored-by:
flamber <1447303+flamber@users.noreply.github.com>
-
Dalton authored
* add new linting package * add rule to eslint config * remove it.only * fix race condition err in test
-
Tim Macdonald authored
-
- Mar 23, 2021
-
-
Cam Saul authored
Port the metabase.mbql utility namespaces to ./shared/ so they can be used on both the frontend and backend.
-
Paul Rosenzweig authored
-
Paul Rosenzweig authored
* Add cypress tests for reference/metrics/:id page * Add metrics/:metricId/edit route * Use router location for metric's isEditing state Data Reference keeps `isEditing` state flag in Redux store (it's shared across metrics, segments and DB references) Metrics page now uses router's path name to distinguish reading and editing states * Use non-Redux callbacks at MetricDetailContainer * Add missing prop type definition * Fix editing callbacks not passed to MetricDetail * Fix signInAsAdmin test utility usage * Reorder imports * Use cy.findByText instead of cy.contains * Fix Metrics data reference test For some reason, when running Cypress tests, the page appears in `cannot read property fields of undefined` However it works correctly when running Metabase locally Checking for undefined `fields` explicitly fixes the problem Anyway, most likely this component is going to be removed in #15209 * Fix metrics test Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com>
-
Dalton authored
-
Maz Ameli authored
* nicer no-results search message * also update SRP
-
Howon Lee authored
* complicated prefix trim to solve 15247 * found regression, hah * lint * test
-
- Mar 22, 2021
-
-
Ariya Hidayat authored
* Custom expression editor: fix Enter not commmitting the change * Remove superfluous onChange * Merge onDone and onUpdateAndCommit
-
Kyle Doherty authored
* initial prototype of 'Explore results' * use ViewButton * use same button type as ViewFooter * check for database * extract explore results url into fn
-
Maz Ameli authored
-
Ariya Hidayat authored
The width should be fixed only when the editor is being used in the notebook, and not from the sidebar.
-
Luis Paolini authored
-
Ariya Hidayat authored
There is this famous Firefox issue with empty contentEditable: https://bugzilla.mozilla.org/show_bug.cgi?id=1020973 The workaround is to inject <br> when there is no expression (it will be wiped out anyway on subsequent typing by the user).
-
Kyle Doherty authored
* use schema list loader to check for number of schemas when displaying table context * set loadingAndErrorWrapper to false to prevent UI flash * fix up translation strings for metric/segments * remove duplicate length check
-
- Mar 19, 2021
-
-
Cam Saul authored
* Record login history [WIP] * WIP * Add API endpoint and ugly React component * Fix fn name * Lookin good * Test fixes
* Prettier * Test fix * Test fixes * Better login history info * Less ugly login history & tests * Update migration numbers * Deduplicate https-request? util function from metabase.server.middleware .session & .util * Refactor -- new Ring request utils namespace * Test fixes * Reorganize stuff a bit; API endpoint tests * Tests for login/logout recording history * Test fix * Test fixes * Test fix * Copy FE test fixture DB so it stops getting changed every time we run tests * Test fixes * layout and code style tweaks * Fix ns sorting Co-authored-by:Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
Ariya Hidayat authored
-
Dalton authored
-
dpsutton authored
* Fix typo in semantic migration * Update semantic migrations for mysql compatibility mysql updates as it goes, not in a row level transaction. So ```sql update a = null, b = (case a ...) where a is not null ``` mysql will use the new null value of a rather than the pre-udpate value of a whereas pg and h2 will do row level transaction so you are considering the pre-updated value of a. Solution is to update these migrations to leave semantic type alone and then one final set semantic_type = null where coercion_strategy is not null. This is sensical since these two properties used to both be in semantic_type, so if we extracted a coercion it could not have had a meaningful semantic_type before.
-
dpsutton authored
* Look at effective-type in the UI still want to fall back to base_type if effective_type is not present. Our inference doesn't set effective_type at the moment as this change was super invasive and led to conflicts to other refactors at the time. In the future almost nothing except for query processors should care about base_type and only look at the (required) effective_type. * Check base and semantic (not base and effective) when no effective_type * Correct typo in isNumericBaseType was incorrectly checking effective_type instead of either effective or base
-