This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Mar 01, 2023
-
-
Braden Shepherdson authored
The new approach uses a dev-mode-only CLJC reader conditional `#?(:cljs-dev ...)` to make `metabase.util.devtools` empty except in dev builds. The previous approach for this relied on dead code elimination. But DCE relies on tracing function calls and `:require`s from the `:entries` list in shadow-cljs.edn. Top-level namespace code is handled differently; in particular a namespace listed in `:entries` like `metabase.util.devtools` will always have its top-level code in the build.
-
metabase-bot[bot] authored
* Register new E2E path alias * Move E2E support files * Move E2E runner files * Move E2E snapshot related files * Move E2E visual regression tests * Move E2E `downloads` scenarios * Move E2E `admin` scenarios * Move E2E `auditing` scenarios * Move E2E `bining` scenarios * Move E2E `ccollections` scenarios * Move E2E `cross-version` scenarios * Move E2E `custom-column` scenarios * Move E2E `dashboard` scenarios * Move E2E `dashboard-filters` scenarios * Move E2E `dashboard` reproductions * Move E2E `embedding` scenarios * Move E2E `filters` scenarios * Move E2E `joins` scenarios * Move E2E `models` scenarios * Move E2E `native-filters` scenarios * Move E2E `native` scenarios * Move E2E `onboarding` scenarios * Move E2E `organization` scenarios * Move E2E `permissions` scenarios * Move E2E `question` scenarios * Move E2E `visualizations` scenarios * Move E2E `sharing` scenarios * Move E2E `docker-compose` * Fix commands imports * Fix helpers imports * Fix downloads reproductions imports * Fix integration imports * Move visual regression tests * Various fixes * Move `validate-e2e-files` script * Add eslint rules for E2E folder * Improve file paths * Move `cross-version` tests into scenarios * Path fixes * Register E2E alias in tsconfig * Fix failing tests after rebase Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Natalie <nat@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
metabase-bot[bot] authored
* Ensure query action's db matches model id This is only a half-way measure. Needs some FE loving as well. The +New -> Action workflow lets you create an action. This starts with the user choosing the database, writing the action. On save it prompts you to choose a model it should live under. But this model's db and the db chosen originally are not checked in the FE. Ideally we only show models on that existing db, but it kinda seems weird to have an action do things to a random table and it live under a model that just needs to be on the db. * reword error message * Check both databases for enabled actions when they disagree a custom action can have its own query which brings its own database. When creating a new custom action from the models detail page, these go hand in hand. When using the workflow from the "+New" button, the model is chosen at the last step, well after the action's db and query is set. And there's nothing holding these two together. Asked if this was a bug and was told no. But we want to make sure we check both for actions enabled. * fix lint --------- Co-authored-by:
dpsutton <dan@dpsutton.com> Co-authored-by:
Maz Ameli <maz@metabase.com>
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
-
- Feb 28, 2023
-
-
dpsutton authored
* Delay substituting persisted native query until after analysis We were substituting persisted queries into the query at too early a stage. Card 729 is a persisted model of `select * from categories` ```clojure {:type :query, :query {:source-table "card__729", :expressions {:adjective ["case" [[[">" ["field" 100 nil] 30] "expensive"] [[">" ["field" 100 nil] 20] "not too bad"]] {:default "its ok"}]}, :aggregation [["count"]], :breakout [["expression" "adjective" nil] ["field" 101 nil]]}, :database 3, :parameters []} ``` This would immediately get turned into an equivalent ```clojure {:type :query, :query {:source-table 12 :persisted-info/native "select \"id\", \"ean\", \"title\", \"category\", \"vendor\", \"price\", \"rating\", \"created_at\" from \"metabase_cache_424a9_3\".\"model_729_products_r\"" :expressions {:adjective ["case" [[[">" ["field" 100 nil] 30] "expensive"] [[">" ["field" 100 nil] 20] "not too bad"]] {:default "its ok"}]}, :aggregation [["count"]], :breakout [["expression" "adjective" nil] ["field" 101 nil]]}, :database 3, :parameters []} ``` And the obvious failure here is the use of `[:field 100 nil]` (price) against an inner query of `select ... price ... from cache_table`. This could break many queries and caused a flood of ``` WARN middleware.fix-bad-references :: Bad :field clause [:field 100 #:metabase.query-processor.util.add-alias-info{:source-table :metabase.query-processor.util.add-alias-info/source, :source-alias "price"}] for field "products.price" at [:expressions "adjective" :case :>]: clause should have a :join-alias. Unable to infer an appropriate join. Query may not work as expected. WARN middleware.fix-bad-references :: Bad :field clause [:field 100 #:metabase.query-processor.util.add-alias-info{:source-table :metabase.query-processor.util.add-alias-info/source, :source-alias "price"}] for field "products.price" at [:expressions "adjective" :case :>]: clause should have a :join-alias. Unable to infer an appropriate join. Query may not work as expected. ``` * forgot to commit new test file * Handle persisted before native * Add test for native models - have to populate the metadata. You can do this by running the query, but there are some requirements around the `:info` object to actually save it. So just take the more mechanical route - `wait-for-result` returns a time out value, but it's namespaced autoresolved to a namespace inside of the metabase.test forest and not mt itself. So easy to mess up and watch for the wrong keyword. Want an arity so i can check my own timeout value and throw a helpful error message. I checked around and noone seems to care. So not great, but at least people aren't checking `::mt/timed-out` when it should be `::tu.async/timed-out` or `:metabase.test.util.async/timed-out`. Possibly best scenario is we remove the autoresolved bit and have it return `:async/timed-out` or something stable. * properly compile the native query * bump timeout to set redshift metadata
-
john-metabase authored
Cleans/fixes serdes v2 export :collections handling in cmd and API
-
Anton Kulyk authored
* Handle errors when enabling database actions * Use more common error message fallback * Use `Promise<void>` for other `Sidebar` callbacks
-
Alexander Polyankin authored
-
Nick Fitzpatrick authored
* Adding flex grow to card wrapper * Optimize repro * fix height on cards --------- Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
Anton Kulyk authored
* Handle archived and not existing actions * Handle model ID mismatch * Migrate to `fetch-mock` * Don't use URL helpers in tests * Fix action editor assertions in model detail tests
-
john-metabase authored
-
Cal Herries authored
-
Aleksandr Lesnenko authored
* Revert "Fixing Table isValid check (#28411)" This reverts commit 5e18759f. * Revert "GH 28304 and GH 28311 (#28314)" This reverts commit 47bad0d3. * revert column settings changes * object detail view * adjusting e2e tests --------- Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
Denis Berezin authored
-
Nemanja Glumac authored
* Run workflows using `ubuntu-22.04` - batch 2 * Do not run `i18n` workflow on the latest Ubuntu
-
Nemanja Glumac authored
[ci skip]
-
Ngoc Khuat authored
* add tests for sandbox user apis
-
Ngoc Khuat authored
-
Aleksandr Lesnenko authored
-
- Feb 27, 2023
-
-
john-metabase authored
Adds basic logging to v2 export/import, resolves #26859
-
Emmad Usmani authored
-
Braden Shepherdson authored
Dev experience: - CLJS now has source maps - Devtools extension renders CLJS data in Chrome (et al) Devtools - Use a debug build of CLJS in the tests - Fixed line numbers and breakpoints being off-by-one in Devtools CLJC infra: - More robust direct approach to JS<->CLJS conversions, powered by Malli transformers. - Powerful `define-getters-and-setters` macro to generate the accessors.
-
Anton Kulyk authored
* Fix Jest coverage config * Run FE specs when jest configs change --------- Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix ErrorBoundary not working in some cases * Allow users to remove database, even if it contains error * Unskip the repro for #25715
-
Nemanja Glumac authored
* Track only frontend source files * Bump `frontend` target to 50% * Bump `backend` target to 85% * Ignore unit tests coverage directly in jest config * Ignore Storybook components from coverage reports
-
Gustavo Saiani authored
* Ensure visible before clicking * Wait for question to load --------- Co-authored-by:
Nemanja <31325167+nemanjaglumac@users.noreply.github.com>
-
Mark Bastian authored
Added post-collection retrieval function `remove-other-users-personal-collections` that will filter out any personal collection that doesn't belong to the current user when the `exclude-other-user-collections=true` path param is used. Also added unit tests for both the `api/collection/` and `api/collection/tree` endpoint.
-
Cal Herries authored
* Add comment for database-enable-actions * Enforce actions not supported implies actions are disabled * Remove test and update check * Fix typos * Revert "Remove test and update check" This reverts commit 8b1f14f44bd97514cd8ce0c9b0a5df048d713b16. * Fix test
-
Braden Shepherdson authored
Large dashboards, and especially tables, cause a lot of recomputation of number and date formats. There's enough overhead in converting to CLJS data that it causes noticable lag on large dashboards, especially in the editor view. There are paths to avoiding the recomputation, which is pretty wasteful in either language. To be investigated after the 46 cut.
-
Alexander Polyankin authored
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Feb 26, 2023
-
-
Nemanja Glumac authored
-
Nemanja Glumac authored
-
- Feb 25, 2023
-
-
Nemanja Glumac authored
[ci skip]
-
- Feb 24, 2023
-
-
Aleksandr Lesnenko authored
-
Aleksandr Lesnenko authored
-