Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 28, 2022
  2. Nov 25, 2022
  3. Nov 24, 2022
  4. Nov 23, 2022
  5. Nov 22, 2022
    • adam-james's avatar
      Fix bug where grouping strategy would NPE when fingerprint was `nil` (#26659) · 78d506c5
      adam-james authored
      
      * Fix bug where grouping strategy would NPE when fingerprint was `nil`
      
      The axes grouping relies on fingerprint data existing, AND for now only works on :type/Number columns, so this bugfix
      guards against those situations where the logic would fail.
      
      The bug that brought this to my attention came up when there was a Custom column. This set the col-meta count to be
      one greater than the count of the 'real' columns, which threw off my old assumptions, where if the grouped-columns
      count was less than the total col-meta count, you had a potential grouping. This broke in part because some custom
      columns are essentially derived from a real column, and so will most likely be groupable with the column they're
      derived from.
      
      Anyway, this filters out columns that won't work, so we hopefully eliminate the problem.
      
      * Update src/metabase/pulse/render/body.clj
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      
      * Fix some broken logic
      
      Co-authored-by: default avatarTim Macdonald <tim@metabase.com>
      Unverified
      78d506c5
    • Gustavo Saiani's avatar
      Fix foriegn → foreign (#26673) · 01a66c91
      Gustavo Saiani authored
      Unverified
      01a66c91
    • Anton Kulyk's avatar
      Clean up collection entity (#26487) · f40d2d9b
      Anton Kulyk authored
      * Move collection entity tests to entity directory
      
      * Simplify `normalizedCollection` helper
      
      * Remove nested ternaries in `getCollectionType`
      
      * Simplify list endpoint code
      
      * Remove comment
      
      * Simplify null check
      
      * Fix collection's `authority_level` types
      
      * Convert collection utils to TypeScript
      
      * Convert `index` file to TypeScript
      
      * Move `getInitialCollectionId` to its own file
      
      * Move `getExpandedCollectionsById` to its own file
      
      * Simplify `getExpandedCollectionsById` usage
      
      * Convert collections entity to TypeScript
      
      * Add missing type
      
      * Fix type errors
      
      * Remove embarrassing backticks
      Unverified
      f40d2d9b
Loading