This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 11, 2024
-
-
Mark Bastian authored
* Don't send results works at the card level (#37546) * Don't send results works at the card level When a user enables **Don't send if there aren't results** this was the previous behavior: - If no results appeared on any card, no emails was sent. This was expected. - If any card contained results, all cards were sent in the email, including those that had no results. This PR modifieds that behavior to only send those cards that contain results for a dashboard pulse. For example, if 5 cards are present on a dashboard and 3 have no results, only results for the 2 cards containing data are included in the pulse. Primary changes: - `metabase.pulse/execute-dashboard` now removes any card with a row count of 0 in its computed result if `skip_if_empty` is true for the pulse. - The addition of tests covering the matrix of tests where `skip_if_empty` is true or false, all cards contain data, some cards contain data, and no cards contain data. - The `with-skip-if-empty-pulse-result` makes the above set of tests nice and concise. Minor changes: - Fixing a minor issue in `with-metadata-data-cards` in which the macroexpansion logic would go bad if the user used a different symbol name for `base-card-id`. - Spelling and formatting issues in `metabase.pulse` Fixes #34777 * lint fix for #_{:clj-kondo/ignore [:unresolved-symbol]} (cherry picked from commit 6f0161ac) * Fixing test dataset reference
-
metabase-bot[bot] authored
Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
bryan <bryan.maass@gmail.com>
-
metabase-bot[bot] authored
Resolves #37555 Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* Validate json settings during init (#36182) (#37313) * Validate json settings during init (#36182) * Use correct translation for error message Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> * Make extensible, only throw on env vars * Better check for whether a setting came from an environment variable Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> * Resuse existing parser validation, improve security * Add example of better exception * Add precise exception messages as exmaples * DRY up tests * Add test for realize * make the example actually deep * better hygiene around ex-cause * Use strict json parsing for all settings * Disable validation on non-json configuration --------- Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> * Update test to reflect lack of redaction --------- Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
Chris Truter <chris@metabase.com>
-
metabase-bot[bot] authored
Resolves #37453 Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metabase-bot[bot] authored
* Drop then recreate a column should refingerprint and analyze the field (#37110) * there is no mt/malli=? in the 48 branch --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Jan 10, 2024
-
-
metabase-bot[bot] authored
backported "Apply selective malli mu.fn enforcement for certain namespaces to improve performance" (#37544) Co-authored-by:bryan <bryan.maass@gmail.com> Co-authored-by:
dan sutton <dan@dpsutton.com>
-
metabase-bot[bot] authored
Co-authored-by:
bryan <bryan.maass@gmail.com>
-
Mark Bastian authored
When trying to render a card with viz settings containing a nonexistent dimension, an error would result in `mult-x-axis-rowfn` causing a failure to render. This fix simply replaces `map` with `keep` in `metabase.util.ui-logic/mult-x-axis-rowfn` and `metabase.util.ui-logic/mult-y-axis-rowfn` so that `nil` values are dropped if a bad dimension or metric name is provided. The following easily shows the broken case (now fixed). Previously, an error was rendered. Now you get the chart. ```clojure ;; REPRO (comment (ns tickets.37266-slack-error (:require [clojure.test :refer :all] [dev.render-png :as render-png] [metabase.models :refer [Card]] [metabase.pulse.render.body :as body] [metabase.query-processor :as qp] [metabase.test :as mt] [toucan2.core :as t2])) (let [busted? true] (mt/dataset test-data ;; Note that this uses orders since we have that as test data. (mt/with-temp [Card {base-card-id :id} {:dataset_query {:database (mt/id) :type :query :query {:source-table (mt/id :orders) :aggregation [[:count]] :filter [:between [:field (mt/id :orders :created_at) nil] "2019-05-16" "2019-08-16"] :breakout [:field (mt/id :orders :created_at) {:temporal-unit :week}]}} :display :line :visualization_settings {:table.pivot_column "state" ;; This is also intentionally broken :graph.metrics (if busted? ["frooby"] ["count"]) :graph.show_trendline false :graph.x_axis.title_text "Week" :graph.y_axis.title_text "PR Review Activity" ;; Using a missing dimension name breaks the results :graph.dimensions (if busted? ["_sdc_extracted_at"] ["created_at"]) :graph.show_values false :table.cell_column "count"}}] (render-png/render-card-to-png base-card-id))))) ``` (cherry picked from commit 27587264)
-
Mark Bastian authored
* Updating honeysql alias in dev ns This just fixes a broken require to align with the work in #36670. Fixes #36757 (cherry picked from commit b4408e03)
-
- Jan 09, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* Fix static viz funnel chart rendering by changing row idx values (#37415) * Fix static viz funnel chart rendering by changing row idx values Pass into the js code the row data that the funnel component expects. This means changing a row from for example, [0 120] to something like: ["January" 120] when :funnel.rows exists in the viz-settings map. Also add some helpers to the render test utils ns which will be used in the test. * Add funnel test * Add docstrings. Slight change in funnel render rows * Slight rewrite for readability. * Use sample-dataset symbol --------- Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
Jeff Bruemmer authored
-
metabase-bot[bot] authored
* Multiple Cypress Reporters This PR modifies our Cypress reporter to support multiple reporters, currently pretty mochawesome reports and junit xml files. This was enabled using the [cypress-multi-reporters](https://www.npmjs.com/package/cypress-multi-reporters) reporter. Additional reporters are added via yarn packages: - [mocha-junit-reporter](https://www.npmjs.com/package/mocha-junit-reporter) - [mochawesome](https://www.npmjs.com/package/mochawesome) which was already installed One of the biggest challenges here is simply getting the config keys right, primarily `mochaJunitReporterReporterOptions` as opposed to the more sane `mochaJunitReporterOptions`, but I guess that the legacy of Java (
). Also be aware that `mochawesomeReporterOptions` is NOT the same as `mochaAwesomeReporterOptions` but `mochaJunitReporterReporterOptions` is not `mochJunitReporterReporterOptions` for obvious reasons. For future reference, note that multiple `mochawesome` reporters are available. Read more [here](https://glebbahmutov.com/blog/the-awesome-battle/ ) in the event that one of them is mochawesomer than the other and we want to level up. Closes #37195 * Adding feedback per @iethree. * Updated lock file Co-authored-by:Mark Bastian <markbastian@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
- Jan 08, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com>
-
metabase-bot[bot] authored
* Fix collection nil * address comments Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
* add collection/list endpoint * add children * address changes * address change * fix test * fix like * address comments * Update src/metabase/api/collection.clj * address changes * exclude other user collections in the sql query * fix logic * fix acrhive * make remove-other-users-personal-collections cleaner * fix tests * fix errors * fix other test * add test * fix merge * fix formatting * address comments --------- Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Jan 05, 2024
-
-
metabase-bot[bot] authored
* Add backport resolution script * Number viz render method properly uses :scalar.field name to render value (#37274) * Add number-viz test to pulse integration test. This is a currently failing test. The first card succeeds because the 'narrowing' to 1 field is done in the query directly, so the expected single value is shown. The second (currently failing) card has the viz for a 'number' applied but the query isn't 'narrowed' at all, so we see the failure. * Fix the :scalar render to look at the column specified in :scalar.field * Addressed feedback: improved get-col-by-name impl. and added test comment * Fix dataset symbol --------- Co-authored-by:
Metabase bot <metabase-bot@metabase.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Adam James <adam.vermeer2@gmail.com>
-
metabase-bot[bot] authored
* Don't coerce add-implicit-clauses Fixes #33861 Renames `::nest-query/outer-select` to `qp/ignore-coercion` since it was already applied outside nest-query and currently only controls that aspect. * Fix whitespace * Only add ignore-coercion if temporal-unit or binning are present * Fix tests * Only add ignore-coercion flag when coercion strategy is present Co-authored-by:
Case Nelson <case@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* add reproducing e2e spec * show failed button state and error message * add failed button and error message to e2e spec * Use findByLabelText and findByRole rather than cy.get * Add role=alert and aria-label to FormErrorMessage --------- Co-authored-by:
shaun <shaun@metabase.com> Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com>
-
metabase-bot[bot] authored
Previously date arithmetic was only supported with a single date or datetime +/- 0 or more intervals. This adds a new flavour of temporal arithmetic - subtracting two `:type/Date` or two `:type/DateTime` values yields a `:type/Interval`. Fixes #37263. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
Noah Moss authored
-
- Jan 04, 2024
-
-
metabase-bot[bot] authored
* Error if DB downgrades are required Before running migrations, check the major versions of: - the latest database migration that was actually applied (e.g. if v49 ran migrations, this would be 49) - the latest database migration that liquibase is aware of (e.g. if we're currently running v48, this would be 48) If the database has executed migrations that we don't know about, throw an exception and exit with a helpful error message telling the user they need to run `migrate down` from the newer version before they can downgrade. Fixes #27906 Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com>
-
metabase-bot[bot] authored
* add collection/list endpoint * add children * address changes * address change * fix test * fix like * address comments * Update src/metabase/api/collection.clj * address changes --------- Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Nemanja Glumac authored
* Fix stress-test workflow Use `replay-chromium' browser for these tests as well. This gives us a bit more confidence because we're using the same browser in both "regular" and "stress-test" runs. [ci skip] * Enable Replay via envvar [ci skip]
-
metabase-bot[bot] authored
* Use counter instead of `gensym` to make mongo field aliases unique (#37189) * Add test * Use atom to track next alias index * Update testing string Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Use volatile instead of atom for index tracking --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Use only tables from test-data in test --------- Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
Uladzimir Havenchyk authored
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-