This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Jan 29, 2024
-
-
metabase-bot[bot] authored
* Display chart caption even where there is no card title (#36801) * Display chart caption even where there is no card title * Add E2E reproduction for #36788 * Adapt the test for the release 48 branch --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
- Jan 26, 2024
-
-
metabase-bot[bot] authored
* Chain filter search should check block perms * Simplify test Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
metabase-bot[bot] authored
* Field values cache needs to check permissions (#38104) * Field values cache needs to check permissions If a user does not have permissions to the field, we should not return the cached field values. * Update default-get-or-create-field-values-for-current-user to check can-read too * Revert params.field-values change * Use query processor permissions checks before returning cached values * Return true from check * Fix test * Check for ee config * Fix merge issue --------- Co-authored-by:
Case Nelson <case@metabase.com>
-
Nemanja Glumac authored
Fixes #36734.
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
CVE updates: lambdaisland/uri, aws sdk (drop ions), specify guava for googleanalytics (#38118) (#38141) Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metabase-bot[bot] authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
- Jan 25, 2024
-
-
metabase-bot[bot] authored
switch to regenerator-runtime and update follow-redirects to silence Snyk warnings (#38124) (#38164) * switch to regenerator-runtime and update glob to silence Snyk warnings * no glob update * update follow-redirects * lets update debug as well Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metabase-bot[bot] authored
* Fix NPE in schema pattern matching fns in sync * Require PG Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
metabase-bot[bot] authored
* Fix Snowflake sync not returning all schemas regression in 48+ * Fix extra whitespace * Better DB name * Improved test Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* Fix dashboard parameter values in embed preview not working * Fix iframe rerendering unnecessarily * Add E2E reproduction test * Prevent iframe from rerendering unnecessarily Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
- Jan 24, 2024
-
-
metabase-bot[bot] authored
* Formatting for time types (#37942) * Formatting for time types Currently, the frontend does not do any special formatting for time of day types. These are always formatted as 12 hour AM/PM times. This PR adds a new function to `frontend/src/metabase/lib/formatting/time.ts`, `formatTimeWithOptions`, that applies user-defined formatting to the time. Previously, `formatTime` was called, which takes no formatting options, so none can be applied. Fixes #11398 * e2e tests for time of day formatting. * Update frontend/src/metabase/lib/formatting/time.ts Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu> * Replacing formatTime with formatTimeWithOptions This replaces uses of `formatTime` with `formatTimeWithOptions`, updates unit tests, removes references to `formatTime`, and incorporates some code suggestions. * Unit tests * Adding test id for field info popover. * Refactoring `formatTimeWithOptions` to `formatTime` * Moved `TimeOnlyOptions` interface to formatting types and made it an ancestor of `OptionsType` --------- Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu> * Fixing type issue --------- Co-authored-by:
Mark Bastian <markbastian@gmail.com> Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
-
metabase-bot[bot] authored
This regressed in 48 - it only works when either none of the several filters has a value, or when all of them do. This PR restores the 47 behavior: whatever subset of the filters have values (including defaults) will be used, and the others are ignored. The fix is on the BE but the change actually occurred in the FE - previously only those parameters with values were sent in the request. We might want that FE behavior back, but the new BE logic should work either way. Fixes #38012. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
metabase-bot[bot] authored
* add personal-only to collection endpoint * address some comments * fix test * fix select-collections test * Update src/metabase/api/collection.clj * Update src/metabase/api/collection.clj * address comments --------- Co-authored-by:
Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by:
bryan <bryan.maass@gmail.com>
-
metabase-bot[bot] authored
* Move _lastAutocomplete to a variable in closure * Debounce the initial autocomplete * Add e2e tests * Fix typo in test case * Remove async from 2e2 tests * Fix wording of comment * Avoid casting in lastAutoComplete * Clarify comment in skip condition for initial autocomplete * Remove outdated comment in e2e test * Describe problem in filename, not assertion * Use early return instead of skip variable * Pass results from last autocomplete to ace * Actually use last autocompletions result * Detect the first autocomplete without looking at the actual prefix * Add test for backspacing to one character in native editor * Rename resultsForAce to prepareResultsForAce * Avoid running autocompleter with prefix of length 1 * Remove unnecessary fallback --------- Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Vladimir Zaytsev <vladimir@trunk.io>
-
metabase-bot[bot] authored
Resolves https://github.com/metabase/metabase/security/dependabot/130 Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
- Jan 23, 2024
-
-
Chris Truter authored
Fixes https://github.com/metabase/metabase/issues/38009 ### Description This makes the feature flag loading code more robust by making the function re-entrant. To understand how this function could deadlock before, see the description in https://github.com/metabase/metabase/pull/38027. It works by ensuring that the call to initialize the nonce comes from the same thread that initially locked on fetching the tokens. There is a subtle behavior change here - was allow for a 10s timeout on each call individually now. Since it is unlikely that both endpoints will timeout consecutively, and the combined wait time is still fairly short, I think this is OK. ### How to verify You can use the same steps as https://github.com/metabase/metabase/pull/38027, either of these PRs are sufficient to fix the bug.
-
metabase-bot[bot] authored
Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
metabase-bot[bot] authored
Fixes #37345. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
metabase-bot[bot] authored
This reverts commit d78f324c. This is a revert-of-a-revert, see: - https://github.com/metabase/metabase/pull/37519 (original) - https://github.com/metabase/metabase/pull/37809 (revert) Co-authored-by:
Chris Truter <chris@metabase.com>
-
- Jan 22, 2024
-
-
metabase-bot[bot] authored
* Enabling dragging of long-named TabButtons The primary change needed to support rearranging of tabs with super long names is the to shorten the names only when dragging. This was achieved by exposing the `isDragging` prop of the `useSortable` hook in the `RenameableTabButtonStyled` component. The label of this component is dynamically shortened if it is very long on a drag operation by the following logic and function: ``` // Update the label prop when dragging label={isDragging ? dragLabel(label) : label} ``` The `dragLabel` function is as follows: ``` const dragLabel = (s: string) => { if (s.length < 20) { return s; } else { return `${s.slice(0, 17)}...`; } }; ``` The other change needed to support e2e testing for this operation was the addition of the `MouseSensor` hook to the DnDContext. See [this issue comment](https://github.com/clauderic/dnd-kit/issues/208#issuecomment-824469766) for explanation. Once that change was in place it was possible to do a drag and drop rearrange test in the "should allow me to rearrange long tabs (#34970)" spec. This test: - Creates a dashboard with 3 tabs - Ensures their order - Gives the last tab a super long name that would not be rearrangeable before fix - Drags that tab to the first position - Saves the dashboard - Asserts the new tab order is saved Fixes #34970 * Fixing type from T to unknown to satisfy the type of the render function in TabButton.unit.spec.ts * Fixing type from T to any to satisfy the type of the render function in TabButton.unit.spec.ts * Fixing divergent tests The tests to ensure DnD works required the addition of the `mouseSensor` in TabRow.tsx. This, in turn, broke the tests in DashboardTabs.unit.spec.tsx. Adding in the `activationConstraint: { distance: 10 }` prop to the mouseSensor fixed the DashboardTabs.unit.spec.tsx tests, but broke the DnD tests. Based on the docs [here](https://docs.dndkit.com/api-documentation/sensors/mouse) it looks like you need to move a "distance, in pixels, by which the mouse needs to be moved before a drag start event is emitted." So, the DnD test in tabs.cy.spec.js added an addtional mousemove trigger of 11 pixels to activate the mouseSensor. Yeah, it totally makes sense.
* prettier Co-authored-by:Mark Bastian <markbastian@gmail.com>
-
metabase-bot[bot] authored
* fix auto y-axis split on native queries * specs Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
metabase-bot[bot] authored
* Filter out audit tables in search results * add test Co-authored-by:
bryan <bryan.maass@gmail.com>
-
metabase-bot[bot] authored
* Add :timezone key to database metadata (#36413) * Add timezone to database metadata * Use UTC as _user timezone_ for snowflake driver * Use user timezone as db-default-timezone * Update oracles unprepare-value to handle Z UTC * Update `driver/db-default-timezone :h2` to use jvm timezone * Update containers timezone to match instance timezone and tests * Update modules/drivers/oracle/src/metabase/driver/oracle.clj Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Make unprepare symmetric for offset and zoned datetime --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> * Adjust e2e for US/Pacific timezone instead of offset --------- Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
metabase-bot[bot] authored
* Fix salt in pulse unsub hash * Workaround for read-only settings not supporting temp overrides yet Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
Ensure we read and update nested JSON in a transaction Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
- Introduce an "init" hook for application settings. - Add guards against introducing race conditions again in other ways. - Fix the usage of hygienic scope macros with read only settings. - Lots of misc improvements to settings API and implementation. This init hooks better ergonomics, and protects against race conditions. The previous pattern of calling setters inside getters almost caused a P0. See https://github.com/metabase/metabase/issues/37801 . Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-