This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 06, 2024
-
-
metabase-bot[bot] authored
* Fixing static-viz exports of saved x-ray dashboards When dashboards were generated with x-rays, the `:visualization_settings` were not properly filled in. In particular, the `:graph.dimensions` and `:graph.metrics` were being populated from either the raw template values or not at all. The following namespace demonstrates this: ```clojure (ns tickets.38350-broken-xray-export (:require [dev.render-png :as render-png] [metabase.models :refer [Card]] [metabase.test :as mt])) (mt/dataset test-data (mt/with-temp [Card {bad-card-id :id} {:display :row :dataset_query {:database (mt/id) :type :query :query {:source-table (mt/id :orders) :aggregation [[:count]] :breakout [[:field (mt/id :products :category) {:source-field (mt/id :orders :product_id)}]]}} :visualization_settings {:graph.series_labels [nil] :graph.dimensions [{:ProductCategoryMedium {}}] :graph.colors ["#EF8C8C"] :graph.metrics [nil]}} Card {good-card-id :id} {:display :row :dataset_query {:database (mt/id) :type :query :query {:source-table (mt/id :orders) :aggregation [[:count]] :breakout [[:field (mt/id :products :category) {:base-type :type/Text :source-field (mt/id :orders :product_id)}]]}} :visualization_settings {:graph.dimensions ["CATEGORY"] :graph.metrics ["count"]}}] (render-png/render-card-to-png bad-card-id) (render-png/render-card-to-png good-card-id))) ``` The FE seemed to have some level of error checking and was robust enough to recover from these bad `:visualization_settings`. The solution is to correctly populate these values. This required updating the `:dimension-name->field` value in each card to include mappings derived from both metrics and dimensions and then using the right logic in the `visualization-settings` function. * Removed unneeded `->legacy-MBQL` on values in `:mbql/query` dispatch (cherry picked from commit ee1581fb) Co-authored-by:
Mark Bastian <markbastian@gmail.com>
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
This is at the `metabase.lib.js` level. Should help solve some performance issues where eg. `expressionable-columns` was getting called on every keystroke for autocomplete; see #37528. Powered by `metabase.lib.cache/side-channel-cache`, which attaches the cache in an Atom on a private property mutated onto the `query`. That means it is invalidated with any edit to the query (since a new object is returned) and becomes garbage at the same time the query does. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Feb 05, 2024
-
-
metabase-bot[bot] authored
* add Hebrew support Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Feb 02, 2024
-
-
metabase-bot[bot] authored
- refactor fix to match the old functionality of trend charts - add test to verify the fix works as expected * auto-adjust native query dates to be at the start of the date range * re-work trend charts compute function to handle updated native query date formatting * add test to validate the native query date formatting * fix unit tests * reorganize test Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
Kamil Mielnik authored
* Handle changing database in DataStep * Add e2e test for metabase#38354 * Add external tag, fix ORDERS_ID
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Luis Paolini <paoliniluis@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
- Feb 01, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Makes sure we pass the parameter values to the question when running it after a user reverts to an older version. Resolves metabase#38176. * Pass correct shape of parameters to question * Add reproduction for #38176, where a reverted question does not use the parameters * Reduce paramterValues to the correct format instead of using internal field * Add issue specifier to test * Create test question with relevant name * Avoid setting delay on input * Fix text in cell * Simplify selectors for button * Add comment on parameterValues building --------- Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
On version 4.8 metabase version 9.4 is not supported Co-authored-by:
Tony-metabase <110378427+Tony-metabase@users.noreply.github.com> Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
- Jan 31, 2024
-
-
metabase-bot[bot] authored
I misunderstood the desired behavior when I implemented this before. We only want the limit to apply when the `add-default-userland-constraints` middleware is applied to the query, not when we're downloading the data directly. This is a bit of a rat's nest. If there's a better way to approach the problem, I'd be happy to hear it. I added documentation for the odd approach as much as possible. The main difficulty is that the userland middleware does not have access to db-local settings. So if we want db-local settings to apply only to userland, we have to hack our way around it. The solution here is to divide the userland middleware into two parts: - the actually-userland bit, which just marks the query as needing default limits, and - a middleware inserted deeper in the middleware stack (just before we actually apply limits) that actually calculates those limits and attaches them to the query. Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
* Reproduction: Run selected text does not use parameter values correctly * Use question instead of card when overriding * Switch to overrideWithQuestion in RELOAD_CARD * Rename run to dataset in e2e test * Use cypress builtins instead of custom selectors * Remove async from e2e test * Avoid assigning editor to variable * Type closing }} on editor * Set type delay to 0 * Add explainer about why the reproduction differs from the issue * Add limit to test case * Test actual vizualisation results instead of implementation detauls of dataset * Clarify that the space is not needed * Simplify cypress check Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
- Jan 30, 2024
-
-
metabase-bot[bot] authored
* Cast to timestamp before truncating The shift according to the timezone after the truncation can produce values not at the beginning of the truncation period. * Separate handling of time and date inputs * Add test reproducing issue #37065 Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
metabase-bot[bot] authored
* Do not use `async` functions as Cypress tests * Add eslint rule that enforces no `async` functions * Skip broken tests (created a follow up issue for this: https://github.com/metabase/metabase/issues/38258 ) Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Jan 29, 2024
-
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
* Display chart caption even where there is no card title (#36801) * Display chart caption even where there is no card title * Add E2E reproduction for #36788 * Adapt the test for the release 48 branch --------- Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
- Jan 26, 2024
-
-
metabase-bot[bot] authored
* Chain filter search should check block perms * Simplify test Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
metabase-bot[bot] authored
* Field values cache needs to check permissions (#38104) * Field values cache needs to check permissions If a user does not have permissions to the field, we should not return the cached field values. * Update default-get-or-create-field-values-for-current-user to check can-read too * Revert params.field-values change * Use query processor permissions checks before returning cached values * Return true from check * Fix test * Check for ee config * Fix merge issue --------- Co-authored-by:
Case Nelson <case@metabase.com>
-
Nemanja Glumac authored
Fixes #36734.
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
CVE updates: lambdaisland/uri, aws sdk (drop ions), specify guava for googleanalytics (#38118) (#38141) Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metabase-bot[bot] authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
- Jan 25, 2024
-
-
metabase-bot[bot] authored
switch to regenerator-runtime and update follow-redirects to silence Snyk warnings (#38124) (#38164) * switch to regenerator-runtime and update glob to silence Snyk warnings * no glob update * update follow-redirects * lets update debug as well Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metabase-bot[bot] authored
* Fix NPE in schema pattern matching fns in sync * Require PG Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
metabase-bot[bot] authored
* Fix Snowflake sync not returning all schemas regression in 48+ * Fix extra whitespace * Better DB name * Improved test Co-authored-by:
Cam Saul <1455846+camsaul@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Kyle Doherty <5248953+kdoh@users.noreply.github.com>
-