This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Feb 22, 2024
-
-
Cal Herries authored
Co-authored-by:
Case Nelson <case@metabase.com>
-
- Feb 21, 2024
-
-
adam-james authored
* Do not create param_values on Dashboard Load, only fetch if they exist (#38980) * Do not fetch param_values on Dashboard Load Fixes: #38826 This change removes the *-or-create* behaviour of `field-ids->param-field-values`. This means that on Dashboard Load, if the param values already exist, they'll be grabbed. But, if they don't, we won't try to fetch or create them. This is WIP because it seems to contradict changes related to fixing #30218 * Comment out the other test added for #30218 * Remove the tests from 30218 These tests are asserting that param_values are created on dashboard load when the Field Values don't exist. This is the behaviour we want to revert, so the tests are asserting something we don't want anymore. * Improved test string wording * Update src/metabase/models/params.clj Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Add the refactored fns that were used to solve 38826 * empty commit to try re-start CI --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Feb 16, 2024
-
-
metamben authored
Fixes #30454 for x.48.x.
-
metabase-bot[bot] authored
* Update test * Remove driver exclusions Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com>
-
- Feb 13, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
- Feb 12, 2024
-
-
metabase-bot[bot] authored
- do the unzip sooner, still hash from the file system - java-time -> java-time.api Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
metabase-bot[bot] authored
Sometimes analytics bits get removed by other tests (e.g. deleting all cards, dashboards, users, etc.). When we run `ensure-audit-db-installed!`, though, the checksum hasn't changed (since the underlying analytics files didn't change), so we skip reloading the data. This sets `last-analytics-checksum` to `-1` (meaning: skip the checksum and just load the analytics data) when running `ensure-audit-db-installed!` in the tests that we've seen flake. Co-authored-by:
Bryan Maass <bryan.maass@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Luis Paolini <paoliniluis@gmail.com> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
metabase-bot[bot] authored
* load analytics only when changed using a checksum (#38280) * load analytics only when changed using a checksum - over audit deserialization files * update docstrings * fix testing wording * remove :export? It won't get exported because it's not in `metabase.models.setting/exported-settings`. --------- Co-authored-by:
bryan <bryan.maass@gmail.com>
-
metabase-bot[bot] authored
* Fix time-interval against expressions When simplifying time-interval filters, we forgot to place a temporal-unit on expressions, which meant that the date-trunc used by quarters had to match the date exactly rather than being in the interval range. * Update optimize temporal filters for expressions There is a dependency with this middleware and mongo. Without optimization mongo cannot compare the bucketed timestamps because AFAICT mongo 4 doesn't have date truncation so we do so in clojure for the compared literal but cannot do the lhs field/expression. Co-authored-by:
Case Nelson <case@metabase.com> Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
metabase-bot[bot] authored
* Compare datetimes w/o timezone fields with literals as strings Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
metabase-bot[bot] authored
* Fix custom destination to public dashboard not working on static embedding (#38647) * Fix linking to public or embed resource on dashboards not working * Update embedding test name to use a snazzier term * Add tests * Add missing test util from 49 --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
- Feb 09, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Thomas Schmidt <somtom91@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
- Feb 07, 2024
-
-
metabase-bot[bot] authored
* Update default Metabot model The default GPT-based Metabot model has been `"gpt-4"`. This model is no longer state of the art, has a limit of 8,192 tokens, and is priced at input: $0.03/ktoken and output: $0.06/ktoken. `"gpt-4-turbo-preview"`, which points internally to `"gpt-4-0125-preview"` is the current state of the art, has a limit of 128,000 tokens, and is priced at input: $0.01/ktoken and output: $0.03/ktoken. This should solve any issues of reasonable cases of token limit failures (e.g. [Metabot 2.0 failing when context length exceeded](https://github.com/metabase/metabase/issues/29932)) without needing to do any extra handling on the backend. For more info on the models, token limits, and pricing, see: - [OpenAI model docs](https://platform.openai.com/docs/models/gpt-4-and-gpt-4-turbo) - [OpenAI pricing](https://openai.com/pricing ) * whitespace * Removing irrelevant settings test Co-authored-by:
Mark Bastian <markbastian@gmail.com>
-
metabase-bot[bot] authored
* Fix ESlint rules (#38458) * Fix ESlint from the result of upgrading ESLint package * Support `component` prop on Mantine * Prevent accidental ESLint log in Cypress * Upgrade ESLint rule * Fix ESLint --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by:
Mahatthana Nomsawadi <mahatthana.n@gmail.com>
-
metabase-bot[bot] authored
add a comment about enterprise version Co-authored-by:
Luis Paolini <paoliniluis@gmail.com>
-
- Feb 06, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
adam-james authored
* Add internal setting for table render row limit (#36996) * Add internal setting for table render row limit This change will keep default behaviour of a 10 row limit but allow users to set an env variable to change this default. * test that table render row limits can be adjusted w/ env var. Add a test that shows the table render respects the default 10 row limit, and also show that if the user uses the environment variable `MB_ATTACHMENT_TABLE_ROW_LIMIT`, then they can change the row limit. * Explicitly unset env. var in the test so it truly tests the default * Adjust :getter for setting so that defaults are used appropriately * Fix tests that expected exact text matches on some hiccup nodes * New default of 20. * Add a limit of 100 to the rows and add a test for it too. * Keep rows-limit def but set it to use the public-setting * Fix up settings tests
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
[E2E] Overload the existing E2E `visitDashboard` helper to make it work with the alias (#38309) (#38473) * Add `visitDashboardAlias` E2E helper * Overload `visitDashboard` helper It should work with either dashboard id, or with a dashboard id alias. * PoC: Use overloaded `visitDashboard` helper * Update even more tests with the overloaded `visitDashboard` helper * Use `cy.visit` for tests with `cy.clock` instead of a custom helper * Rename non-exported functions Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
metabase-bot[bot] authored
Adding `r.metadata.source.branch === "master" &&` to `randomlyUploadAll` for master-only uploads. Also adding more info to log message. (cherry picked from commit ab9ede8e) Co-authored-by:
Mark Bastian <markbastian@gmail.com>
-
metabase-bot[bot] authored
* Fixing static-viz exports of saved x-ray dashboards When dashboards were generated with x-rays, the `:visualization_settings` were not properly filled in. In particular, the `:graph.dimensions` and `:graph.metrics` were being populated from either the raw template values or not at all. The following namespace demonstrates this: ```clojure (ns tickets.38350-broken-xray-export (:require [dev.render-png :as render-png] [metabase.models :refer [Card]] [metabase.test :as mt])) (mt/dataset test-data (mt/with-temp [Card {bad-card-id :id} {:display :row :dataset_query {:database (mt/id) :type :query :query {:source-table (mt/id :orders) :aggregation [[:count]] :breakout [[:field (mt/id :products :category) {:source-field (mt/id :orders :product_id)}]]}} :visualization_settings {:graph.series_labels [nil] :graph.dimensions [{:ProductCategoryMedium {}}] :graph.colors ["#EF8C8C"] :graph.metrics [nil]}} Card {good-card-id :id} {:display :row :dataset_query {:database (mt/id) :type :query :query {:source-table (mt/id :orders) :aggregation [[:count]] :breakout [[:field (mt/id :products :category) {:base-type :type/Text :source-field (mt/id :orders :product_id)}]]}} :visualization_settings {:graph.dimensions ["CATEGORY"] :graph.metrics ["count"]}}] (render-png/render-card-to-png bad-card-id) (render-png/render-card-to-png good-card-id))) ``` The FE seemed to have some level of error checking and was robust enough to recover from these bad `:visualization_settings`. The solution is to correctly populate these values. This required updating the `:dimension-name->field` value in each card to include mappings derived from both metrics and dimensions and then using the right logic in the `visualization-settings` function. * Removed unneeded `->legacy-MBQL` on values in `:mbql/query` dispatch (cherry picked from commit ee1581fb) Co-authored-by:
Mark Bastian <markbastian@gmail.com>
-
metabase-bot[bot] authored
-
metabase-bot[bot] authored
This is at the `metabase.lib.js` level. Should help solve some performance issues where eg. `expressionable-columns` was getting called on every keystroke for autocomplete; see #37528. Powered by `metabase.lib.cache/side-channel-cache`, which attaches the cache in an Atom on a private property mutated onto the `query`. That means it is invalidated with any edit to the query (since a new object is returned) and becomes garbage at the same time the query does. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- Feb 05, 2024
-
-
metabase-bot[bot] authored
* add Hebrew support Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- Feb 02, 2024
-
-
metabase-bot[bot] authored
- refactor fix to match the old functionality of trend charts - add test to verify the fix works as expected * auto-adjust native query dates to be at the start of the date range * re-work trend charts compute function to handle updated native query date formatting * add test to validate the native query date formatting * fix unit tests * reorganize test Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
Kamil Mielnik authored
* Handle changing database in DataStep * Add e2e test for metabase#38354 * Add external tag, fix ORDERS_ID
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-