Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Feb 22, 2024
  2. Feb 21, 2024
    • adam-james's avatar
      Backport 38826 to 48 (#39023) · 95ad5d4e
      adam-james authored
      
      * Do not create param_values on Dashboard Load, only fetch if they exist (#38980)
      
      * Do not fetch param_values on Dashboard Load
      
      Fixes: #38826
      
      This change removes the *-or-create* behaviour of `field-ids->param-field-values`. This means that on Dashboard Load,
      if the param values already exist, they'll be grabbed. But, if they don't, we won't try to fetch or create them.
      
      This is WIP because it seems to contradict changes related to fixing #30218
      
      * Comment out the other test added for #30218
      
      * Remove the tests from 30218
      
      These tests are asserting that param_values are created on dashboard load when the Field Values don't exist. This is
      the behaviour we want to revert, so the tests are asserting something we don't want anymore.
      
      * Improved test string wording
      
      * Update src/metabase/models/params.clj
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
      
      * Add the refactored fns that were used to solve 38826
      
      * empty commit to try re-start CI
      
      ---------
      
      Co-authored-by: default avatarNgoc Khuat <qn.khuat@gmail.com>
  3. Feb 16, 2024
  4. Feb 13, 2024
  5. Feb 12, 2024
  6. Feb 09, 2024
  7. Feb 07, 2024
  8. Feb 06, 2024
  9. Feb 05, 2024
  10. Feb 02, 2024
Loading