Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Jun 03, 2024
    • github-automation-metabase's avatar
      Show the columns for the correct stage when using combine/extract in the... · 7a8b73e2
      github-automation-metabase authored
      Show the columns for the correct stage when using combine/extract in the presence of an aggregation (#43226) (#43450)
      
      * Do not use asReturned to determine columns for extractions and combine columns
      
      * Add reproduction for #43226 for combine columns
      
      * Add reproduction for #43226 for extract columns
      
      * Remove commented out code
      
      * Only render extraction shortcut when there are extractions
      
      * Only render combination shortcut when there are combinations
      
      * Use hasCombinations from CombineColumns
      
      * Add hasExtractions from ExtractColumn
      
      * Use appendStageIfAggregated over Lib.asReturned
      
      * Only show combine column shortcut when there are two or more columns to be combined
      
      * Lift appendStageIfAggregated to top-level drill
      
      * Add test for extraction on table with just breakout
      
      * Add test for combinations on table with just breakouts
      
      * Disable the 2-column requirement for combinations
      
      * Remove Lib.asReturned in appendStageIfAggregated
      
      * Remove + 1 to stageIndex in appendStageIfAggregated
      
      * Check for empty breakouts too in as-returned
      
      * Switch back to Lib.asReturned
      
      * Fix test for combine column on breakouts
      
      * Reference the correct query and stageIndex
      
      * add CLJS unit tests for as-returned with only aggs, breakouts
      
      ---------
      
      Co-authored-by: default avatarRomeo Van Snick <romeo@romeovansnick.be>
      Co-authored-by: default avatarBraden Shepherdson <braden@metabase.com>
    • github-automation-metabase's avatar
      Fix unit tests running multiple times in watch mode (#43445) (#43448) · 481ae835
      github-automation-metabase authored
      
      * Fix unit tests running multiple times in watch mode
      
      * Ignore even more
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
  2. Jun 01, 2024
    • github-automation-metabase's avatar
      Fix data labels too dense with large single series (#42985) (#43486) · 3d4732c4
      github-automation-metabase authored
      
      * remove unused variable
      
      * conditionally render labels sparsely if large amount of data points
      
      * update loki snapshots
      
      * refactor data label formatter conditions
      
      * setup intelligent label plotting
      
      * handle the case when there are no labels
      
      * add sparse data label rendering to bar charts
      
      * do not compute if no labels need to be shown or hidden
      
      * add sparse data labeling to waterfall charts
      
      * adjustment for large series waterfall labels
      
      * revert change
      
      * refactor name
      
      * add sparse labels to stacked bar and area
      
      * improve scaleFactor
      
      * fix type errors
      
      * remove unused labelFormatter
      
      * update snapshots
      
      * patch ECharts
      
      - labels with no text, i.e. "", were still being considered as plot-able labels which was causing labels with real text "asdfec.." to be hidden because of overlap.
      - This patch makes it so that labels with no text, i.e. "", are not considered to be candidates for overlap checking.
      
      * update loki snapshots
      
      * only loop over dataset once for getWaterfallChartDataDensity
      
      * improve performance of chart data density calculations
      
      * update loki snapshots
      
      * update E2E spec
      
      * update E2E spec
      
      * increase cartesian label density allotment
      
      * update loki snapshots
      
      * update loki snapshots
      
      * comment out node_modules cache since it cannot be skipped by commit and is breaking CI
      
      * fix type errors
      
      * Reset node modules if patches are changed
      
      * refactor type naming
      
      ---------
      
      Co-authored-by: default avatarJesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
      Co-authored-by: default avatarUladzimir Havenchyk <uladzimir.dev@gmail.com>
      Co-authored-by: default avatarUladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
  3. May 31, 2024
  4. May 30, 2024
  5. May 29, 2024
Loading