Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 05, 2024
    • github-automation-metabase's avatar
      fix: mongo ObjectId should be orderable (#46501) (#46503) · 8a8c0494
      github-automation-metabase authored
      
      * fix: mongo ObjectId should be orderable
      
      Fixes #46259
      
      Mongo ObjectId derive :type/TextLike but that can't be an orderable
      type, so we mark the specific Mongo type as orderable for malli schemas.
      
      * Fix test
      
      Co-authored-by: default avatarCase Nelson <case@metabase.com>
      2 tags
      8a8c0494
    • github-automation-metabase's avatar
    • Sloan Sparger's avatar
    • github-automation-metabase's avatar
      fix db switching in ts/with-dbs (#46481) (#46490) · b27df2a7
      github-automation-metabase authored
      
      mt/with-temp opens transaction which is used by toucan to make requests, so `mt/with-db` had no impact on database used inside of mt/with-temp
      
      Co-authored-by: default avatarAlexander Solovyov <alexander@solovyov.net>
      b27df2a7
    • Kamil Mielnik's avatar
      Manual backport - #46322 - "Reset all filters" button (#46486) · 1b358551
      Kamil Mielnik authored
      * Cherry pick changes
      
      * Remove unit of time parameters tests
      
      * Downgrade tests to v50 behavior
      
      * Remove unit of time test
      1b358551
    • github-automation-metabase's avatar
      🤖 backported "Update "Clear" and "Reset" buttons" (#46473) · a0eeb46a
      github-automation-metabase authored
      * Update "Clear" and "Reset" buttons (#46050)
      
      * Refactor dashboard helpers to TypeScript
      
      * Reuse existing helper
      
      * Refactor cy.createQuestionAndDashboard to a function helper
      - there was no good place to put it, so I also created new helpers/api directory
      - and I moved all helpers using cy.request (with 1 exception, where a CSV download helper also does a bunch of assertions) in there
      
      * Merge TS command definitions into a single file
      
      * Export types
      
      * Make dashboardDetails optional
      
      * Export StructuredQuestionDetails
      
      * Remove duplicated function
      
      * Extract createNativeQuestion to separate file
      - 1 exported helper per file, no exceptions!
      
      * Reuse const
      
      * Add test for unit of time parameters
      
      * Improve assertions
      
      * Extract createDashboardWithParameters
      
      * Add tests for time parameters
      
      * Fix hardcoded parameter_mappings ids
      
      * Format code
      
      * Extract checkButtonVisible
      
      * Improve test names
      
      * Add tests for location parameters
      
      * Reuse const
      
      * Update test name
      
      * Add WidgetStatusButton
      
      * Add unit tests for WidgetStatusButton
      
      * Rename handler
      
      * Remove redundant assertions
      
      * Add iconSize prop
      
      * Fix styling
      
      * Replace WidgetStatusIcon with WidgetStatusButton
      - Remove WidgetStatusIcon
      
      * Fix tooltip issue
      
      * Fix tooltip for good
      
      * Use default compact button size
      
      * Prevent overflow
      
      * Fix alignment issues in parameter sidebar
      - Remove iconSize prop
      - Simplify StatusConfig
      
      * Update padding in Unit of Time input to make it consistent with other inputs in dashboard parameter sidebar
      
      * Update unit tests
      
      * Rename WidgetStatusButton to WidgetStatus
      
      * Explicitly specify what is a button
      
      * Update helpers in tests
      
      * Update when buttons are displayed according to the new spec, update tests
      
      * Simplify label
      
      * Remove utils
      
      * Adjust padding
      
      * Update reset icon
      
      * Make the button gray when color is undesired
      
      * Remove old definitions
      
      * Add missing export
      
      * Remove unused type
      
      * Add test for location (single value)
      
      * Add test for id (single value)
      
      * Add more assertions
      
      * Add test for id (multiple values)
      
      * Improve name
      
      * Add tests for number (single and multi value)
      
      * Add tests for text (single and multi value)
      
      * Rename file
      
      * Update comment
      
      * Update test name
      
      * Use unique ids
      
      * Use new color name
      
      * Add a test for chevron icons alignment
      
      * Lift className up
      
      * Make types more specific
      
      * Sort attributes
      
      * Revert "Make types more specific"
      
      This reverts commit 2e6994b5.
      
      * Revert "Use new color name"
      
      This reverts commit 2cc68df6.
      
      * Remove TODO
      
      * Introduce editFilter util, refactor chevron assertions to work with any number of chevrons
      
      * Connect label to the default value input in ParameterSettings
      
      * Add a whitespace in the default value label when required "(required)" is shown
      
      * Add parameter sidebar tests for unit of time
      
      * Add parameter sidebar tests for date filters
      
      * Extract checkParameterSidebarDefaultValue
      
      * Add parameter sidebar tests for location - single values
      
      * Add parameter sidebar tests for location - multiple values
      
      * Use constants for test case names
      
      * Add parameter sidebar tests for id parameters - single values
      
      * Add parameter sidebar tests for id parameters - multi values
      
      * Add parameter sidebar tests for number parameters - single values
      
      * Add parameter sidebar tests for number parameters - multi values
      
      * Add parameter sidebar tests for text parameters - single values
      
      * Add parameter sidebar tests for text parameters - multi values
      
      * Extract checkDashboardFilters
      
      * Use checkDashboardFilters in time parameters
      
      * Use checkParameterSidebarDefaultValue in checkDashboardFilters
      
      * Use checkDashboardFilters everywhere
      
      * Sort helpers
      
      * Rename checkDashboardFilters to checkDashboardParameters
      
      * Rename checkOnlyOneButtonVisible to checkStatusIcon
      
      * Add test suite for sql filters, coverage for text filter - single value
      
      * Add a whitespace in the default value label when required "(required)" is shown - SQL filters
      - Similar to 930dd3a5
      
      * Add test suite for sql filters, coverage for number filters
      
      * Add test for sql filters - date
      
      * Remove unused things, rename placeholder to labelOrPlaceholder
      
      * Apply label only to 1 input
      
      * Add test for sql filters - field parameters
      
      * Fix date tests
      
      * Make all sql filters tests work
      
      * Add assertions for required without default in text filters
      
      * Add assertions for required without default in date filters
      
      * Add assertions for required without default in field filters
      
      * Allow clearing required SQL filters without default value
      
      * Add a test to ensure comma-separated numeric values work
      
      * Update unit test
      
      * Update helper
      
      * Update e2e tests
      
      * Use != null and == null checks with defaultValue instead of just checking if its truthy/falsy
      
      * Run `yarn test-visual:loki` and then `yarn loki approve`
      - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069
      
      * Use parameterHasNoDisplayValue to account for empty strings
      
      * Run `yarn test-visual:loki` and then `yarn loki approve` after merging master
      - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069
      
      * Run `yarn test-visual:loki` and then `yarn loki approve`
      - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069
      
      * Run `yarn test-visual:loki` and then `yarn loki approve`
      - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069
      
      
      
      * Remove unit of time parameters tests
      
      * Downgrade tests to v50 behavior
      
      * Downgrade tests to v50 behavior
      
      * Remove unit of time test
      
      ---------
      
      Co-authored-by: default avatarKamil Mielnik <kamil@kamilmielnik.com>
      a0eeb46a
    • github-automation-metabase's avatar
    • github-automation-metabase's avatar
  2. Aug 02, 2024
  3. Aug 01, 2024
  4. Jul 31, 2024
  5. Jul 30, 2024
Loading