This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Aug 05, 2024
-
-
github-automation-metabase authored
* fix: mongo ObjectId should be orderable Fixes #46259 Mongo ObjectId derive :type/TextLike but that can't be an orderable type, so we mark the specific Mongo type as orderable for malli schemas. * Fix test Co-authored-by: Case Nelson <case@metabase.com>
-
github-automation-metabase authored
-
Sloan Sparger authored
-
github-automation-metabase authored
mt/with-temp opens transaction which is used by toucan to make requests, so `mt/with-db` had no impact on database used inside of mt/with-temp Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
-
Kamil Mielnik authored
* Cherry pick changes * Remove unit of time parameters tests * Downgrade tests to v50 behavior * Remove unit of time test
-
github-automation-metabase authored
* Update "Clear" and "Reset" buttons (#46050) * Refactor dashboard helpers to TypeScript * Reuse existing helper * Refactor cy.createQuestionAndDashboard to a function helper - there was no good place to put it, so I also created new helpers/api directory - and I moved all helpers using cy.request (with 1 exception, where a CSV download helper also does a bunch of assertions) in there * Merge TS command definitions into a single file * Export types * Make dashboardDetails optional * Export StructuredQuestionDetails * Remove duplicated function * Extract createNativeQuestion to separate file - 1 exported helper per file, no exceptions! * Reuse const * Add test for unit of time parameters * Improve assertions * Extract createDashboardWithParameters * Add tests for time parameters * Fix hardcoded parameter_mappings ids * Format code * Extract checkButtonVisible * Improve test names * Add tests for location parameters * Reuse const * Update test name * Add WidgetStatusButton * Add unit tests for WidgetStatusButton * Rename handler * Remove redundant assertions * Add iconSize prop * Fix styling * Replace WidgetStatusIcon with WidgetStatusButton - Remove WidgetStatusIcon * Fix tooltip issue * Fix tooltip for good * Use default compact button size * Prevent overflow * Fix alignment issues in parameter sidebar - Remove iconSize prop - Simplify StatusConfig * Update padding in Unit of Time input to make it consistent with other inputs in dashboard parameter sidebar * Update unit tests * Rename WidgetStatusButton to WidgetStatus * Explicitly specify what is a button * Update helpers in tests * Update when buttons are displayed according to the new spec, update tests * Simplify label * Remove utils * Adjust padding * Update reset icon * Make the button gray when color is undesired * Remove old definitions * Add missing export * Remove unused type * Add test for location (single value) * Add test for id (single value) * Add more assertions * Add test for id (multiple values) * Improve name * Add tests for number (single and multi value) * Add tests for text (single and multi value) * Rename file * Update comment * Update test name * Use unique ids * Use new color name * Add a test for chevron icons alignment * Lift className up * Make types more specific * Sort attributes * Revert "Make types more specific" This reverts commit 2e6994b5. * Revert "Use new color name" This reverts commit 2cc68df6. * Remove TODO * Introduce editFilter util, refactor chevron assertions to work with any number of chevrons * Connect label to the default value input in ParameterSettings * Add a whitespace in the default value label when required "(required)" is shown * Add parameter sidebar tests for unit of time * Add parameter sidebar tests for date filters * Extract checkParameterSidebarDefaultValue * Add parameter sidebar tests for location - single values * Add parameter sidebar tests for location - multiple values * Use constants for test case names * Add parameter sidebar tests for id parameters - single values * Add parameter sidebar tests for id parameters - multi values * Add parameter sidebar tests for number parameters - single values * Add parameter sidebar tests for number parameters - multi values * Add parameter sidebar tests for text parameters - single values * Add parameter sidebar tests for text parameters - multi values * Extract checkDashboardFilters * Use checkDashboardFilters in time parameters * Use checkParameterSidebarDefaultValue in checkDashboardFilters * Use checkDashboardFilters everywhere * Sort helpers * Rename checkDashboardFilters to checkDashboardParameters * Rename checkOnlyOneButtonVisible to checkStatusIcon * Add test suite for sql filters, coverage for text filter - single value * Add a whitespace in the default value label when required "(required)" is shown - SQL filters - Similar to 930dd3a5 * Add test suite for sql filters, coverage for number filters * Add test for sql filters - date * Remove unused things, rename placeholder to labelOrPlaceholder * Apply label only to 1 input * Add test for sql filters - field parameters * Fix date tests * Make all sql filters tests work * Add assertions for required without default in text filters * Add assertions for required without default in date filters * Add assertions for required without default in field filters * Allow clearing required SQL filters without default value * Add a test to ensure comma-separated numeric values work * Update unit test * Update helper * Update e2e tests * Use != null and == null checks with defaultValue instead of just checking if its truthy/falsy * Run `yarn test-visual:loki` and then `yarn loki approve` - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069 * Use parameterHasNoDisplayValue to account for empty strings * Run `yarn test-visual:loki` and then `yarn loki approve` after merging master - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069 * Run `yarn test-visual:loki` and then `yarn loki approve` - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069 * Run `yarn test-visual:loki` and then `yarn loki approve` - see https://metaboat.slack.com/archives/C505ZNNH4/p1721289287037069 * Remove unit of time parameters tests * Downgrade tests to v50 behavior * Downgrade tests to v50 behavior * Remove unit of time test --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
-
github-automation-metabase authored
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
-
- Aug 02, 2024
-
-
github-automation-metabase authored
* fix pivot table missing horizontal scroll * spec * Update Loki Snapshots --------- Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by: Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
-
github-automation-metabase authored
-
github-automation-metabase authored
* Update values-from-card-query * Add test * Update values-from-card-query * Add missing issue no Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com>
-
github-automation-metabase authored
* fix viz settings not persisted during question edit (#46308) * fix lost settings * add e2e test * trigger ci * fix e2e test * fix lint --------- Co-authored-by: Emmad Usmani <emmadusmani@berkeley.edu>
-
github-automation-metabase authored
* fix db connection form icons (#46290) * fix db connection form icons * fix db connection form icons * appease typescript * update tooltip helper for v50 --------- Co-authored-by: Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by: Ryan Laurie <iethree@gmail.com>
-
github-automation-metabase authored
This reverts commit c7a5aee1. Co-authored-by: John Swanson <john.swanson@metabase.com>
-
github-automation-metabase authored
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* do not update size if width or height is 0 * add a comment Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
* link fixes * more links Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* updates the ordering of create queries permissions options so that granular permissions is the last option * fix unit test * move granular option above no Co-authored-by: Sloan Sparger <sloansparger@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
-
github-automation-metabase authored
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
-
github-automation-metabase authored
* Avoid adding temporal-unit to lhs cols * Use :default temporal-unit * Simplify logic, update comments * Update substitute-field-filter-test * Update align-temporal-unit-with-param-type-test * Update field-filter-date-test * Use end-excludding gte lt filter for DateTime fields * Update substitute-field-filter-test * Update align-temporal-unit-with-param-type-test * Update field-filter-date-test * Update bigquery test + comment * Update date-str->qp-aware-offset-dt * Add guard for unexpected date string format This is just for the completeness, I haven't encountered it. * Address review remarks * Update comment Co-authored-by: lbrdnk <lbrdnk@users.noreply.github.com>
-
github-automation-metabase authored
Previously we unpacked everything and picked up first entry as the directory containing the data. This works well when archives are passed as is. However, if a user unpacks and then packs an archive, there is a good chance that some hidden directories will appear - and they are first in order. So we skip those right now, and additionally check known markers of the serialization data directory. Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
-
- Aug 01, 2024
-
-
github-automation-metabase authored
* dismiss permissions modal regardless of network request * Spelling is hard Co-authored-by: Nick Fitzpatrick <nick@metabase.com>
-
github-automation-metabase authored
Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
-
github-automation-metabase authored
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
-
- Jul 31, 2024
-
-
github-automation-metabase authored
* Add new strings for v50.15 * import updated translations --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Ryan Laurie <iethree@gmail.com>
-
github-automation-metabase authored
Co-authored-by: Gustavo Saiani <gus@metabase.com>
-
github-automation-metabase authored
Co-authored-by: Raphael Krut-Landau <raphael.kl@gmail.com>
-
github-automation-metabase authored
Since I set auto-merge to #45691, I missed some bits of review feedback. Luckily, nothing was blocking, so these are small readability/docs changes Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by: Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
Co-authored-by: Alex Yarosh <alexandra@metabase.com>
-
github-automation-metabase authored
Co-authored-by: Metabase bot <metabase-bot@metabase.com>
-
github-automation-metabase authored
Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* Use function helpers * Only assert the resize down * Refactor repro 31701 * Remove flaky tag * Better organize describe blocks * Move custom `requestTimeout` config to the common block for resizing tests Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
-
- Jul 30, 2024
-
-
github-automation-metabase authored
🤖 backported "fix(admin/nav): Ensure that the "Exit admin" button can be clicked regardless of locale or viewport size" (#46171) Closes #45876 Co-authored-by: Raphael Krut-Landau <raphael.kl@gmail.com> -
github-automation-metabase authored
* Indicate in-progress exports (#45697) * indicate in-progress exports * specs, public dashboards * add onbeforeunload hook when uploads are in-progress * fix resolving conflicts --------- Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>
-