Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Aug 21, 2024
  2. Aug 20, 2024
  3. Aug 19, 2024
  4. Aug 18, 2024
  5. Aug 16, 2024
  6. Aug 15, 2024
    • github-automation-metabase's avatar
      🤖 backported "Add Timeseries insights even when Custom Columns exist" (#46742) · 64d1a8ad
      github-automation-metabase authored
      
      * Add Timeseries insights even when Custom Columns exist (#46253)
      
      * Add Timeseries insights even when Custom Columns exist
      
      WIP
      
      Fixes 46244
      
      I don't know why it was (maybe still is) required that the :other columns be empty before providing insights.
      
      * might be a solution to changing trendlines when data doesn't change
      
      The insights code that powers the frontend trendline requires taking a sample of the dataset.
      
      This sampling has some randomness associated by design, and should maintain its randomness. But it makes some sense to
      use the exact same sample when the input has not changed at all, hence trying this memoize approach out.
      
      Might not be the final solution, but it's a start
      
      * add test to show that insights are computed
      
      * use java.util.random with a seed to keep insights stable
      
      * fix failing e2e test
      
      I don't understand why other runs on the release branch have been passing this? But in any case, I've copied this
      change from master to fix it.
      
      ---------
      
      Co-authored-by: default avataradam-james <21064735+adam-james-v@users.noreply.github.com>
      Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
      2 tags
      64d1a8ad
    • github-automation-metabase's avatar
      skip some troubleshooting stats when hosted (#46749) (#46899) · dcd17d88
      github-automation-metabase authored
      
      * skip some troubleshooting stats when hosted
      
      * fix typo
      
      * just skip "system-info" and "app db details"
      
      Co-authored-by: default avatarbryan <bryan.maass@gmail.com>
      dcd17d88
    • John Swanson's avatar
      Allow disabling encryption for settings (#43085) (#46773) · b28675d6
      John Swanson authored
      * Allow disabling encryption for settings
      
      For two settings, we want to disable encryption entirely.
      
      On the way out of the data source, we don't need to worry - the
      decryption is already backwards-compatible with non-encrypted data.
      
      On the way in, things are a bit less straightforward. The core of the
      change is replacing the `t2/deftransform` that *always* runs
      `encryption/maybe-encrypt` on the value with:
      
      - a define-after-select that always tries to decrypt the value (so we
      can handle existing encrypted values in the db)
      
      - a define-before-insert that encrypts the value if the `defsetting`
      told us to, and
      
      - a define-before-update that does the same thing.
      
      For now, set two settings to be never-encrypted: `analytics-uuid` and
      `anon-tracking-enabled`.
      b28675d6
Loading