This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 05, 2024
-
-
github-automation-metabase authored
* walk the error to remove any visualization settings Thanks Dan for the patch, this approach is nice because it doesn't require changing all 3 streaming-response-writer implementations (json csv and xlsx). It keeps behaviour basically the same, but just cleans up the output to not include potentially sensitive column/dataset details. * add a test that confirms json/csv errors are cleaned * walk the error to remove any visualization settings Thanks Dan for the patch, this approach is nice because it doesn't require changing all 3 streaming-response-writer implementations (json csv and xlsx). It keeps behaviour basically the same, but just cleans up the output to not include potentially sensitive column/dataset details. * add a test that confirms json/csv errors are cleaned * fix dataset error test * cljfmt * try to be a little more surgical with what we take out of the error * formatting again, oops * pass export format, only modify the obj for file exports In the case of errors being saved to files, the obj is a map with a :status :failed key assoc'd by the qp somewhere along the way. The format-exception cond branch is not used in this case, so we can't rely on modifying `format-exception` to just dissoc ex-data. Instead, I've kept the obj modification, but it excludes the query and the preprocessed keys, which are the only 2 keys where we see :viz-settings. This doesn't eliminate the problem of needing to exclude other keys in the future, but it does improve the surface area - the query and viz settings are the most likely candidates for holding potentially sensitive info. I'd prefer to stick with this solution, as we can get a fix for the security concern in quicker, and perhaps a non-security bug can be opened regarding the most correct way to indicate errors to users whose downloads have failed. * keep format-exception the same * cleaner passing of export-format to write-error! Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
* perf: Optimize reading rows into vectors in JDBC driver * perf: Use direct interop when computing with-time-zone-same-instant Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
github-automation-metabase authored
Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
Mahatthana (Kelvin) Nomsawadi authored
* Fix visualization with warnings doesn't work when embedding * Clarify the test name
-
Aleksandr Lesnenko authored
-
github-automation-metabase authored
(#47650) Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
github-automation-metabase authored
* newsletter-toggle-clicked event * use ValidateEvent, * rename event -> simple_event and trackEvent -> trackSimpleEvent * use the renamed trackSimpleEvent function Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
github-automation-metabase authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
github-automation-metabase authored
* perf: [insights] Optimize last-2 allocations * perf: [insights] Optimize best-fit allocations when creating validation sample * perf: [insights] Optimize simple-linear-regression Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
- Sep 04, 2024
-
-
github-automation-metabase authored
* fix hidden pivot table scroll bar in QB * Update Loki Snapshots * Update Loki Snapshots --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
* cumulative aggregations * Apply suggestions from code review * cumulative articles * consolidate cumsum and cumcount articlesa * links * remove previews * sort clarification * Apply suggestions from code review * link --------- Co-authored-by:
Alex Yarosh <alexandra@metabase.com> Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* fixup backport of: Entity id translation service * entity id translation + tests * add api level test * simplify definition of eid-table->model + add test * update tests to take keywords * improve comment * generate the eid-table->model map * delete now-obsolete test * make it work in oss * put the resulting response into a key, so we can add more information later * formatting * use model names without the model/ prefix as keys * Creates list of `api/model->db-model` - update keys for util/entity_id request - update shape of util/entity_id response - add test for not-found eids * formatting * Respond to code review feedback --------- Co-authored-by:
Oisin Coveney <oisin@metabase.com> * remove unrelated test --------- Co-authored-by:
Bryan Maass <bryan.maass@gmail.com> Co-authored-by:
Oisin Coveney <oisin@metabase.com>
-
github-automation-metabase authored
backported "fix time series with data gaps stacked bar charts crash when enabling segments labels" (#47619) * fix time series with gaps stacked bar charts crash when enabling all labels (#47599) * Update Loki Snapshots --------- Co-authored-by:Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
* rename event -> simple_event and trackEvent -> trackSimpleEvent * add empty line at the end of the file --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Thomas Schmidt <thomas@metabase.com>
-
github-automation-metabase authored
* Add E2E tests * Default locked parameter value to `[]` * Fix unit tests Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
Anton Kulyk authored
* Add repro test for #47170 * Use type guard when checking for cancelled request * Export `isObject` type guard * Avoid type casting * Update e2e test
-
- Sep 03, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
github-automation-metabase authored
Fixes #47341. The QP now supports temporal bucketing of custom expressions, but that has not been surfaced in the UI until now. Describe the steps to verify that the changes are working as expected. 1. Use a database other than H2, since it doesn't support time zones. 1. New question -> Anything with a DateTime column 1. Create a custom expression like `convertTimezone([Date Column], "America/New_York", "UTC")` 1. Break out by that expression The temporal bucketing should work in the UI and in the query results, save properly, etc. Co-authored-by:
Braden Shepherdson <braden@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* Add v0.49.25 to the list of releases * Update releases.md --------- Co-authored-by:
Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
github-automation-metabase authored
* Simplify finding metrics in Summarize (#46887) * Use global search for aggregation picker * Add names to aggregation picker items so they can be searched * Render info icon metric descriptions * Add unit tests for global aggregation picker search * Add test for searching metrics * Add a test for metrics descriptions * Sort metrics * Fix e2e test * Use Flex from metabase/ui * Handle markdown in metric description * Add test for sorted metrics * Update Markdown styling in metric description * Fix clojure formatting * Test for markdown in the Metric description * Fix lint * Fix test for markdown * Use simpler equality test * Fix overflow in test * Add e2e test for legacy metrics searching * Maintain results as a vec --------- Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
github-automation-metabase authored
Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
github-automation-metabase authored
I still don't want users' eyes to bleed looking at (unnecessary?) stacktraces, but we need to be able to see exception causes to determine what is going wrong references #47520 Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
github-automation-metabase authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
- Sep 02, 2024
-
-
github-automation-metabase authored
Resolved minor conflicts in the following files due to unbackported PRs src/metabase/lib/schema/util.cljc - perf: Optimize validation with Malli #46485 src/metabase/query_processor/util.clj - Use the new private defn #46013 ------------------------------------------------------------------------------- Disallow duplicate order-by clauses in ::lib.schema.order-by/order-bys (#47489) * Move query-processor.util/remove-lib-uuids to lib.schema.util This function will soon be needed in lib.schema.util in order to implement distinct order-by clause schema checking. This function feels like it should live in lib.util instead of lib.schema.util, but that would create the following circular import dependency since lib.util indirectly requires stuff from lib.schema.util: lib.schema.util -> lib.util -> lib.schema.util * Don't create queries with duplicate order-bys in remove_replace_test.cljc Otherwise, theses tests would fail soon when we add update the order-by schema to reject duplicates. * Declare lib.order-by/order-bys to return ::lib.schema.order-by/order-bys Previously it inlined the schema instead. * Disallow duplicate order-by clauses in ::lib.schema.order-by/order-bys Fixes: 39384 Co-authored-by:
Mike Appleby <86076+appleby@users.noreply.github.com>
-
github-automation-metabase authored
Use consistent approach for disabling permission checks in QP to fix sandboxing error in downloads (#47481) (#47530) Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Alexander Solovyov authored
-
github-automation-metabase authored
* Use original display name for fields in uploaded tables (#47303) * Rename --------- Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com> Co-authored-by:
Chris Truter <chris@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Chris Truter <chris@metabase.com>
-
- Aug 31, 2024
-
-
github-automation-metabase authored
* Snowflake Variant cols should also work in attachments A previous PR fixed the snowflake variant bug by using a try/catch aroung the global-type-settings function. I realized there was a second codepath using the same function and it gets used in xlsx attachment code, so I've made the change there as well to prevent the same error in attachments. * add a test to confirm the viz-settings-for-col function doesn't throw Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
* perf: Use optimized stats functions for computing insights * perf: Rewrite fingerprinters/with-error-handling to not generate closures * fix: Don't reuse global-fingerprinter object Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
- Aug 30, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com> Co-authored-by:
Noah Moss <noahbmoss@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-