Skip to content
Snippets Groups Projects
This project is mirrored from https://github.com/metabase/metabase. Pull mirroring updated .
  1. Nov 20, 2024
  2. Nov 14, 2024
  3. Nov 13, 2024
  4. Nov 10, 2024
  5. Nov 08, 2024
  6. Nov 07, 2024
  7. Nov 05, 2024
  8. Nov 04, 2024
  9. Oct 31, 2024
    • lbrdnk's avatar
      [Backport 50] Use case expression type inference logic similar to annotate... · ecc660a2
      lbrdnk authored
      [Backport 50] Use case expression type inference logic similar to annotate middleware in MLv2 (#47902) (#48923)
      
      * Use case expression type inference logic similar to annotate middleware in MLv2 (#47902)
      
      * Use type date for case expression when there are Date and DateTime args
      
      * Use logic for getting case expr type from annotate middleware
      
      * Add e2e test
      
      * Add bigquery test
      
      * Update test
      
      * cljfmt and comment
      
      * Adjust e2e test
      
      * Adjust e2e test
  10. Oct 30, 2024
  11. Oct 29, 2024
  12. Oct 23, 2024
  13. Oct 22, 2024
  14. Oct 18, 2024
  15. Oct 15, 2024
  16. Oct 14, 2024
  17. Oct 11, 2024
  18. Oct 10, 2024
    • Nemanja Glumac's avatar
      🍒 [MS1, MS2] Better Onboarding: "Add Data" Section in the Main Sidebar (#48369) (#48490) · 1f643eae
      Nemanja Glumac authored
      * [MS1] Better Onboarding: Educational Section in the Main Sidebar (#48369)
      
      * [MS 1.1] Better Onboarding via First-Time UX (#48202)
      
      * Add new `learn` icon
      
      * Add initial visual elements WIP
      
      * Add a menu WIP
      
      * Use named export instead of a named one
      
      * Encapsulate the menu item logic
      
      * Redo the styling
      
      * Add todo notes
      
      * Get rid of the `style` prop where possible
      
      * Fix CSS logic for the container
      
      * Collapse section when the sidebar is closed
      
      * Use Mantine prop instead of the `style`
      
      * Fix the translation issue
      
      * Collapse section completely when the sidebar is closed
      
      * Remove hard coded color reference from SVG
      
      * Simplify element positioning
      
      * Collapse sidebar when closed
      
      * Fix E2E tests unscoped selectors
      
      * Rename props
      
      * Extract `SidebarOnboardingSection` logic into a separate component
      
      * Allow only admins to add data
      
      * Remove "Add your own data" button
      
      * Simplify menuitem component
      
      * Add initial unit tests
      
      * Use predefined vars for the CSV button subtitle
      
      * Show Upload CSV modal
      
      * Enable file uploads
      
      * Improve file organization
      
      * Tidy up types
      
      * Add analytics
      
      * Remove "Upload CSV" button from the sidebar
      
      * Fix "unmocked GET request"
      
      * Make menu usable on small screens
      
      * Make sure sidebar is scrollable
      
      * Fix E2E tests
      
      * Fix unit tests
      
      * [MS2] Better Onboarding UX: Expanded CSV upload permissions (#48475)
      
      * Use more granular permissions
      
      * Simplify the "upload spreadsheet" button logic
      
      * Simplify the "add database" button logic
      
      * Go back to using the existing `databases` prop
      
      * Conditionally display `UploadInput`
      
      * Refine `canUpload` logic
      
      * Reduce prop drilling
      
      * Make visual logic more "reader-friendly"
      
      * Fix and expand tests
      
      * Pass down the existing prop `hasDataAccess`
      
      * Remove the Metabase "learn" link
      
      * Move sub-components out of the render
      
      * Fix unrelated E2E tests
      
      * Try yet another thing to unblock a failing test
    • github-automation-metabase's avatar
      Do not cache all token check failures (#48147) (#48213) · 6da0d718
      github-automation-metabase authored
      
      * Do not cache all token check failures
      
      We want to cache token checks to avoid an issue where we repeatedly ask
      the store "hey, is this token valid?? is this token valid?? is this
      token valid??" for the same token.
      
      However, transient errors can also occur. For example, maybe a network
      issue causes the HTTP request to fail entirely. In this case, if we
      cache the result, the user needs to restart metabase (or wait 5 minutes
      until the cache is cleared) before they can attempt to validate their
      token again.
      
      This PR moves the cache logic deeper into the stack. We want to cache
      "successful" responses from the store API - cases where the store has
      told us categorically that the token is or is not valid. We don't want
      or need to cache other things that might happen. Maybe your token isn't
      the right length - we can recalculate that, it's ok. Maybe you get a 503
      error from the Store - we should let you retry. Maybe your network is
      having issues and you can't contact the Store at all - again, we should
      let you retry.
      
      The one potential issue I see here is that if the store goes down, we'll
      massively increase the number of requests we send to the store,
      potentially making it harder to recover. If this is a concern, I can add
      a circuit breaker: if we repeatedly get errors back from the store, back
      off and stop making requests for a while.
      
      * Add a circuit breaker to store API requests
      
      In the pathological case where the store goes down for >5 minutes, the
      cache will expire and all instances everywhere will start repeatedly
      making requests for token validation at once. This might make recovering
      from an outage more difficult.
      
      This adds a circuit breaker around the API request. If the call
      repeatedly throws (5XX errors, socket timeouts, etc.) then we'll pause
      for 1 minute, during which time all calls to token validation will
      immediately fail without making any request to the API.
      
      After one minute, we'll allow one request through to the API. If it
      succeeds, we'll go back to normal operation. Otherwise, we'll wait
      another minute.
      
      Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
    • Kamil Mielnik's avatar
      Manual backport - [Epic] Search in selection in entity picker (#47755) (#48516) · c771897f
      Kamil Mielnik authored
      * Manually backport #47755
      
      * Add missing import
      
      * Disable TypeScript in backported code due to a bug in TypeScript 4 which was fixed in TypeScript 5
      
      * Update test
      
      * Remove mentions of metrics from tests
  19. Oct 09, 2024
  20. Oct 08, 2024
  21. Oct 07, 2024
Loading