This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Nov 20, 2024
-
-
Noah Moss authored
-
- Nov 14, 2024
-
-
lbrdnk authored
* Map Oracle DATE to type/DateTime * Modify test * Add test
-
Noah Moss authored
-
Nemanja Glumac authored
* Backport dd509575 * Make "Add database" more prominent (#49678) * Remove dead code from browse models page * Use the grid to control the gap * Implement "Add database" button * Add basic unit tests * Make sure the feature works when there are no databases * Add analytics to the db list * Add "Add database" button to the sidebar * Add E2E Snowplow tests * Add unit tests * Deal with authentication in each beforeEeach separately * Add Snowplow E2E test for a database card * Slightly tweak the title line height * Fix imports * Fix failing unit test * Fix color references * Deal with async tests
-
- Nov 13, 2024
-
-
Ngoc Khuat authored
-
- Nov 10, 2024
-
-
metabase-bot[bot] authored
* Revert "[streaming-response] Use HttpEndpoint.isOpen() instead of reading a byte from TCP socket (#49460)" This reverts commit 060baf0c. * Disable connection reuse for requests that serve streaming responses Co-authored-by: Oleksandr Yakushev <alex@bytopia.org>
-
- Nov 08, 2024
-
-
metabase-bot[bot] authored
* Email throttling config (#49477) * remove new setting from setting export --------- Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
-
- Nov 07, 2024
-
-
Noah Moss authored
-
metabase-bot[bot] authored
previously import would return 200 w/o regard if it was successful or not fixes #49602 Co-authored-by: Alexander Solovyov <alexander@solovyov.net>
-
- Nov 05, 2024
-
-
metabase-bot[bot] authored
[streaming-response] Use HttpEndpoint.isOpen() instead of reading a byte from TCP socket (#49460) (#49549) * [streaming-response] Use HttpEndpoint.isOpen() instead of reading a byte from TCP socket * Comment out cancellation test Co-authored-by: Oleksandr Yakushev <alex@bytopia.org>
-
Alexander Solovyov authored
Co-authored-by: Romeo Van Snick <romeo@romeovansnick.be>
-
- Nov 04, 2024
- Oct 31, 2024
-
-
lbrdnk authored
[Backport 50] Use case expression type inference logic similar to annotate middleware in MLv2 (#47902) (#48923) * Use case expression type inference logic similar to annotate middleware in MLv2 (#47902) * Use type date for case expression when there are Date and DateTime args * Use logic for getting case expr type from annotate middleware * Add e2e test * Add bigquery test * Update test * cljfmt and comment * Adjust e2e test * Adjust e2e test
-
- Oct 30, 2024
-
-
Nemanja Glumac authored
* Cherry-pick 1c0e4f2c * Fix UTM tags * Use better naming * Fix wrong type on Icon
-
Braden Shepherdson authored
This was throwing errors trying to `nippy/freeze!` an Atom. That was because in certain circumstances a pMBQL query can end up in `(:json_query metadata)` for a query, and those can contain an atom due to `metabase.lib.cache` and both `CachedMetadataProvider` and `InvocationTracker`. I added `lib.query/serializable` as a single location to strip out anything that isn't serializable, such as atoms. (And the entire `:lib/metadata`, which is a wasted effort to serialize.)
-
- Oct 29, 2024
-
-
Nemanja Glumac authored
* Add `use-temp-storage` hook * Remove try/catch * Add reducer * Add tests * Use RTK to create a new slice and reducer
-
- Oct 23, 2024
-
-
metabase-bot[bot] authored
Co-authored-by: Chris Truter <crisptrutski@users.noreply.github.com>
-
- Oct 22, 2024
-
-
adam-james authored
* Manual Backport of 48867 to 50 Related: #48867 * empty commit
-
metabase-bot[bot] authored
Co-authored-by: github-automation-metabase <166700802+github-automation-metabase@users.noreply.github.com> Co-authored-by: Metabase bot <metabase-bot@metabase.com>
-
metabase-bot[bot] authored
* Fix #48878 by avoiding to use entity framework which can serve incomplete card objects * Make sure canWrite is a boolean * Remove redundant optional chaining * Add repro for #48878 * Optimize * Improve comment * Fix test setup * Update test code for v50 --------- Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
-
- Oct 18, 2024
-
-
Dennis Schridde authored
== Behaviour without this fix == See #48881 == Behaviour with this fix == 1. Metabase starts with an empty application database, and a config file containing configuration for a connected database 3. By the time it reaches "INFO metabase.task :: Task scheduler started", `qrtz_triggers` contains `metabase.task.sync-and-analyze.trigger.1` (sample DB) and `metabase.task.sync-and-analyze.trigger.2` (DB from config file) Closes: https://github.com/metabase/metabase/issues/48881 Co-authored-by: Noah Moss <noah@metabase.com>
-
metabase-bot[bot] authored
Store API can handle higher load and customers might want to see changes earlier. Fixes: cc28ee60 Co-authored-by: Dennis Schridde <63082+devurandom@users.noreply.github.com>
-
- Oct 15, 2024
-
-
metabase-bot[bot] authored
Co-authored-by: github-automation-metabase <166700802+github-automation-metabase@users.noreply.github.com> Co-authored-by: Metabase bot <metabase-bot@metabase.com>
-
Case Nelson authored
Pulled from #41384 on master
-
Ryan Laurie authored
* Add Release Channel selection in-product (#48126)
-
Noah Moss authored
Manual backport 'Use saved card metadata to filter fields in query metadata for sandboxed tables' to 50 (#48706)
-
Kamil Mielnik authored
* Refactor remaining e2e API commands to TS helper functions (#48672) * Refactor createDashboardWithQuestions, createQuestionAndAddToDashboard and editDashboardCard to TS function helpers * Fix createNativeQuestionAndDashboard that got out of sync * Add missing export * Fix import
-
- Oct 14, 2024
-
-
github-automation-metabase authored
Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com> Co-authored-by: Cam Saul <github@camsaul.com>
-
metabase-bot[bot] authored
* Revert "fix flakiness during resize (#48556)" This reverts commit 03b6584b. * Move .should call up to fix flaky test * Use consistent naming Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
-
metabase-bot[bot] authored
* Update GitHub link that has been moved * Get rid of a failing link Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
-
- Oct 11, 2024
-
-
metabase-bot[bot] authored
Co-authored-by: github-automation-metabase <166700802+github-automation-metabase@users.noreply.github.com> Co-authored-by: Metabase bot <metabase-bot@metabase.com>
-
- Oct 10, 2024
-
-
Nemanja Glumac authored
* [MS1] Better Onboarding: Educational Section in the Main Sidebar (#48369) * [MS 1.1] Better Onboarding via First-Time UX (#48202) * Add new `learn` icon * Add initial visual elements WIP * Add a menu WIP * Use named export instead of a named one * Encapsulate the menu item logic * Redo the styling * Add todo notes * Get rid of the `style` prop where possible * Fix CSS logic for the container * Collapse section when the sidebar is closed * Use Mantine prop instead of the `style` * Fix the translation issue * Collapse section completely when the sidebar is closed * Remove hard coded color reference from SVG * Simplify element positioning * Collapse sidebar when closed * Fix E2E tests unscoped selectors * Rename props * Extract `SidebarOnboardingSection` logic into a separate component * Allow only admins to add data * Remove "Add your own data" button * Simplify menuitem component * Add initial unit tests * Use predefined vars for the CSV button subtitle * Show Upload CSV modal * Enable file uploads * Improve file organization * Tidy up types * Add analytics * Remove "Upload CSV" button from the sidebar * Fix "unmocked GET request" * Make menu usable on small screens * Make sure sidebar is scrollable * Fix E2E tests * Fix unit tests * [MS2] Better Onboarding UX: Expanded CSV upload permissions (#48475) * Use more granular permissions * Simplify the "upload spreadsheet" button logic * Simplify the "add database" button logic * Go back to using the existing `databases` prop * Conditionally display `UploadInput` * Refine `canUpload` logic * Reduce prop drilling * Make visual logic more "reader-friendly" * Fix and expand tests * Pass down the existing prop `hasDataAccess` * Remove the Metabase "learn" link * Move sub-components out of the render * Fix unrelated E2E tests * Try yet another thing to unblock a failing test
-
github-automation-metabase authored
* Do not cache all token check failures We want to cache token checks to avoid an issue where we repeatedly ask the store "hey, is this token valid?? is this token valid?? is this token valid??" for the same token. However, transient errors can also occur. For example, maybe a network issue causes the HTTP request to fail entirely. In this case, if we cache the result, the user needs to restart metabase (or wait 5 minutes until the cache is cleared) before they can attempt to validate their token again. This PR moves the cache logic deeper into the stack. We want to cache "successful" responses from the store API - cases where the store has told us categorically that the token is or is not valid. We don't want or need to cache other things that might happen. Maybe your token isn't the right length - we can recalculate that, it's ok. Maybe you get a 503 error from the Store - we should let you retry. Maybe your network is having issues and you can't contact the Store at all - again, we should let you retry. The one potential issue I see here is that if the store goes down, we'll massively increase the number of requests we send to the store, potentially making it harder to recover. If this is a concern, I can add a circuit breaker: if we repeatedly get errors back from the store, back off and stop making requests for a while. * Add a circuit breaker to store API requests In the pathological case where the store goes down for >5 minutes, the cache will expire and all instances everywhere will start repeatedly making requests for token validation at once. This might make recovering from an outage more difficult. This adds a circuit breaker around the API request. If the call repeatedly throws (5XX errors, socket timeouts, etc.) then we'll pause for 1 minute, during which time all calls to token validation will immediately fail without making any request to the API. After one minute, we'll allow one request through to the API. If it succeeds, we'll go back to normal operation. Otherwise, we'll wait another minute. Co-authored-by: John Swanson <john.swanson@metabase.com>
-
Kamil Mielnik authored
* Manually backport #47755 * Add missing import * Disable TypeScript in backported code due to a bug in TypeScript 4 which was fixed in TypeScript 5 * Update test * Remove mentions of metrics from tests
-
- Oct 09, 2024
-
-
metabase-bot[bot] authored
* add a clarification to sso docs * rephrase * Update docs/people-and-groups/authenticating-with-saml.md --------- Co-authored-by: Alex Yarosh <alexandra@metabase.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
-
github-automation-metabase authored
Co-authored-by: Luiz Arakaki <luiz.arakaki@metabase.com>
-
- Oct 08, 2024
-
-
dpsutton authored
https://github.com/metabase/metabase/issues/41919#issuecomment-2400542908 This issue goes away in 5.3.1 of apache poi. Seems like they have a yearly release cadence so we can ensure this exists for the time being and then remove this when we can bump to 5.3.1 ```diff index b763a1ffdf..c87992c935 100644 --- a/deps.edn +++ b/deps.edn @@ -122,7 +122,7 @@ {:mvn/version "2.23.1"} ; allows the slf4j2 API to work with log4j 2 org.apache.logging.log4j/log4j-layout-template-json {:mvn/version "2.23.1"} ; allows the custom json logging format - org.apache.poi/poi {:mvn/version "5.2.5"} ; Work with Office documents (e.g. Excel spreadsheets) -- newer version than one specified by Docjure + org.apache.poi/poi {:mvn/version "5.3.1"} ; Work with Office documents (e.g. Excel spreadsheets) -- newer version than one specified by Docjure org.apache.poi/poi-ooxml {:mvn/version "5.2.5" :exclusions [org.bouncycastle/bcpkix-jdk15on org.bouncycastle/bcprov-jdk15on]} ```
-
github-automation-metabase authored
* docs: JWT groups with env vars * typo Co-authored-by: Alex Yarosh <alexandra@metabase.com>
-
- Oct 07, 2024
-
-
github-automation-metabase authored
* gauge * progress addition * alternatives * update link * Apply suggestions from code review --------- Co-authored-by: Alex Yarosh <alexandra@metabase.com> Co-authored-by: Jeff Bruemmer <jeff.bruemmer@gmail.com>
-