This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- May 23, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
- May 21, 2024
-
-
John Swanson authored
This is a bit painful. I merged this change, but realized we need to backport the fix to v49. However: - we don't want to have two versions of the migration (one with a v49 id, one with a v50 id) because then if someone upgrades to 50, then downgrades to 49, the `rollback` will run and change the type back, leading to a bug. - we don't want to push a v51 changeSet ID to v49 or v50, because we give the user a helpful notice when their database needs a downgrade. We do this by checking for the latest *executed* migration in the database and comparing it to the latest migration that Liquibase knows about, and making sure the executed isn't bigger than the known (e.g. you can't have executed a v51 migration if it isn't in the local migration yaml). That would all work fine, except that then we want to tell you how to downgrade your database, and we use the latest-executed version for that. So if, for example, someone upgraded from 48 to 49 and got a v51 changeset, then downgraded back to 48, they would get an error telling them to run the *v51* jar to roll back their DB. In this case though, I think it's fine to just move the migration around to v49, then we can backport it to 49 and 50.
-
- May 20, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
- May 17, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
- May 16, 2024
-
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Polyankin <alexander.polyankin@metabase.com>
-
metabase-bot[bot] authored
* Add `collection.effective_ancestors` to search Fixes #41909 The ultimate goal here is to be able to display a UI that showed the entire (effective) path to each collection. This was a bit more painful than I'd hoped. The primary issue is that we tied two things together: - scoring results - "serializing" results (really, partially serializing results, because we do more work to shape the data later) Why is this a problem? The `top-scorers` function took a transducer and returned the *serialized* top scorers. Later, when we need to operate on *all* the top results (in this case, to collect all the collection IDs and names that we know of), we're looking at the serialized results. In our case, we needed some data (collection location) that wasn't included after serialization. We could add it, of course, but it's frustrating to need to change the API of what data is *returned* from the endpoint for purely internal purposes (changing the data available during *processing*). I ended up pulling serialization out of the scoring function. At some point down the road, we should go ahead and move the `serialize` function out of the `search.scoring` namespace entirely - there's really no reason for it to belong there as far as I can tell. Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
3 TODOs were removed here: - "a way to SET Database-local values." More like TODONE :haaa: - "we should probably also bind this [that is, *database-local-values*] in sync contexts e.g. functions in [[metabase.sync]]" I think we don't need to do this. The full set of maybe-database-local settings right now is `aggregated-query-row-limit`, `unaggregated-query-row-limit`, `database-enable-actions`, and `persist-models-enabled`. None of these need to be set when `sync`ing. If at some point we do add a db-local setting that should affect the way syncing works, we will need to do this - but I don't think this TODO will help figure that out. - "settings sent via an env var aren't returned for security purposes. It is an open question whether we should obfuscate them and still show the last two characters like we do for sensitive values that are set via the UI." I think if it's been this way for 5 years, it no longer qualifies as an "open question." We can reopen if down the road if this is something we want. Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
metabase-bot[bot] authored
backported "Realize DB transient rows in after-select hook before calling `driver.u/features`" (#42745) * Realize DB transient rows in after-select hook before calling `driver.u/features` (#42744) --------- Co-authored-by:Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- May 15, 2024
-
-
metabase-bot[bot] authored
* update collections * feedback * links * Update docs/questions/native-editor/sql-parameters.md --------- Co-authored-by:
Alex Yarosh <alexandra@metabase.com> Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
this lowers memory usage 100x for 50kb strings (our limit before this change) and speeds up parsing by an order of magnitude. For example, results for parsing 42kb string (already in memory): Before: Time per call: 6.32 ms Alloc per call: 8,732,850b After: Time per call: 55.16 us Alloc per call: 83,254b
-
metabase-bot[bot] authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
- May 14, 2024
-
-
metabase-bot[bot] authored
-
Cal Herries authored
-
- May 13, 2024
-
-
metabase-bot[bot] authored
* Don't use the slugify util for filenames * Fix tests that looked for incorrect filenames * add a test * fix filename in pulse test util Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
- May 10, 2024
-
-
metabase-bot[bot] authored
* Format Rows toggle also applies to Column Names Fixes: #42500 When format-rows is false, we want to also pass that true/false value to the title column formatting. That is, if a column is renamed and formatting is applied, we want to use that column's name. But, if a column is renamed and the user exports unformatted csv or json, the custom column name should NOT be used, as was the behaviour in prior versions. * write a better test explanation Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
metabase-bot[bot] authored
* fix pie chart display when switching from notebook editor * remove hack * fix missing pie chart display * fix missing pie chart display * address feedback * fix type error Co-authored-by:
Jesse Devaney <22608765+JesseSDevaney@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
metabase-bot[bot] authored
* serialization update * anchor links * more anchor links * correct curl call * Apply suggestions from code review * Apply suggestions from code review * review feedback * links * Update docs/installation-and-operation/serialization.md --------- Co-authored-by:
Alex Yarosh <alexandra@metabase.com> Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
* fix pie chart tooltip * add unit test Co-authored-by:
Emmad Usmani <emmadusmani@berkeley.edu>
-
metabase-bot[bot] authored
* how optional clauses work * Apply suggestions from code review --------- Co-authored-by:
Alex Yarosh <alexandra@metabase.com> Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
- May 09, 2024
-
-
metabase-bot[bot] authored
* see shared content * Apply suggestions from code review --------- Co-authored-by:
Alex Yarosh <alexandra@metabase.com> Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
metabase-bot[bot] authored
Co-authored-by:
Uladzimir Havenchyk <125459446+uladzimirdev@users.noreply.github.com>
-
metabase-bot[bot] authored
Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com>
-
metabase-bot[bot] authored
* Fix flaky question management test * Update assertions order to reduce probability of a flake * Use explicit assertions * Change assertion order * Decrease flakiness Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
-
metabase-bot[bot] authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
Luis Paolini authored
-
metabase-bot[bot] authored
Co-authored-by:
Jacob Joseph <likeshumidity@users.noreply.github.com>
-
metabase-bot[bot] authored
* attempt to type the return value of actions created by createThunkAction * use built in Awaited instead of custom AwaitedIfPromise Co-authored-by:
Nicolò Pretto <info@npretto.com>
-
Cal Herries authored
-