This project is mirrored from https://github.com/metabase/metabase.
Pull mirroring updated .
- Sep 03, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Jeff Bruemmer <jeff.bruemmer@gmail.com>
-
github-automation-metabase authored
* Add v0.49.25 to the list of releases * Update releases.md --------- Co-authored-by:
Metabase bot <metabase-bot@metabase.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com>
-
github-automation-metabase authored
* Simplify finding metrics in Summarize (#46887) * Use global search for aggregation picker * Add names to aggregation picker items so they can be searched * Render info icon metric descriptions * Add unit tests for global aggregation picker search * Add test for searching metrics * Add a test for metrics descriptions * Sort metrics * Fix e2e test * Use Flex from metabase/ui * Handle markdown in metric description * Add test for sorted metrics * Update Markdown styling in metric description * Fix clojure formatting * Test for markdown in the Metric description * Fix lint * Fix test for markdown * Use simpler equality test * Fix overflow in test * Add e2e test for legacy metrics searching * Maintain results as a vec --------- Co-authored-by:
Romeo Van Snick <romeo@romeovansnick.be>
-
github-automation-metabase authored
Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
-
github-automation-metabase authored
I still don't want users' eyes to bleed looking at (unnecessary?) stacktraces, but we need to be able to see exception causes to determine what is going wrong references #47520 Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
github-automation-metabase authored
Co-authored-by:
Cal Herries <39073188+calherries@users.noreply.github.com>
-
- Sep 02, 2024
-
-
github-automation-metabase authored
Resolved minor conflicts in the following files due to unbackported PRs src/metabase/lib/schema/util.cljc - perf: Optimize validation with Malli #46485 src/metabase/query_processor/util.clj - Use the new private defn #46013 ------------------------------------------------------------------------------- Disallow duplicate order-by clauses in ::lib.schema.order-by/order-bys (#47489) * Move query-processor.util/remove-lib-uuids to lib.schema.util This function will soon be needed in lib.schema.util in order to implement distinct order-by clause schema checking. This function feels like it should live in lib.util instead of lib.schema.util, but that would create the following circular import dependency since lib.util indirectly requires stuff from lib.schema.util: lib.schema.util -> lib.util -> lib.schema.util * Don't create queries with duplicate order-bys in remove_replace_test.cljc Otherwise, theses tests would fail soon when we add update the order-by schema to reject duplicates. * Declare lib.order-by/order-bys to return ::lib.schema.order-by/order-bys Previously it inlined the schema instead. * Disallow duplicate order-by clauses in ::lib.schema.order-by/order-bys Fixes: 39384 Co-authored-by:
Mike Appleby <86076+appleby@users.noreply.github.com>
-
github-automation-metabase authored
Use consistent approach for disabling permission checks in QP to fix sandboxing error in downloads (#47481) (#47530) Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
Alexander Solovyov authored
-
github-automation-metabase authored
* Use original display name for fields in uploaded tables (#47303) * Rename --------- Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com> Co-authored-by:
Chris Truter <chris@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Chris Truter <chris@metabase.com>
-
- Aug 31, 2024
-
-
github-automation-metabase authored
* Snowflake Variant cols should also work in attachments A previous PR fixed the snowflake variant bug by using a try/catch aroung the global-type-settings function. I realized there was a second codepath using the same function and it gets used in xlsx attachment code, so I've made the change there as well to prevent the same error in attachments. * add a test to confirm the viz-settings-for-col function doesn't throw Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
* perf: Use optimized stats functions for computing insights * perf: Rewrite fingerprinters/with-error-handling to not generate closures * fix: Don't reuse global-fingerprinter object Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
- Aug 30, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Luiz Arakaki <luiz.arakaki@metabase.com> Co-authored-by:
Noah Moss <noahbmoss@gmail.com>
-
github-automation-metabase authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
# Conflicts: # release/src/auto-translate.ts Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com>
-
adam-james authored
* Incrementally add rows to Native Pivot xlsx exports Adds a boolean env var `MB_NATIVE_PIVOT_EXPORTS` which enables the 'native pivot' feature in Downloads of xlsx files. * Simplify the init * remove unnecessary step * properly use streaming workbook for pivot export too This change initializes a non-streaming workbook so that a Pivot table can be added. Then, it turns that workbook into a streaming workbook, so that we never have to keep the entire output in memory; just like non-pivot xlsx exports, we can ensure more efficient output. * Env var name more indicative of its temporary nature I mean, all things eventually succumb to the inexorable march of time that sands away all lustre, it's just that this environment variable will disappear much sooner, and intentionally. * change env var name, add default row count in case no counts exist * try to improve the area-ref code * just kidding, figured out how to do A:D style refs Still need to avoid the zip bomb problem, but at least now we don't need to know or guess the row count beforehand. And, the fileszie ends up being smaller, though the time to download goes up a little bit. * fix xlsx test * should keep col name format behaviour the same
-
github-automation-metabase authored
Fixes #30602 We were overriding localdate in bigquery driver to produce offsetdatetimes for no apparent reason. This causes a number of problems when dealing with date type columns. Co-authored-by:
Case Nelson <case@metabase.com>
-
github-automation-metabase authored
* Snowflake Variant Type should not prevent downloads or attachments Fixes #46981 The :type/SnowflakeVariant key matches 2 methods in `metabase.query-processor.streaming.common/global-type-settings`. In this case, it seems that the variant type can be any type, so we shouldn't try to guess anything here, except if the user has provided a :semantic_type, which we can use. Otherwise, we'll keep going without formatting details about the variant column, which is likely fine already, as it should result in strings in the export/attachments. * add a test Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com>
-
github-automation-metabase authored
* fix trend lines scaling (#47361) * fix trend lines scaling * Update Loki Snapshots --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
* locale query string support on public links and static embeds (#47186) * keep locale in url query params * e2e tests * ugly fix for the missing baseUrl error * applies suggestion from Kelvin to make code more demure * Update e2e/test/scenarios/sharing/public-question.cy.spec.js Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> * remove it.skip added by mistake * sort imports * handle native question/ SyncedParametersList too * shorter and more accurate comment
* Update e2e/support/helpers/e2e-embedding-helpers.js Co-authored-by:Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> --------- Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * fix tests, the button i was looking for is not on v50 --------- Co-authored-by:
Nicolò Pretto <info@npretto.com> Co-authored-by:
Anton Kulyk <kuliks.anton@gmail.com> Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
-
github-automation-metabase authored
Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Chris Truter <chris@metabase.com>
-
github-automation-metabase authored
* Add test against serialization YAML format changing (#47349) * fixup --------- Co-authored-by:
Chris Truter <crisptrutski@users.noreply.github.com> Co-authored-by:
Chris Truter <chris@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Oleksandr Yakushev <alex@bytopia.org>
-
github-automation-metabase authored
Co-authored-by:
Thomas Schmidt <somtom91@gmail.com>
-
- Aug 29, 2024
-
-
github-automation-metabase authored
Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
-
github-automation-metabase authored
Co-authored-by:
Thomas Schmidt <somtom91@gmail.com>
-
Aleksandr Lesnenko authored
-
github-automation-metabase authored
Co-authored-by:
Metabase bot <metabase-bot@metabase.com>
-
github-automation-metabase authored
Co-authored-by:
Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
These migrations will be backported to v49. Three changes: - update IDs/locations of the migrations to v49 vs v51 - add one preCondition (when adding the foreign key constraint) - add `onFail: MARK_RAN` to the index preconditions. I forgot this before, so it blows up when the precondition doesn't hold. Co-authored-by:
John Swanson <john.swanson@metabase.com>
-
github-automation-metabase authored
backported "Exclude inactive tables from the perms cache, and block queries over inactive tables in the QP" (#47404) Co-authored-by:Noah Moss <32746338+noahmoss@users.noreply.github.com>
-
github-automation-metabase authored
* Increase log level to INFO from error Closes #47396 logs before: ``` 2024-08-29 08:37:03,836 INFO db.liquibase :: Checking if Database has unrun migrations... 2024-08-29 08:37:04,045 INFO db.liquibase :: Database has unrun migrations. Checking if migration lock is taken... 2024-08-29 08:37:04,047 INFO db.liquibase :: No migration lock found. 2024-08-29 08:37:04,047 INFO db.liquibase :: Migration lock acquired. 2024-08-29 08:37:04,167 INFO db.liquibase :: Running 83 migrations ... ``` logs after: ``` 2024-08-29 08:39:45,019 INFO db.liquibase :: Running 83 migrations ... ... 2024-08-29 08:39:45,166 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:00::calherries ran successfully in 0ms 2024-08-29 08:39:45,182 INFO liquibase.changelog :: Columns is_defective_duplicate(boolean) added to metabase_field 2024-08-29 08:39:45,182 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:01::calherries ran successfully in 14ms 2024-08-29 08:39:45,199 INFO liquibase.changelog :: Custom SQL executed 2024-08-29 08:39:45,200 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:02::calherries ran successfully in 16ms 2024-08-29 08:39:45,202 INFO liquibase.changelog :: Foreign key fk_field_parent_ref_field_id dropped 2024-08-29 08:39:45,202 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:03::calherries ran successfully in 1ms 2024-08-29 08:39:45,204 INFO liquibase.changelog :: Foreign key constraint added to metabase_field (parent_id) 2024-08-29 08:39:45,205 INFO liquibase.changelog :: ChangeSet migrations/001_update_migrations.yaml::v49.2024-06-27T00:00:04::calherries ran successfully in 2ms ... ``` * empty commit to bump CI Co-authored-by:
dpsutton <dan@dpsutton.com>
-
github-automation-metabase authored
* handle cache config overflowed * fix root too * do not comment out test * make cljfmt happy --------- Co-authored-by:
Alexander Solovyov <alexander@solovyov.net>
-
metamben authored
* Make metrics inherit the name of the aggregation Fixes #40355. The query processor expects the columns resulting from metric aggregations to be named based on the aggregation in the metric definition, not by the name of the metric. This change brings metabase lib in sync with the query processor. * Make metrics inherit the name of the aggregation Fixes #40355. The query processor expects the columns resulting from metric aggregations to be named based on the aggregation in the metric definition, not by the name of the metric. This change brings metabase lib in sync with the query processor. * Fix test * Resolve metric once only
-