Skip to content
Snippets Groups Projects
Select Git revision
20 results
Compare
user avatar
Handle locationlization errors from java.util.Locale (#22226)
dpsutton authored 
* Handle locationlization errors from java.util.Locale

Indonesian has code "id". But
```
;; java 11
(str (java.util.Locale/forLanguageTag "id")) => "in"

;; java 17
(str (java.util.Locale/forLanguageTag "id")) => "id"
```

And this was bad. Because the frontend sends us the language to use:
"id" for indonesian. We write that down. And then when we need to
construct the index.html page with the correct translations, instead of
using "id"-- the value we were given-- we construct a Locale from "id"
and then get the str value of that which is "in". We don't have a in.edn
file, there's no frontend in.json file, and moment.js has no in
localization. And this all happened because we kept this value we all
agreed upon in a java util class and then asked it for that value back.

* Localization names have hyphens, files underscores

* Added docstring

* docstrings

* Assert language id and POE header value in tests

* localized json files don't exist until a build step

Co-authored-by: default avatarAdam James <adam.vermeer2@gmail.com>
64b5c40c
History
user avatar 64b5c40c
History
Name Last commit Last update
.babel_cache
.circleci
.clj-kondo
.devcontainer
.github
.husky
.lsp
.storybook
.vscode
bin
dev
docs
enterprise
frontend
hooks
locales
modules/drivers
resources
shared
snowplow
src/metabase
test/metabase
test_config
test_modules/drivers
test_resources
.babelrc
.dir-locals.el
.dockerignore
.editorconfig
.eslintignore
.eslintrc
.gitignore
.percy.yml
.prettierignore
.prettierrc
.yarnrc
Dockerfile
LICENSE-AGPL.txt
LICENSE-EMBEDDING.txt
LICENSE-MCL.txt
LICENSE.txt
Procfile
README.md
SECURITY.md
app.json
build.clj
codecov.yml
deps.edn
jest.tz.unit.conf.json
jest.unit.conf.json
jsconfig.json
lint-config.edn
package.json
postcss.config.js
renovate.json
shadow-cljs.edn
tsconfig.json
webpack.config.js
webpack.shared.config.js
webpack.static-viz.config.js
yarn.lock
zen.md
README.md

Metabase

Metabase is the easy, open-source way for everyone in your company to ask questions and learn from data.

Metabase Product Screenshot

Latest Release Circle CI codecov

Features

Take a tour of Metabase.

Supported databases

Installation

Metabase can be run just about anywhere. Check out our Installation Guides.

Contributing

To get started with a development installation of the Metabase, check out our Developers Guide.

Internationalization

We want Metabase to be available in as many languages as possible. See which translations are available and help contribute to internationalization using our project over at POEditor. You can also check out our policies on translations.

Extending Metabase

Metabase also allows you to hit our Query API directly from Javascript to integrate the simple analytics we provide with your own application or third party services to do things like:

  • Build moderation interfaces.
  • Export subsets of your users to third party marketing automation software.
  • Provide a specialized customer lookup application for the people in your company.

Check out our guide, Working with the Metabase API.

Security Disclosure

See SECURITY.md for details.

License

This repository contains the source code for both the Open Source edition of Metabase, released under the AGPL, as well as the commercial editions of Metabase, which are released under the Metabase Commercial Software License.

See LICENSE.txt for details.

Unless otherwise noted, all files © 2022 Metabase, Inc.