Nicolò Pretto
authored
* fix: cancel ongoing query when removing card from dashboard * test: #12926 remove card test with xhr.abort stub * test: use cy.on(fail instead, to specifically expect that request to be aborted * Revert "test: use cy.on(fail instead, to specifically expect that request to be aborted" This reverts commit 75e204e8e2c45cc490d79729ee12795ea10291fa. * refactor: move cancelFetchCardData inside removeCardFromDashboard, which becomes a thunk * doc jsdocs for should_wait param in visitDashboard * "undo remove card" re-fetches the card * test: test for undo -> re-fetch card * refactor: removed unused param * revert should_wait on visitDashboard in favor or manually using cy.visit * artificially slow down requests via cy instead of using pg_sleep * rename before block * when undoing remove card, only refetch data if needed * remove debug console log * refactor: remove .within call with only one function call inside * docs: add comment to req.continue * test: adds assertion that the query data is actually loaded * remove data already present check as it is already in the thunk
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
Name | Last commit | Last update |
---|---|---|
.. | ||
runner | ||
snapshot-creators | ||
support | ||
test | ||
.eslintrc | ||
tsconfig.json | ||
validate-e2e-test-files.js |