Denis Berezin
authored
feat(sdk): SDK theming part 6 - text-brand, text-dark, text-light, text-medium, admin-navbar, `accentX` (#43687) * Migrate text-brand * Migrate text-dark * Migrate text-light * Migrate text-medium * Migrate admin-navbar * make compact formatting consistent across all series (#43472) * make compact formatting consistent across all series * fix rebase * [Browse] Show Browse models link in nav only when there are models (#43286) * Upgrade to TypeScript v5.4 (#43736) * use correct github api for CI (#43750) * update list of releases (#43754) * Multi Series Dashcards Render with Filters Applied To All Series (#43428) * Multi Series Dashcards Render with Filters Applied To All Series Fixes: #39083 Multi-series dashcards now properly render when a subscription is set up with filters that impact the values of each card in the multi-series card. * Small refactor for executing dashcards in a pulse context. - move execute-dashboard-subscription to pulse.util - this fn now will also execute all card series cards and put those results into a list on the key :series-results in the dashcard which is then used in the render multimethod to send the correct data to the javascript context A small todo was taken care of as well, we can now use :dashboard-subscription in the :context key * Fix up render fn The shape of hte data going into the javascript was a bit unclear before. This keeps things a little more understandable. Next step is probably to create some Malli schemas inside the js_svg namespace to document and enforce the needed data shapes * pull :data up a level from :result in the series cards * Update src/metabase/pulse/render/body.clj Co-authored-by:Ngoc Khuat <qn.khuat@gmail.com> * Remove unneeded let * set/rename-keys won't work here because we raise the :data key I've realised a suggested change to just use set/rename-keys won't do what we need. We need instead to raise :data from within the result key up to the same level (and dissoc result). I've renamed the helper function to make its purpose a bit clearer --------- Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> * Hydrate can_run_adhoc_query and address review comments (#43747) This is a followup on #43625. * Consolidate dashboard-card specs (#43716) * Consolidate joins specs (#43717) * Update translations for v50 and add Danish Language Support (#43314) * update translations for v50 * add Danish * update translations for v50 release * alphabetical order is nice * Move database role to url parameters from connection properties on Snowflake (#43602) * Move role to url parameters from connection properties * Fix test * Fix width of save button in cache sidebar (#43755) * Remove dead code (#43603) * Combine search e2e specs (#43718) * Highlight the table cell data in dashboards when the cell is an ID column (#43728) * highlight id cell column * add simpletable stories * add simple table test data * add loki reference image * Update frontend/src/metabase/visualizations/components/TableSimple/TableCell.styled.tsx Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> --------- Co-authored-by:
Denis Berezin <denis.berezin@metabase.com> * Remove old repro for 39150 (#43749) * Fix remaining `tinyint` booleans in MySQL (#43296) * Correct type for `report_card.dataset` This was missed in the original migration of boolean types to ${boolean.type} in MySQL/MariaDB, and then missed again by me when I migrated `collection_preview` over a week ago. * Change all boolean types to `bit(1)` in MySQL Liquibase changed their boolean type in MySQL from `bit(1)` to `tinyint(4)` in version 4.25.1. Our JDBC driver does not recognize these as booleans, so we needed to migrate them to `bit(1)`s. As discussed [here](#36964), we changed all existing `boolean` types that were in the `001_update_migrations.yml` but not the SQL initialization file. For new installations, this works: things in the SQL initialization file get created with the `bit(1)` type. However, for existing installations, there's a potential issue. Say I'm on v42 and am upgrading to v49. In v43, a new `boolean` was added. In this case, I'll get the `boolean` from the liquibase migration rather than from the SQL initialization file, and it need to be changed to a `bit(1)`. I installed Metabase v41 with MySQL, migrated the database, and then installed Metabase v49 and migrated again. I made a list of all the columns that had the type `tinyint`: ``` mysql> SELECT TABLE_SCHEMA, TABLE_NAME, COLUMN_NAME, COLUMN_TYPE, COLUMN_DEFAULT, IS_NULLABLE FROM INFORMATION_SCHEMA.COLUMNS WHERE COLUMN_TYPE = 'tinyint' AND TABLE_SCHEMA='metabase_test'; +---------------+------------------------------+-------------------+-------------+----------------+-------------+ | TABLE_SCHEMA | TABLE_NAME | COLUMN_NAME | COLUMN_TYPE | COLUMN_DEFAULT | IS_NULLABLE | +---------------+------------------------------+-------------------+-------------+----------------+-------------+ | metabase_test | core_user | is_datasetnewb | tinyint | 1 | NO | | metabase_test | metabase_field | database_required | tinyint | 0 | NO | | metabase_test | metabase_fieldvalues | has_more_values | tinyint | 0 | YES | | metabase_test | permissions_group_membership | is_group_manager | tinyint | 0 | NO | | metabase_test | persisted_info | active | tinyint | 0 | NO | | metabase_test | report_card | dataset | tinyint | 0 | NO | | metabase_test | timeline | archived | tinyint | 0 | NO | | metabase_test | timeline | default | tinyint | 0 | NO | | metabase_test | timeline_event | archived | tinyint | 0 | NO | | metabase_test | timeline_event | time_matters | tinyint | NULL | NO | +---------------+------------------------------+-------------------+-------------+----------------+-------------+ 10 rows in set (0.01 sec) ``` Then wrote migrations. For each column, we: - turn it into a `bit(1)`, - re-set the previously existing default value, and - re-add the NOT NULL constraint, if applicable. * Change author and add missing `dbms` --------- Co-authored-by:
John Swanson <john.swanson@metabase.com> * Add ts-pattern library (#43752) * Add events to measure search performance (#43135) * new_search_query event * Filters in object, search click event * updating event schema * type and event schema adjustments * delete comments BE code * adjusting tests * PR feedback * typos and spacing * Fixup missing colors --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@users.noreply.github.com> Co-authored-by:
Raphael Krut-Landau <raphael.kl@gmail.com> Co-authored-by:
Sloan Sparger <sloansparger@users.noreply.github.com> Co-authored-by:
Ryan Laurie <30528226+iethree@users.noreply.github.com> Co-authored-by:
Alex Yarosh <alexandra@metabase.com> Co-authored-by:
adam-james <21064735+adam-james-v@users.noreply.github.com> Co-authored-by:
Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com> Co-authored-by:
lbrdnk <lbrdnk@users.noreply.github.com> Co-authored-by:
Phoomparin Mano <poom@metabase.com> Co-authored-by:
Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com> Co-authored-by:
SakuragiYoshimasa <ysrhsp@outlook.com> Co-authored-by:
John Swanson <john.swanson@metabase.com> Co-authored-by:
Nick Fitzpatrick <nick@metabase.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
Name | Last commit | Last update |
---|---|---|
.. | ||
main.js | ||
preview-head.html | ||
preview.tsx |