Skip to content
Snippets Groups Projects
  • appleby's avatar
    52284e62
    Ensure that CI checks fail if cljs tests fail (#47192) · 52284e62
    appleby authored
    * Fix typo in expression-clause-normalization-test
    
    s/time-interval/relative-time-interval/
    
    * Add missing table-id to card def to fix failing legacy-ref-test
    
    * Ensure that if yarn test-cljs fails it fails the CI checks
    
    When configured to autorun, the command
    
       shadow-cljs compile test
    
    will exit success even if test failures occur in the node test. See
    
       https://github.com/thheller/shadow-cljs/issues/425
    
    In order to ensure our CI checks fail when cljs tests fail, we need to invoke
    node directly. To prevent running the tests twice, remove `:autorun true` from
    the `:test` target in shadow-cljs.edn.
    Ensure that CI checks fail if cljs tests fail (#47192)
    appleby authored
    * Fix typo in expression-clause-normalization-test
    
    s/time-interval/relative-time-interval/
    
    * Add missing table-id to card def to fix failing legacy-ref-test
    
    * Ensure that if yarn test-cljs fails it fails the CI checks
    
    When configured to autorun, the command
    
       shadow-cljs compile test
    
    will exit success even if test failures occur in the node test. See
    
       https://github.com/thheller/shadow-cljs/issues/425
    
    In order to ensure our CI checks fail when cljs tests fail, we need to invoke
    node directly. To prevent running the tests twice, remove `:autorun true` from
    the `:test` target in shadow-cljs.edn.
Code owners
Assign users and groups as approvers for specific file changes. Learn more.