Skip to content
Snippets Groups Projects
  • Cal Herries's avatar
    6ad641d8
    Allow actions to run on H2 and sample database (#28212) · 6ad641d8
    Cal Herries authored
    
    * Decouple checking ddl from classifying h2 stmts
    
    - should enable followup for easily blocking more kinds of queries
    - check all statements to make sure they aren't "ddl".
    
    * fix classify-query
    
    * linter fixes + get-field refactor
    
    * return the CommandInterface values as ints
    
    Reach into the CommandList when needed
    
    * docstring wording
    
    * catch invalid queries -- they can't be classified
    
    * Remove action subtypes from inlined-models
    
    * Add ddl check for `execute-write-query!`
    
    * Remove ACCESS_MODE_DATA
    
    * Check queries are single select statements
    
    * Add test for sample database privileges
    
    * Fix single-select check
    
    * Add single-select test
    
    * Rename and add more tests for checking read only commands
    
    * commands -> statements
    
    * Fix check-disallow-ddl-commands
    
    * new line
    
    * Add more read-only statements to the tests
    
    * Update error text
    
    * Use are
    
    * Add integration test for executing actions with disallowed commands
    
    * Add test before inserting row
    
    * Run GRANT ALL ON SCHEMA "PUBLIC" TO GUEST
    
    * Restore classify-query
    
    * whitespace
    
    ---------
    
    Co-authored-by: default avatarBryan Maass <bryan.maass@gmail.com>
    Allow actions to run on H2 and sample database (#28212)
    Cal Herries authored
    
    * Decouple checking ddl from classifying h2 stmts
    
    - should enable followup for easily blocking more kinds of queries
    - check all statements to make sure they aren't "ddl".
    
    * fix classify-query
    
    * linter fixes + get-field refactor
    
    * return the CommandInterface values as ints
    
    Reach into the CommandList when needed
    
    * docstring wording
    
    * catch invalid queries -- they can't be classified
    
    * Remove action subtypes from inlined-models
    
    * Add ddl check for `execute-write-query!`
    
    * Remove ACCESS_MODE_DATA
    
    * Check queries are single select statements
    
    * Add test for sample database privileges
    
    * Fix single-select check
    
    * Add single-select test
    
    * Rename and add more tests for checking read only commands
    
    * commands -> statements
    
    * Fix check-disallow-ddl-commands
    
    * new line
    
    * Add more read-only statements to the tests
    
    * Update error text
    
    * Use are
    
    * Add integration test for executing actions with disallowed commands
    
    * Add test before inserting row
    
    * Run GRANT ALL ON SCHEMA "PUBLIC" TO GUEST
    
    * Restore classify-query
    
    * whitespace
    
    ---------
    
    Co-authored-by: default avatarBryan Maass <bryan.maass@gmail.com>
Code owners
Assign users and groups as approvers for specific file changes. Learn more.