* Decouple checking ddl from classifying h2 stmts

- should enable followup for easily blocking more kinds of queries
- check all statements to make sure they aren't "ddl".

* fix classify-query

* linter fixes + get-field refactor

* return the CommandInterface values as ints

Reach into the CommandList when needed

* docstring wording

* catch invalid queries -- they can't be classified

* Remove action subtypes from inlined-models

* Add ddl check for `execute-write-query!`

* Remove ACCESS_MODE_DATA

* Check queries are single select statements

* Add test for sample database privileges

* Fix single-select check

* Add single-select test

* Rename and add more tests for checking read only commands

* commands -> statements

* Fix check-disallow-ddl-commands

* new line

* Add more read-only statements to the tests

* Update error text

* Use are

* Add integration test for executing actions with disallowed commands

* Add test before inserting row

* Run GRANT ALL ON SCHEMA "PUBLIC" TO GUEST

* Restore classify-query

* whitespace

---------

Co-authored-by: Bryan Maass <bryan.maass@gmail.com>

* Make LinkViz search test more robust

It was flaking on CI due to the race described in the comment

* More sensible implementation courtesy of AlexP

* add logics to skip generate subscription contents for link cards and actions

* Limit the number of results for better performance

* Set the viewport dimensions in the test config

This prevents window resizing and reduces or completely removes the flake,
which was Cypress complaining that the icon "pencil" is still animating when it
tries to click on it.

https://docs.cypress.io/guides/references/error-messages#cy-failed-because-the-element-is-currently-animating

* Fix test titles to match the assertion

* Remove suprefluous search for a string

* Use `editDashboard` helper

* Add `model_id` to action search results so that URLs can be made

[Fixes #28565]

* Fix typo in Cypress filename

* set action.model_id to cascade on delete

* add rollback

* Clean up tests

* Improve popover a11y

* Allow testing sequenced setting changes

* Fix `NaN` being a default numeric parameter value

* Allow no default value

* Update empty state

* Clean up layout

* Bring back sticky headers

* Move `ace` element ID to constants

* Close ace popover before opening the save modal

* Change name

* Workaround type warning

* Wrap things with `useMemo` and `useCallback`

* Hide dbs without actions if `requireWriteback`

* Add e2e check

* Strip semicolons from card refs in native queries

Fixes #28218

While source-query substitution handled semicolons in native questions
within outer mbql queries, we used a different code path when splicing
into native queries. This brings the two paths inline.

* Reference issue in testing

* Add docstring

* Convert sqlite driver to honey-sql-2

* Fix bad case statement

* We can't run native queries with AS for oracle

* Dont call ->honeysql on a honeysql-expr

* Fix bad call to h2x

* Identifier needs to be wrapped

* Update kondo config

* Fix test

* Remove hformat fn handler

* Rotate the Snowflake DB prefix AGAIN

* `sql.qp/format-honeysql` needs to wrap stuff in parens when generating SQL snippets

* Update tests to match new expected SQL format

* Sort namespaces

* Fix the flaky paging test

* Fix flaky `metabase.query-processor-test.timezones-test/filter-datetime-by-date-in-timezone-test`

* MySQL test fix 



* Try running Redshift with a beefier runner

---------

Co-authored-by: Cam Saul <github@camsaul.com>
Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>

Co-authored-by: Cam Saul <1455846+camsaul@users.noreply.github.com>
Co-authored-by: Cam Saul <github@camsaul.com>

* behavior logic

* restructure Chart Settings HTML

* adjusting e2e tests

* adjusting unit tests

* Removing pivot-grouping column when checking isSensible

* fixing footer button sizing, unit test

* adjusting e2e tests

[ci skip]

* Resolve nested questions in native queries

Fixes #25988.

* Decouple checking ddl from classifying h2 stmts

- should enable followup for easily blocking more kinds of queries
- check all statements to make sure they aren't "ddl".

* fix classify-query

* linter fixes + get-field refactor

* return the CommandInterface values as ints

Reach into the CommandList when needed

* docstring wording

* catch invalid queries -- they can't be classified

* respond to review comments

- fix see: comment
- remove CommandList typehint
- rename command-list -> command
- skip checking disallowed ddl commands when query is `nil`

then also:
- fix a linter error
- add a test for `nil` query ddl command checking

* rename command-list-type -> first-command-type

* fix schema + handle h2-parser build failure

* Fix action loading and extraction of action type

* Remove comment

* Fix handling required parameters for public basic actions (#28415)

* Fix presenting required parameters

* Add tests

* Add explanation text to the action editor (#28406)

* Add explanation text to the action editor

* Replace link

* Add missing `nock.cleanAll` calls (#28441)

* [CI] Improve `codenotify` workflow (#28432)

* Add path filtering to codenotify workflow

* Upgrade action to its latest version (v0.6.4)

* [E2E] Prevent app permission flakes (#28445)

* Ensure dashcards are deleted after actions are deleted (#28446)

(c.f. discussion at https://metaboat.slack.com/archives/C04FG88HL95/p1676649795131089

)

* Show not found view when opening archived model (#28443)

* Add `isArchived` method to `Question` class

* Show nice not found view when opening archived model

* [CI] Unify E2E tests workflows (#28431)

* [Ci] Fix wildcard glob pattern in path filters (#28447)

[ci skip]

* Remove dupe tests

* Add database_id to implicit actions

* Tidy

* Update select-actions docstring

* Add test for database_id in action dashcards

* Remove database_id before insert and update

* whitespace

* Refactor select-actions

* Add database_id to action-create-test

* Add test for create+update+select for implicit actions

* Fix test

* Remove conditional

* style

---------

Co-authored-by: Anton Kulyk <kuliks.anton@gmail.com>
Co-authored-by: Nemanja Glumac <31325167+nemanjaglumac@users.noreply.github.com>
Co-authored-by: Tim Macdonald <tim@metabase.com>

* Add `aria-label` to the run button

* Assert run action button is shown when expected

* Hide run button when actions are disabled

* If a model is converted to a card, archive the associated actions
* If an action is unarchived and its model _is_ a card, throw an error

* Fix missing type property on a card breaks frontend UI

* Add E2E test

* MISC improvements

* Update test/metabase/models/secret_test.clj

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Update .clj-kondo/hooks/clojure/test.clj

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Update .clj-kondo/hooks/clojure/test.clj

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

---------

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Improves consistency of substring in MBQL

Standard SQL SUBSTRING() uses a 1-based start index, with various drivers
handling a 0 start index in different ways. To make the behavior of substring
consistent across drivers, we will always convert a 0 start index in MBQL
to a 1 in SQL. The ->honeysql implementation of substring has been generalized
and drivers can now override just the name of the substring function, or the
entire expression if necessary. SQL Server now calls the parent implementation.

Resolves #12445

* Fixes substring from 0 in Mongo

* Adds arg to substring parent call

* Fix docs and helper text for substring()

* Adds schema to require positive integer index for substring

* WIP, adds frontend validation for substring index arg

* Adds frontend test for substring arg validation

* Updates substring test to expect exception on index 0

* Update src/metabase/driver/sql/query_processor.clj

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Use s/if instead of s/conditional

* Fix substring call in mysql substring spec

* Reverts driver and sql.qp changes for substring index

* Reverts changes to dispatch-by-clause-name-or-class

* Fixes typeinferencer test substring index

* Adds test for canonicalizing substring

* Fixes substring canonicalization with extra args

* Updates string extracts test to account for substring canonicalization

* Rewrites resolver validation application

* Adds test case for frontend expression validation errors

* Fixes frontend compiler spec for new substring validation

---------

Co-authored-by: metamben <103100869+metamben@users.noreply.github.com>

* Custom migrations

Current syntax:

specify the migration with
```
  - changeSet:
      id: v46.00-080
      author: dpsutton
      comment: Uppercases all Card names
      changes:
        - customChange:
            class: "metabase.db.custom_migrations.ReversibleUppercaseCards"
```

and in the new namespace metabase.db.custom-migrations:

```clojure
(defmigration UppercaseCards
  (db/execute! {:update :report_card
                :set    {:name :%upper.name}}))

(def-reversible-migration ReversibleUppercaseCards
  (db/execute! {:update :report_card
                :set    {:name :%upper.name}})
  (db/execute! {:update :report_card
                :set    {:name :%lower.name}}))
```

* Use db provided by liquibase

* edit docstring

* set *warn-on-reflection* to fix lint error & rebase

---------

Co-authored-by: Noah Moss <noahbmoss@gmail.com>
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>